Add support for WLED5
Subsystems (5)
v5 cover Add support for WLED5
Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L.
PM8150L WLED supports the following.
- Two modulators and each sink can use any of the modulator
- Multiple CABC selection options
- Multiple brightness width selection (12 bits to 15 bits)
Changes from V1:
- Rebased on top of the below commit.
backlight: qcom-wled: Fix unsigned comparison to zero
Changes from V2:
- Addressed Bjorn's comments by splitting the WLED4 changes in a seperate patch.
- Added WLED5 auto calibration support
Changes from V3:
- Addressed comments from Daniel Thompson and Rob Herring
- Seperated the WLED5 bindings from the driver changes
- Squashed wled5 auto string detection and wled5 basic changes to avoid the NULL callback function pointer issue.
Changes from V4:
- Addressed the yaml formatting comments from Rob Herring.
- Addressed the comments from Daniel Thompson on the below patch "backlight: qcom-wled: Add callback functions"
Kiran Gunda (3):
backlight: qcom-wled: convert the wled bindings to .yaml format
backlight: qcom-wled: Add callback functions
backlight: qcom-wled: Add WLED5 bindings
Subbaraman Narayanamurthy (1):
backlight: qcom-wled: Add support for WLED5 peripheral that is present
on PM8150L PMICs
.../bindings/leds/backlight/qcom-wled.txt | 154 ----- .../bindings/leds/backlight/qcom-wled.yaml | 255 ++++++++ drivers/video/backlight/qcom-wled.c | 659 ++++++++++++++++++--- 3 files changed, 841 insertions(+), 227 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt create mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v5 1/4 backlight: qcom-wled: convert the wled bindings to .yaml format
Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4.
--- .../bindings/leds/backlight/qcom-wled.txt | 154 ---------------- .../bindings/leds/backlight/qcom-wled.yaml | 201 +++++++++++++++++++++ 2 files changed, 201 insertions(+), 154 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt create mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt deleted +0 -154
@@ -1,154 +0,0 @@ -Binding for Qualcomm Technologies, Inc. WLED driver - -WLED (White Light Emitting Diode) driver is used for controlling display -backlight that is part of PMIC on Qualcomm Technologies, Inc. reference -platforms. The PMIC is connected to the host processor via SPMI bus. - -- compatible - Usage: required - Value type: <string> - Definition: should be one of: - "qcom,pm8941-wled" - "qcom,pmi8998-wled" - "qcom,pm660l-wled" - -- reg - Usage: required - Value type: <prop encoded array> - Definition: Base address of the WLED modules. - -- default-brightness - Usage: optional - Value type: <u32> - Definition: brightness value on boot, value from: 0-4095. - Default: 2048 - -- label - Usage: required - Value type: <string> - Definition: The name of the backlight device - -- qcom,cs-out - Usage: optional - Value type: <bool> - Definition: enable current sink output. - This property is supported only for PM8941. - -- qcom,cabc - Usage: optional - Value type: <bool> - Definition: enable content adaptive backlight control. - -- qcom,ext-gen - Usage: optional - Value type: <bool> - Definition: use externally generated modulator signal to dim. - This property is supported only for PM8941. - -- qcom,current-limit - Usage: optional - Value type: <u32> - Definition: mA; per-string current limit; value from 0 to 25 with - 1 mA step. Default 20 mA. - This property is supported only for pm8941. - -- qcom,current-limit-microamp - Usage: optional - Value type: <u32> - Definition: uA; per-string current limit; value from 0 to 30000 with - 2500 uA step. Default 25 mA. - -- qcom,current-boost-limit - Usage: optional - Value type: <u32> - Definition: mA; boost current limit. - For pm8941: one of: 105, 385, 525, 805, 980, 1260, 1400, - 1680. Default: 805 mA. - For pmi8998: one of: 105, 280, 450, 620, 970, 1150, 1300, - 1500. Default: 970 mA. - -- qcom,switching-freq - Usage: optional - Value type: <u32> - Definition: kHz; switching frequency; one of: 600, 640, 685, 738, - 800, 872, 960, 1066, 1200, 1371, 1600, 1920, 2400, 3200, - 4800, 9600. - Default: for pm8941: 1600 kHz - for pmi8998: 800 kHz - -- qcom,ovp - Usage: optional - Value type: <u32> - Definition: V; Over-voltage protection limit; one of: - 27, 29, 32, 35. Default: 29V - This property is supported only for PM8941. - -- qcom,ovp-millivolt - Usage: optional - Value type: <u32> - Definition: mV; Over-voltage protection limit; - For pmi8998: one of 18100, 19600, 29600, 31100. - Default 29600 mV. - If this property is not specified for PM8941, it - falls back to "qcom,ovp" property. - -- qcom,num-strings - Usage: optional - Value type: <u32> - Definition: #; number of led strings attached; - value: For PM8941 from 1 to 3. Default: 2 - For PMI8998 from 1 to 4. - -- interrupts - Usage: optional - Value type: <prop encoded array> - Definition: Interrupts associated with WLED. This should be - "short" and "ovp" interrupts. Interrupts can be - specified as per the encoding listed under - Documentation/devicetree/bindings/spmi/ - qcom,spmi-pmic-arb.txt. - -- interrupt-names - Usage: optional - Value type: <string> - Definition: Interrupt names associated with the interrupts. - Must be "short" and "ovp". The short circuit detection - is not supported for PM8941. - -- qcom,enabled-strings - Usage: optional - Value tyoe: <u32 array> - Definition: Array of the WLED strings numbered from 0 to 3. Each - string of leds are operated individually. Specify the - list of strings used by the device. Any combination of - led strings can be used. - -- qcom,external-pfet - Usage: optional - Value type: <bool> - Definition: Specify if external PFET control for short circuit - protection is used. This property is supported only - for PMI8998. - -- qcom,auto-string-detection - Usage: optional - Value type: <bool> - Definition: Enables auto-detection of the WLED string configuration. - This feature is not supported for PM8941. - - -Example: - -pm8941-wled@d800 { - compatible = "qcom,pm8941-wled"; - reg = <0xd800>; - label = "backlight"; - - qcom,cs-out; - qcom,current-limit = <20>; - qcom,current-boost-limit = <805>; - qcom,switching-freq = <1600>; - qcom,ovp = <29>; - qcom,num-strings = <2>; - qcom,enabled-strings = <0 1>; -};
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +201 -0
201 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Rob Herring
maintainerRe: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
Quoted 73 lines · Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4.
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>Acked-by Daniel Thompson <[email protected]>--- .../bindings/leds/backlight/qcom-wled.txt | 154 ---------------- .../bindings/leds/backlight/qcom-wled.yaml | 201 +++++++++++++++++++++ 2 files changed, 201 insertions(+), 154 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt create mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.yamlDocumentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +53
-0@@ -0,0 +1,201 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/qcom-wled.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Binding for Qualcomm Technologies, Inc. WLED driver + +maintainers: + - Bjorn Andersson <[email protected]> + - Kiran Gunda <[email protected]> + +description: | + WLED (White Light Emitting Diode) driver is used for controlling display + backlight that is part of PMIC on Qualcomm Technologies, Inc. reference + platforms. The PMIC is connected to the host processor via SPMI bus. + +properties: + compatible: + enum: + - qcom,pm8941-wled + - qcom,pmi8998-wled + - qcom,pm660l-wled + + reg: + maxItems: 1 + + default-brightness: + description: + brightness value on boot. + minimum: 0 + maximum: 4095 + default: 2048 + + label: true + + qcom,cs-out: + description: + enable current sink output. + This property is supported only for WLED3. + type: boolean + + qcom,cabc: + description: + enable content adaptive backlight control. + type: boolean + + qcom,ext-gen: + description: + use externally generated modulator signal to dim. + This property is supported only for WLED3. + type: boolean +
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 63
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +10
-0+ qcom,current-limit: + description: + mA; per-string current limit. + This property is supported only for WLED3. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + default: 20 + minimum: 0 + maximum: 25 + multipleOf: 1
No point in defining a multiple of 1.
Quoted 107 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +107
-0+ + qcom,current-limit-microamp: + description: + uA; per-string current limit. + default: 25 + minimum: 0 + maximum: 30000 + multipleOf: 25 + + qcom,current-boost-limit: + description: + mA; boost current limit. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + + qcom,switching-freq: + description: + kHz; switching frequency. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371, 1600, 1920, 2400, 3200, 4800, 9600 ] + + qcom,ovp: + description: + V; Over-voltage protection limit. + This property is supported only for WLED3. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 27, 29, 32, 35 ] + - default: 29 + + qcom,ovp-millivolt: + description: + Over-voltage protection limit. This property is for WLED4 only. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 18100, 19600, 29600, 31100 ] + - default: 29600 + + qcom,num-strings: + description: + number of led strings attached. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + + qcom,enabled-strings: + description: + Array of the WLED strings numbered from 0 to 3. Each + string of leds are operated individually. Specify the + list of strings used by the device. Any combination of + led strings can be used. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 4 + + qcom,external-pfet: + description: + Specify if external PFET control for short circuit + protection is used. This property is supported only + for WLED4. + type: boolean + + qcom,auto-string-detection: + description: + Enables auto-detection of the WLED string configuration. + This feature is not supported for WLED3. + type: boolean + +allOf: + - if: + properties: + compatible: + contains: + const: qcom,pm8941-wled + + then: + properties: + qcom,current-boost-limit: + enum: [ 105, 385, 525, 805, 980, 1260, 1400, 1680 ] + default: 805 + + qcom,switching-freq: + default: 1600 + + qcom,num-strings: + enum: [ 1, 2, 3 ] + + interrupts: + items: + - description: over voltage protection interrupt. + + interrupt-names: + items: + - const: ovp + + else: + properties: + qcom,current-boost-limit: + enum: [ 105, 280, 450, 620, 970, 1150, 1300, 1500 ] + default: 970 + + qcom,switching-freq: + default: 800 + + qcom,num-strings: + enum: [ 1, 2, 3, 4 ]
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 180
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +10
-0+ + interrupts: + items: + - description: over voltage protection interrupt. + - description: short circuit interrupt. + + interrupt-names: + items: + - const: ovp + - const: short
Move these 2 props to the main section adding a 'minItems: 1'. Then just define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 185
Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +5
-0+ +required: + - compatible + - reg + - label
Add:
additionalProperties: false
Quoted 20 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +16
-0+ +examples: + - | + backlight@d800 { + compatible = "qcom,pm8941-wled"; + reg = <0xd800 0x100>; + label = "backlight"; + + qcom,cs-out; + qcom,current-limit = <20>; + qcom,current-boost-limit = <805>; + qcom,switching-freq = <1600>; + qcom,ovp = <29>; + qcom,num-strings = <2>; + qcom,enabled-strings = <0 1>; + };Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
Quoted 238 lines · Rob Herring
Quoted 80 lines · Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4.
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>Acked-by Daniel Thompson <[email protected]>--- .../bindings/leds/backlight/qcom-wled.txt | 154 ---------------- .../bindings/leds/backlight/qcom-wled.yaml | 201 +++++++++++++++++++++ 2 files changed, 201 insertions(+), 154 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt create mode 100644
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yamlDocumentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +14
-0@@ -0,0 +1,201 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/qcom-wled.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Binding for Qualcomm Technologies, Inc. WLED driver + +maintainers: + - Bjorn Andersson <[email protected]> + - Kiran Gunda <[email protected]> + +description: | + WLED (White Light Emitting Diode) driver is used for controllingdisplay
+ backlight that is part of PMIC on Qualcomm Technologies, Inc. reference
+ platforms. The PMIC is connected to the host processor via SPMI bus.Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +37
-0+ +properties: + compatible: + enum: + - qcom,pm8941-wled + - qcom,pmi8998-wled + - qcom,pm660l-wled + + reg: + maxItems: 1 + + default-brightness: + description: + brightness value on boot. + minimum: 0 + maximum: 4095 + default: 2048 + + label: true + + qcom,cs-out: + description: + enable current sink output. + This property is supported only for WLED3. + type: boolean + + qcom,cabc: + description: + enable content adaptive backlight control. + type: boolean + + qcom,ext-gen: + description: + use externally generated modulator signal to dim. + This property is supported only for WLED3. + type: boolean +Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 63
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +10
-0+ qcom,current-limit: + description: + mA; per-string current limit. + This property is supported only for WLED3. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + default: 20 + minimum: 0 + maximum: 25 + multipleOf: 1No point in defining a multiple of 1.
Quoted 108 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +21
-0+ + qcom,current-limit-microamp: + description: + uA; per-string current limit. + default: 25 + minimum: 0 + maximum: 30000 + multipleOf: 25 + + qcom,current-boost-limit: + description: + mA; boost current limit. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + + qcom,switching-freq: + description: + kHz; switching frequency. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371,1600, 1920, 2400, 3200, 4800, 9600 ]
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +86
-0+ + qcom,ovp: + description: + V; Over-voltage protection limit. + This property is supported only for WLED3. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 27, 29, 32, 35 ] + - default: 29 + + qcom,ovp-millivolt: + description: + Over-voltage protection limit. This property is for WLED4 only. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 18100, 19600, 29600, 31100 ] + - default: 29600 + + qcom,num-strings: + description: + number of led strings attached. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + + qcom,enabled-strings: + description: + Array of the WLED strings numbered from 0 to 3. Each + string of leds are operated individually. Specify the + list of strings used by the device. Any combination of + led strings can be used. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 4 + + qcom,external-pfet: + description: + Specify if external PFET control for short circuit + protection is used. This property is supported only + for WLED4. + type: boolean + + qcom,auto-string-detection: + description: + Enables auto-detection of the WLED string configuration. + This feature is not supported for WLED3. + type: boolean + +allOf: + - if: + properties: + compatible: + contains: + const: qcom,pm8941-wled + + then: + properties: + qcom,current-boost-limit: + enum: [ 105, 385, 525, 805, 980, 1260, 1400, 1680 ] + default: 805 + + qcom,switching-freq: + default: 1600 + + qcom,num-strings: + enum: [ 1, 2, 3 ] + + interrupts: + items: + - description: over voltage protection interrupt. + + interrupt-names: + items: + - const: ovp + + else: + properties: + qcom,current-boost-limit: + enum: [ 105, 280, 450, 620, 970, 1150, 1300, 1500 ] + default: 970 + + qcom,switching-freq: + default: 800 + + qcom,num-strings: + enum: [ 1, 2, 3, 4 ]Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 180
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +10
-0+ + interrupts: + items: + - description: over voltage protection interrupt. + - description: short circuit interrupt. + + interrupt-names: + items: + - const: ovp + - const: shortMove these 2 props to the main section adding a 'minItems: 1'. Then just define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 185
Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +5
-0+ +required: + - compatible + - reg + - labelAdd:
additionalProperties: false
Quoted 12 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +12
-0+ +examples: + - | + backlight@d800 { + compatible = "qcom,pm8941-wled"; + reg = <0xd800 0x100>; + label = "backlight"; + + qcom,cs-out; + qcom,current-limit = <20>; + qcom,current-boost-limit = <805>; + qcom,switching-freq = <1600>;
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +4
-1+ qcom,ovp = <29>; + qcom,num-strings = <2>; + qcom,enabled-strings = <0 1>; + }; --The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Thanks for reviewing. I will submit the next revision with all the fixes.
Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
Quoted 18 lines · On Fri, 17 Apr 2020, [email protected] wrote:
Quoted 17 lines · Rob Herring
Quoted 16 lines · Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4.
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>Acked-by Daniel Thompson <[email protected]>--- .../bindings/leds/backlight/qcom-wled.txt | 154 ---------------- .../bindings/leds/backlight/qcom-wled.yaml | 201 +++++++++++++++++++++ 2 files changed, 201 insertions(+), 154 deletions(-) delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt create mode 100644
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
[...]
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 180
Quoted 4 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +4
-0+ interrupt-names: + items: + - const: ovp + - const: shortMove these 2 props to the main section adding a 'minItems: 1'. Then just define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 185
Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +5
-0+ +required: + - compatible + - reg + - labelAdd:
additionalProperties: false
Quoted 9 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +9
-0+ +examples: + - | + backlight@d800 { + compatible = "qcom,pm8941-wled"; + reg = <0xd800 0x100>; + label = "backlight"; + + qcom,cs-out;
Quoted 8 lines
Quoted 7 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml line 201
Quoted 7 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml new file +7
-0+ qcom,current-limit = <20>; + qcom,current-boost-limit = <805>; + qcom,switching-freq = <1600>; + qcom,ovp = <29>; + qcom,num-strings = <2>; + qcom,enabled-strings = <0 1>; + };Thanks for reviewing. I will submit the next revision with all the fixes.
Please trim your replies.
Also, if you agree with all of the review comments, there really is no need to reply and/or thank the reviewer. Simply submit a subsequent set with a bumped version indicator.
Signature · 8 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v5 2/4 backlight: qcom-wled: Add callback functions
In reply to Kiran GundaAdd wled_cabc_config, wled_sync_toggle, wled_ovp_fault_status and wled_ovp_delay and wled_auto_detection_required callback functions to prepare the driver for adding WLED5 support.
--- drivers/video/backlight/qcom-wled.c | 216 ++++++++++++++++++++++++------------ 1 file changed, 144 insertions(+), 72 deletions(-)
drivers/video/backlight/qcom-wled.c +144 -72
@@ -147,6 +147,7 @@ struct wled {u32 max_brightness;u32 short_count;u32 auto_detect_count; +u32 version;bool disabled_by_short;bool has_short_detect;int short_irq;
@@ -154,7 +155,33 @@ struct wled {struct wled_config cfg;struct delayed_work ovp_work; + +/* Configures the brightness. Applicable for wled3, wled4 and wled5 */ int (*wled_set_brightness)(struct wled *wled,u16 brightness); + +/* Configures the cabc register. Applicable for wled4 and wled5 */ +int (*wled_cabc_config)(struct wled *wled,bool enable); + +/* +* Toggles the sync bit for the brightness update to take place. +* Applicable for WLED3, WLED4 and WLED5. +*/ +int (*wled_sync_toggle)(struct wled *wled); + +/* Determines OVP fault status. Applicable for WLED4 and WLED5 */ +int (*wled_ovp_fault_status)(struct wled *wled,bool *fault_set); + +/* +* Time to wait before checking the OVP status after wled module enable. +* Applicable for WLED4 and WLED5. +*/ +int (*wled_ovp_delay)(struct wled *wled); + +/* +* Determines if the auto string detection is required. +* Applicable for WLED4 and WLED5 +*/ +bool (*wled_auto_detection_required)(struct wled *wled); };static int wled3_set_brightness (struct wled *wled,u16 brightness)
@@ -237,7 +264,7 @@ static int wled_module_enable(struct wled *wled, int val)return 0 ; } -static int wled_sync_toggle (struct wled *wled) +static int wled3_sync_toggle (struct wled *wled) {int rc;unsigned int mask =GENMASK (wled->max_string_count -1 ,0 );
@@ -255,6 +282,46 @@ static int wled_sync_toggle(struct wled *wled)return rc; } +static int wled4_ovp_fault_status (struct wled *wled,bool *fault_set) +{ +int rc; +u32 int_rt_sts, fault_sts; + + *fault_set = false; + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_INT_RT_STS , + &int_rt_sts); +if (rc <0 ) { +dev_err (wled->dev,"Failed to read INT_RT_STS rc=%d\n" , rc); +return rc; + } + + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_FAULT_STATUS , + &fault_sts); +if (rc <0 ) { +dev_err (wled->dev,"Failed to read FAULT_STATUS rc=%d\n" , rc); +return rc; + } + +if (int_rt_sts &WLED3_CTRL_REG_OVP_FAULT_STATUS ) + *fault_set = true; + +if (fault_sts &WLED3_CTRL_REG_OVP_FAULT_BIT ) + *fault_set = true; + +if (*fault_set) +dev_dbg (wled->dev,"WLED OVP fault detected, int_rt_sts=0x%x fault_sts=0x%x\n" , + int_rt_sts, fault_sts); + +return rc; +} + +static int wled4_ovp_delay (struct wled *wled) +{ +return WLED_SOFT_START_DLY_US ; +} +static int wled_update_status (struct backlight_device *bl) {struct wled *wled =bl_get_data (bl);
@@ -275,7 +342,7 @@ static int wled_update_status(struct backlight_device *bl) goto unlock_mutex; } - rc =wled_sync_toggle (wled); + rc = wled->wled_sync_toggle (wled);if (rc <0 ) {dev_err (wled->dev,"wled sync failed rc:%d\n" , rc); goto unlock_mutex;
@@ -298,6 +365,25 @@ static int wled_update_status(struct backlight_device *bl)return rc; } +static int wled4_cabc_config (struct wled *wled,bool enable) +{ +int i, j, rc; +u8 val; + +for (i =0 ; i < wled->cfg.num_strings; i++) { + j = wled->cfg.enabled_strings[i]; + + val = enable ?WLED4_SINK_REG_STR_CABC_MASK :0 ; + rc =regmap_update_bits (wled->regmap, wled->sink_addr + +WLED4_SINK_REG_STR_CABC (j), +WLED4_SINK_REG_STR_CABC_MASK , val); +if (rc <0 ) +return rc; + } + +return 0 ; +} +#define WLED_SHORT_DLY_MS 20#define WLED_SHORT_CNT_MAX 5#define WLED_SHORT_RESET_CNT_DLY_US USEC_PER_SEC
@@ -345,9 +431,10 @@ static irqreturn_t wled_short_irq_handler(int irq, void *_wled)static void wled_auto_string_detection (struct wled *wled) { -int rc =0 , i; -u32 sink_config =0 , int_sts; +int rc =0 , i, delay_time_us; +u32 sink_config =0 ;u8 sink_test =0 , sink_valid =0 , val; +bool fault_set;/* Read configured sink configuration */ rc = regmap_read(wled->regmap, wled->sink_addr +
@@ -376,14 +463,9 @@ static void wled_auto_string_detection(struct wled *wled) }if (wled->cfg.cabc) { -for (i =0 ; i < wled->cfg.num_strings; i++) { - rc =regmap_update_bits (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_STR_CABC (i), -WLED4_SINK_REG_STR_CABC_MASK , -0 ); -if (rc <0 ) - goto failed_detect; - } + rc = wled->wled_cabc_config (wled, false); +if (rc <0 ) + goto failed_detect; }/* Disable all sinks */
@@ -427,18 +509,17 @@ static void wled_auto_string_detection(struct wled *wled) goto failed_detect; } -usleep_range (WLED_SOFT_START_DLY_US , -WLED_SOFT_START_DLY_US +1000 ); + delay_time_us = wled->wled_ovp_delay (wled); +usleep_range (delay_time_us, delay_time_us +1000 ); - rc =regmap_read (wled->regmap, wled->ctrl_addr + -WLED3_CTRL_REG_INT_RT_STS , &int_sts); + rc = wled->wled_ovp_fault_status (wled, &fault_set);if (rc <0 ) { -dev_err (wled->dev,"Error in reading WLED3_CTRL_INT_RT_STS rc=%d\n" , +dev_err (wled->dev,"Error in getting OVP fault_sts, rc=%d\n" , rc); goto failed_detect; } -if (int_sts &WLED3_CTRL_REG_OVP_FAULT_STATUS ) +if (fault_set)dev_dbg (wled->dev,"WLED OVP fault detected with SINK %d\n" , i +1 );else
@@ -478,30 +559,30 @@ static void wled_auto_string_detection(struct wled *wled) }/* Enable valid sinks */ -for (i =0 ; i < wled->cfg.num_strings; i++) { -if (wled->cfg.cabc) { - rc =regmap_update_bits (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_STR_CABC (i), -WLED4_SINK_REG_STR_CABC_MASK , -WLED4_SINK_REG_STR_CABC_MASK ); -if (rc <0 ) +if (wled->version ==4 ) { +for (i =0 ; i < wled->cfg.num_strings; i++) { +if (sink_config & +BIT (WLED4_SINK_REG_CURR_SINK_SHFT + i)) + val =WLED4_SINK_REG_STR_MOD_MASK ; +else +/* Disable modulator_en for unused sink */ + val =0 ; + + rc =regmap_write (wled->regmap, wled->sink_addr + +WLED4_SINK_REG_STR_MOD_EN (i), val); +if (rc <0 ) { +dev_err (wled->dev,"Failed to configure MODULATOR_EN rc=%d\n" , + rc); goto failed_detect; - } - -if (sink_config &BIT (WLED4_SINK_REG_CURR_SINK_SHFT + i)) - val =WLED4_SINK_REG_STR_MOD_MASK ; -else - val =0x0 ;/* Disable modulator_en for unused sink */ - - rc =regmap_write (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_STR_MOD_EN (i), val); -if (rc <0 ) { -dev_err (wled->dev,"Failed to configure MODULATOR_EN rc=%d\n" , - rc); - goto failed_detect; + } } } +/* Enable CABC */ + rc = wled->wled_cabc_config (wled, true); +if (rc <0 ) + goto failed_detect; +/* Restore the feedback setting */ rc =regmap_write (wled->regmap, wled->ctrl_addr +WLED3_CTRL_REG_FEEDBACK_CONTROL ,0 );
@@ -534,7 +615,7 @@ static void wled_auto_string_detection(struct wled *wled)#define WLED_AUTO_DETECT_OVP_COUNT 5#define WLED_AUTO_DETECT_CNT_DLY_US USEC_PER_SEC -static bool wled_auto_detection_required (struct wled *wled) +static bool wled4_auto_detection_required (struct wled *wled) {s64 elapsed_time_us;
@@ -570,29 +651,19 @@ static bool wled_auto_detection_required(struct wled *wled)static int wled_auto_detection_at_init (struct wled *wled) {int rc; -u32 fault_status, rt_status; +bool fault_set;if (!wled->cfg.auto_detection_enabled)return 0 ; - rc =regmap_read (wled->regmap, - wled->ctrl_addr +WLED3_CTRL_REG_INT_RT_STS , - &rt_status); -if (rc <0 ) { -dev_err (wled->dev,"Failed to read RT status rc=%d\n" , rc); -return rc; - } - - rc =regmap_read (wled->regmap, - wled->ctrl_addr +WLED3_CTRL_REG_FAULT_STATUS , - &fault_status); + rc = wled->wled_ovp_fault_status (wled, &fault_set);if (rc <0 ) { -dev_err (wled->dev,"Failed to read fault status rc=%d\n" , rc); +dev_err (wled->dev,"Error in getting OVP fault_sts, rc=%d\n" , + rc);return rc; } -if ((rt_status &WLED3_CTRL_REG_OVP_FAULT_STATUS ) || - (fault_status &WLED3_CTRL_REG_OVP_FAULT_BIT )) { +if (fault_set) {mutex_lock (&wled->lock);wled_auto_string_detection (wled);mutex_unlock (&wled->lock);
@@ -629,7 +700,7 @@ static irqreturn_t wled_ovp_irq_handler(int irq, void *_wled) int_sts, fault_sts);if (fault_sts &WLED3_CTRL_REG_OVP_FAULT_BIT ) { -if (wled_auto_detection_required (wled)) { +if (wled->wled_auto_detection_required (wled)) {mutex_lock (&wled->lock);wled_auto_string_detection (wled);mutex_unlock (&wled->lock);
@@ -811,17 +882,12 @@ static int wled4_setup(struct wled *wled) wled->cfg.string_i_limit);if (rc <0 )return rc; - - addr = wled->sink_addr + -WLED4_SINK_REG_STR_CABC (j); - rc =regmap_update_bits (wled->regmap, addr, -WLED4_SINK_REG_STR_CABC_MASK , - wled->cfg.cabc ? -WLED4_SINK_REG_STR_CABC_MASK :0 ); -if (rc <0 ) -return rc; } + rc =wled4_cabc_config (wled, wled->cfg.cabc); +if (rc <0 ) +return rc; + rc = regmap_update_bits(wled->regmap, wled->ctrl_addr + WLED3_CTRL_REG_MOD_EN, WLED3_CTRL_REG_MOD_EN_MASK,
@@ -835,7 +901,7 @@ static int wled4_setup(struct wled *wled)if (rc <0 )return rc; - rc =wled_sync_toggle (wled); + rc = wled->wled_sync_toggle (wled);if (rc <0 ) {dev_err (wled->dev,"Failed to toggle sync reg rc:%d\n" , rc);return rc;
@@ -951,7 +1017,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)return idx; } -static int wled_configure (struct wled *wled,int version) +static int wled_configure (struct wled *wled) {struct wled_config *cfg = &wled->cfg;struct device *dev = wled->dev;
@@ -1035,12 +1101,13 @@ static int wled_configure(struct wled *wled, int version)if (rc) wled->name =devm_kasprintf (dev,GFP_KERNEL ,"%pOFn" , dev->of_node); -switch (version) { +switch (wled->version) {case 3 : u32_opts = wled3_opts; size =ARRAY_SIZE (wled3_opts); *cfg = wled3_config_defaults; wled->wled_set_brightness = wled3_set_brightness; + wled->wled_sync_toggle = wled3_sync_toggle; wled->max_string_count =3 ; wled->sink_addr = wled->ctrl_addr;break ;
@@ -1050,6 +1117,12 @@ static int wled_configure(struct wled *wled, int version) size =ARRAY_SIZE (wled4_opts); *cfg = wled4_config_defaults; wled->wled_set_brightness = wled4_set_brightness; + wled->wled_sync_toggle = wled3_sync_toggle; + wled->wled_cabc_config = wled4_cabc_config; + wled->wled_ovp_fault_status = wled4_ovp_fault_status; + wled->wled_ovp_delay = wled4_ovp_delay; + wled->wled_auto_detection_required = + wled4_auto_detection_required; wled->max_string_count =4 ; prop_addr =of_get_address (dev->of_node,1 ,NULL ,NULL );
@@ -1186,7 +1259,6 @@ static int wled_probe(struct platform_device *pdev)struct backlight_device *bl;struct wled *wled;struct regmap *regmap; -int version;u32 val;int rc;
@@ -1203,18 +1275,18 @@ static int wled_probe(struct platform_device *pdev) wled->regmap = regmap; wled->dev = &pdev->dev; - version = (uintptr_t )of_device_get_match_data (&pdev->dev); -if (!version) { + wled->version = (uintptr_t )of_device_get_match_data (&pdev->dev); +if (!wled->version) {dev_err (&pdev->dev,"Unknown device version\n" );return -ENODEV ; }mutex_init (&wled->lock); - rc =wled_configure (wled, version); + rc =wled_configure (wled);if (rc)return rc; -switch (version) { +switch (wled->version) {case 3 : wled->cfg.auto_detection_enabled = false; rc =wled3_setup (wled);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH V5 2/4] backlight: qcom-wled: Add callback functions
Quoted 6 lines · Kiran Gunda
Add
wled_cabc_config,wled_sync_toggle,wled_ovp_fault_statusandwled_ovp_delayandwled_auto_detection_requiredcallback functions to prepare the driver for adding WLED5 support.Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>
PATCH v5 3/4 backlight: qcom-wled: Add WLED5 bindings
In reply to Kiran GundaAdd WLED5 specific bindings.
--- .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- 1 file changed, 57 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +57 -3
@@ -21,6 +21,7 @@ properties: - qcom,pm8941-wled - qcom,pmi8998-wled - qcom,pm660l-wled + - qcom,pm8150l-wled reg: maxItems: 1
@@ -28,12 +29,13 @@ properties: default-brightness: description: brightness value on boot. - minimum: 0 - maximum: 4095 - default: 2048 label: true + max-brightness: + description: + Maximum brightness level. + qcom,cs-out: description: enable current sink output.
@@ -130,6 +132,31 @@ properties: This feature is not supported for WLED3. type: boolean + qcom,modulator-sel: + description: + Selects the modulator used for brightness modulation. + Allowed values are, + 0 - Modulator A + 1 - Modulator B + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1 ] + - default: 0 + + qcom,cabc-sel: + description: + Selects the CABC pin signal used for brightness modulation. + Allowed values are, + 0 - CABC disabled + 1 - CABC 1 + 2 - CABC 2 + 3 - External signal (e.g. LPG) is used for dimming + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1, 2, 3 ] + allOf: - if: properties:
@@ -179,6 +206,33 @@ allOf: - const: ovp - const: short + - if: + properties: + compatible: + contains: + enum: + - qcom,pm8150l-wled + + then: + properties: + default-brightness: + minimum: 0 + maximum: 32767 + + max-brightness: + minimum: 0 + maximum: 32767 + + else: + properties: + default-brightness: + minimum: 0 + maximum: 4095 + + max-brightness: + minimum: 0 + maximum: 4095 + required: - compatible - reg
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Rob Herring
maintainerRe: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings
Quoted 2 lines · Kiran Gunda
Add WLED5 specific bindings.
checkpatch.pl complains about some trailing whitespace. The previous patch too.
Quoted 36 lines
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>--- .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- 1 file changed, 57 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +5
-3@@ -21,6 +21,7 @@ properties: - qcom,pm8941-wled - qcom,pmi8998-wled - qcom,pm660l-wled + - qcom,pm8150l-wled reg: maxItems: 1@@ -28,12 +29,13 @@ properties: default-brightness: description: brightness value on boot. - minimum: 0 - maximum: 4095 - default: 2048 label: true + max-brightness: + description: + Maximum brightness level. + qcom,cs-out: description: enable current sink output.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml properties: · line 136
Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +2
-0@@ -130,6 +132,31 @@ properties: This feature is not supported for WLED3. type: boolean + qcom,modulator-sel: + description:
Need a '|' at the end to preserve formatting.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml properties: · line 148
Quoted 12 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +12
-0+ Selects the modulator used for brightness modulation. + Allowed values are, + 0 - Modulator A + 1 - Modulator B + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1 ] + - default: 0 + + qcom,cabc-sel: + description:
Need a '|'.
Quoted 30 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +23
-0+ Selects the CABC pin signal used for brightness modulation. + Allowed values are, + 0 - CABC disabled + 1 - CABC 1 + 2 - CABC 2 + 3 - External signal (e.g. LPG) is used for dimming + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1, 2, 3 ] + allOf: - if: properties:@@ -179,6 +206,33 @@ allOf: - const: ovp - const: short + - if: + properties: + compatible: + contains: + enum: + - qcom,pm8150l-wled + + then: + properties: + default-brightness: + minimum: 0 + maximum: 32767
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml allOf: · line 230
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +10
-0+ + max-brightness: + minimum: 0 + maximum: 32767 + + else: + properties: + default-brightness: + minimum: 0 + maximum: 4095
Wrong indentation.
Quoted 12 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +5
-0+ + max-brightness: + minimum: 0 + maximum: 4095 + required: - compatible - regSignature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings
Quoted 110 lines · Rob Herring
Quoted 2 lines · Kiran Gunda
Add WLED5 specific bindings.
checkpatch.pl complains about some trailing whitespace. The previous patch too.
Quoted 37 lines
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>--- .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- 1 file changed, 57 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +5
-3@@ -21,6 +21,7 @@ properties: - qcom,pm8941-wled - qcom,pmi8998-wled - qcom,pm660l-wled + - qcom,pm8150l-wled reg: maxItems: 1@@ -28,12 +29,13 @@ properties: default-brightness: description: brightness value on boot. - minimum: 0 - maximum: 4095 - default: 2048 label: true + max-brightness: + description: + Maximum brightness level. + qcom,cs-out: description: enable current sink output.Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml properties: · line 136
Quoted 5 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +2
-0@@ -130,6 +132,31 @@ properties: This feature is not supported for WLED3. type: boolean + qcom,modulator-sel: + description:Need a '|' at the end to preserve formatting.
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml properties: · line 148
Quoted 12 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +12
-0+ Selects the modulator used for brightness modulation. + Allowed values are, + 0 - Modulator A + 1 - Modulator B + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1 ] + - default: 0 + + qcom,cabc-sel: + description:Need a '|'.
Quoted 30 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +23
-0+ Selects the CABC pin signal used for brightness modulation. + Allowed values are, + 0 - CABC disabled + 1 - CABC 1 + 2 - CABC 2 + 3 - External signal (e.g. LPG) is used for dimming + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1, 2, 3 ] + allOf: - if: properties:@@ -179,6 +206,33 @@ allOf: - const: ovp - const: short + - if: + properties: + compatible: + contains: + enum: + - qcom,pm8150l-wled + + then: + properties: + default-brightness: + minimum: 0 + maximum: 32767Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml allOf: · line 230
Quoted 10 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +10
-0+ + max-brightness: + minimum: 0 + maximum: 32767 + + else: + properties: + default-brightness: + minimum: 0 + maximum: 4095Wrong indentation.
Quoted 12 lines
Quoted 9 lines
Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +5
-1+ + max-brightness: + minimum: 0 + maximum: 4095 + required: - compatible - reg --Quoted 3 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Thanks for reviewing. I will submit the next revision with all the fixes.
Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings
In reply to Kiran GundaQuoted 4 lines · Kiran Gunda
Add WLED5 specific bindings.
Signed-off-by Kiran Gunda <[email protected]>Signed-off-by Subbaraman Narayanamurthy <[email protected]>
If v6 is just reacting to Rob's feedback then feel free to add the following when you recirculate:
Quoted 102 lines
--- .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- 1 file changed, 57 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +57
-3@@ -21,6 +21,7 @@ properties: - qcom,pm8941-wled - qcom,pmi8998-wled - qcom,pm660l-wled + - qcom,pm8150l-wled reg: maxItems: 1@@ -28,12 +29,13 @@ properties: default-brightness: description: brightness value on boot. - minimum: 0 - maximum: 4095 - default: 2048 label: true + max-brightness: + description: + Maximum brightness level. + qcom,cs-out: description: enable current sink output.@@ -130,6 +132,31 @@ properties: This feature is not supported for WLED3. type: boolean + qcom,modulator-sel: + description: + Selects the modulator used for brightness modulation. + Allowed values are, + 0 - Modulator A + 1 - Modulator B + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1 ] + - default: 0 + + qcom,cabc-sel: + description: + Selects the CABC pin signal used for brightness modulation. + Allowed values are, + 0 - CABC disabled + 1 - CABC 1 + 2 - CABC 2 + 3 - External signal (e.g. LPG) is used for dimming + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1, 2, 3 ] + allOf: - if: properties:@@ -179,6 +206,33 @@ allOf: - const: ovp - const: short + - if: + properties: + compatible: + contains: + enum: + - qcom,pm8150l-wled + + then: + properties: + default-brightness: + minimum: 0 + maximum: 32767 + + max-brightness: + minimum: 0 + maximum: 32767 + + else: + properties: + default-brightness: + minimum: 0 + maximum: 4095 + + max-brightness: + minimum: 0 + maximum: 4095 + required: - compatible - regSignature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v5 4/4 backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs
In reply to Kiran GundaFrom: Subbaraman Narayanamurthy <[email protected]>
PM8150L WLED supports the following:
- Two modulators and each sink can use any of the modulator
- Multiple CABC selection options from which one can be selected/enabled
- Multiple brightness width selection (12 bits to 15 bits)
--- drivers/video/backlight/qcom-wled.c | 443 +++++++++++++++++++++++++++++++++++- 1 file changed, 442 insertions(+), 1 deletion(-)
drivers/video/backlight/qcom-wled.c +442 -1
@@ -19,12 +19,15 @@#define WLED_DEFAULT_BRIGHTNESS 2048#define WLED_SOFT_START_DLY_US 10000#define WLED3_SINK_REG_BRIGHT_MAX 0xFFF +#define WLED5_SINK_REG_BRIGHT_MAX_12B 0xFFF +#define WLED5_SINK_REG_BRIGHT_MAX_15B 0x7FFF/* WLED3/WLED4 control registers */ #define WLED3_CTRL_REG_FAULT_STATUS 0x08#define WLED3_CTRL_REG_ILIM_FAULT_BIT BIT(0)#define WLED3_CTRL_REG_OVP_FAULT_BIT BIT(1)#define WLED4_CTRL_REG_SC_FAULT_BIT BIT(2) +#define WLED5_CTRL_REG_OVP_PRE_ALARM_BIT BIT(4)#define WLED3_CTRL_REG_INT_RT_STS 0x10#define WLED3_CTRL_REG_OVP_FAULT_STATUS BIT(1)
@@ -40,6 +43,7 @@#define WLED3_CTRL_REG_OVP 0x4d#define WLED3_CTRL_REG_OVP_MASK GENMASK(1, 0) +#define WLED5_CTRL_REG_OVP_MASK GENMASK(3, 0)#define WLED3_CTRL_REG_ILIMIT 0x4e#define WLED3_CTRL_REG_ILIMIT_MASK GENMASK(2, 0)
@@ -101,6 +105,44 @@#define WLED4_SINK_REG_BRIGHT (n) (0x57 + (n * 0x10)) +/* WLED5 specific control registers */ +#define WLED5_CTRL_REG_OVP_INT_CTL 0x5f +#define WLED5_CTRL_REG_OVP_INT_TIMER_MASK GENMASK(2, 0) + +/* WLED5 specific sink registers */ +#define WLED5_SINK_REG_MOD_A_EN 0x50 +#define WLED5_SINK_REG_MOD_B_EN 0x60 +#define WLED5_SINK_REG_MOD_EN_MASK BIT(7) + +#define WLED5_SINK_REG_MOD_A_SRC_SEL 0x51 +#define WLED5_SINK_REG_MOD_B_SRC_SEL 0x61 +#define WLED5_SINK_REG_MOD_SRC_SEL_HIGH 0 +#define WLED5_SINK_REG_MOD_SRC_SEL_EXT 0x03 +#define WLED5_SINK_REG_MOD_SRC_SEL_MASK GENMASK(1, 0) + +#define WLED5_SINK_REG_MOD_A_BRIGHTNESS_WIDTH_SEL 0x52 +#define WLED5_SINK_REG_MOD_B_BRIGHTNESS_WIDTH_SEL 0x62 +#define WLED5_SINK_REG_BRIGHTNESS_WIDTH_12B 0 +#define WLED5_SINK_REG_BRIGHTNESS_WIDTH_15B 1 + +#define WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB 0x53 +#define WLED5_SINK_REG_MOD_A_BRIGHTNESS_MSB 0x54 +#define WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB 0x63 +#define WLED5_SINK_REG_MOD_B_BRIGHTNESS_MSB 0x64 + +#define WLED5_SINK_REG_MOD_SYNC_BIT 0x65 +#define WLED5_SINK_REG_SYNC_MOD_A_BIT BIT(0) +#define WLED5_SINK_REG_SYNC_MOD_B_BIT BIT(1) +#define WLED5_SINK_REG_SYNC_MASK GENMASK(1, 0) + +/* WLED5 specific per-'string' registers below */ +#define WLED5_SINK_REG_STR_FULL_SCALE_CURR (n) (0x72 + (n * 0x10)) + +#define WLED5_SINK_REG_STR_SRC_SEL (n) (0x73 + (n * 0x10)) +#define WLED5_SINK_REG_SRC_SEL_MOD_A 0 +#define WLED5_SINK_REG_SRC_SEL_MOD_B 1 +#define WLED5_SINK_REG_SRC_SEL_MASK GENMASK(1, 0) +struct wled_var_cfg {const u32 *values;u32 (*fn)(u32 );
@@ -125,6 +167,8 @@ struct wled_config {u32 num_strings;u32 string_i_limit;u32 enabled_strings[WLED_MAX_STRINGS ]; +u32 mod_sel; +u32 cabc_sel;bool cs_out_en;bool ext_gen;bool cabc;
@@ -150,6 +194,7 @@ struct wled {u32 version;bool disabled_by_short;bool has_short_detect; +bool cabc_disabled;int short_irq;int ovp_irq;
@@ -184,6 +229,27 @@ struct wled {bool (*wled_auto_detection_required)(struct wled *wled); }; +enum wled5_mod_sel { +MOD_A , +MOD_B , +MOD_MAX , +}; + +static const u8 wled5_brightness_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB , + [MOD_B ] =WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB , +}; + +static const u8 wled5_src_sel_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_SRC_SEL , + [MOD_B ] =WLED5_SINK_REG_MOD_B_SRC_SEL , +}; + +static const u8 wled5_brt_wid_sel_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_BRIGHTNESS_WIDTH_SEL , + [MOD_B ] =WLED5_SINK_REG_MOD_B_BRIGHTNESS_WIDTH_SEL , +}; +static int wled3_set_brightness (struct wled *wled,u16 brightness) {int rc, i;
@@ -225,6 +291,25 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness)return 0 ; } +static int wled5_set_brightness (struct wled *wled,u16 brightness) +{ +int rc, offset; +u16 low_limit = wled->max_brightness *1 /1000 ; +u8 v[2 ]; + +/* WLED5's lower limit is 0.1% */ +if (brightness < low_limit) + brightness = low_limit; + + v[0 ] = brightness &0xff ; + v[1 ] = (brightness >>8 ) &0x7f ; + + offset = wled5_brightness_reg[wled->cfg.mod_sel]; + rc =regmap_bulk_write (wled->regmap, wled->sink_addr + offset, + v,2 ); +return rc; +} +static void wled_ovp_work (struct work_struct *work) { struct wled *wled = container_of(work,
@@ -282,6 +367,24 @@ static int wled3_sync_toggle(struct wled *wled)return rc; } +static int wled5_sync_toggle (struct wled *wled) +{ +int rc; +u8 val; + + val = (wled->cfg.mod_sel ==MOD_A ) ?WLED5_SINK_REG_SYNC_MOD_A_BIT : +WLED5_SINK_REG_SYNC_MOD_B_BIT ; + rc =regmap_update_bits (wled->regmap, + wled->sink_addr +WLED5_SINK_REG_MOD_SYNC_BIT , +WLED5_SINK_REG_SYNC_MASK , val); +if (rc <0 ) +return rc; + +return regmap_update_bits (wled->regmap, + wled->sink_addr +WLED5_SINK_REG_MOD_SYNC_BIT , +WLED5_SINK_REG_SYNC_MASK ,0 ); +} +static int wled4_ovp_fault_status (struct wled *wled,bool *fault_set) {int rc;
@@ -317,11 +420,67 @@ static int wled4_ovp_fault_status(struct wled *wled, bool *fault_set)return rc; } +static int wled5_ovp_fault_status (struct wled *wled,bool *fault_set) +{ +int rc; +u32 int_rt_sts, fault_sts; + + *fault_set = false; + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_INT_RT_STS , + &int_rt_sts); +if (rc <0 ) { +dev_err (wled->dev,"Failed to read INT_RT_STS rc=%d\n" , rc); +return rc; + } + + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_FAULT_STATUS , + &fault_sts); +if (rc <0 ) { +dev_err (wled->dev,"Failed to read FAULT_STATUS rc=%d\n" , rc); +return rc; + } + +if (int_rt_sts &WLED3_CTRL_REG_OVP_FAULT_STATUS ) + *fault_set = true; + +if (fault_sts & (WLED3_CTRL_REG_OVP_FAULT_BIT | +WLED5_CTRL_REG_OVP_PRE_ALARM_BIT )) + *fault_set = true; + +if (*fault_set) +dev_dbg (wled->dev,"WLED OVP fault detected, int_rt_sts=0x%x fault_sts=0x%x\n" , + int_rt_sts, fault_sts); + +return rc; +} +static int wled4_ovp_delay (struct wled *wled) {return WLED_SOFT_START_DLY_US ; } +static int wled5_ovp_delay (struct wled *wled) +{ +int rc, delay_us; +u32 val; +u8 ovp_timer_ms[8 ] = {1 ,2 ,4 ,8 ,12 ,16 ,20 ,24 }; + +/* For WLED5, get the delay based on OVP timer */ + rc =regmap_read (wled->regmap, wled->ctrl_addr + +WLED5_CTRL_REG_OVP_INT_CTL , &val); +if (rc <0 ) + delay_us = + ovp_timer_ms[val &WLED5_CTRL_REG_OVP_INT_TIMER_MASK ] *1000 ; +else + delay_us =2 *WLED_SOFT_START_DLY_US ; + +dev_dbg (wled->dev,"delay_time_us: %d\n" , delay_us); + +return delay_us; +} +static int wled_update_status (struct backlight_device *bl) {struct wled *wled =bl_get_data (bl);
@@ -384,6 +543,29 @@ static int wled4_cabc_config(struct wled *wled, bool enable)return 0 ; } +static int wled5_cabc_config (struct wled *wled,bool enable) +{ +int rc, offset; +u8 reg; + +if (wled->cabc_disabled) +return 0 ; + + reg = enable ? wled->cfg.cabc_sel :0 ; + offset = wled5_src_sel_reg[wled->cfg.mod_sel]; + rc =regmap_update_bits (wled->regmap, wled->sink_addr + offset, +WLED5_SINK_REG_MOD_SRC_SEL_MASK , reg); +if (rc <0 ) { +pr_err ("Error in configuring CABC rc=%d\n" , rc); +return rc; + } + +if (!wled->cfg.cabc_sel) + wled->cabc_disabled = true; + +return 0 ; +} +#define WLED_SHORT_DLY_MS 20#define WLED_SHORT_CNT_MAX 5#define WLED_SHORT_RESET_CNT_DLY_US USEC_PER_SEC
@@ -615,6 +797,7 @@ static void wled_auto_string_detection(struct wled *wled)#define WLED_AUTO_DETECT_OVP_COUNT 5#define WLED_AUTO_DETECT_CNT_DLY_US USEC_PER_SEC +static bool wled4_auto_detection_required (struct wled *wled) {s64 elapsed_time_us;
@@ -648,6 +831,46 @@ static bool wled4_auto_detection_required(struct wled *wled)return false; } +static bool wled5_auto_detection_required (struct wled *wled) +{ +s64 elapsed_time_us; + +if (!wled->cfg.auto_detection_enabled) +return false; + +/* +* Check if the OVP fault was an occasional one +* or if it's firing continuously, the latter qualifies +* for an auto-detection check. +*/ +if (!wled->auto_detection_ovp_count) { + wled->start_ovp_fault_time =ktime_get (); + wled->auto_detection_ovp_count++; + }else { +/* +* WLED5 has OVP fault density interrupt configuration i.e. to +* count the number of OVP alarms for a certain duration before +* triggering OVP fault interrupt. By default, number of OVP +* fault events counted before an interrupt is fired is 32 and +* the time interval is 12 ms. If we see more than one OVP fault +* interrupt, then that should qualify for a real OVP fault +* condition to run auto calibration algorithm. +*/ + +if (wled->auto_detection_ovp_count >1 ) { + elapsed_time_us =ktime_us_delta (ktime_get (), + wled->start_ovp_fault_time); + wled->auto_detection_ovp_count =0 ; +dev_dbg (wled->dev,"Elapsed time: %lld us\n" , + elapsed_time_us); +return true; + } + wled->auto_detection_ovp_count++; + } + +return false; +} +static int wled_auto_detection_at_init (struct wled *wled) {int rc;
@@ -923,6 +1146,115 @@ static const struct wled_config wled4_config_defaults = { .auto_detection_enabled = false, }; +static int wled5_setup (struct wled *wled) +{ +int rc, temp, i, j; +u8 sink_en =0 ; +u16 addr; +u32 val; + + rc =regmap_update_bits (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_OVP , +WLED5_CTRL_REG_OVP_MASK , wled->cfg.ovp); +if (rc <0 ) +return rc; + + rc =regmap_update_bits (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_ILIMIT , +WLED3_CTRL_REG_ILIMIT_MASK , + wled->cfg.boost_i_limit); +if (rc <0 ) +return rc; + + rc =regmap_update_bits (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_FREQ , +WLED3_CTRL_REG_FREQ_MASK , + wled->cfg.switch_freq); +if (rc <0 ) +return rc; + +/* Per sink/string configuration */ +for (i =0 ; i < wled->cfg.num_strings; ++i) { + j = wled->cfg.enabled_strings[i]; + addr = wled->sink_addr + +WLED4_SINK_REG_STR_FULL_SCALE_CURR (j); + rc =regmap_update_bits (wled->regmap, addr, +WLED4_SINK_REG_STR_FULL_SCALE_CURR_MASK , + wled->cfg.string_i_limit); +if (rc <0 ) +return rc; + + addr = wled->sink_addr +WLED5_SINK_REG_STR_SRC_SEL (j); + rc =regmap_update_bits (wled->regmap, addr, +WLED5_SINK_REG_SRC_SEL_MASK , + wled->cfg.mod_sel ==MOD_A ? +WLED5_SINK_REG_SRC_SEL_MOD_A : +WLED5_SINK_REG_SRC_SEL_MOD_B ); + + temp = j +WLED4_SINK_REG_CURR_SINK_SHFT ; + sink_en |=1 << temp; + } + + rc =wled5_cabc_config (wled, wled->cfg.cabc_sel ? true : false); +if (rc <0 ) +return rc; + +/* Enable one of the modulators A or B based on mod_sel */ + addr = wled->sink_addr +WLED5_SINK_REG_MOD_A_EN ; + val = (wled->cfg.mod_sel ==MOD_A ) ?WLED5_SINK_REG_MOD_EN_MASK :0 ; + rc =regmap_update_bits (wled->regmap, addr, +WLED5_SINK_REG_MOD_EN_MASK , val); +if (rc <0 ) +return rc; + + addr = wled->sink_addr +WLED5_SINK_REG_MOD_B_EN ; + val = (wled->cfg.mod_sel ==MOD_B ) ?WLED5_SINK_REG_MOD_EN_MASK :0 ; + rc =regmap_update_bits (wled->regmap, addr, +WLED5_SINK_REG_MOD_EN_MASK , val); +if (rc <0 ) +return rc; + + addr = wled->sink_addr + wled5_brt_wid_sel_reg[wled->cfg.mod_sel]; + val = (wled->max_brightness ==WLED5_SINK_REG_BRIGHT_MAX_15B ) ? +WLED5_SINK_REG_BRIGHTNESS_WIDTH_15B : +WLED5_SINK_REG_BRIGHTNESS_WIDTH_12B ; + rc =regmap_write (wled->regmap, addr, val); +if (rc <0 ) +return rc; + + rc =regmap_update_bits (wled->regmap, + wled->sink_addr +WLED4_SINK_REG_CURR_SINK , +WLED4_SINK_REG_CURR_SINK_MASK , sink_en); +if (rc <0 ) +return rc; + +/* This updates only FSC configuration in WLED5 */ + rc = wled->wled_sync_toggle (wled); +if (rc <0 ) { +pr_err ("Failed to toggle sync reg rc:%d\n" , rc); +return rc; + } + + rc =wled_auto_detection_at_init (wled); +if (rc <0 ) +return rc; + +return 0 ; +} + +static const struct wled_config wled5_config_defaults = { + .boost_i_limit =5 , + .string_i_limit =10 , + .ovp =4 , + .num_strings =4 , + .switch_freq =11 , + .mod_sel =0 , + .cabc_sel =0 , + .cabc = false, + .external_pfet = false, + .auto_detection_enabled = false, +}; +static const u32 wled3_boost_i_limit_values[] = {105 ,385 ,525 ,805 ,980 ,1260 ,1400 ,1680 , };
@@ -941,6 +1273,16 @@ static const struct wled_var_cfg wled4_boost_i_limit_cfg = { .size = ARRAY_SIZE(wled4_boost_i_limit_values), }; +static inline u32 wled5_boost_i_limit_values_fn (u32 idx) +{ +return 525 + (idx *175 ); +} + +static const struct wled_var_cfg wled5_boost_i_limit_cfg = { + .fn = wled5_boost_i_limit_values_fn, + .size =8 , +}; +static const u32 wled3_ovp_values[] = {35 ,32 ,29 ,27 , };
@@ -959,6 +1301,21 @@ static const struct wled_var_cfg wled4_ovp_cfg = { .size = ARRAY_SIZE(wled4_ovp_values), }; +static inline u32 wled5_ovp_values_fn (u32 idx) +{ +/* +* 0000 - 38.5 V +* 0001 - 37 V .. +* 1111 - 16 V +*/ +return 38500 - (idx *1500 ); +} + +static const struct wled_var_cfg wled5_ovp_cfg = { + .fn = wled5_ovp_values_fn, + .size =16 , +}; +static u32 wled3_num_strings_values_fn (u32 idx) {return idx +1 ;
@@ -1006,6 +1363,14 @@ static const struct wled_var_cfg wled4_string_cfg = { .size = 16, }; +static const struct wled_var_cfg wled5_mod_sel_cfg = { + .size =2 , +}; + +static const struct wled_var_cfg wled5_cabc_sel_cfg = { + .size =4 , +}; +static u32 wled_values (const struct wled_var_cfg *cfg,u32 idx) {if (idx >= cfg->size)
@@ -1082,6 +1447,44 @@ static int wled_configure(struct wled *wled) }, }; +const struct wled_u32_opts wled5_opts[] = { + { + .name ="qcom,current-boost-limit" , + .val_ptr = &cfg->boost_i_limit, + .cfg = &wled5_boost_i_limit_cfg, + }, + { + .name ="qcom,current-limit-microamp" , + .val_ptr = &cfg->string_i_limit, + .cfg = &wled4_string_i_limit_cfg, + }, + { + .name ="qcom,ovp-millivolt" , + .val_ptr = &cfg->ovp, + .cfg = &wled5_ovp_cfg, + }, + { + .name ="qcom,switching-freq" , + .val_ptr = &cfg->switch_freq, + .cfg = &wled3_switch_freq_cfg, + }, + { + .name ="qcom,num-strings" , + .val_ptr = &cfg->num_strings, + .cfg = &wled4_num_strings_cfg, + }, + { + .name ="qcom,modulator-sel" , + .val_ptr = &cfg->mod_sel, + .cfg = &wled5_mod_sel_cfg, + }, + { + .name ="qcom,cabc-sel" , + .val_ptr = &cfg->cabc_sel, + .cfg = &wled5_cabc_sel_cfg, + }, + }; +const struct wled_bool_opts bool_opts[] = { {"qcom,cs-out" , &cfg->cs_out_en, }, {"qcom,ext-gen" , &cfg->ext_gen, },
@@ -1133,6 +1536,27 @@ static int wled_configure(struct wled *wled) wled->sink_addr =be32_to_cpu (*prop_addr);break ; +case 5 : + u32_opts = wled5_opts; + size =ARRAY_SIZE (wled5_opts); + *cfg = wled5_config_defaults; + wled->wled_set_brightness = wled5_set_brightness; + wled->wled_sync_toggle = wled5_sync_toggle; + wled->wled_cabc_config = wled5_cabc_config; + wled->wled_ovp_fault_status = wled5_ovp_fault_status; + wled->wled_ovp_delay = wled5_ovp_delay; + wled->wled_auto_detection_required = + wled5_auto_detection_required; + wled->max_string_count =4 ; + + prop_addr =of_get_address (dev->of_node,1 ,NULL ,NULL ); +if (!prop_addr) { +dev_err (wled->dev,"invalid IO resources\n" ); +return -EINVAL ; + } + wled->sink_addr =be32_to_cpu (*prop_addr); +break ; +default :dev_err (wled->dev,"Invalid WLED version\n" );return -EINVAL ;
@@ -1286,6 +1710,10 @@ static int wled_probe(struct platform_device *pdev)if (rc)return rc; + val =WLED3_SINK_REG_BRIGHT_MAX ; +of_property_read_u32 (pdev->dev.of_node,"max-brightness" , &val); + wled->max_brightness = val; +switch (wled->version) {case 3 : wled->cfg.auto_detection_enabled = false;
@@ -1305,6 +1733,18 @@ static int wled_probe(struct platform_device *pdev) }break ; +case 5 : + wled->has_short_detect = true; +if (wled->cfg.cabc_sel) + wled->max_brightness =WLED5_SINK_REG_BRIGHT_MAX_12B ; + + rc =wled5_setup (wled); +if (rc) { +dev_err (&pdev->dev,"wled5_setup failed\n" ); +return rc; + } +break ; +default :dev_err (wled->dev,"Invalid WLED version\n" );break ;
@@ -1326,7 +1766,7 @@ static int wled_probe(struct platform_device *pdev)memset (&props,0 ,sizeof (struct backlight_properties )); props.type =BACKLIGHT_RAW ; props.brightness = val; - props.max_brightness =WLED3_SINK_REG_BRIGHT_MAX ; + props.max_brightness = wled->max_brightness; bl =devm_backlight_device_register (&pdev->dev, wled->name, &pdev->dev, wled, &wled_ops, &props);
@@ -1349,6 +1789,7 @@ static const struct of_device_id wled_match_table[] = { { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, + { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, {} };MODULE_DEVICE_TABLE (of, wled_match_table);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH V5 4/4] backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs
Quoted 23 lines · Kiran Gunda
From: Subbaraman Narayanamurthy <[email protected]>
PM8150L WLED supports the following:
- Two modulators and each sink can use any of the modulator
- Multiple CABC selection options from which one can be selected/enabled
- Multiple brightness width selection (12 bits to 15 bits)Signed-off-by Subbaraman Narayanamurthy <[email protected]>Signed-off-by Kiran Gunda <[email protected]>--- drivers/video/backlight/qcom-wled.c | 443 +++++++++++++++++++++++++++++++++++- 1 file changed, 442 insertions(+), 1 deletion(-)drivers/video/backlight/qcom-wled.c +5
-0+static const u8 wled5_brightness_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB , + [MOD_B ] =WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB , +}; +
drivers/video/backlight/qcom-wled.c struct wled { · line 252
Quoted 10 lines
drivers/video/backlight/qcom-wled.c +10
-0+static const u8 wled5_src_sel_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_SRC_SEL , + [MOD_B ] =WLED5_SINK_REG_MOD_B_SRC_SEL , +}; + +static const u8 wled5_brt_wid_sel_reg[MOD_MAX ] = { + [MOD_A ] =WLED5_SINK_REG_MOD_A_BRIGHTNESS_WIDTH_SEL , + [MOD_B ] =WLED5_SINK_REG_MOD_B_BRIGHTNESS_WIDTH_SEL , +}; +
Each of these lookup tables are used exactly once... and half the time when this code chooses between MOD_A and MOD_B a ternary is used and half the time these lookup tables.
I suggest these be removed.
drivers/video/backlight/qcom-wled.c static int wled4_set_brightness(struct wled *wled, u16 brightness) · line 297
Quoted 11 lines
static int
wled3_set_brightness(struct wled *wled, u16 brightness){drivers/video/backlight/qcom-wled.c +4
-0int rc, i;@@ -225,6 +291,25 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness)return 0 ; } +static int wled5_set_brightness (struct wled *wled,u16 brightness) +{ +int rc, offset; +u16 low_limit = wled->max_brightness *1 /1000 ;
Multiplying by 1 is redundant.
Quoted 39 lines
drivers/video/backlight/qcom-wled.c +32
-0+u8 v[2 ]; + +/* WLED5's lower limit is 0.1% */ +if (brightness < low_limit) + brightness = low_limit; + + v[0 ] = brightness &0xff ; + v[1 ] = (brightness >>8 ) &0x7f ; + + offset = wled5_brightness_reg[wled->cfg.mod_sel]; + rc =regmap_bulk_write (wled->regmap, wled->sink_addr + offset, + v,2 ); +return rc; +} +static void wled_ovp_work (struct work_struct *work) { struct wled *wled = container_of(work,@@ -317,11 +420,67 @@ static int wled4_ovp_fault_status(struct wled *wled, bool *fault_set)return rc; } +static int wled5_ovp_fault_status (struct wled *wled,bool *fault_set) +{ +int rc; +u32 int_rt_sts, fault_sts; + + *fault_set = false; + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_INT_RT_STS , + &int_rt_sts); +if (rc <0 ) { +dev_err (wled->dev,"Failed to read INT_RT_STS rc=%d\n" , rc); +return rc; + } + + rc =regmap_read (wled->regmap, + wled->ctrl_addr +WLED3_CTRL_REG_FAULT_STATUS , + &fault_sts);
drivers/video/backlight/qcom-wled.c static int wled4_ovp_fault_status(struct wled *wled, bool *fault_set) · line 449
Quoted 10 lines
drivers/video/backlight/qcom-wled.c +10
-0+if (rc <0 ) { +dev_err (wled->dev,"Failed to read FAULT_STATUS rc=%d\n" , rc); +return rc; + } + +if (int_rt_sts &WLED3_CTRL_REG_OVP_FAULT_STATUS ) + *fault_set = true; + +if (fault_sts & (WLED3_CTRL_REG_OVP_FAULT_BIT | +WLED5_CTRL_REG_OVP_PRE_ALARM_BIT ))
Correct me if I'm wrong but isn't the only difference between the WLED4 and WLED5 code that the wled5 code also checks the WLED5_CTRL_REG_OVP_PRE_ALARM_BIT ?
If so why do we need to pull out (and duplicate) this code code using the function pointers?
Quoted 10 lines
drivers/video/backlight/qcom-wled.c +9
-0+ *fault_set = true; + +if (*fault_set) +dev_dbg (wled->dev,"WLED OVP fault detected, int_rt_sts=0x%x fault_sts=0x%x\n" , + int_rt_sts, fault_sts); + +return rc; +} +
drivers/video/backlight/qcom-wled.c static void wled_auto_string_detection(struct wled *wled) · line 800
Quoted 4 lines
drivers/video/backlight/qcom-wled.c +1
-0@@ -615,6 +797,7 @@ static void wled_auto_string_detection(struct wled *wled)#define WLED_AUTO_DETECT_OVP_COUNT 5#define WLED_AUTO_DETECT_CNT_DLY_US USEC_PER_SEC +
Nit picking but this additional line is in the wrong patch ;-)
Quoted 22 lines
drivers/video/backlight/qcom-wled.c +15
-0static bool wled4_auto_detection_required (struct wled *wled) {s64 elapsed_time_us;@@ -648,6 +831,46 @@ static bool wled4_auto_detection_required(struct wled *wled)return false; } +static bool wled5_auto_detection_required (struct wled *wled) +{ +s64 elapsed_time_us; + +if (!wled->cfg.auto_detection_enabled) +return false; + +/* +* Check if the OVP fault was an occasional one +* or if it's firing continuously, the latter qualifies +* for an auto-detection check. +*/ +if (!wled->auto_detection_ovp_count) { + wled->start_ovp_fault_time =ktime_get (); + wled->auto_detection_ovp_count++;
drivers/video/backlight/qcom-wled.c static bool wled4_auto_detection_required(struct wled *wled) · line 858
Quoted 10 lines
drivers/video/backlight/qcom-wled.c +10
-0+ }else { +/* +* WLED5 has OVP fault density interrupt configuration i.e. to +* count the number of OVP alarms for a certain duration before +* triggering OVP fault interrupt. By default, number of OVP +* fault events counted before an interrupt is fired is 32 and +* the time interval is 12 ms. If we see more than one OVP fault +* interrupt, then that should qualify for a real OVP fault +* condition to run auto calibration algorithm. +*/
Given the above why do we have a software mechanism to wait until the second time the interrupt fires? I'm a bit rusty on this driver but wasn't there already some mechanism to slightly delay turning on the fault detection?
Daniel.