Skip to contentSkip to conversation

drm: drm_fourcc: Add uncompressed AFBC modifier

PATCH Superseded Ben Davis 2 participants 2 messages Apr 22, 2020 – Apr 28, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ben Davis

author
#0 lore raw

PATCH 1/1 drm: drm_fourcc: Add uncompressed AFBC modifier

AFBC has a mode that allows use of AFBC with an uncompressed buffer, we add a new modifier to support this mode.

---
 include/uapi/drm/drm_fourcc.h | 6 ++++++
 1 file changed, 6 insertions(+)
include/uapi/drm/drm_fourcc.h +6 -0
index 8bc0b31597d8..97c47baef7fc 100644
@@ -780,6 +780,12 @@ extern "C" {
  */
 #define AFBC_FORMAT_MOD_BCH     (1ULL << 11)
 
+/* AFBC uncompressed storage mode
+ *
+ * Indicates that the buffer is using uncompressed AFBC mode.
+ */
+#define AFBC_FORMAT_MOD_USM	(1ULL << 12)
+
 /*
  * Arm 16x16 Block U-Interleaved modifier
  *
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 13 lines · Ben Davis

AFBC has a mode that allows use of AFBC with an uncompressed buffer, we add a new modifier to support this mode.

---
 include/uapi/drm/drm_fourcc.h | 6 ++++++
 1 file changed, 6 insertions(+)
include/uapi/drm/drm_fourcc.h +0 -0
index 8bc0b31597d8..97c47baef7fc 100644

include/uapi/drm/drm_fourcc.h extern "C" { · line 785

Quoted 6 lines
include/uapi/drm/drm_fourcc.h +3 -0
@@ -780,6 +780,12 @@ extern "C" {
  */
 #define AFBC_FORMAT_MOD_BCH     (1ULL << 11)
 
+/* AFBC uncompressed storage mode
+ *
+ * Indicates that the buffer is using uncompressed AFBC mode.

Since this sounds a bit baffling, might be good to spend a few more words on what exactly this means. If it's just a fancy way of saying linear/untiled, then this shouldn't be a modifier. If it's some kind of specific tiling layout, then I think that should be specified (we've been a bit more lax with the compressor magic soup, but tiled formats are generally fully specced).
-Daniel

Quoted 9 lines
include/uapi/drm/drm_fourcc.h +3 -0
+ */
+#define AFBC_FORMAT_MOD_USM	(1ULL << 12)
+
 /*
  * Arm 16x16 Block U-Interleaved modifier
  *
Signature · 1 line
2.24.0
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel