ath10k: enable rx duration report default for wmi tlv
PATCH 1/1 ath10k: enable rx duration report default for wmi tlv
When run command "iw dev wlan0 station dump", the rx duration is 0. When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of statsis not set by default, so firmware do not report rx duration.
one sample:
localhost # iw wlan0 station dump
Station c4:04:15:5d:97:22 (on wlan0)
inactive time: 48 ms
rx bytes: 21670
rx packets: 147
tx bytes: 11529
tx packets: 100
tx retries: 88
tx failed: 36
beacon loss: 1
beacon rx: 31
rx drop misc: 47
signal: -72 [-74, -75] dBm
signal avg: -71 [-74, -75] dBm beacon signal avg: -71 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 0 us
This patch enable firmware's extened flag of stats by setting flag WMI_TLV_STAT_PEER_EXTD of ar->fw_stats_req_mask which is set in ath10k_core_init_firmware_features via WMI_REQUEST_STATS_CMDID.
After apply this patch, rx duration show value with the command:
Station c4:04:15:5d:97:22 (on wlan0)
inactive time: 883 ms
rx bytes: 44289
rx packets: 265
tx bytes: 10838
tx packets: 93
tx retries: 899
tx failed: 103
beacon loss: 0
beacon rx: 78
rx drop misc: 46
signal: -71 [-74, -76] dBm
signal avg: -70 [-74, -76] dBm beacon signal avg: -70 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 358004 us
This patch do not have side effect for all chips, because function ath10k_debug_fw_stats_request is already exported to debugfs "fw_stats" and WMI_REQUEST_STATS_CMDID is safely sent after condition checked by ath10k_peer_stats_enabled in ath10k_sta_statistics.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
--- drivers/net/wireless/ath/ath10k/debug.c | 2 +- drivers/net/wireless/ath/ath10k/debug.h | 8 ++++++++ drivers/net/wireless/ath/ath10k/mac.c | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/debug.c +1 -1
@@ -349,7 +349,7 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)spin_unlock_bh (&ar->data_lock); } -static int ath10k_debug_fw_stats_request (struct ath10k *ar) +int ath10k_debug_fw_stats_request (struct ath10k *ar) {unsigned long timeout, time_left;int ret;
drivers/net/wireless/ath/ath10k/debug.h +8 -0
@@ -125,6 +125,9 @@ static inline int ath10k_debug_is_extd_tx_stats_enabled(struct ath10k *ar) {return ar->debug.enable_extd_tx_stats; } + +int ath10k_debug_fw_stats_request (struct ath10k *ar); +#else static inline int ath10k_debug_start (struct ath10k *ar)
@@ -192,6 +195,11 @@ static inline int ath10k_debug_is_extd_tx_stats_enabled(struct ath10k *ar)return 0 ; } +static inline int ath10k_debug_fw_stats_request (struct ath10k *ar) +{ +return 0 ; +} +#define ATH10K_DFS_STAT_INC (ar, c) do { } while (0)#define ath10k_debug_get_et_strings NULL
drivers/net/wireless/ath/ath10k/mac.c +2 -0
@@ -8306,6 +8306,8 @@ static void ath10k_sta_statistics(struct ieee80211_hw *hw,if (!ath10k_peer_stats_enabled (ar))return ; +ath10k_debug_fw_stats_request (ar); + sinfo->rx_duration = arsta->rx_duration; sinfo->filled |=BIT_ULL (NL80211_STA_INFO_RX_DURATION );
Signature · 1 line
2.23.0
Quoted 52 lines · Wen Gong
When run command "iw dev wlan0 station dump", the rx duration is 0. When firmware indicate
WMI_UPDATE_STATS_EVENTID, extended flag of statsis not set by default, so firmware do not report rx duration.one sample:
localhost # iw wlan0 station dump
Station c4:04:15:5d:97:22 (on wlan0)inactive time: 48 ms rx bytes: 21670 rx packets: 147 tx bytes: 11529 tx packets: 100 tx retries: 88 tx failed: 36 beacon loss: 1 beacon rx: 31 rx drop misc: 47 signal: -72 [-74, -75] dBm signal avg: -71 [-74, -75] dBmbeacon signal avg: -71 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 0 usThis patch enable firmware's extened flag of stats by setting flag
WMI_TLV_STAT_PEER_EXTDofar->fw_stats_req_maskwhich is set inath10k_core_init_firmware_featuresviaWMI_REQUEST_STATS_CMDID.After apply this patch, rx duration show value with the command:
Station c4:04:15:5d:97:22 (on wlan0)inactive time: 883 ms rx bytes: 44289 rx packets: 265 tx bytes: 10838 tx packets: 93 tx retries: 899 tx failed: 103 beacon loss: 0 beacon rx: 78 rx drop misc: 46 signal: -71 [-74, -76] dBm signal avg: -70 [-74, -76] dBmbeacon signal avg: -70 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 358004 usThis patch do not have side effect for all chips, because function
ath10k_debug_fw_stats_requestis already exported to debugfs "fw_stats" andWMI_REQUEST_STATS_CMDIDis safely sent after condition checked byath10k_peer_stats_enabledinath10k_sta_statistics.
Quoted 4 lines
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
4913e675630e ath10k: enable rx duration report default for wmi tlv
Signature · 3 lines
https://patchwork.kernel.org/patch/11504895/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 52 lines · Wen Gong
When run command "iw dev wlan0 station dump", the rx duration is 0. When firmware indicate
WMI_UPDATE_STATS_EVENTID, extended flag of statsis not set by default, so firmware do not report rx duration.one sample:
localhost # iw wlan0 station dump
Station c4:04:15:5d:97:22 (on wlan0)inactive time: 48 ms rx bytes: 21670 rx packets: 147 tx bytes: 11529 tx packets: 100 tx retries: 88 tx failed: 36 beacon loss: 1 beacon rx: 31 rx drop misc: 47 signal: -72 [-74, -75] dBm signal avg: -71 [-74, -75] dBmbeacon signal avg: -71 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 0 usThis patch enable firmware's extened flag of stats by setting flag
WMI_TLV_STAT_PEER_EXTDofar->fw_stats_req_maskwhich is set inath10k_core_init_firmware_featuresviaWMI_REQUEST_STATS_CMDID.After apply this patch, rx duration show value with the command:
Station c4:04:15:5d:97:22 (on wlan0)inactive time: 883 ms rx bytes: 44289 rx packets: 265 tx bytes: 10838 tx packets: 93 tx retries: 899 tx failed: 103 beacon loss: 0 beacon rx: 78 rx drop misc: 46 signal: -71 [-74, -76] dBm signal avg: -70 [-74, -76] dBmbeacon signal avg: -70 dBm
tx bitrate: 54.0 MBit/s MCS 3 40MHz
rx bitrate: 1.0 MBit/s
rx duration: 358004 usThis patch do not have side effect for all chips, because function
ath10k_debug_fw_stats_requestis already exported to debugfs "fw_stats" andWMI_REQUEST_STATS_CMDIDis safely sent after condition checked byath10k_peer_stats_enabledinath10k_sta_statistics.
Quoted 4 lines
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
4913e675630e ath10k: enable rx duration report default for wmi tlv
Signature · 8 lines
https://patchwork.kernel.org/patch/11504895/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k