perf report: fix warning Comparison of 0/1 to bool variable
PATCH 1/1 perf report: fix warning Comparison of 0/1 to bool variable
Fixes coccicheck warning:
tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Reported-by Hulk Robot <[email protected]>
Signed-off-by Zou Wei <[email protected]>
--- tools/perf/builtin-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-report.c +1 -1
@@ -1400,7 +1400,7 @@ int cmd_report(int argc, const char **argv) }if (branch_call_mode) { callchain_param.key =CCKEY_ADDRESS ; - callchain_param.branch_callstack =1 ; + callchain_param.branch_callstack = true; symbol_conf.use_callchain = true;callchain_register_param (&callchain_param);if (sort_order ==NULL )
Signature · 1 line
2.6.2
Arnaldo Carvalho de Melo
AppliedEm Sun, Apr 26, 2020 at 08:38:03PM +0800, Zou Wei escreveu:
Quoted 3 lines
Fixes coccicheck warning:
tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Fixed the subject line to have "assignment", not "comparison",
Thanks, applied,
- Arnaldo
[tip: perf/core] perf report: Fix warning assignment of 0/1 to bool variable
In reply to Zou WeiThe following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 6fa9c3e779b89612c56f8ee0096b2252d906357a Gitweb: https://git.kernel.org/tip/6fa9c3e779b89612c56f8ee0096b2252d906357a Author: Zou Wei <[email protected]> AuthorDate: Sun, 26 Apr 2020 20:38:03 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00
perf report: Fix warning assignment of 0/1 to bool variable
Fixes coccicheck warning:
tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable
Reported-by Hulk Robot <[email protected]>
Signed-off-by Zou Wei <[email protected]>
Cc Alexander Shishkin <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-report.c +1 -1
@@ -1413,7 +1413,7 @@ repeat: }if (branch_call_mode) { callchain_param.key =CCKEY_ADDRESS ; - callchain_param.branch_callstack =1 ; + callchain_param.branch_callstack = true; symbol_conf.use_callchain = true;callchain_register_param (&callchain_param);if (sort_order ==NULL )