Skip to contentSkip to conversation

perf report: fix warning Comparison of 0/1 to bool variable

PATCH Applied Zou Wei 3 participants 3 messages Apr 26, 2020 – May 8, 2020 perf events

lore
Share & tools
lore

Zou Wei

author
#0 lore raw

PATCH 1/1 perf report: fix warning Comparison of 0/1 to bool variable

Fixes coccicheck warning:

tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable

---
 tools/perf/builtin-report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-report.c +1 -1
index 26d8fc2..02c09fd 100644
@@ -1400,7 +1400,7 @@ int cmd_report(int argc, const char **argv)
 	}
 	if (branch_call_mode) {
 		callchain_param.key = CCKEY_ADDRESS;
-		callchain_param.branch_callstack = 1;
+		callchain_param.branch_callstack = true;
 		symbol_conf.use_callchain = true;
 		callchain_register_param(&callchain_param);
 		if (sort_order == NULL)
Signature · 1 line
2.6.2
#1 lore raw

Em Sun, Apr 26, 2020 at 08:38:03PM +0800, Zou Wei escreveu:

Quoted 3 lines

Fixes coccicheck warning:

tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable

Fixed the subject line to have "assignment", not "comparison",

Thanks, applied,

- Arnaldo

merge bot Applied
#2 lore raw

[tip: perf/core] perf report: Fix warning assignment of 0/1 to bool variable

In reply to Zou Wei
The following commit has been merged into the perf/core branch of tip:

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     6fa9c3e779b89612c56f8ee0096b2252d906357a
Gitweb:        https://git.kernel.org/tip/6fa9c3e779b89612c56f8ee0096b2252d906357a
Author:        Zou Wei <[email protected]>
AuthorDate:    Sun, 26 Apr 2020 20:38:03 +08:00
Committer:     Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00

perf report: Fix warning assignment of 0/1 to bool variable

Fixes coccicheck warning:

tools/perf/builtin-report.c:1403:2-34: WARNING: Assignment of 0/1 to bool variable

---
 tools/perf/builtin-report.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-report.c +1 -1
index 0c32767..7da1342 100644
@@ -1413,7 +1413,7 @@ repeat:
 	}
 	if (branch_call_mode) {
 		callchain_param.key = CCKEY_ADDRESS;
-		callchain_param.branch_callstack = 1;
+		callchain_param.branch_callstack = true;
 		symbol_conf.use_callchain = true;
 		callchain_register_param(&callchain_param);
 		if (sort_order == NULL)