drm/amdgpu: address the static checker warnings V2
Subsystems (2)
PATCH 1/1 drm/amdgpu: address the static checker warnings V2
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4199 amdgpu_device_gpu_recover()
error: we previously assumed 'hive' could be null (see line 4196)
This is introduced by "drm/amdgpu: optimize the gpu reset for XGMI setup V2".
V2: drop this mutex release needed for XGMI since XGMI never fails on
this
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
@@ -4274,7 +4274,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,if (!amdgpu_device_lock_adev (tmp_adev, !hive)) {DRM_INFO ("Bailing on TDR for s_job:%llx, as another already in progress" , job ? job->base.id :-1 ); -mutex_unlock (&hive->hive_lock);return 0 ; }
Signature · 6 lines
2.26.2 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Ping..
-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Wednesday, April 29, 2020 10:39 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; [email protected]; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amdgpu: address the static checker warnings V2
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4199 amdgpu_device_gpu_recover()
error: we previously assumed 'hive' could be null (see line 4196)
This is introduced by "drm/amdgpu: optimize the gpu reset for XGMI setup V2".
V2: drop this mutex release needed for XGMI since XGMI never fails on
this
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
@@ -4274,7 +4274,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,if (!amdgpu_device_lock_adev (tmp_adev, !hive)) {DRM_INFO ("Bailing on TDR for s_job:%llx, as another already in progress" , job ? job->base.id :-1 ); -mutex_unlock (&hive->hive_lock);return 0 ; }
--
2.26.2
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx