Skip to contentSkip to conversation

drm/amdgpu: address the static checker warnings V2

PATCH In review Evan Quan 1 participant 2 messages Apr 29, 2020 – May 6, 2020

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amdgpu: address the static checker warnings V2

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4199 amdgpu_device_gpu_recover()
error: we previously assumed 'hive' could be null (see line 4196)

This is introduced by "drm/amdgpu: optimize the gpu reset for XGMI setup V2".

V2: drop this mutex release needed for XGMI since XGMI never fails on
this

Change-Id I9c22b57abc9f512114112f93fb035f1fecf26beb
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
index 71278942f9f0..900c636c64be 100644
@@ -4274,7 +4274,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 		if (!amdgpu_device_lock_adev(tmp_adev, !hive)) {
 			DRM_INFO("Bailing on TDR for s_job:%llx, as another already in progress",
 				  job ? job->base.id : -1);
-			mutex_unlock(&hive->hive_lock);
 			return 0;
 		}
 
Signature · 6 lines
2.26.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
author
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

Ping..

-----Original Message-----
From: Quan, Evan <[email protected]>
Sent: Wednesday, April 29, 2020 10:39 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; [email protected]; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amdgpu: address the static checker warnings V2

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4199 amdgpu_device_gpu_recover()
error: we previously assumed 'hive' could be null (see line 4196)

This is introduced by "drm/amdgpu: optimize the gpu reset for XGMI setup V2".

V2: drop this mutex release needed for XGMI since XGMI never fails on
this

Change-Id I9c22b57abc9f512114112f93fb035f1fecf26beb
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -1
index 71278942f9f0..900c636c64be 100644
@@ -4274,7 +4274,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 if (!amdgpu_device_lock_adev(tmp_adev, !hive)) {
 DRM_INFO("Bailing on TDR for s_job:%llx, as another already in progress",
   job ? job->base.id : -1);
-mutex_unlock(&hive->hive_lock);
 return 0;
 }
 

--
2.26.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx