Skip to contentSkip to conversation

x86: efi: Add a 64-bit coreboot payload

PATCH New Simon Glass 3 participants 8 messages May 1, 2020 – May 4, 2020

lore
Share & tools
lore
#0 lore raw

v5 cover x86: efi: Add a 64-bit coreboot payload

This series creates a new 64-bit 'coreboot64' build which can be launched from coreboot. It uses SPL to effect the jump to 64-bit mode.

This was done in an attempt to get the Ubuntu FirmwareTestSuite[1] working. Unfortunately the latest version shows a splash screen and hangs, perhaps due to some missing EFI support.

[1] https://wiki.ubuntu.com/FirmwareTestSuite

Changes in v5:
- Rewrite commit message to explain what coreboot is

Simon Glass (1):
x86: Add a 64-bit 'coreboot64' build

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
Signature · 1 line
2.26.2.526.g744177e7f7-goog
#1 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:	Maintained
 F:	board/coreboot/coreboot/
 F:	include/configs/chromebook_link.h
 F:	configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:	Simon Glass <[email protected]>
+S:	Maintained
+F:	board/coreboot/coreboot/
+F:	include/configs/chromebook_link.h
+F:	configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +48 -0

48 lines not on this page · raw message

doc/board/coreboot/coreboot.rst +10 -0
index fd974229eb..9c44c025a4 100644
@@ -40,3 +40,13 @@ To enable video you must enable these options in coreboot:
 At present it seems that for Minnowboard Max, coreboot does not pass through
 the video information correctly (it always says the resolution is 0x0). This
 works correctly for link though.
+
+64-bit U-Boot
+-------------
+
+In addition to the 32-bit 'coreboot' build there is a 'coreboot64' build. This
+produces an image which can be booted from coreboot (32-bit). Internally it
+works by using a 32-bit SPL binary to switch to 64-bit for running U-Boot. It
+can be useful for running UEFI applications, for example.
+
+This has only been lightly tested.
Signature · 1 line
2.26.2.526.g744177e7f7-goog
#2 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

Quoted 18 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Quoted 9 lines

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
#3 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

In reply to Simon Glass
Quoted 51 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:	Maintained
 F:	board/coreboot/coreboot/
 F:	include/configs/chromebook_link.h
 F:	configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:	Simon Glass <[email protected]>
+S:	Maintained
+F:	board/coreboot/coreboot/
+F:	include/configs/chromebook_link.h
+F:	configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +4 -0
new file mode 100644
index 0000000000..80353b8eb3
@@ -0,0 +1,48 @@
+CONFIG_X86=y
+CONFIG_SYS_TEXT_BASE=0x1120000
+CONFIG_ENV_SIZE=0x1000
+CONFIG_NR_DRAM_BANKS=8

configs/coreboot64_defconfig line 14

Quoted 10 lines
configs/coreboot64_defconfig new file +10 -0
+CONFIG_PRE_CON_BUF_ADDR=0x100000
+CONFIG_X86_RUN_64BIT=y
+CONFIG_VENDOR_COREBOOT=y
+CONFIG_TARGET_COREBOOT=y
+CONFIG_SPL_TEXT_BASE=0x1110000
+CONFIG_FIT=y
+CONFIG_FIT_SIGNATURE=y
+CONFIG_SHOW_BOOT_PROGRESS=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"

The coreboot firmware supports a lot of different boards. The board may have two SATA drives or may be using NVME drives instead. Why do we have this BOOTARGS line instead of using CONFIG_DISTRO_DEFAULTS=y?

Best regards

Heinrich

Quoted 53 lines
configs/coreboot64_defconfig new file +34 -0
+CONFIG_PRE_CONSOLE_BUFFER=y
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_LAST_STAGE_INIT=y
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_IDE=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_PART=y
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+# CONFIG_CMD_NFS is not set
+CONFIG_CMD_PING=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_SOUND=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_MAC_PARTITION=y
+# CONFIG_SPL_MAC_PARTITION is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_ISO_PARTITION=y
+CONFIG_EFI_PARTITION=y
+# CONFIG_SPL_EFI_PARTITION is not set
+CONFIG_DEFAULT_DEVICE_TREE="coreboot"
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_REGMAP=y
+CONFIG_SYSCON=y
+# CONFIG_PCI_PNP is not set
+CONFIG_SOUND=y
+CONFIG_SOUND_I8254=y
+CONFIG_CONSOLE_SCROLL_LINES=5
doc/board/coreboot/coreboot.rst +10 -0
index fd974229eb..9c44c025a4 100644
@@ -40,3 +40,13 @@ To enable video you must enable these options in coreboot:
 At present it seems that for Minnowboard Max, coreboot does not pass through
 the video information correctly (it always says the resolution is 0x0). This
 works correctly for link though.
+
+64-bit U-Boot
+-------------
+
+In addition to the 32-bit 'coreboot' build there is a 'coreboot64' build. This
+produces an image which can be booted from coreboot (32-bit). Internally it
+works by using a 32-bit SPL binary to switch to 64-bit for running U-Boot. It
+can be useful for running UEFI applications, for example.
+
+This has only been lightly tested.
#4 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

Hi Heinrich,

Quoted 59 lines · Heinrich Schuchardt
Quoted 57 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:   Maintained
 F:   board/coreboot/coreboot/
 F:   include/configs/chromebook_link.h
 F:   configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:   Simon Glass <[email protected]>
+S:   Maintained
+F:   board/coreboot/coreboot/
+F:   include/configs/chromebook_link.h
+F:   configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +10 -0
new file mode 100644
index 0000000000..80353b8eb3
@@ -0,0 +1,48 @@
+CONFIG_X86=y
+CONFIG_SYS_TEXT_BASE=0x1120000
+CONFIG_ENV_SIZE=0x1000
+CONFIG_NR_DRAM_BANKS=8
+CONFIG_PRE_CON_BUF_ADDR=0x100000
+CONFIG_X86_RUN_64BIT=y
+CONFIG_VENDOR_COREBOOT=y
+CONFIG_TARGET_COREBOOT=y
+CONFIG_SPL_TEXT_BASE=0x1110000
+CONFIG_FIT=y
Quoted 9 lines

configs/coreboot64_defconfig line 14

Quoted 4 lines
configs/coreboot64_defconfig new file +4 -0
+CONFIG_FIT_SIGNATURE=y
+CONFIG_SHOW_BOOT_PROGRESS=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"

The coreboot firmware supports a lot of different boards. The board may have two SATA drives or may be using NVME drives instead. Why do we have this BOOTARGS line instead of using CONFIG_DISTRO_DEFAULTS=y?

Convert coreboot BOOTARGS

#5 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

Hi Heinrich,

Quoted 73 lines · Bin Meng

Hi Heinrich,

Quoted 59 lines · Heinrich Schuchardt
Quoted 57 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:   Maintained
 F:   board/coreboot/coreboot/
 F:   include/configs/chromebook_link.h
 F:   configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:   Simon Glass <[email protected]>
+S:   Maintained
+F:   board/coreboot/coreboot/
+F:   include/configs/chromebook_link.h
+F:   configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +10 -0
new file mode 100644
index 0000000000..80353b8eb3
@@ -0,0 +1,48 @@
+CONFIG_X86=y
+CONFIG_SYS_TEXT_BASE=0x1120000
+CONFIG_ENV_SIZE=0x1000
+CONFIG_NR_DRAM_BANKS=8
+CONFIG_PRE_CON_BUF_ADDR=0x100000
+CONFIG_X86_RUN_64BIT=y
+CONFIG_VENDOR_COREBOOT=y
+CONFIG_TARGET_COREBOOT=y
+CONFIG_SPL_TEXT_BASE=0x1110000
+CONFIG_FIT=y
Quoted 9 lines

configs/coreboot64_defconfig line 14

Quoted 4 lines
configs/coreboot64_defconfig new file +4 -0
+CONFIG_FIT_SIGNATURE=y
+CONFIG_SHOW_BOOT_PROGRESS=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"

The coreboot firmware supports a lot of different boards. The board may have two SATA drives or may be using NVME drives instead. Why do we have this BOOTARGS line instead of using CONFIG_DISTRO_DEFAULTS=y?

Quoted 1 line

Convert coreboot BOOTARGS

Sorry, hit send too soon.

Convert coreboot BOOTARGS to CONFIG_DISTRO_DEFAULTS makes sense.

Let's keep this series as it is.

Would you please come up with a patch to do distro boot for coreboot?

Regards,
Bin

#6 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

Quoted 80 lines · Bin Meng

Hi Heinrich,

Quoted 73 lines · Bin Meng

Hi Heinrich,

Quoted 59 lines · Heinrich Schuchardt
Quoted 57 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:   Maintained
 F:   board/coreboot/coreboot/
 F:   include/configs/chromebook_link.h
 F:   configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:   Simon Glass <[email protected]>
+S:   Maintained
+F:   board/coreboot/coreboot/
+F:   include/configs/chromebook_link.h
+F:   configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +10 -0
new file mode 100644
index 0000000000..80353b8eb3
@@ -0,0 +1,48 @@
+CONFIG_X86=y
+CONFIG_SYS_TEXT_BASE=0x1120000
+CONFIG_ENV_SIZE=0x1000
+CONFIG_NR_DRAM_BANKS=8
+CONFIG_PRE_CON_BUF_ADDR=0x100000
+CONFIG_X86_RUN_64BIT=y
+CONFIG_VENDOR_COREBOOT=y
+CONFIG_TARGET_COREBOOT=y
+CONFIG_SPL_TEXT_BASE=0x1110000
+CONFIG_FIT=y
Quoted 9 lines

configs/coreboot64_defconfig line 14

Quoted 4 lines
configs/coreboot64_defconfig new file +4 -0
+CONFIG_FIT_SIGNATURE=y
+CONFIG_SHOW_BOOT_PROGRESS=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro"

The coreboot firmware supports a lot of different boards. The board may have two SATA drives or may be using NVME drives instead. Why do we have this BOOTARGS line instead of using CONFIG_DISTRO_DEFAULTS=y?

Quoted 1 line

Convert coreboot BOOTARGS

Sorry, hit send too soon.

Quoted 9 lines

Convert coreboot BOOTARGS to CONFIG_DISTRO_DEFAULTS makes sense.

Let's keep this series as it is.

Would you please come up with a patch to do distro boot for coreboot?

Regards,
Bin

If the move to DISTRO_DEFAULTS is done in a follow-up patch, I am fine with the patch merged as is.

Best regards

Heinrich

#7 lore raw

PATCH v5 1/1 x86: Add a 64-bit 'coreboot64' build

In reply to Simon Glass
Quoted 18 lines · Simon Glass

Coreboot is a first-stage bootloader mostly used on x86 devices as an alternative to UEFI. Coreboot runs in 32-bit mode.

U-Boot currently supports booting from coreboot as a second-stage bootloader, also in 32-bit mode. However it is useful to be able to run U-Boot in 64-bit mode. To do this we can have a 32-bit SPL which switches over the CPU and jumps to a 64-bit U-Boot proper.

Add a new 'coreboot64' board for running 64-bit U-Boot from coreboot. This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

This allows running 64-bit EFI images on x86, for example, without needing a native U-Boot port for a board.

---

Quoted 9 lines

Changes in v5:
- Rewrite commit message to explain what coreboot is

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig

applied to u-boot-x86, thanks!