Skip to contentSkip to conversation

hw/i386/vmport: Drop superfluous parenthesis around function typedef

PATCH In review Philippe Mathieu-Daudé 2 participants 3 messages May 5, 2020 – Jul 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/i386/vmport: Drop superfluous parenthesis around function typedef

Drop superfluous parenthesis around VMPortReadFunc typedef (added in d67f679d99, missed to remove when moved in e595112985).

---
 hw/i386/vmport.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/vmport.h +1 -1
index 47eda7a22b..a6624e3045 100644
@@ -27,7 +27,7 @@
 
 #define TYPE_VMPORT "vmport"
 
-typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
+typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
 
 void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
 
Signature · 1 line
2.21.3
#1 lore raw
Quoted 15 lines · Philippe Mathieu-Daudé

Drop superfluous parenthesis around VMPortReadFunc typedef (added in d67f679d99, missed to remove when moved in e595112985).

---
 hw/i386/vmport.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/vmport.h +0 -0
index 47eda7a22b..a6624e3045 100644

hw/i386/vmport.h line 33

Quoted 8 lines
hw/i386/vmport.h +1 -1
@@ -27,7 +27,7 @@
 
 #define TYPE_VMPORT "vmport"
 
-typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
+typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
 
 void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
 

ping?

#2 lore raw
Quoted 18 lines · Philippe Mathieu-Daudé
Quoted 17 lines · Philippe Mathieu-Daudé

Drop superfluous parenthesis around VMPortReadFunc typedef (added in d67f679d99, missed to remove when moved in e595112985).

---
 hw/i386/vmport.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/vmport.h +0 -0
index 47eda7a22b..a6624e3045 100644
@@ -27,7 +27,7 @@
 
 #define TYPE_VMPORT "vmport"
 
Quoted 8 lines

hw/i386/vmport.h line 33

Quoted 6 lines
hw/i386/vmport.h +1 -1
-typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
+typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
 
 void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
 

ping?

Queued for 5.2. Sorry for missing it.

Signature · 1 line
Eduardo