Improvements for kallsyms__parse
Ian Rogers
reviewerv3 cover Improvements for kallsyms__parse
kallsyms__parse is called 4 times during perf record startup. Add a benchmark to measure its performance. Transition it to using the api io.h buffered reading, improving performance by ~8% or saving ~5% from perf record start up time.
v3. Fixed a link error report in hex2u64 by [email protected]. v2. Fix the err return value for success, error reported by
[email protected]. Add clean-up for hex2u64.
Ian Rogers (3):
perf bench: add kallsyms parsing
lib kallsyms: parse using io api
lib kallsyms: move hex2u64 out of header
tools/lib/api/io.h | 3 ++ tools/lib/symbol/kallsyms.c | 86 ++++++++++++++----------------- tools/lib/symbol/kallsyms.h | 2 - tools/perf/bench/Build | 1 + tools/perf/bench/bench.h | 1 + tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++ tools/perf/builtin-bench.c | 1 + tools/perf/util/symbol.c | 14 +++++ 8 files changed, 133 insertions(+), 50 deletions(-) create mode 100644 tools/perf/bench/kallsyms-parse.c
Signature · 1 line
2.26.2.526.g744177e7f7-goog
Ian Rogers
reviewerPATCH v3 1/3 perf bench: add kallsyms parsing
Add a benchmark for kallsyms parsing. Example output:
Running 'internals/kallsyms-parse' benchmark:
Average kallsyms__parse took: 103.971 ms (+- 0.121 ms)
--- tools/perf/bench/Build | 1 + tools/perf/bench/bench.h | 1 + tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++++++ tools/perf/builtin-bench.c | 1 + 4 files changed, 78 insertions(+) create mode 100644 tools/perf/bench/kallsyms-parse.c
tools/perf/bench/Build +1 -0
@@ -9,6 +9,7 @@ perf-y += futex-lock-pi.o perf-y += epoll-wait.o perf-y += epoll-ctl.o perf-y += synthesize.o +perf-y += kallsyms-parse.o perf-$(CONFIG_X86_64) += mem-memcpy-x86-64-lib.o perf-$(CONFIG_X86_64) += mem-memcpy-x86-64-asm.o
tools/perf/bench/bench.h +1 -0
@@ -44,6 +44,7 @@ int bench_futex_lock_pi(int argc, const char **argv);int bench_epoll_wait (int argc,const char **argv);int bench_epoll_ctl (int argc,const char **argv);int bench_synthesize (int argc,const char **argv); +int bench_kallsyms_parse (int argc,const char **argv);#define BENCH_FORMAT_DEFAULT_STR "default"#define BENCH_FORMAT_DEFAULT 0
tools/perf/bench/kallsyms-parse.c new file +75 -0
75 lines not on this page · raw message
tools/perf/builtin-bench.c +1 -0
@@ -78,6 +78,7 @@ static struct bench epoll_benchmarks[] = {static struct bench internals_benchmarks[] = { {"synthesize" ,"Benchmark perf event synthesis" , bench_synthesize }, + {"kallsyms-parse" ,"Benchmark kallsyms parsing" , bench_kallsyms_parse }, {NULL ,NULL ,NULL } };
Signature · 1 line
2.26.2.526.g744177e7f7-goog
Ian Rogers
reviewerPATCH v3 2/3 lib kallsyms: parse using io api
In reply to Ian RogersPerf record will call kallsyms__parse 4 times during startup and process megabytes of data. This changes kallsyms__parse to use the io library rather than fgets to improve performance of the user code by over 8%.
Before:
Running 'internals/kallsyms-parse' benchmark:
Average kallsyms__parse took: 103.988 ms (+- 0.203 ms)
After:
Running 'internals/kallsyms-parse' benchmark:
Average kallsyms__parse took: 95.571 ms (+- 0.006 ms)
For a workload like:
$ perf record /bin/true Run under 'perf record -e cycles:u -g' the time goes from: Before 30.10% 1.67% perf perf [.] kallsyms__parse After 25.55% 20.04% perf perf [.] kallsyms__parse So a little under 5% of the start-up time is removed. A lot of what remains is on the kernel side, but caching kallsyms within perf would at least impact memory footprint.
--- tools/lib/api/io.h | 3 ++ tools/lib/symbol/kallsyms.c | 81 +++++++++++++++++++------------------ 2 files changed, 45 insertions(+), 39 deletions(-)
tools/lib/api/io.h +3 -0
@@ -7,6 +7,9 @@ #ifndef __API_IO__ #define __API_IO__ +#include <stdlib.h> +#include <unistd.h> + struct io { /* File descriptor being read/ */ int fd;
tools/lib/symbol/kallsyms.c +42 -39
110 lines not on this page · raw message
Signature · 1 line
2.26.2.526.g744177e7f7-goog
Ian Rogers
reviewerPATCH v3 3/3 lib kallsyms: move hex2u64 out of header
In reply to Ian Rogershex2u64 is a helper that's out of place in kallsyms.h as not being kallsyms related. Move from kallsyms.h to the only user.
--- tools/lib/symbol/kallsyms.c | 13 ------------- tools/lib/symbol/kallsyms.h | 2 -- tools/perf/util/symbol.c | 14 ++++++++++++++ 3 files changed, 14 insertions(+), 15 deletions(-)
tools/lib/symbol/kallsyms.c +0 -13
@@ -17,19 +17,6 @@ bool kallsyms__is_function(char symbol_type)return symbol_type =='T' || symbol_type =='W' ; } -/* -* While we find nice hex chars, build a long_val. -* Return number of chars processed. -*/ -int hex2u64 (const char *ptr,u64 *long_val) -{ -char *p; - - *long_val =strtoull (ptr, &p,16 ); - -return p - ptr; -} -static void read_to_eol (struct io *io) {int ch;
tools/lib/symbol/kallsyms.h +0 -2
@@ -18,8 +18,6 @@ static inline u8 kallsyms2elf_binding(char type)return isupper (type) ?STB_GLOBAL :STB_LOCAL ; } -int hex2u64 (const char *ptr,u64 *long_val); -u8 kallsyms2elf_type (char type);bool kallsyms__is_function (char symbol_type);
tools/perf/util/symbol.c +14 -0
@@ -566,6 +566,20 @@ void dso__sort_by_name(struct dso *dso)return symbols__sort_by_name (&dso->symbol_names, &dso->symbols); } +/* +* While we find nice hex chars, build a long_val. +* Return number of chars processed. +*/ +static int hex2u64 (const char *ptr,u64 *long_val) +{ +char *p; + + *long_val =strtoull (ptr, &p,16 ); + +return p - ptr; +} + +int modules__parse (const char *filename,void *arg,int (*process_module)(void *arg,const char *name,u64 start,u64 size))
Signature · 1 line
2.26.2.526.g744177e7f7-goog