Skip to content

Improvements for kallsyms__parse

Ian Rogers lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 5 repliesApplied
  3. v11 patch 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3perf bench: add kallsyms parsingtools/perf/bench/Build tools/perf/bench/bench.h tools/perf/bench/kallsyms-parse.c +1 more+78 -00 replies
2/3lib kallsyms: parse using io apitools/lib/api/io.h tools/lib/symbol/kallsyms.c+45 -390 replies
3/3lib kallsyms: move hex2u64 out of headertools/lib/symbol/kallsyms.c tools/lib/symbol/kallsyms.h tools/perf/util/symbol.c+14 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] Improvements for kallsyms__parse

kallsyms__parse is called 4 times during perf record startup. Add a benchmark to measure its performance. Transition it to using the api io.h buffered reading, improving performance by ~8% or saving ~5% from perf record start up time.

v3. Fixed a link error report in hex2u64 by [email protected]. v2. Fix the err return value for success, error reported by
[email protected]. Add clean-up for hex2u64.

Ian Rogers (3):
perf bench: add kallsyms parsing
lib kallsyms: parse using io api
lib kallsyms: move hex2u64 out of header

 tools/lib/api/io.h                |  3 ++
 tools/lib/symbol/kallsyms.c       | 86 ++++++++++++++-----------------
 tools/lib/symbol/kallsyms.h       |  2 -
 tools/perf/bench/Build            |  1 +
 tools/perf/bench/bench.h          |  1 +
 tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++
 tools/perf/builtin-bench.c        |  1 +
 tools/perf/util/symbol.c          | 14 +++++
 8 files changed, 133 insertions(+), 50 deletions(-)
 create mode 100644 tools/perf/bench/kallsyms-parse.c
Signature · 1 line
2.26.2.526.g744177e7f7-goog