ASoC: Intel: Skylake: Update description for HDaudio kconfig
Subsystems (3)
Cezary Rojewski
maintainerPATCH 1/1 ASoC: Intel: Skylake: Update description for HDaudio kconfig
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.
--- sound/soc/intel/Kconfig | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
sound/soc/intel/Kconfig +2 -6
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC bool "HDAudio codec support" help - This option broke audio on Linus' Skylake laptop in December 2018 - and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver. - Distributions should not enable this option and there are no known - users of this capability. + If you have Intel Skylake or Kabylake with HDaudio codec + then enable this option by saying Y or m. config SND_SOC_INTEL_SKYLAKE_COMMON tristate
Signature · 1 line
2.17.1
Quoted 13 lines · Cezary Rojewski
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.
Signed-off-by Cezary Rojewski <[email protected]>--- sound/soc/intel/Kconfig | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)sound/soc/intel/Kconfig +0
-0
sound/soc/intel/Kconfig config SND_SOC_INTEL_SKYLAKE_SSP_CLK · line 212
Quoted 10 lines
sound/soc/intel/Kconfig +1
-6@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC bool "HDAudio codec support" help - This option broke audio on Linus' Skylake laptop in December 2018 - and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver. - Distributions should not enable this option and there are no known - users of this capability. + If you have Intel Skylake or Kabylake with HDaudio codec
I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so
Thanks Cezary.
Quoted 5 lines
sound/soc/intel/Kconfig +1
-0+ then enable this option by saying Y or m. config SND_SOC_INTEL_SKYLAKE_COMMON tristate
Cezary Rojewski
maintainerQuoted 29 lines · Pierre-Louis Bossart
Quoted 15 lines · Cezary Rojewski
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.
Signed-off-by Cezary Rojewski <[email protected]>---
sound/soc/intel/Kconfig| 8 ++------1 file changed, 2 insertions(+), 6 deletions(-)sound/soc/intel/Kconfig +0
-0@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLKconfig
SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
bool "HDAudio codec support"Quoted 8 lines
help
- This option broke audio on Linus' Skylake laptop in December 2018 - and the race conditions during the probe were not fixed since. - This option is DEPRECATED, all HDaudio codec support needs - to be handled by the SOF driver.
- Distributions should not enable this option and there are no known - users of this capability.
+ If you have Intel Skylake or Kabylake with HDaudio codecI would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so
Quoted 9 lines
Thanks Cezary.
Quoted 4 lines
+ then enable this option by saying Y or m.
configSND_SOC_INTEL_SKYLAKE_COMMON
tristate
Do you want me to spin v3? While copying desc from other kconfgs, I added 'or m' by mistake. Don't mind to update once more if you want me to.
Czarek
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines
+ If you have Intel Skylake or Kabylake with HDaudio codec
I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so
Thanks Cezary.
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
+ then enable this option by saying Y or m.
configSND_SOC_INTEL_SKYLAKE_COMMON
tristateDo you want me to spin v3? While copying desc from other kconfgs, I added 'or m' by mistake. Don't mind to update once more if you want me to.
That would be nicer indeed if you don't mind, thanks!