Skip to contentSkip to conversation

ASoC: Intel: Skylake: Update description for HDaudio kconfig

PATCH Superseded Cezary Rojewski 2 participants 4 messages May 6, 2020

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Cezary Rojewski

author maintainer
#0 lore raw

PATCH 1/1 ASoC: Intel: Skylake: Update description for HDaudio kconfig

With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.

---
 sound/soc/intel/Kconfig | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
sound/soc/intel/Kconfig +2 -6
index c8de0bb5bed9..4d11f4f3f7e2 100644
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
 config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
 	bool "HDAudio codec support"
 	help
-	  This option broke audio on Linus' Skylake laptop in December 2018
-	  and the race conditions during the probe were not fixed since.
-	  This option is DEPRECATED, all HDaudio codec support needs
-	  to be handled by the SOF driver.
-	  Distributions should not enable this option and there are no known
-	  users of this capability.
+	  If you have Intel Skylake or Kabylake with HDaudio codec
+	  then enable this option by saying Y or m.
 
 config SND_SOC_INTEL_SKYLAKE_COMMON
 	tristate
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Cezary Rojewski

With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.

---
  sound/soc/intel/Kconfig | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)
sound/soc/intel/Kconfig +0 -0
index c8de0bb5bed9..4d11f4f3f7e2 100644

sound/soc/intel/Kconfig config SND_SOC_INTEL_SKYLAKE_SSP_CLK · line 212

Quoted 10 lines
sound/soc/intel/Kconfig +1 -6
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
  config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
  	bool "HDAudio codec support"
  	help
-	  This option broke audio on Linus' Skylake laptop in December 2018
-	  and the race conditions during the probe were not fixed since.
-	  This option is DEPRECATED, all HDaudio codec support needs
-	  to be handled by the SOF driver.
-	  Distributions should not enable this option and there are no known
-	  users of this capability.
+	  If you have Intel Skylake or Kabylake with HDaudio codec

I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so

Thanks Cezary.

Quoted 5 lines
sound/soc/intel/Kconfig +1 -0
+	  then enable this option by saying Y or m.
 
  config SND_SOC_INTEL_SKYLAKE_COMMON
  	tristate
author maintainer
#2 lore raw
Quoted 29 lines · Pierre-Louis Bossart
Quoted 15 lines · Cezary Rojewski

With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied, warning is no longer true. Remove it and update the description.

---
  sound/soc/intel/Kconfig | 8 ++------

  1 file changed, 2 insertions(+), 6 deletions(-)
sound/soc/intel/Kconfig +0 -0
index c8de0bb5bed9..4d11f4f3f7e2 100644
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK

  config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
      bool "HDAudio codec support"

Quoted 8 lines

      help
-      This option broke audio on Linus' Skylake laptop in December 2018 -      and the race conditions during the probe were not fixed since. -      This option is DEPRECATED, all HDaudio codec support needs -      to be handled by the SOF driver.
-      Distributions should not enable this option and there are no known -      users of this capability.
+      If you have Intel Skylake or Kabylake with HDaudio codec

I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so

Quoted 9 lines

Thanks Cezary.

Quoted 4 lines

+      then enable this option by saying Y or m.
  config SND_SOC_INTEL_SKYLAKE_COMMON
      tristate

Do you want me to spin v3? While copying desc from other kconfgs, I added 'or m' by mistake. Don't mind to update once more if you want me to.

Czarek

#3 lore raw
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

+      If you have Intel Skylake or Kabylake with HDaudio codec

I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so

Thanks Cezary.

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

+      then enable this option by saying Y or m.
  config SND_SOC_INTEL_SKYLAKE_COMMON
      tristate

Do you want me to spin v3? While copying desc from other kconfgs, I added 'or m' by mistake. Don't mind to update once more if you want me to.

That would be nicer indeed if you don't mind, thanks!