Skip to contentSkip to conversation

arm64: dts: ti: k3-am654-main: Update otap-del-sel values

PATCH Superseded Faiz Abbas 2 participants 4 messages May 7, 2020 – May 19, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Faiz Abbas

author
#0 lore raw

PATCH v2 1/1 arm64: dts: ti: k3-am654-main: Update otap-del-sel values

According to the latest AM65x Data Manual[1], a different output tap delay value is optimum for a given speed mode. Update these values.

[1] http://www.ti.com/lit/gpn/am6526

---
v2: Rebased to the latest mainline kernel

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +11 -1
index 11887c72f23a..6cd9701e4ead 100644
@@ -244,7 +244,17 @@
 		interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
 		mmc-ddr-1_8v;
 		mmc-hs200-1_8v;
-		ti,otap-del-sel = <0x2>;
+		ti,otap-del-sel-legacy = <0x0>;
+		ti,otap-del-sel-mmc-hs = <0x0>;
+		ti,otap-del-sel-sd-hs = <0x0>;
+		ti,otap-del-sel-sdr12 = <0x0>;
+		ti,otap-del-sel-sdr25 = <0x0>;
+		ti,otap-del-sel-sdr50 = <0x8>;
+		ti,otap-del-sel-sdr104 = <0x5>;
+		ti,otap-del-sel-ddr50 = <0x5>;
+		ti,otap-del-sel-ddr52 = <0x5>;
+		ti,otap-del-sel-hs200 = <0x5>;
+		ti,otap-del-sel-hs400 = <0x0>;
 		ti,trm-icp = <0x8>;
 		dma-coherent;
 	};
Signature · 1 line
2.17.1
author
#1 lore raw

Tero,

Quoted 9 lines · Faiz Abbas

According to the latest AM65x Data Manual[1], a different output tap delay value is optimum for a given speed mode. Update these values.

[1] http://www.ti.com/lit/gpn/am6526

---
v2: Rebased to the latest mainline kernel

Gentle ping.

Thanks,
Faiz

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
In reply to Faiz Abbas
Quoted 18 lines · Faiz Abbas

According to the latest AM65x Data Manual[1], a different output tap delay value is optimum for a given speed mode. Update these values.

[1] http://www.ti.com/lit/gpn/am6526

---
v2: Rebased to the latest mainline kernel

  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -0
index 11887c72f23a..6cd9701e4ead 100644
@@ -244,7 +244,17 @@
  		interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 253

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +7 -1
  		mmc-ddr-1_8v;
  		mmc-hs200-1_8v;
-		ti,otap-del-sel = <0x2>;
+		ti,otap-del-sel-legacy = <0x0>;
+		ti,otap-del-sel-mmc-hs = <0x0>;
+		ti,otap-del-sel-sd-hs = <0x0>;
+		ti,otap-del-sel-sdr12 = <0x0>;
+		ti,otap-del-sel-sdr25 = <0x0>;
+		ti,otap-del-sel-sdr50 = <0x8>;
+		ti,otap-del-sel-sdr104 = <0x5>;

Isn't this wrong? Doc claims the value for sdr104 should be 0x7?

-Tero

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 260

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +4 -0
+		ti,otap-del-sel-ddr50 = <0x5>;
+		ti,otap-del-sel-ddr52 = <0x5>;
+		ti,otap-del-sel-hs200 = <0x5>;
+		ti,otap-del-sel-hs400 = <0x0>;
  		ti,trm-icp = <0x8>;
  		dma-coherent;
  	};

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#3 lore raw

Hi Tero,

Quoted 23 lines · Tero Kristo
Quoted 22 lines · Faiz Abbas

According to the latest AM65x Data Manual[1], a different output tap delay value is optimum for a given speed mode. Update these values.

[1] http://www.ti.com/lit/gpn/am6526

---
v2: Rebased to the latest mainline kernel

  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 12 +++++++++++-

  1 file changed, 11 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
index 11887c72f23a..6cd9701e4ead 100644
@@ -244,7 +244,17 @@
           interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
           mmc-ddr-1_8v;
           mmc-hs200-1_8v;
-        ti,otap-del-sel = <0x2>;
+        ti,otap-del-sel-legacy = <0x0>;
Quoted 9 lines

arch/arm64/boot/dts/ti/k3-am65-main.dtsi line 253

Quoted 6 lines
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +6 -0
+        ti,otap-del-sel-mmc-hs = <0x0>;
+        ti,otap-del-sel-sd-hs = <0x0>;
+        ti,otap-del-sel-sdr12 = <0x0>;
+        ti,otap-del-sel-sdr25 = <0x0>;
+        ti,otap-del-sel-sdr50 = <0x8>;
+        ti,otap-del-sel-sdr104 = <0x5>;

Isn't this wrong? Doc claims the value for sdr104 should be 0x7?

Yes. There seems to be an update to the document since I last updated the value. Thanks for catching. I will post another version soon.

Thanks,
Faiz

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel