ACPI/IORT: Remove the unused __get_pci_rid()
Subsystems (2)
PATCH 1/1 ACPI/IORT: Remove the unused __get_pci_rid()
Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed.
--- drivers/acpi/arm64/iort.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/acpi/arm64/iort.c +0 -9
@@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)dev_set_msi_domain (dev, msi_domain); } -static int __maybe_unused __get_pci_rid (struct pci_dev *pdev,u16 alias, -void *data) -{ -u32 *rid = data; - - *rid = alias; -return 0 ; -} -#ifdef CONFIG_IOMMU_API static struct acpi_iort_node *iort_get_msi_resv_iommu (struct device *dev) {
Signature · 1 line
2.19.1
Quoted 4 lines · Zenghui Yu
Since commit
bc8648d49a95("ACPI/IORT: Handle PCI aliases properly for IOMMUs"),__get_pci_rid()has become actually unused and can be removed.Signed-off-by Zenghui Yu <[email protected]>
Looks good to me,
Quoted 9 lines · Hanjun Guo
Quoted 4 lines · Zenghui Yu
Since commit
bc8648d49a95("ACPI/IORT: Handle PCI aliases properly for IOMMUs"),__get_pci_rid()has become actually unused and can be removed.Signed-off-by Zenghui Yu <[email protected]>Looks good to me,
Acked-by Hanjun Guo <[email protected]>
Hi Will,
Could you please take this patch [*] into v5.8 (if it's not too late)? I've tried and it can be applied to for-next/acpi cleanly.
[*] https://lore.kernel.org/linux-acpi/[email protected]/
Thanks,
Zenghui
Quoted 7 lines · Zenghui Yu
Since commit
bc8648d49a95("ACPI/IORT: Handle PCI aliases properly for IOMMUs"),__get_pci_rid()has become actually unused and can be removed.Signed-off-by Zenghui Yu <[email protected]>--- drivers/acpi/arm64/iort.c | 9 --------- 1 file changed, 9 deletions(-)
If we miss v5.8 (which I think it is likely, even though this patch is just removing dead code so it is safe at this stage) I will resend it for v5.9 - not a problem.
Lorenzo
Quoted 23 lines
drivers/acpi/arm64/iort.c +0
-9@@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)dev_set_msi_domain (dev, msi_domain); } -static int __maybe_unused __get_pci_rid (struct pci_dev *pdev,u16 alias, -void *data) -{ -u32 *rid = data; - - *rid = alias; -return 0 ; -} -#ifdef CONFIG_IOMMU_API static struct acpi_iort_node *iort_get_msi_resv_iommu (struct device *dev) {Signature · 1 line
2.19.1
Quoted 2 lines · Zenghui Yu
Since commit
bc8648d49a95("ACPI/IORT: Handle PCI aliases properly for IOMMUs"),__get_pci_rid()has become actually unused and can be removed.
Applied to arm64 (for-next/acpi), thanks!
[1/1] ACPI/IORT: Remove the unused __get_pci_rid()
https://git.kernel.org/arm64/c/09cda9a71350
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev