Skip to contentSkip to conversation

ACPI/IORT: Remove the unused __get_pci_rid()

PATCH Applied Zenghui Yu 4 participants 5 messages May 9, 2020 – May 26, 2020

Subsystems (2)
lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

PATCH 1/1 ACPI/IORT: Remove the unused __get_pci_rid()

Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed.

---
 drivers/acpi/arm64/iort.c | 9 ---------
 1 file changed, 9 deletions(-)
drivers/acpi/arm64/iort.c +0 -9
index 7d04424189df..ec94dbb60c7a 100644
@@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)
 		dev_set_msi_domain(dev, msi_domain);
 }
 
-static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias,
-					void *data)
-{
-	u32 *rid = data;
-
-	*rid = alias;
-	return 0;
-}
-
 #ifdef CONFIG_IOMMU_API
 static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev)
 {
Signature · 1 line
2.19.1
author
#2 lore raw
Quoted 9 lines · Hanjun Guo
Quoted 4 lines · Zenghui Yu

Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed.

Looks good to me,

Hi Will,

Could you please take this patch [*] into v5.8 (if it's not too late)? I've tried and it can be applied to for-next/acpi cleanly.

[*] https://lore.kernel.org/linux-acpi/[email protected]/

Thanks,
Zenghui

Acked-by on v1 1/1
#3 lore raw
In reply to Zenghui Yu
Quoted 7 lines · Zenghui Yu

Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed.

---
 drivers/acpi/arm64/iort.c | 9 ---------
 1 file changed, 9 deletions(-)

If we miss v5.8 (which I think it is likely, even though this patch is just removing dead code so it is safe at this stage) I will resend it for v5.9 - not a problem.

Lorenzo

Quoted 23 lines
drivers/acpi/arm64/iort.c +0 -9
index 7d04424189df..ec94dbb60c7a 100644
@@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)
 		dev_set_msi_domain(dev, msi_domain);
 }
 
-static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias,
-					void *data)
-{
-	u32 *rid = data;
-
-	*rid = alias;
-	return 0;
-}
-
 #ifdef CONFIG_IOMMU_API
 static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev)
 {
Signature · 1 line
2.19.1
maintainer Applied
#4 lore raw
In reply to Zenghui Yu
Quoted 2 lines · Zenghui Yu

Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed.

Applied to arm64 (for-next/acpi), thanks!

[1/1] ACPI/IORT: Remove the unused __get_pci_rid()

      https://git.kernel.org/arm64/c/09cda9a71350

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev