iio: adc: exynos: Simplify Exynos7-specific init
Subsystems (2)
Krzysztof Kozlowski
maintainerPATCH 1/1 iio: adc: exynos: Simplify Exynos7-specific init
The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data instance. Therefore the initialization code does not have to check if it is true.
---
Only build tested.
--- drivers/iio/adc/exynos_adc.c | 3 --- 1 file changed, 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -3
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info) {u32 con1, con2; -if (info->data->needs_adc_phy) -regmap_write (info->pmu_map, info->data->phy_offset,1 ); - con1 =ADC_V2_CON1_SOFT_RESET ;writel (con1,ADC_V2_CON1 (info->regs));
Signature · 1 line
2.17.1
Hello Krzysztof,
Thanks for the patch.
Quoted 12 lines
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: 11 May 2020 14:04
To: Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald- Stadler <[email protected]>; Kukjin Kim <[email protected]>; Krzysztof Kozlowski <[email protected]>; [email protected]; linux-arm- [email protected]; [email protected]; linux- [email protected]
Cc: Alim Akhtar <[email protected]>
Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
Quoted 3 lines
The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set inexynos7_adc_datainstance. Therefore the initialization code does not have to check if it
is true.
Quoted 3 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>
Tested on exynos7-espresso board so,
drivers/iio/adc/exynos_adc.c
Quoted 8 lines
---
Only build tested.
--- drivers/iio/adc/exynos_adc.c | 3 --- 1 file changed, 3 deletions(-)drivers/iio/adc/exynos_adc.c +0
-0
index
Quoted 15 lines
22131a677445..219c8eb32d16100644drivers/iio/adc/exynos_adc.c +0
-4@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info) {u32 con1, con2; -if (info->data->needs_adc_phy) -regmap_write (info->pmu_map, info->data->phy_offset,1 ); - con1 =ADC_V2_CON1_SOFT_RESET ;writel (con1,ADC_V2_CON1 (info->regs)); --2.17.1
Jonathan Cameron
maintainerQuoted 18 lines · On Mon, 11 May 2020 22:49:28 +0530 "Alim Akhtar" <[email protected]>…
Hello Krzysztof,
Thanks for the patch.Quoted 12 lines
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: 11 May 2020 14:04
To: Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald- Stadler <[email protected]>; Kukjin Kim <[email protected]>; Krzysztof Kozlowski <[email protected]>; [email protected]; linux-arm- [email protected]; [email protected]; linux- [email protected]
Cc: Alim Akhtar <[email protected]>
Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific initQuoted 3 lines
The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set inexynos7_adc_datainstance. Therefore the initialization code does not have to check if it
Quoted 7 lines
is true.
Quoted 3 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Alim Akhtar <[email protected]>Tested on exynos7-espresso board so,
Tested-by Alim Akhtar <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
Quoted 27 lines
drivers/iio/adc/exynos_adc.c
Quoted 9 lines
---
Only build tested.
--- drivers/iio/adc/exynos_adc.c | 3 --- 1 file changed, 3 deletions(-)drivers/iio/adc/exynos_adc.c +0
-0index
Quoted 15 lines
22131a677445..219c8eb32d16100644drivers/iio/adc/exynos_adc.c +0
-4@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info) {u32 con1, con2; -if (info->data->needs_adc_phy) -regmap_write (info->pmu_map, info->data->phy_offset,1 ); - con1 =ADC_V2_CON1_SOFT_RESET ;writel (con1,ADC_V2_CON1 (info->regs)); --2.17.1