Skip to contentSkip to conversation

iio: adc: exynos: Simplify Exynos7-specific init

PATCH In review Krzysztof Kozlowski 3 participants 3 messages May 11, 2020 – May 16, 2020

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: exynos: Simplify Exynos7-specific init

The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data instance. Therefore the initialization code does not have to check if it is true.

---

Only build tested.

---
 drivers/iio/adc/exynos_adc.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -3
index 22131a677445..219c8eb32d16 100644
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct exynos_adc *info)
 {
 	u32 con1, con2;
 
-	if (info->data->needs_adc_phy)
-		regmap_write(info->pmu_map, info->data->phy_offset, 1);
-
 	con1 = ADC_V2_CON1_SOFT_RESET;
 	writel(con1, ADC_V2_CON1(info->regs));
 
Signature · 1 line
2.17.1
reviewer Reviewed-by Tested-by on v1 1/1
#1 lore raw

Hello Krzysztof,
Thanks for the patch.

Quoted 12 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: 11 May 2020 14:04
To: Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald- Stadler <[email protected]>; Kukjin Kim <[email protected]>; Krzysztof Kozlowski <[email protected]>; [email protected]; linux-arm- [email protected]; [email protected]; linux- [email protected]
Cc: Alim Akhtar <[email protected]>
Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init

Quoted 3 lines

The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data instance. Therefore the initialization code does not have to check if it

is true.

Quoted 3 lines

Tested on exynos7-espresso board so,

drivers/iio/adc/exynos_adc.c

Quoted 8 lines

---

Only build tested.

---
 drivers/iio/adc/exynos_adc.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -0

index

Quoted 15 lines

22131a677445..219c8eb32d16 100644

drivers/iio/adc/exynos_adc.c +0 -4
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
 exynos_adc *info)  {
 	u32 con1, con2;
 
-	if (info->data->needs_adc_phy)
-		regmap_write(info->pmu_map, info->data->phy_offset, 1);
-
 	con1 = ADC_V2_CON1_SOFT_RESET;
 	writel(con1, ADC_V2_CON1(info->regs));
 
--

2.17.1

maintainer
#2 lore raw
Quoted 18 lines · On Mon, 11 May 2020 22:49:28 +0530 "Alim Akhtar" <[email protected]>…

Hello Krzysztof,
Thanks for the patch.

Quoted 12 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: 11 May 2020 14:04
To: Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald- Stadler <[email protected]>; Kukjin Kim <[email protected]>; Krzysztof Kozlowski <[email protected]>; [email protected]; linux-arm- [email protected]; [email protected]; linux- [email protected]
Cc: Alim Akhtar <[email protected]>
Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init

Quoted 3 lines

The Exynos7-specific code bits in ADC driver do not play with PHY:
the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data instance. Therefore the initialization code does not have to check if it

Quoted 7 lines

is true.

Quoted 3 lines

Tested on exynos7-espresso board so,

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 27 lines

drivers/iio/adc/exynos_adc.c

Quoted 9 lines

---

Only build tested.

---
 drivers/iio/adc/exynos_adc.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/iio/adc/exynos_adc.c +0 -0

index

Quoted 15 lines

22131a677445..219c8eb32d16 100644

drivers/iio/adc/exynos_adc.c +0 -4
@@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
 exynos_adc *info)  {
 	u32 con1, con2;
 
-	if (info->data->needs_adc_phy)
-		regmap_write(info->pmu_map, info->data->phy_offset, 1);
-
 	con1 = ADC_V2_CON1_SOFT_RESET;
 	writel(con1, ADC_V2_CON1(info->regs));
 
--

2.17.1