Skip to contentSkip to conversation

gpio: add possibility to search for gpio label name

PATCH Superseded Heiko Schocher 4 participants 10 messages May 15, 2020 – Jul 3, 2020 GPIO

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover gpio: add possibility to search for gpio label name

search for gpio label if gpio name from bankname is not found.

This makes sense on boards with different hardware verions. You can now search for the gpio label name, and can give the gpio a unique name. The real gpio pin number is not needed in board code anymore.

while at it add basic gpio hog test functions in seperate patch.

Travis build:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/687305014

Changes in v5:
- add comment from patrick, update the descriptor flags in _dm_gpio_set_dir_flags() if setting direction was OK.

Changes in v4:
- new in version 4
- rebased to current master ac14bc4169
- rebased to current master ac14bc4169

Changes in v3:
- add comment from Simon Glass
make this new function configurable through Kconfig option DM_GPIO_LOOKUP_LABEL

Changes in v2:
- add basic gpio hog test functions
- add comment from Simon Glass
move code into seperate function dm_gpio_lookup_label() add test if dm_gpio_lookup_label() works

Heiko Schocher (3):
gpio-uclass.c: save the GPIOD flags also in the gpio descriptor sandbox, test: add test for GPIO_HOG function
gpio: search for gpio label if gpio is not found through bank name

 arch/sandbox/dts/test.dts          | 20 +++++++++++
 configs/sandbox64_defconfig        |  1 +
 configs/sandbox_defconfig          |  1 +
 configs/sandbox_flattree_defconfig |  1 +
 configs/sandbox_spl_defconfig      |  1 +
 drivers/gpio/Kconfig               | 22 ++++++++++++
 drivers/gpio/gpio-uclass.c         | 55 +++++++++++++++++++++++++++---
 test/dm/gpio.c                     | 30 ++++++++++++++++
 8 files changed, 127 insertions(+), 4 deletions(-)
Signature · 1 line
2.24.1
#1 lore raw

PATCH v5 1/3 gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

save the GPIOD_ flags also in the gpio descriptor.

---

Changes in v5:
- add comment from patrick, update the descriptor flags in _dm_gpio_set_dir_flags() if setting direction was OK.

Changes in v4:
- new in version 4

Changes in v3: None
Changes in v2: None

 drivers/gpio/gpio-uclass.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpio/gpio-uclass.c +4 -4
index d3cea11f76..d241263970 100644
@@ -599,6 +599,10 @@ static int _dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
 		}
 	}
 
+	/* save the flags also in descriptor */
+	if (!ret)
+		desc->flags = flags;
+
 	return ret;
 }
 
@@ -614,10 +618,6 @@ int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
 	flags |= desc->flags;
 	ret = _dm_gpio_set_dir_flags(desc, flags);
 
-	/* update the descriptor flags */
-	if (ret)
-		desc->flags = flags;
-
 	return ret;
 }
 
Signature · 1 line
2.24.1
#2 lore raw

PATCH v5 1/3 gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

Hi Heiko

Quoted 14 lines

From: Heiko Schocher <[email protected]>
Sent: vendredi 15 mai 2020 16:01

save the GPIOD_ flags also in the gpio descriptor.

---

Changes in v5:
- add comment from patrick, update the descriptor flags in _dm_gpio_set_dir_flags() if setting direction was OK.

Quoted 9 lines

Changes in v4:
- new in version 4

Changes in v3: None
Changes in v2: None

 drivers/gpio/gpio-uclass.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Fixes 788ea834124b ("gpio: add function _dm_gpio_set_dir_flags")

Thanks

Patrick

#3 lore raw

PATCH v5 1/3 gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

In reply to Heiko Schocher
Quoted 12 lines · Heiko Schocher

save the GPIOD_ flags also in the gpio descriptor.

---

Changes in v5:
- add comment from patrick, update the descriptor flags in _dm_gpio_set_dir_flags() if setting direction was OK.

Quoted 9 lines

Changes in v4:
- new in version 4

Changes in v3: None
Changes in v2: None

 drivers/gpio/gpio-uclass.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Would be good mention 'why' in patches like this.

#4 lore raw

PATCH v5 1/3 gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

In reply to Heiko Schocher

Hi Heiko,

Quoted 5 lines · Heiko Schocher

save the GPIOD_ flags also in the gpio descriptor.

This fixes SD card access on Hummingboard2. Current master uses the wrong out polarity to control the SD card power regulator.

Should go to v2020.07 I believe.

One more comment below.

drivers/gpio/gpio-uclass.c int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags) · line 621

Quoted 9 lines
drivers/gpio/gpio-uclass.c +0 -4
@@ -614,10 +618,6 @@ int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
 	flags |= desc->flags;
 	ret = _dm_gpio_set_dir_flags(desc, flags);
 
-	/* update the descriptor flags */
-	if (ret)
-		desc->flags = flags;
-
 	return ret;

You can just do

  return _dm_gpio_set_dir_flags(desc, flags);

here instead.

Thanks,
baruch

Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#5 lore raw

PATCH v5 1/3 gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

Hello Baruch,

Am 02.07.2020 um 21:05 schrieb Baruch Siach:

Quoted 9 lines

Hi Heiko,

Quoted 5 lines · Heiko Schocher

save the GPIOD_ flags also in the gpio descriptor.

Quoted 6 lines

This fixes SD card access on Hummingboard2. Current master uses the wrong out polarity to control the SD card power regulator.

Should go to v2020.07 I believe.

Toms decision... but it seems this bug pops up on more and more boards, as also some days ago Walter reported that this patch fixes a problem on iMX6 Hummingboard with mmc...

There is also a v6 version of this patchset ... see:

http://patchwork.ozlabs.org/project/uboot/list/?series=178637

Quoted 14 lines

One more comment below.

drivers/gpio/gpio-uclass.c int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags) · line 621

Quoted 9 lines
drivers/gpio/gpio-uclass.c +0 -4
@@ -614,10 +618,6 @@ int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
  	flags |= desc->flags;
  	ret = _dm_gpio_set_dir_flags(desc, flags);
 
-	/* update the descriptor flags */
-	if (ret)
-		desc->flags = flags;
-
  	return ret;

You can just do

Quoted 3 lines
   return _dm_gpio_set_dir_flags(desc, flags);

here instead.

Yes!

I would let the patch as it is and (I or you?) send a fix on top?

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#6 lore raw

PATCH v5 2/3 sandbox, test: add test for GPIO_HOG function

In reply to Heiko Schocher

currently gpio hog function is not tested with "ut dm gpio" so add some basic tests for gpio hog functionality.

For this enable GPIO_HOG in sandbox_defconfig, add in DTS some gpio hog entries, and add testcase in "ut dm gpio" command.

---

Changes in v5: None
Changes in v4:
- rebased to current master ac14bc4169

Changes in v3: None
Changes in v2:
- add basic gpio hog test functions

 arch/sandbox/dts/test.dts          | 20 ++++++++++++++++++++
 configs/sandbox64_defconfig        |  1 +
 configs/sandbox_defconfig          |  1 +
 configs/sandbox_flattree_defconfig |  1 +
 configs/sandbox_spl_defconfig      |  1 +
 test/dm/gpio.c                     | 23 +++++++++++++++++++++++
 6 files changed, 47 insertions(+)
arch/sandbox/dts/test.dts +20 -0
index 5ce5e28476..24bb3ce36f 100644
@@ -343,6 +343,26 @@
 			#gpio-cells = <1>;
 			gpio-bank-name = "a";
 			sandbox,gpio-count = <20>;
+			hog_input_active_low {
+				gpio-hog;
+				input;
+				gpios = <0 GPIO_ACTIVE_LOW>;
+			};
+			hog_input_active_high {
+				gpio-hog;
+				input;
+				gpios = <1 GPIO_ACTIVE_HIGH>;
+			};
+			hog_output_low {
+				gpio-hog;
+				output-low;
+				gpios = <2 GPIO_ACTIVE_HIGH>;
+			};
+			hog_output_high {
+				gpio-hog;
+				output-high;
+				gpios = <3 GPIO_ACTIVE_HIGH>;
+			};
 		};
 
 		gpio_b: extra-gpios {
configs/sandbox64_defconfig +1 -0
index c1237ea296..39dc3dc687 100644
@@ -98,6 +98,7 @@ CONFIG_DM_DEMO_SIMPLE=y
 CONFIG_DM_DEMO_SHAPE=y
 CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
+CONFIG_GPIO_HOG=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
configs/sandbox_defconfig +1 -0
index 9445d78118..9015458070 100644
@@ -115,6 +115,7 @@ CONFIG_BOARD_SANDBOX=y
 CONFIG_DMA=y
 CONFIG_DMA_CHANNELS=y
 CONFIG_SANDBOX_DMA=y
+CONFIG_GPIO_HOG=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_DM_HWSPINLOCK=y
configs/sandbox_flattree_defconfig +1 -0
index a4a7ae8379..b5a85e1278 100644
@@ -83,6 +83,7 @@ CONFIG_DM_DEMO_SIMPLE=y
 CONFIG_DM_DEMO_SHAPE=y
 CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
+CONFIG_GPIO_HOG=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
configs/sandbox_spl_defconfig +1 -0
index 945fe54d20..7341fa3221 100644
@@ -102,6 +102,7 @@ CONFIG_DM_DEMO_SHAPE=y
 CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_SPL_FIRMWARE=y
+CONFIG_GPIO_HOG=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
test/dm/gpio.c +23 -0
index 7c18e5c411..1443a2db79 100644
@@ -19,6 +19,7 @@ static int dm_test_gpio(struct unit_test_state *uts)
 	unsigned int offset, gpio;
 	struct dm_gpio_ops *ops;
 	struct udevice *dev;
+	struct gpio_desc *desc;
 	const char *name;
 	int offset_count;
 	char buf[80];
@@ -108,6 +109,28 @@ static int dm_test_gpio(struct unit_test_state *uts)
 	ut_asserteq_str("a", name);
 	ut_asserteq(20, offset_count);
 
+	/* add gpio hog tests */
+	ut_assertok(gpio_hog_lookup_name("hog_input_active_low", &desc));
+	ut_asserteq(GPIOD_IS_IN | GPIOD_ACTIVE_LOW, desc->flags);
+	ut_asserteq(0, desc->offset);
+	ut_asserteq(1, dm_gpio_get_value(desc));
+	ut_assertok(gpio_hog_lookup_name("hog_input_active_high", &desc));
+	ut_asserteq(GPIOD_IS_IN, desc->flags);
+	ut_asserteq(1, desc->offset);
+	ut_asserteq(0, dm_gpio_get_value(desc));
+	ut_assertok(gpio_hog_lookup_name("hog_output_low", &desc));
+	ut_asserteq(GPIOD_IS_OUT, desc->flags);
+	ut_asserteq(2, desc->offset);
+	ut_asserteq(0, dm_gpio_get_value(desc));
+	ut_assertok(dm_gpio_set_value(desc, 1));
+	ut_asserteq(1, dm_gpio_get_value(desc));
+	ut_assertok(gpio_hog_lookup_name("hog_output_high", &desc));
+	ut_asserteq(GPIOD_IS_OUT, desc->flags);
+	ut_asserteq(3, desc->offset);
+	ut_asserteq(1, dm_gpio_get_value(desc));
+	ut_assertok(dm_gpio_set_value(desc, 0));
+	ut_asserteq(0, dm_gpio_get_value(desc));
+
 	return 0;
 }
 DM_TEST(dm_test_gpio, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
Signature · 1 line
2.24.1
#7 lore raw

PATCH v5 2/3 sandbox, test: add test for GPIO_HOG function

Hi Heiko,

Quoted 20 lines · Heiko Schocher

currently gpio hog function is not tested with "ut dm gpio" so add some basic tests for gpio hog functionality.

For this enable GPIO_HOG in sandbox_defconfig, add in DTS some gpio hog entries, and add testcase in "ut dm gpio" command.

---

Changes in v5: None
Changes in v4:
- rebased to current master ac14bc4169

Changes in v3: None
Changes in v2:
- add basic gpio hog test functions

Quoted 8 lines
 arch/sandbox/dts/test.dts          | 20 ++++++++++++++++++++
 configs/sandbox64_defconfig        |  1 +
 configs/sandbox_defconfig          |  1 +
 configs/sandbox_flattree_defconfig |  1 +
 configs/sandbox_spl_defconfig      |  1 +
 test/dm/gpio.c                     | 23 +++++++++++++++++++++++
 6 files changed, 47 insertions(+)

It is OK to just enable on sandbox if you like, since we don't normally run the bulk of the tests on the others.

#8 lore raw

PATCH v5 3/3 gpio: search for gpio label if gpio is not found through bank name

In reply to Heiko Schocher

dm_gpio_lookup_name() searches for a gpio through the bank name. But we have also gpio labels, and it makes sense to search for a gpio also in the labels we have defined, if no gpio is found through the bank name definition.

This is useful for example if you have a wp pin on different gpios on different board versions.

If dm_gpio_lookup_name() searches also for the gpio labels, you can give the gpio an unique label name and search for this label, and do not need to differ between board revisions.

---

Example on the aristainetos board:

=> gpio clear wp_spi_nor.gpio-hog
gpio: pin wp_spi_nor.gpio-hog (gpio 47) value is 0 =>

before this patch, you need to know where your
pin is:

=> gpio clear GPIO2_15
gpio: pin GPIO2_15 (gpio 47) value is 0
=>

travis build:

Changes in v5: None
Changes in v4:
- rebased to current master ac14bc4169

Changes in v3:
- add comment from Simon Glass
make this new function configurable through Kconfig option DM_GPIO_LOOKUP_LABEL

Changes in v2:
- add comment from Simon Glass
move code into seperate function dm_gpio_lookup_label() add test if dm_gpio_lookup_label() works

 drivers/gpio/Kconfig       | 22 ++++++++++++++++++
 drivers/gpio/gpio-uclass.c | 47 ++++++++++++++++++++++++++++++++++++++
 test/dm/gpio.c             |  7 ++++++
 3 files changed, 76 insertions(+)
drivers/gpio/Kconfig +22 -0
index 2081520f42..4a635b905c 100644
@@ -46,6 +46,28 @@ config GPIO_HOG
 	  is a mechanism providing automatic GPIO request and config-
 	  uration as part of the gpio-controller's driver probe function.
 
+config DM_GPIO_LOOKUP_LABEL
+	bool "Enable searching for gpio labelnames"
+	depends on DM_GPIO
+	default y
+	help
+	  This option enables searching for gpio names in
+	  the defined gpio labels, if the search for the
+	  gpio bank name failed. This makes sense if you use
+	  different gpios on different hardware versions
+	  for the same functionality in board code.
+
+config SPL_DM_GPIO_LOOKUP_LABEL
+	bool "Enable searching for gpio labelnames"
+	depends on DM_GPIO && SPL_DM && SPL_GPIO_SUPPORT
+	default n
+	help
+	  This option enables searching for gpio names in
+	  the defined gpio labels, if the search for the
+	  gpio bank name failed. This makes sense if you use
+	  different gpios on different hardware versions
+	  for the same functionality in board code.
+
 config ALTERA_PIO
 	bool "Altera PIO driver"
 	depends on DM_GPIO
drivers/gpio/gpio-uclass.c +47 -0

59 lines not on this page · raw message

test/dm/gpio.c +7 -0
index 1443a2db79..e2f147e776 100644
@@ -131,6 +131,13 @@ static int dm_test_gpio(struct unit_test_state *uts)
 	ut_assertok(dm_gpio_set_value(desc, 0));
 	ut_asserteq(0, dm_gpio_get_value(desc));
 
+	/* Check if lookup for labels work */
+	ut_assertok(gpio_lookup_name("hog_input_active_low", &dev, &offset,
+				     &gpio));
+	ut_asserteq_str(dev->name, "base-gpios");
+	ut_asserteq(0, offset);
+	ut_asserteq(CONFIG_SANDBOX_GPIO_COUNT + 0, gpio);
+
 	return 0;
 }
 DM_TEST(dm_test_gpio, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
Signature · 1 line
2.24.1
#9 lore raw

PATCH v5 3/3 gpio: search for gpio label if gpio is not found through bank name

Hi Heiko,

Quoted 47 lines · Heiko Schocher

dm_gpio_lookup_name() searches for a gpio through the bank name. But we have also gpio labels, and it makes sense to search for a gpio also in the labels we have defined, if no gpio is found through the bank name definition.

This is useful for example if you have a wp pin on different gpios on different board versions.

If dm_gpio_lookup_name() searches also for the gpio labels, you can give the gpio an unique label name and search for this label, and do not need to differ between board revisions.

---

Example on the aristainetos board:

=> gpio clear wp_spi_nor.gpio-hog
gpio: pin wp_spi_nor.gpio-hog (gpio 47) value is 0 =>

before this patch, you need to know where your
pin is:

=> gpio clear GPIO2_15
gpio: pin GPIO2_15 (gpio 47) value is 0
=>

travis build:

Changes in v5: None
Changes in v4:
- rebased to current master ac14bc4169

Changes in v3:
- add comment from Simon Glass
make this new function configurable through Kconfig option DM_GPIO_LOOKUP_LABEL

Changes in v2:
- add comment from Simon Glass
move code into seperate function dm_gpio_lookup_label() add test if dm_gpio_lookup_label() works

Quoted 4 lines
 drivers/gpio/Kconfig       | 22 ++++++++++++++++++
 drivers/gpio/gpio-uclass.c | 47 ++++++++++++++++++++++++++++++++++++++
 test/dm/gpio.c             |  7 ++++++
 3 files changed, 76 insertions(+)

Some optional thoughts below

Quoted 13 lines
drivers/gpio/Kconfig +4 -0
index 2081520f42..4a635b905c 100644
@@ -46,6 +46,28 @@ config GPIO_HOG
          is a mechanism providing automatic GPIO request and config-
          uration as part of the gpio-controller's driver probe function.
 
+config DM_GPIO_LOOKUP_LABEL
+       bool "Enable searching for gpio labelnames"
+       depends on DM_GPIO
+       default y

drivers/gpio/Kconfig config GPIO_HOG · line 62

Quoted 10 lines
drivers/gpio/Kconfig +10 -0
+       help
+         This option enables searching for gpio names in
+         the defined gpio labels, if the search for the
+         gpio bank name failed. This makes sense if you use
+         different gpios on different hardware versions
+         for the same functionality in board code.
+
+config SPL_DM_GPIO_LOOKUP_LABEL
+       bool "Enable searching for gpio labelnames"
+       depends on DM_GPIO && SPL_DM && SPL_GPIO_SUPPORT

Perhaps the first term could be DM_GPIO_LOOKUP_LABEL?

drivers/gpio/Kconfig config GPIO_HOG · line 63

Quoted 1 line
drivers/gpio/Kconfig +1 -0
+       default n

Not needed

Quoted 21 lines
drivers/gpio/Kconfig +7 -0
+       help
+         This option enables searching for gpio names in
+         the defined gpio labels, if the search for the
+         gpio bank name failed. This makes sense if you use
+         different gpios on different hardware versions
+         for the same functionality in board code.
+
 config ALTERA_PIO
        bool "Altera PIO driver"
        depends on DM_GPIO
drivers/gpio/gpio-uclass.c +3 -0
index d241263970..317b486982 100644
@@ -67,6 +67,46 @@ static int gpio_to_device(unsigned int gpio, struct gpio_desc *desc)
        return ret ? ret : -ENOENT;
 }
 
+#if CONFIG_IS_ENABLED(DM_GPIO_LOOKUP_LABEL)
+/**
+ * dm_gpio_lookup_label() - look for name in gpio device

drivers/gpio/gpio-uclass.c static int gpio_to_device(unsigned int gpio, struct gpio_desc *desc) · line 82

Quoted 10 lines
drivers/gpio/gpio-uclass.c +10 -0
+ *
+ * search in uc_priv, if there is a gpio with labelname same
+ * as name.
+ *
+ * @name:      name which is searched
+ * @uc_priv:   gpio_dev_priv pointer.
+ * @offset:    gpio offset within the device
+ * @return:    0 if found, -ENOENT if not.
+ */
+static int

I prefer to have the type on the same line as the function

Quoted 49 lines
drivers/gpio/gpio-uclass.c +34 -0
+dm_gpio_lookup_label(const char *name, struct gpio_dev_priv *uc_priv,
+                    ulong *offset)
+{
+       int len;
+       int i;
+
+       *offset = -1;
+       len = strlen(name);
+       for (i = 0; i < uc_priv->gpio_count; i++) {
+               if (!uc_priv->name[i])
+                       continue;
+               if (!strncmp(name, uc_priv->name[i], len)) {
+                       *offset = i;
+                       return 0;
+               }
+       }
+       return -ENOENT;
+}
+#else
+static int
+dm_gpio_lookup_label(const char *name, struct gpio_dev_priv *uc_priv,
+                    ulong *offset)
+{
+       return -ENOENT;
+}
+#endif
+
 int dm_gpio_lookup_name(const char *name, struct gpio_desc *desc)
 {
        struct gpio_dev_priv *uc_priv = NULL;
@@ -95,6 +135,13 @@ int dm_gpio_lookup_name(const char *name, struct gpio_desc *desc)
                        if (!strict_strtoul(name + len, 10, &offset))
                                break;
                }
+
+               /*
+                * if we did not found a gpio through its bank
+                * name, we search for a valid gpio label.
+                */
+               if (!dm_gpio_lookup_label(name, uc_priv, &offset))
+                       break;
        }
 
        if (!dev)
test/dm/gpio.c +0 -0
index 1443a2db79..e2f147e776 100644

test/dm/gpio.c static int dm_test_gpio(struct unit_test_state *uts) · line 139

Quoted 9 lines
test/dm/gpio.c +6 -0
@@ -131,6 +131,13 @@ static int dm_test_gpio(struct unit_test_state *uts)
        ut_assertok(dm_gpio_set_value(desc, 0));
        ut_asserteq(0, dm_gpio_get_value(desc));
 
+       /* Check if lookup for labels work */
+       ut_assertok(gpio_lookup_name("hog_input_active_low", &dev, &offset,
+                                    &gpio));
+       ut_asserteq_str(dev->name, "base-gpios");
+       ut_asserteq(0, offset);
+       ut_asserteq(CONFIG_SANDBOX_GPIO_COUNT + 0, gpio);

Could add a negative test too (where you don't find it).

Quoted 7 lines
test/dm/gpio.c +1 -1
+
        return 0;
 }
 DM_TEST(dm_test_gpio, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
--

2.24.1

Regards,
SImon