Skip to content

gpio: add possibility to search for gpio label name

Heiko Schocher u-boot 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 0 repliesNew
  2. v53 patches 0 repliesSuperseded
  3. v43 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v32 patches0 repliesSuperseded
v22 patches0 repliesSuperseded

Changes in v6 from the cover letter

- add reviewed by from Patrick and Fixes tag
- add Reviewed-by tag from Simon
- add additional comments from Simon:
- remove "default n" in Kconfig for SPL_DM_GPIO_LOOKUP_LABEL
- type of function in same line as the function
- add negativ test, where label is not found

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpio-uclass.c: save the GPIOD flags also in the gpio descriptordrivers/gpio/gpio-uclass.c+4 -44 replies
2/3sandbox, test: add test for GPIO_HOG functionarch/sandbox/dts/test.dts configs/sandbox64_defconfig configs/sandbox_defconfig +3 more+47 -01 reply
3/3gpio: search for gpio label if gpio is not found through bank namedrivers/gpio/Kconfig drivers/gpio/gpio-uclass.c test/dm/gpio.c+76 -02 replies
3/3gpio: search for gpio label if gpio is not found through bank name+0 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPatrick DelaunaySimon GlassWalter Lozano
1/3R-b R-b T-b
2/3R-b
3/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] gpio: add possibility to search for gpio label name

search for gpio label if gpio name from bankname is not found.

This makes sense on boards with different hardware verions. You can now search for the gpio label name, and can give the gpio a unique name. The real gpio pin number is not needed in board code anymore.

while at it add basic gpio hog test functions in seperate patch.

Travis:
https://travis-ci.org/github/hsdenx/u-boot-test/builds/689908393

Changes in v6:
- add reviewed by from Patrick and Fixes tag
- add Reviewed-by tag from Simon
- add additional comments from Simon:
- remove "default n" in Kconfig for SPL_DM_GPIO_LOOKUP_LABEL
- type of function in same line as the function
- add negativ test, where label is not found

Changes in v5:
- add comment from patrick, update the descriptor flags in _dm_gpio_set_dir_flags() if setting direction was OK.
- add Reviewed-by tag from Simon

Changes in v4:
- new in version 4
- rebased to current master ac14bc4169
- rebased to current master ac14bc4169

Changes in v3:
- add comment from Simon Glass
make this new function configurable through Kconfig option DM_GPIO_LOOKUP_LABEL

Changes in v2:
- add basic gpio hog test functions
- add comment from Simon Glass
move code into seperate function dm_gpio_lookup_label() add test if dm_gpio_lookup_label() works

Heiko Schocher (3):
gpio-uclass.c: save the GPIOD flags also in the gpio descriptor sandbox, test: add test for GPIO_HOG function
gpio: search for gpio label if gpio is not found through bank name

 arch/sandbox/dts/test.dts          | 20 +++++++++++
 configs/sandbox64_defconfig        |  1 +
 configs/sandbox_defconfig          |  1 +
 configs/sandbox_flattree_defconfig |  1 +
 configs/sandbox_spl_defconfig      |  1 +
 drivers/gpio/Kconfig               | 21 ++++++++++++
 drivers/gpio/gpio-uclass.c         | 54 +++++++++++++++++++++++++++---
 test/dm/gpio.c                     | 32 ++++++++++++++++++
 8 files changed, 127 insertions(+), 4 deletions(-)
Signature · 1 line
2.24.1