sdhci: tegra: Avoid reading autocal timeout values when not applicable
Subsystems (3)
PATCH 1/1 sdhci: tegra: Avoid reading autocal timeout values when not applicable
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)
drivers/mmc/host/sdhci-tegra.c +33 -24
@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL. +*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ; + + err =device_property_read_u32 (host->mmc->parent,"nvidia,pad-autocal-pull-up-offset-3v3-timeout" , &autocal->pull_up_3v3_timeout);if (err) {
@@ -647,30 +680,6 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) mmc_hostname(host->mmc)); autocal->pull_down_1v8_timeout =0 ; } - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-sdr104" , - &autocal->pull_up_sdr104); -if (err) - autocal->pull_up_sdr104 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-sdr104" , - &autocal->pull_down_sdr104); -if (err) - autocal->pull_down_sdr104 = autocal->pull_down_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-hs400" , - &autocal->pull_up_hs400); -if (err) - autocal->pull_up_hs400 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-hs400" , - &autocal->pull_down_hs400); -if (err) - autocal->pull_down_hs400 = autocal->pull_down_1v8; }static void tegra_sdhci_request (struct mmc_host *mmc,struct mmc_request *mrq)
Signature · 1 line
2.7.4
20.05.2020 23:08, Sowjanya Komatineni пишет:
Quoted 6 lines
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
Quoted 8 lines
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)
Hello Sowjanya,
Thank you for the patch.
Quoted 44 lines · Sowjanya Komatineni
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +21
-0@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err)
drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) · line 638
Quoted 10 lines
drivers/mmc/host/sdhci-tegra.c +10
-0+ autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL. +*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ;
Hm... so what exactly is the difference between NVQUIRK_HAS_PADCALIB? I think Tegra30 will also end up calling tegra_sdhci_set_padctrl(), but it will then write the default (0) value for these drive strength. Is that okay?
Thierry
22.05.2020 15:26, Thierry Reding пишет:
Quoted 52 lines · Sowjanya Komatineni
Quoted 51 lines
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +28
-0@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL.
Quoted 8 lines
drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) · line 638
Quoted 3 lines
drivers/mmc/host/sdhci-tegra.c +3
-0+*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ;Hm... so what exactly is the difference between
NVQUIRK_HAS_PADCALIB? I think Tegra30 will also end up callingtegra_sdhci_set_padctrl(), but it will then write the default (0) value for these drive strength. Is that okay?
It won't write 0, but skip the writing if values are 0. Technically T30+ supports the customized strengths, but I'm not sure whether it was ever tested and whether it's really needed. I think Sowjanya said before that the default values are always okay for older SoCs.
Thierry Reding
Acked-byQuoted 62 lines · Dmitry Osipenko
22.05.2020 15:26, Thierry Reding пишет:
Quoted 52 lines · Sowjanya Komatineni
Quoted 51 lines
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +28
-0@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL. Quoted 8 lines
drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) · line 638
Quoted 3 lines
drivers/mmc/host/sdhci-tegra.c +3
-0+*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ;Hm... so what exactly is the difference between
NVQUIRK_HAS_PADCALIB? I think Tegra30 will also end up callingtegra_sdhci_set_padctrl(), but it will then write the default (0) value for these drive strength. Is that okay?
Quoted 4 lines
It won't write 0, but skip the writing if values are 0. Technically T30+ supports the customized strengths, but I'm not sure whether it was ever tested and whether it's really needed. I think Sowjanya said before that the default values are always okay for older SoCs.
Alright then, in that case:
Quoted 53 lines · Thierry Reding
Quoted 52 lines · Dmitry Osipenko
22.05.2020 15:26, Thierry Reding пишет:
Quoted 51 lines · Sowjanya Komatineni
Quoted 50 lines
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +27
-0@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) · line 638
Quoted 4 lines
drivers/mmc/host/sdhci-tegra.c +4
-0+* have NVQUIRK_NEEDS_PAD_CONTROL. +*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ;Hm... so what exactly is the difference between
NVQUIRK_HAS_PADCALIB? I think Tegra30 will also end up callingtegra_sdhci_set_padctrl(), but it will then write the default (0) value for these drive strength. Is that okay?
Yes separate 3v3 and 1v8 drive strengths are for Tegra210/184/194 where they have separate pad controls.
T30 also has auto calibration enabled but don't need to use these properties as they don't have separate default drive strengths based on signaling.
Same default drive strengths set by boot loader/default pinmux will hold good.
Quoted 7 lines
Quoted 4 lines
It won't write 0, but skip the writing if values are 0. Technically T30+ supports the customized strengths, but I'm not sure whether it was ever tested and whether it's really needed. I think Sowjanya said before that the default values are always okay for older SoCs.
Alright then, in that case:
Acked-by Thierry Reding <[email protected]>
20.05.2020 23:08, Sowjanya Komatineni пишет:
Quoted 40 lines
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +17
-0@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; +
drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) · line 634
Quoted 10 lines
drivers/mmc/host/sdhci-tegra.c +10
-0+ err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't
typo s/properies/properties/ ^^^
Quoted 2 lines
drivers/mmc/host/sdhci-tegra.c +2
-0+* have NVQUIRK_NEEDS_PAD_CONTROL. +*/
...
Quoted 11 lines · Sowjanya Komatineni
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>
Quoted 80 lines
--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +33
-24@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL. +*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ; + + err =device_property_read_u32 (host->mmc->parent,"nvidia,pad-autocal-pull-up-offset-3v3-timeout" , &autocal->pull_up_3v3_timeout);if (err) {@@ -647,30 +680,6 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) mmc_hostname(host->mmc)); autocal->pull_down_1v8_timeout =0 ; } - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-sdr104" , - &autocal->pull_up_sdr104); -if (err) - autocal->pull_up_sdr104 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-sdr104" , - &autocal->pull_down_sdr104); -if (err) - autocal->pull_down_sdr104 = autocal->pull_down_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-hs400" , - &autocal->pull_up_hs400); -if (err) - autocal->pull_up_hs400 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-hs400" , - &autocal->pull_down_hs400); -if (err) - autocal->pull_down_hs400 = autocal->pull_down_1v8; }static void tegra_sdhci_request (struct mmc_host *mmc,struct mmc_request *mrq)
Quoted 4 lines · Sowjanya Komatineni
When auto calibration timeouts, calibration is disabled and fail-safe drive strength values are programmed based on the signal voltage.
Quoted 8 lines
Different fail-safe drive strength values based on voltage are applicable only for SoCs supporting 3V3 and 1V8 pad controls.
So, this patch avoids reading these properties from the device tree for SoCs not using pad controls and the warning of missing properties will not show up on these SoC platforms.
Signed-off-by Sowjanya Komatineni <[email protected]>
Applied for next and by fixing the misspelled "properies", thanks!
Kind regards
Uffe
Quoted 82 lines
--- drivers/mmc/host/sdhci-tegra.c | 57 ++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 24 deletions(-)drivers/mmc/host/sdhci-tegra.c +33
-25@@ -605,6 +605,39 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) autocal->pull_down_1v8 =0 ; err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-sdr104" , + &autocal->pull_up_sdr104); +if (err) + autocal->pull_up_sdr104 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-sdr104" , + &autocal->pull_down_sdr104); +if (err) + autocal->pull_down_sdr104 = autocal->pull_down_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-up-offset-hs400" , + &autocal->pull_up_hs400); +if (err) + autocal->pull_up_hs400 = autocal->pull_up_1v8; + + err =device_property_read_u32 (host->mmc->parent, +"nvidia,pad-autocal-pull-down-offset-hs400" , + &autocal->pull_down_hs400); +if (err) + autocal->pull_down_hs400 = autocal->pull_down_1v8; + +/* +* Different fail-safe drive strength values based on the signaling +* voltage are applicable for SoCs supporting 3V3 and 1V8 pad controls. +* So, avoid reading below device tree properies for SoCs that don't +* have NVQUIRK_NEEDS_PAD_CONTROL. +*/ +if (!(tegra_host->soc_data->nvquirks &NVQUIRK_NEEDS_PAD_CONTROL )) +return ; + + err =device_property_read_u32 (host->mmc->parent,"nvidia,pad-autocal-pull-up-offset-3v3-timeout" , &autocal->pull_up_3v3_timeout);if (err) {@@ -647,30 +680,6 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) mmc_hostname(host->mmc)); autocal->pull_down_1v8_timeout =0 ; } - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-sdr104" , - &autocal->pull_up_sdr104); -if (err) - autocal->pull_up_sdr104 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-sdr104" , - &autocal->pull_down_sdr104); -if (err) - autocal->pull_down_sdr104 = autocal->pull_down_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-up-offset-hs400" , - &autocal->pull_up_hs400); -if (err) - autocal->pull_up_hs400 = autocal->pull_up_1v8; - - err =device_property_read_u32 (host->mmc->parent, -"nvidia,pad-autocal-pull-down-offset-hs400" , - &autocal->pull_down_hs400); -if (err) - autocal->pull_down_hs400 = autocal->pull_down_1v8; }static void tegra_sdhci_request (struct mmc_host *mmc,struct mmc_request *mrq) --2.7.4