Skip to contentSkip to conversation

board/freescale: increase the vfat size

PATCH New Fabio Estevam 3 participants 4 messages May 26, 2020 – Jun 1, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 board/freescale: increase the vfat size

i.MX8 targets typically use the standard ARM64 defconfig, which builds lots of ARM64 platforms leading to super large kernels that can easily not fit within the current 32MB size for vfat.

Increase the vfat size to better accomodate such large kernels.

---
 board/freescale/common/imx/genimage.cfg.template_imx8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/common/imx/genimage.cfg.template_imx8 +1 -1
index 84a812f986..5689205083 100644
@@ -14,7 +14,7 @@ image boot.vfat {
       %FILES%
     }
   }
-  size = 32M
+  size = 64M
 }
 
 image sdcard.img {
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 board/freescale: increase the vfat size

Fabio, All,

On 2020-05-26 18:01 -0300, Fabio Estevam spake thusly:

Quoted 5 lines

i.MX8 targets typically use the standard ARM64 defconfig, which builds lots of ARM64 platforms leading to super large kernels that can easily not fit within the current 32MB size for vfat.

Increase the vfat size to better accomodate such large kernels.

The genimage config files we have do accomodate the needs for the defconfigs they are used in. So, if all the in-tree defconfigs still build with the current size,t this is OK.

That a user then tweaks it locally for their use-case, is not a reason IMHO to carry such a change.

So, question: does this fix an actual build failure of any of the i.MX8 defconfig that we have in-tree in Buildroot? If so, then this should be explcictly stated in the commit log.

Otherwise, there is no reason to catter for out-of-tree use-cases, otherwise there will always be someone that come next and state "This package makes sense for my use-case, but it does not fit in the default size, so increase it". This is not tenable.

Still, 32M is quite low for today's standards, and we want users to be relatively at ease to experiment on the default image anyway.

So: applied to master, with a slightly tweaked commit log. Thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 board/freescale/common/imx/genimage.cfg.template_imx8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/common/imx/genimage.cfg.template_imx8 +1 -1
index 84a812f986..5689205083 100644
@@ -14,7 +14,7 @@ image boot.vfat {
       %FILES%
     }
   }
-  size = 32M
+  size = 64M
 }
 
 image sdcard.img {
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author reviewer
#2 lore raw

PATCH 1/1 board/freescale: increase the vfat size

Hi Yann,

Quoted 3 lines · Yann E. MORIN

So, question: does this fix an actual build failure of any of the i.MX8 defconfig that we have in-tree in Buildroot? If so, then this should be explcictly stated in the commit log.

I noticed this problem when trying to flash a kernel generated by the standard 'defconfig' from an NXP internal tree.

The kernel size was around 35MB.

Soon this kernel will be publicly available and we will need to increase the vfat size to accommodate it.

Thanks for applying it!

#3 lore raw

PATCH 1/1 board/freescale: increase the vfat size

In reply to Fabio Estevam
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabio" == Fabio Estevam <[email protected]> writes:

i.MX8 targets typically use the standard ARM64 defconfig, which builds lots of ARM64 platforms leading to super large kernels that can easily not fit within the current 32MB size for vfat.

Increase the vfat size to better accomodate such large kernels.

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard