Bluetooth: hci_qca: Improve controller ID info log level
PATCH v2 1/1 Bluetooth: hci_qca: Improve controller ID info log level
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.
--- drivers/bluetooth/btqca.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/bluetooth/btqca.c +8 -4
@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, ver = (struct qca_btsoc_version *)(edl->data); -BT_DBG ("%s: Product:0x%08x" , hdev->name,le32_to_cpu (ver->product_id)); -BT_DBG ("%s: Patch :0x%08x" , hdev->name,le16_to_cpu (ver->patch_ver)); -BT_DBG ("%s: ROM :0x%08x" , hdev->name,le16_to_cpu (ver->rom_ver)); -BT_DBG ("%s: SOC :0x%08x" , hdev->name,le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA Product ID :0x%08x" , +le32_to_cpu (ver->product_id)); +bt_dev_info (hdev,"QCA SOC Version :0x%08x" , +le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA ROM Version :0x%08x" , +le16_to_cpu (ver->rom_ver)); +bt_dev_info (hdev,"QCA Patch Version:0x%08x" , +le16_to_cpu (ver->patch_ver));/* QCA chipset version can be decided by patch and SoC * version, combination with upper 2 bytes from SoC
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 21 lines · Zijun Hu
Controller ID info got by VSC
EDL_PATCH_GETVERis very important, so improve its log level from DEBUG to INFO.Signed-off-by Zijun Hu <[email protected]>--- drivers/bluetooth/btqca.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/bluetooth/btqca.c +1
-4@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, ver = (struct qca_btsoc_version *)(edl->data); -BT_DBG ("%s: Product:0x%08x" , hdev->name,le32_to_cpu (ver->product_id)); -BT_DBG ("%s: Patch :0x%08x" , hdev->name,le16_to_cpu (ver->patch_ver)); -BT_DBG ("%s: ROM :0x%08x" , hdev->name,le16_to_cpu (ver->rom_ver)); -BT_DBG ("%s: SOC :0x%08x" , hdev->name,le32_to_cpu (ver->soc_id)); + bt_dev_info(hdev, "QCA Product ID :0x%08x",
drivers/bluetooth/btqca.c int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, · line 87
Quoted 10 lines
drivers/bluetooth/btqca.c +7
-0+ le32_to_cpu(ver->product_id)); +bt_dev_info (hdev,"QCA SOC Version :0x%08x" , +le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA ROM Version :0x%08x" , +le16_to_cpu (ver->rom_ver)); +bt_dev_info (hdev,"QCA Patch Version:0x%08x" , +le16_to_cpu (ver->patch_ver));/* QCA chipset version can be decided by patch and SoC * version, combination with upper 2 bytes from SoC
Marcel Holtmann
maintainerHi Zijun,
Quoted 18 lines
Controller ID info got by VSC
EDL_PATCH_GETVERis very important, so improve its log level from DEBUG to INFO.Signed-off-by Zijun Hu <[email protected]>---
drivers/bluetooth/btqca.c| 12 ++++++++----1 file changed, 8 insertions(+), 4 deletions(-)drivers/bluetooth/btqca.c +0
-2@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, ver = (struct qca_btsoc_version *)(edl->data); -BT_DBG ("%s: Product:0x%08x" , hdev->name,le32_to_cpu (ver->product_id)); -BT_DBG ("%s: Patch :0x%08x" , hdev->name,le16_to_cpu (ver->patch_ver));
drivers/bluetooth/btqca.c int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, · line 84
Quoted 10 lines
drivers/bluetooth/btqca.c +8
-2-BT_DBG ("%s: ROM :0x%08x" , hdev->name,le16_to_cpu (ver->rom_ver)); -BT_DBG ("%s: SOC :0x%08x" , hdev->name,le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA Product ID :0x%08x" , +le32_to_cpu (ver->product_id)); +bt_dev_info (hdev,"QCA SOC Version :0x%08x" , +le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA ROM Version :0x%08x" , +le16_to_cpu (ver->rom_ver)); +bt_dev_info (hdev,"QCA Patch Version:0x%08x" , +le16_to_cpu (ver->patch_ver));
please align correctly according to the coding style.
Regards
Marcel
Quoted 18 lines · Marcel Holtmann
Hi Zijun,
Quoted 16 lines
Controller ID info got by VSC
EDL_PATCH_GETVERis very important, so improve its log level from DEBUG to INFO.Signed-off-by Zijun Hu <[email protected]>---
drivers/bluetooth/btqca.c| 12 ++++++++----1 file changed, 8 insertions(+), 4 deletions(-)drivers/bluetooth/btqca.c +0
-0@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, ver = (struct qca_btsoc_version *)(edl->data);
Quoted 15 lines
drivers/bluetooth/btqca.c int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version, · line 84
Quoted 12 lines
drivers/bluetooth/btqca.c +8
-4-BT_DBG ("%s: Product:0x%08x" , hdev->name,le32_to_cpu (ver->product_id)); -BT_DBG ("%s: Patch :0x%08x" , hdev->name,le16_to_cpu (ver->patch_ver)); -BT_DBG ("%s: ROM :0x%08x" , hdev->name,le16_to_cpu (ver->rom_ver)); -BT_DBG ("%s: SOC :0x%08x" , hdev->name,le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA Product ID :0x%08x" , +le32_to_cpu (ver->product_id)); +bt_dev_info (hdev,"QCA SOC Version :0x%08x" , +le32_to_cpu (ver->soc_id)); +bt_dev_info (hdev,"QCA ROM Version :0x%08x" , +le16_to_cpu (ver->rom_ver)); +bt_dev_info (hdev,"QCA Patch Version:0x%08x" , +le16_to_cpu (ver->patch_ver));please align correctly according to the coding style.
if bt_dev_info() is wrote at one line, it will exceed 80 characters so i split it at two line and aligned via vim.
Quoted 4 lines
Regards
Marcel
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project