Skip to contentSkip to conversation

Bluetooth: hci_qca: Improve controller ID info log level

PATCH Superseded Zijun Hu 2 participants 4 messages May 28, 2020

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Zijun Hu

author
#0 lore raw

PATCH v3 1/1 Bluetooth: hci_qca: Improve controller ID info log level

Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.

---
 drivers/bluetooth/btqca.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/bluetooth/btqca.c +8 -4
index 3ea866d..6193030 100644
@@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
 
 	ver = (struct qca_btsoc_version *)(edl->data);
 
-	BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
-	BT_DBG("%s: Patch  :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
-	BT_DBG("%s: ROM    :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
-	BT_DBG("%s: SOC    :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
+	bt_dev_info(hdev, "QCA Product ID   :0x%08x",
+		    le32_to_cpu(ver->product_id));
+	bt_dev_info(hdev, "QCA SOC Version  :0x%08x",
+		    le32_to_cpu(ver->soc_id));
+	bt_dev_info(hdev, "QCA ROM Version  :0x%08x",
+		    le16_to_cpu(ver->rom_ver));
+	bt_dev_info(hdev, "QCA Patch Version:0x%08x",
+		    le16_to_cpu(ver->patch_ver));
 
 	/* QCA chipset version can be decided by patch and SoC
 	 * version, combination with upper 2 bytes from SoC
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
author
#2 lore raw
Quoted 9 lines · Matthias Kaehlcke
Quoted 4 lines · Zijun Hu

Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.

Please add the tags from earlier version unless the new patch has substantial changes.

actually, this v3 patch is only to correct the code stye issue pointed by you. let me resend it.

Quoted 2 lines
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
#3 lore raw
Quoted 7 lines · Zijun Hu
Quoted 4 lines · Matthias Kaehlcke
Quoted 3 lines · Zijun Hu

Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Please add the tags from earlier version unless the new patch has substantial changes.

actually, this v3 patch is only to correct the code stye issue pointed by you. let me resend it.

no need to resend it, it was just a reminder to do it in the futre.