iommu: Move iommu_group setup to IOMMU core code
Subsystems (14)
Joerg Roedel
maintainerv2 cover iommu: Move iommu_group setup to IOMMU core code
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/
Changes v1->v2:
* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing mutex_unlock() reported by Marek Szyprowski, thanks for that.
There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implement iommu_ops->def_domain_type call-back iommu/vt-d: Wire up iommu_ops->def_domain_type
iommu/amd: Remove dma_mask check from check_device() iommu/amd: Return -ENODEV in add_device when device is not handled by
IOMMU
iommu: Add probe_device() and remove_device() call-backs
iommu: Move default domain allocation to iommu_probe_device()
iommu: Keep a list of allocated groups in __iommu_probe_device()
iommu: Move new probe_device path to separate function
iommu: Split off default domain allocation from group assignment
iommu: Move iommu_group_create_direct_mappings() out of
iommu_group_add_device()
iommu: Export bus_iommu_probe() and make is safe for re-probing iommu/amd: Remove dev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Remove orphan_dev tracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexport iommu_group_get_for_dev()
Sai Praneeth Prakhya (1):
iommu: Add def_domain_type() callback in iommu_ops
drivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------ drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 1/33 iommu: Move default domain allocation to separate function
From: Joerg Roedel <[email protected]>
Move the code out of iommu_group_get_for_dev() into a separate function.
--- drivers/iommu/iommu.c | 74 ++++++++++++++++++++++++++----------------- 1 file changed, 45 insertions(+), 29 deletions(-)
drivers/iommu/iommu.c +45 -29
@@ -1361,6 +1361,41 @@ struct iommu_group *fsl_mc_device_group(struct device *dev) }EXPORT_SYMBOL_GPL (fsl_mc_device_group); +static int iommu_alloc_default_domain (struct device *dev, +struct iommu_group *group) +{ +struct iommu_domain *dom; + +if (group->default_domain) +return 0 ; + + dom =__iommu_domain_alloc (dev->bus, iommu_def_domain_type); +if (!dom && iommu_def_domain_type !=IOMMU_DOMAIN_DMA ) { + dom =__iommu_domain_alloc (dev->bus,IOMMU_DOMAIN_DMA ); +if (dom) { +dev_warn (dev, +"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , + iommu_def_domain_type); + } + } + +if (!dom) +return -ENOMEM ; + + group->default_domain = dom; +if (!group->domain) + group->domain = dom; + +if (!iommu_dma_strict) { +int attr =1 ; +iommu_domain_set_attr (dom, +DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE , + &attr); + } + +return 0 ; +} +/** * iommu_group_get_for_dev - Find or create the IOMMU group for a device * @dev: target device
@@ -1393,40 +1428,21 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)/* * Try to allocate a default domain - needs support from the -* IOMMU driver. +* IOMMU driver. There are still some drivers which don't support +* default domains, so the return value is not yet checked. */ -if (!group->default_domain) { -struct iommu_domain *dom; - - dom =__iommu_domain_alloc (dev->bus, iommu_def_domain_type); -if (!dom && iommu_def_domain_type !=IOMMU_DOMAIN_DMA ) { - dom =__iommu_domain_alloc (dev->bus,IOMMU_DOMAIN_DMA ); -if (dom) { -dev_warn (dev, -"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , - iommu_def_domain_type); - } - } - - group->default_domain = dom; -if (!group->domain) - group->domain = dom; - -if (dom && !iommu_dma_strict) { -int attr =1 ; -iommu_domain_set_attr (dom, -DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE , - &attr); - } - } +iommu_alloc_default_domain (dev, group); ret =iommu_group_add_device (group, dev); -if (ret) { -iommu_group_put (group); -return ERR_PTR (ret); - } +if (ret) + goto out_put_group;return group; + +out_put_group: +iommu_group_put (group); + +return ERR_PTR (ret); }EXPORT_SYMBOL (iommu_group_get_for_dev);
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 2/33 iommu: Add def_domain_type() callback in iommu_ops
In reply to Joerg RoedelFrom: Sai Praneeth Prakhya <[email protected]>
Some devices are reqired to use a specific type (identity or dma) of default domain when they are used with a vendor iommu. When the system level default domain type is different from it, the vendor iommu driver has to request a new default domain with iommu_request_dma_domain_for_dev() and iommu_request_dm_for_dev() in the add_dev() callback. Unfortunately, these two helpers only work when the group hasn't been assigned to any other devices, hence, some vendor iommu driver has to use a private domain if it fails to request a new default one.
This adds def_domain_type() callback in the iommu_ops, so that any special requirement of default domain for a device could be aware by the iommu generic layer.
[ [email protected]: Added iommu_get_def_domain_type() function and use
it to allocate the default domain ]
--- drivers/iommu/iommu.c | 20 +++++++++++++++++--- include/linux/iommu.h | 6 ++++++ 2 files changed, 23 insertions(+), 3 deletions(-)
drivers/iommu/iommu.c +17 -3
@@ -1361,21 +1361,35 @@ struct iommu_group *fsl_mc_device_group(struct device *dev) }EXPORT_SYMBOL_GPL (fsl_mc_device_group); +static int iommu_get_def_domain_type (struct device *dev) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; +unsigned int type =0 ; + +if (ops->def_domain_type) + type = ops->def_domain_type (dev); + +return (type ==0 ) ? iommu_def_domain_type : type; +} +static int iommu_alloc_default_domain (struct device *dev,struct iommu_group *group) {struct iommu_domain *dom; +unsigned int type;if (group->default_domain)return 0 ; - dom =__iommu_domain_alloc (dev->bus, iommu_def_domain_type); -if (!dom && iommu_def_domain_type !=IOMMU_DOMAIN_DMA ) { + type =iommu_get_def_domain_type (dev); + + dom =__iommu_domain_alloc (dev->bus, type); +if (!dom && type !=IOMMU_DOMAIN_DMA ) { dom =__iommu_domain_alloc (dev->bus,IOMMU_DOMAIN_DMA );if (dom) {dev_warn (dev,"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , - iommu_def_domain_type); + type); } }
include/linux/iommu.h +6 -0
@@ -248,6 +248,10 @@ struct iommu_iotlb_gather {* @cache_invalidate: invalidate translation caches * @sva_bind_gpasid: bind guest pasid and mm * @sva_unbind_gpasid: unbind guest pasid and mm +* @def_domain_type: device default domain type, return value: +* - IOMMU_DOMAIN_IDENTITY: must use an identity domain +* - IOMMU_DOMAIN_DMA: must use a dma domain +* - 0: use the default setting * @pgsize_bitmap: bitmap of all possible supported page sizes * @owner: Driver module providing these ops */
@@ -318,6 +322,8 @@ struct iommu_ops {int (*sva_unbind_gpasid)(struct device *dev,int pasid); +int (*def_domain_type)(struct device *dev); +unsigned long pgsize_bitmap;struct module *owner; };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 3/33 iommu/amd: Implement iommu_ops->def_domain_type call-back
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Implement the new def_domain_type call-back for the AMD IOMMU driver.
--- drivers/iommu/amd_iommu.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/iommu/amd_iommu.c +15 -0
@@ -2661,6 +2661,20 @@ static void amd_iommu_iotlb_sync(struct iommu_domain *domain,amd_iommu_flush_iotlb_all (domain); } +static int amd_iommu_def_domain_type (struct device *dev) +{ +struct iommu_dev_data *dev_data; + + dev_data =get_dev_data (dev); +if (!dev_data) +return 0 ; + +if (dev_data->iommu_v2) +return IOMMU_DOMAIN_IDENTITY ; + +return 0 ; +} +const struct iommu_ops amd_iommu_ops = { .capable = amd_iommu_capable, .domain_alloc = amd_iommu_domain_alloc,
@@ -2680,6 +2694,7 @@ const struct iommu_ops amd_iommu_ops = { .pgsize_bitmap = AMD_IOMMU_PGSIZES, .flush_iotlb_all = amd_iommu_flush_iotlb_all, .iotlb_sync = amd_iommu_iotlb_sync, + .def_domain_type = amd_iommu_def_domain_type, };/*****************************************************************************
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 4/33 iommu/vt-d: Wire up iommu_ops->def_domain_type
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
The Intel VT-d driver already has a matching function to determine the default domain type for a device. Wire it up in intel_iommu_ops.
--- drivers/iommu/intel-iommu.c | 1 + 1 file changed, 1 insertion(+)
drivers/iommu/intel-iommu.c +1 -0
@@ -6209,6 +6209,7 @@ const struct iommu_ops intel_iommu_ops = { .dev_enable_feat = intel_iommu_dev_enable_feat, .dev_disable_feat = intel_iommu_dev_disable_feat, .is_attach_deferred = intel_iommu_is_attach_deferred, + .def_domain_type = device_def_domain_type, .pgsize_bitmap = INTEL_IOMMU_PGSIZES, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 5/33 iommu/amd: Remove dma_mask check from check_device()
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
The check was only needed for the DMA-API implementation in the AMD IOMMU driver, which no longer exists.
--- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu.c +1 -1
@@ -326,7 +326,7 @@ static bool check_device(struct device *dev) {int devid; -if (!dev || !dev->dma_mask) +if (!dev)return false; devid =get_device_id (dev);
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 6/33 iommu/amd: Return -ENODEV in add_device when device is not handled by IOMMU
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
When check_device() fails on the device, it is not handled by the IOMMU and amd_iommu_add_device() needs to return -ENODEV.
--- drivers/iommu/amd_iommu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/iommu/amd_iommu.c +4 -1
@@ -2157,9 +2157,12 @@ static int amd_iommu_add_device(struct device *dev)struct amd_iommu *iommu;int ret, devid; -if (!check_device (dev) ||get_dev_data (dev)) +if (get_dev_data (dev))return 0 ; +if (!check_device (dev)) +return -ENODEV ; + devid =get_device_id (dev);if (devid <0 )return devid;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 7/33 iommu: Add probe_device() and remove_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Add call-backs to 'struct iommu_ops' as an alternative to the add_device() and remove_device() call-backs, which will be removed when all drivers are converted.
The new call-backs will not setupt IOMMU groups and domains anymore, so also add a probe_finalize() call-back where the IOMMU driver can do per-device setup work which require the device to be set up with a group and a domain.
--- drivers/iommu/iommu.c | 63 ++++++++++++++++++++++++++++++++++++++----- include/linux/iommu.h | 9 +++++++ 2 files changed, 66 insertions(+), 6 deletions(-)
drivers/iommu/iommu.c +57 -6
@@ -174,6 +174,36 @@ static void dev_iommu_free(struct device *dev) dev->iommu =NULL ; } +static int __iommu_probe_device (struct device *dev) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; +struct iommu_device *iommu_dev; +struct iommu_group *group; +int ret; + + iommu_dev = ops->probe_device (dev); +if (IS_ERR (iommu_dev)) +return PTR_ERR (iommu_dev); + + dev->iommu->iommu_dev = iommu_dev; + + group =iommu_group_get_for_dev (dev); +if (!IS_ERR (group)) { + ret =PTR_ERR (group); + goto out_release; + } +iommu_group_put (group); + +iommu_device_link (iommu_dev, dev); + +return 0 ; + +out_release: + ops->release_device (dev); + +return ret; +} +int iommu_probe_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops;
@@ -191,10 +221,17 @@ int iommu_probe_device(struct device *dev) goto err_free_dev_param; } - ret = ops->add_device (dev); +if (ops->probe_device) + ret =__iommu_probe_device (dev); +else + ret = ops->add_device (dev); +if (ret) goto err_module_put; +if (ops->probe_finalize) + ops->probe_finalize (dev); +return 0 ; err_module_put:
@@ -204,17 +241,31 @@ int iommu_probe_device(struct device *dev)return ret; } +static void __iommu_release_device (struct device *dev) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; + +iommu_device_unlink (dev->iommu->iommu_dev, dev); + +iommu_group_remove_device (dev); + + ops->release_device (dev); +} +void iommu_release_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops; -if (dev->iommu_group) +if (!dev->iommu) +return ; + +if (ops->release_device) +__iommu_release_device (dev); +else if (dev->iommu_group) ops->remove_device (dev); -if (dev->iommu) { -module_put (ops->owner); -dev_iommu_free (dev); - } +module_put (ops->owner); +dev_iommu_free (dev); } static struct iommu_domain *__iommu_domain_alloc(struct bus_type *bus,
include/linux/iommu.h +9 -0
@@ -225,6 +225,10 @@ struct iommu_iotlb_gather {* @iova_to_phys: translate iova to physical address * @add_device: add device to iommu grouping * @remove_device: remove device from iommu grouping +* @probe_device: Add device to iommu driver handling +* @release_device: Remove device from iommu driver handling +* @probe_finalize: Do final setup work after the device is added to an IOMMU +* group and attached to the groups domain * @device_group: find iommu group for a particular device * @domain_get_attr: Query domain attributes * @domain_set_attr: Change domain attributes
@@ -275,6 +279,9 @@ struct iommu_ops {phys_addr_t (*iova_to_phys)(struct iommu_domain *domain,dma_addr_t iova);int (*add_device)(struct device *dev);void (*remove_device)(struct device *dev); +struct iommu_device *(*probe_device)(struct device *dev); +void (*release_device)(struct device *dev); +void (*probe_finalize)(struct device *dev);struct iommu_group *(*device_group)(struct device *dev);int (*domain_get_attr)(struct iommu_domain *domain,enum iommu_attr attr,void *data);
@@ -375,6 +382,7 @@ struct iommu_fault_param {* * @fault_param: IOMMU detected device fault reporting data * @fwspec: IOMMU fwspec data +* @iommu_dev: IOMMU device this device is linked to * @priv: IOMMU Driver private data * * TODO: migrate other per device data pointers under iommu_dev_data, e.g.
@@ -384,6 +392,7 @@ struct dev_iommu {struct mutex lock;struct iommu_fault_param *fault_param;struct iommu_fwspec *fwspec; +struct iommu_device *iommu_dev;void *priv; };
Signature · 1 line
2.17.1
Re: [PATCH v2 07/33] iommu: Add probe_device() and remove_device() call-backs
Quoted 10 lines · Joerg Roedel
From: Joerg Roedel<[email protected]>
Add call-backs to 'struct
iommu_ops' as an alternative to theadd_device()andremove_device()call-backs, which will be removed when all drivers are converted.The new call-backs will not setupt IOMMU groups and domains anymore, so also add a
probe_finalize()call-back where the IOMMU driver can do per-device setup work which require the device to be set up with a group and a domain.
The subject is inaccurate. probe_device() and release_device() are added to replace the add and remove pair.
Best regards,
baolu
Re: [PATCH v2 07/33] iommu: Add probe_device() and remove_device() call-backs
Quoted 7 lines · Lu Baolu
Quoted 6 lines · Joerg Roedel
From: Joerg Roedel<[email protected]>
Add call-backs to 'struct
iommu_ops' as an alternative to theadd_device()andremove_device()call-backs, which will be removed when all drivers are converted.
Quoted 7 lines
Quoted 4 lines
The new call-backs will not setupt IOMMU groups and domains anymore, so also add a
probe_finalize()call-back where the IOMMU driver can do per-device setup work which require the device to be set up with a group and a domain.The subject is inaccurate.
probe_device()andrelease_device()are added to replace the add and remove pair.
This patch does not replace them yet, it just adds the new call-backs. The removal of add_device()/remove_device() happens later in the patch-set when all drivers are converted.
Regards,
Joerg
Joerg Roedel
maintainerPATCH v2 8/33 iommu: Move default domain allocation to iommu_probe_device()
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Well, not really. The call to iommu_alloc_default_domain() in iommu_group_get_for_dev() has to stay around as long as there are IOMMU drivers using the add/remove_device() call-backs instead of probe/release_device().
Those drivers expect that iommu_group_get_for_dev() returns the device attached to a group and the group set up with a default domain (and the device attached to the groups current domain).
But when all drivers are converted this compatability mess can be removed.
--- drivers/iommu/iommu.c | 102 +++++++++++++++++++++++++++++------------- 1 file changed, 71 insertions(+), 31 deletions(-)
drivers/iommu/iommu.c +71 -31
@@ -79,6 +79,16 @@ static bool iommu_cmd_line_dma_api(void)return !!(iommu_cmd_line &IOMMU_CMD_LINE_DMA_API ); } +static int iommu_alloc_default_domain (struct device *dev); +static struct iommu_domain *__iommu_domain_alloc (struct bus_type *bus, +unsigned type); +static int __iommu_attach_device (struct iommu_domain *domain, +struct device *dev); +static int __iommu_attach_group (struct iommu_domain *domain, +struct iommu_group *group); +static void __iommu_detach_group (struct iommu_domain *domain, +struct iommu_group *group); +#define IOMMU_GROUP_ATTR (_name, _mode, _show, _store) \ struct iommu_group_attribute iommu_group_attr_##_name = \ __ATTR(_name, _mode, _show, _store)
@@ -221,10 +231,29 @@ int iommu_probe_device(struct device *dev) goto err_free_dev_param; } -if (ops->probe_device) +if (ops->probe_device) { +struct iommu_group *group; + ret =__iommu_probe_device (dev); -else + +/* +* Try to allocate a default domain - needs support from the +* IOMMU driver. There are still some drivers which don't +* support default domains, so the return value is not yet +* checked. +*/ +if (!ret) +iommu_alloc_default_domain (dev); + + group =iommu_group_get (dev); +if (group && group->default_domain) { + ret =__iommu_attach_device (group->default_domain, dev); +iommu_group_put (group); + } + + }else { ret = ops->add_device (dev); + }if (ret) goto err_module_put;
@@ -268,15 +297,6 @@ void iommu_release_device(struct device *dev)dev_iommu_free (dev); } -static struct iommu_domain *__iommu_domain_alloc (struct bus_type *bus, -unsigned type); -static int __iommu_attach_device (struct iommu_domain *domain, -struct device *dev); -static int __iommu_attach_group (struct iommu_domain *domain, -struct iommu_group *group); -static void __iommu_detach_group (struct iommu_domain *domain, -struct iommu_group *group); -static int __init iommu_set_def_domain_type (char *str) {bool pt;
@@ -1423,25 +1443,18 @@ static int iommu_get_def_domain_type(struct device *dev)return (type ==0 ) ? iommu_def_domain_type : type; } -static int iommu_alloc_default_domain (struct device *dev, -struct iommu_group *group) +static int iommu_group_alloc_default_domain (struct bus_type *bus, +struct iommu_group *group, +unsigned int type) {struct iommu_domain *dom; -unsigned int type; - -if (group->default_domain) -return 0 ; - type =iommu_get_def_domain_type (dev); - - dom =__iommu_domain_alloc (dev->bus, type); + dom =__iommu_domain_alloc (bus, type);if (!dom && type !=IOMMU_DOMAIN_DMA ) { - dom =__iommu_domain_alloc (dev->bus,IOMMU_DOMAIN_DMA ); -if (dom) { -dev_warn (dev, -"failed to allocate default IOMMU domain of type %u; falling back to IOMMU_DOMAIN_DMA" , - type); - } + dom =__iommu_domain_alloc (bus,IOMMU_DOMAIN_DMA ); +if (dom) +pr_warn ("Failed to allocate default IOMMU domain of type %u for group %s - Falling back to IOMMU_DOMAIN_DMA" , + type, group->name); }if (!dom)
@@ -1461,6 +1474,23 @@ static int iommu_alloc_default_domain(struct device *dev,return 0 ; } +static int iommu_alloc_default_domain (struct device *dev) +{ +struct iommu_group *group; +unsigned int type; + + group =iommu_group_get (dev); +if (!group) +return -ENODEV ; + +if (group->default_domain) +return 0 ; + + type =iommu_get_def_domain_type (dev); + +return iommu_group_alloc_default_domain (dev->bus, group, type); +} +/** * iommu_group_get_for_dev - Find or create the IOMMU group for a device * @dev: target device
@@ -1491,16 +1521,26 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)if (IS_ERR (group))return group; + ret =iommu_group_add_device (group, dev); +if (ret) + goto out_put_group; +/* * Try to allocate a default domain - needs support from the * IOMMU driver. There are still some drivers which don't support -* default domains, so the return value is not yet checked. +* default domains, so the return value is not yet checked. Only +* allocate the domain here when the driver still has the +* add_device/remove_device call-backs implemented. */ -iommu_alloc_default_domain (dev, group); +if (!ops->probe_device) { +iommu_alloc_default_domain (dev); - ret =iommu_group_add_device (group, dev); -if (ret) - goto out_put_group; +if (group->default_domain) + ret =__iommu_attach_device (group->default_domain, dev); + +if (ret) + goto out_put_group; + }return group;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 9/33 iommu: Keep a list of allocated groups in __iommu_probe_device()
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
This is needed to defer default_domain allocation for new IOMMU groups until all devices have been added to the group.
--- drivers/iommu/iommu.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/iommu/iommu.c +7 -2
@@ -44,6 +44,7 @@ struct iommu_group {int id;struct iommu_domain *default_domain;struct iommu_domain *domain; +struct list_head entry; };struct group_device {
@@ -184,7 +185,7 @@ static void dev_iommu_free(struct device *dev) dev->iommu =NULL ; } -static int __iommu_probe_device (struct device *dev) +static int __iommu_probe_device (struct device *dev,struct list_head *group_list) {const struct iommu_ops *ops = dev->bus->iommu_ops;struct iommu_device *iommu_dev;
@@ -204,6 +205,9 @@ static int __iommu_probe_device(struct device *dev) }iommu_group_put (group); +if (group_list && !group->default_domain &&list_empty (&group->entry)) +list_add_tail (&group->entry, group_list); +iommu_device_link (iommu_dev, dev);return 0 ;
@@ -234,7 +238,7 @@ int iommu_probe_device(struct device *dev)if (ops->probe_device) {struct iommu_group *group; - ret =__iommu_probe_device (dev); + ret =__iommu_probe_device (dev,NULL );/* * Try to allocate a default domain - needs support from the
@@ -567,6 +571,7 @@ struct iommu_group *iommu_group_alloc(void) group->kobj.kset = iommu_group_kset;mutex_init (&group->mutex);INIT_LIST_HEAD (&group->devices); +INIT_LIST_HEAD (&group->entry);BLOCKING_INIT_NOTIFIER_HEAD (&group->notifier); ret =ida_simple_get (&iommu_group_ida,0 ,0 ,GFP_KERNEL );
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 10/33 iommu: Move new probe_device path to separate function
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
This makes it easier to remove to old code-path when all drivers are converted. As a side effect that it also fixes the error cleanup path.
--- drivers/iommu/iommu.c | 69 ++++++++++++++++++++++++++++--------------- 1 file changed, 46 insertions(+), 23 deletions(-)
drivers/iommu/iommu.c +46 -23
@@ -218,12 +218,55 @@ static int __iommu_probe_device(struct device *dev, struct list_head *group_listreturn ret; } +static int __iommu_probe_device_helper (struct device *dev) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; +struct iommu_group *group; +int ret; + + ret =__iommu_probe_device (dev,NULL ); +if (ret) + goto err_out; + +/* +* Try to allocate a default domain - needs support from the +* IOMMU driver. There are still some drivers which don't +* support default domains, so the return value is not yet +* checked. +*/ +iommu_alloc_default_domain (dev); + + group =iommu_group_get (dev); +if (!group) + goto err_release; + +if (group->default_domain) + ret =__iommu_attach_device (group->default_domain, dev); + +iommu_group_put (group); + +if (ret) + goto err_release; + +if (ops->probe_finalize) + ops->probe_finalize (dev); + +return 0 ; + +err_release: +iommu_release_device (dev); +err_out: +return ret; + +} +int iommu_probe_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops;int ret;WARN_ON (dev->iommu_group); +if (!ops)return -EINVAL ;
@@ -235,30 +278,10 @@ int iommu_probe_device(struct device *dev) goto err_free_dev_param; } -if (ops->probe_device) { -struct iommu_group *group; - - ret =__iommu_probe_device (dev,NULL ); - -/* -* Try to allocate a default domain - needs support from the -* IOMMU driver. There are still some drivers which don't -* support default domains, so the return value is not yet -* checked. -*/ -if (!ret) -iommu_alloc_default_domain (dev); - - group =iommu_group_get (dev); -if (group && group->default_domain) { - ret =__iommu_attach_device (group->default_domain, dev); -iommu_group_put (group); - } - - }else { - ret = ops->add_device (dev); - } +if (ops->probe_device) +return __iommu_probe_device_helper (dev); + ret = ops->add_device (dev);if (ret) goto err_module_put;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 11/33 iommu: Split off default domain allocation from group assignment
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
When a bus is initialized with iommu-ops, all devices on the bus are scanned and iommu-groups are allocated for them, and each groups will also get a default domain allocated.
Until now this happened as soon as the group was created and the first device added to it. When other devices with different default domain requirements were added to the group later on, the default domain was re-allocated, if possible.
This resulted in some back and forth and unnecessary allocations, so change the flow to defer default domain allocation until all devices have been added to their respective IOMMU groups.
The default domains are allocated for newly allocated groups after each device on the bus is handled and was probed by the IOMMU driver.
--- drivers/iommu/iommu.c | 154 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 151 insertions(+), 3 deletions(-)
drivers/iommu/iommu.c +151 -3
@@ -199,7 +199,7 @@ static int __iommu_probe_device(struct device *dev, struct list_head *group_list dev->iommu->iommu_dev = iommu_dev; group =iommu_group_get_for_dev (dev); -if (!IS_ERR (group)) { +if (IS_ERR (group)) { ret =PTR_ERR (group); goto out_release; }
@@ -1599,6 +1599,37 @@ static int add_iommu_group(struct device *dev, void *data)return ret; } +static int probe_iommu_group (struct device *dev,void *data) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; +struct list_head *group_list = data; +int ret; + +if (!dev_iommu_get (dev)) +return -ENOMEM ; + +if (!try_module_get (ops->owner)) { + ret = -EINVAL ; + goto err_free_dev_iommu; + } + + ret =__iommu_probe_device (dev, group_list); +if (ret) + goto err_module_put; + +return 0 ; + +err_module_put: +module_put (ops->owner); +err_free_dev_iommu: +dev_iommu_free (dev); + +if (ret == -ENODEV ) + ret =0 ; + +return ret; +} +static int remove_iommu_group (struct device *dev,void *data) {iommu_release_device (dev);
@@ -1658,10 +1689,127 @@ static int iommu_bus_notifier(struct notifier_block *nb,return 0 ; } +struct __group_domain_type { +struct device *dev; +unsigned int type; +}; + +static int probe_get_default_domain_type (struct device *dev,void *data) +{ +const struct iommu_ops *ops = dev->bus->iommu_ops; +struct __group_domain_type *gtype = data; +unsigned int type =0 ; + +if (ops->def_domain_type) + type = ops->def_domain_type (dev); + +if (type) { +if (gtype->type && gtype->type != type) { +dev_warn (dev,"Device needs domain type %s, but device %s in the same iommu group requires type %s - using default\n" , +iommu_domain_type_str (type), +dev_name (gtype->dev), +iommu_domain_type_str (gtype->type)); + gtype->type =0 ; + } + +if (!gtype->dev) { + gtype->dev = dev; + gtype->type = type; + } + } + +return 0 ; +} + +static void probe_alloc_default_domain (struct bus_type *bus, +struct iommu_group *group) +{ +struct __group_domain_type gtype; + +memset (>ype,0 ,sizeof (gtype)); + +/* Ask for default domain requirements of all devices in the group */ +__iommu_group_for_each_dev (group, >ype, + probe_get_default_domain_type); + +if (!gtype.type) + gtype.type = iommu_def_domain_type; + +iommu_group_alloc_default_domain (bus, group, gtype.type); +} + +static int iommu_group_do_dma_attach (struct device *dev,void *data) +{ +struct iommu_domain *domain = data; +const struct iommu_ops *ops; +int ret; + + ret =__iommu_attach_device (domain, dev); + + ops = domain->ops; + +if (ret ==0 && ops->probe_finalize) + ops->probe_finalize (dev); + +return ret; +} + +static int __iommu_group_dma_attach (struct iommu_group *group) +{ +return __iommu_group_for_each_dev (group, group->default_domain, + iommu_group_do_dma_attach); +} + +static int bus_iommu_probe (struct bus_type *bus) +{ +const struct iommu_ops *ops = bus->iommu_ops; +int ret; + +if (ops->probe_device) { +struct iommu_group *group, *next; +LIST_HEAD (group_list); + +/* +* This code-path does not allocate the default domain when +* creating the iommu group, so do it after the groups are +* created. +*/ + ret =bus_for_each_dev (bus,NULL , &group_list, probe_iommu_group); +if (ret) +return ret; + +list_for_each_entry_safe (group, next, &group_list, entry) { +/* Remove item from the list */ +list_del_init (&group->entry); + +mutex_lock (&group->mutex); + +/* Try to allocate default domain */ +probe_alloc_default_domain (bus, group); + +if (!group->default_domain) { +mutex_unlock (&group->mutex); +continue ; + } + + ret =__iommu_group_dma_attach (group); + +mutex_unlock (&group->mutex); + +if (ret) +break ; + } + }else { + ret =bus_for_each_dev (bus,NULL ,NULL , add_iommu_group); + } + +return ret; +} +static int iommu_bus_init (struct bus_type *bus,const struct iommu_ops *ops) { -int err;struct notifier_block *nb; +int err; nb =kzalloc (sizeof (struct notifier_block ),GFP_KERNEL );if (!nb)
@@ -1673,7 +1821,7 @@ static int iommu_bus_init(struct bus_type *bus, const struct iommu_ops *ops)if (err) goto out_free; - err =bus_for_each_dev (bus,NULL ,NULL , add_iommu_group); + err =bus_iommu_probe (bus);if (err) goto out_err;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 12/33 iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
After the previous changes the iommu group may not have a default domain when iommu_group_add_device() is called. With no default domain iommu_group_create_direct_mappings() will do nothing and no direct mappings will be created.
Rename iommu_group_create_direct_mappings() to iommu_create_device_direct_mappings() to better reflect that the function creates direct mappings only for one device and not for all devices in the group. Then move the call to the places where a default domain actually exists.
--- drivers/iommu/iommu.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-)
drivers/iommu/iommu.c +30 -5
@@ -89,6 +89,8 @@ static int __iommu_attach_group(struct iommu_domain *domain, struct iommu_group *group);static void __iommu_detach_group (struct iommu_domain *domain,struct iommu_group *group); +static int iommu_create_device_direct_mappings (struct iommu_group *group, +struct device *dev);#define IOMMU_GROUP_ATTR (_name, _mode, _show, _store) \ struct iommu_group_attribute iommu_group_attr_##_name = \
@@ -243,6 +245,8 @@ static int __iommu_probe_device_helper(struct device *dev)if (group->default_domain) ret =__iommu_attach_device (group->default_domain, dev); +iommu_create_device_direct_mappings (group, dev); +iommu_group_put (group);if (ret)
@@ -263,6 +267,7 @@ static int __iommu_probe_device_helper(struct device *dev)int iommu_probe_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops; +struct iommu_group *group;int ret;WARN_ON (dev->iommu_group);
@@ -285,6 +290,10 @@ int iommu_probe_device(struct device *dev)if (ret) goto err_module_put; + group =iommu_group_get (dev); +iommu_create_device_direct_mappings (group, dev); +iommu_group_put (group); +if (ops->probe_finalize) ops->probe_finalize (dev);
@@ -736,8 +745,8 @@ int iommu_group_set_name(struct iommu_group *group, const char *name) }EXPORT_SYMBOL_GPL (iommu_group_set_name); -static int iommu_group_create_direct_mappings (struct iommu_group *group, -struct device *dev) +static int iommu_create_device_direct_mappings (struct iommu_group *group, +struct device *dev) {struct iommu_domain *domain = group->default_domain;struct iommu_resv_region *entry;
@@ -841,8 +850,6 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev) dev->iommu_group = group; -iommu_group_create_direct_mappings (group, dev); -mutex_lock (&group->mutex);list_add_tail (&device->list, &group->devices);if (group->domain)
@@ -1736,6 +1743,7 @@ static void probe_alloc_default_domain(struct bus_type *bus, gtype.type = iommu_def_domain_type;iommu_group_alloc_default_domain (bus, group, gtype.type); + }static int iommu_group_do_dma_attach (struct device *dev,void *data)
@@ -1760,6 +1768,21 @@ static int __iommu_group_dma_attach(struct iommu_group *group) iommu_group_do_dma_attach); } +static int iommu_do_create_direct_mappings (struct device *dev,void *data) +{ +struct iommu_group *group = data; + +iommu_create_device_direct_mappings (group, dev); + +return 0 ; +} + +static int iommu_group_create_direct_mappings (struct iommu_group *group) +{ +return __iommu_group_for_each_dev (group, group, + iommu_do_create_direct_mappings); +} +static int bus_iommu_probe (struct bus_type *bus) {const struct iommu_ops *ops = bus->iommu_ops;
@@ -1792,6 +1815,8 @@ static int bus_iommu_probe(struct bus_type *bus)continue ; } +iommu_group_create_direct_mappings (group); + ret =__iommu_group_dma_attach (group);mutex_unlock (&group->mutex);
@@ -2632,7 +2657,7 @@ request_default_domain_for_dev(struct device *dev, unsigned long type)iommu_domain_free (group->default_domain); group->default_domain = domain; -iommu_group_create_direct_mappings (group, dev); +iommu_create_device_direct_mappings (group, dev);dev_info (dev,"Using iommu %s mapping\n" , type ==IOMMU_DOMAIN_DMA ?"dma" :"direct" );
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 13/33 iommu: Export bus_iommu_probe() and make is safe for re-probing
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Add a check to the bus_iommu_probe() call-path to make sure it ignores devices which have already been successfully probed. Then export the bus_iommu_probe() function so it can be used by IOMMU drivers.
--- drivers/iommu/iommu.c | 6 +++++- include/linux/iommu.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/iommu/iommu.c +5 -1
@@ -1615,6 +1615,10 @@ static int probe_iommu_group(struct device *dev, void *data)if (!dev_iommu_get (dev))return -ENOMEM ; +/* Device is probed already if in a group */ +if (iommu_group_get (dev) !=NULL ) +return 0 ; +if (!try_module_get (ops->owner)) { ret = -EINVAL ; goto err_free_dev_iommu;
@@ -1783,7 +1787,7 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group) iommu_do_create_direct_mappings); } -static int bus_iommu_probe (struct bus_type *bus) +int bus_iommu_probe (struct bus_type *bus) {const struct iommu_ops *ops = bus->iommu_ops;int ret;
include/linux/iommu.h +1 -0
@@ -445,6 +445,7 @@ static inline void iommu_iotlb_gather_init(struct iommu_iotlb_gather *gather)#define IOMMU_GROUP_NOTIFY_UNBOUND_DRIVER 6/* Post Driver unbind */ extern int bus_set_iommu (struct bus_type *bus,const struct iommu_ops *ops); +extern int bus_iommu_probe (struct bus_type *bus);extern bool iommu_present (struct bus_type *bus);extern bool iommu_capable (struct bus_type *bus,enum iommu_cap cap);extern struct iommu_domain *iommu_domain_alloc (struct bus_type *bus);
Signature · 1 line
2.17.1
Re: [PATCH v2 13/33] iommu: Export bus_iommu_probe() and make is safe for re-probing
Quoted 17 lines · Joerg Roedel
From: Joerg Roedel <[email protected]>
Add a check to the
bus_iommu_probe()call-path to make sure it ignores devices which have already been successfully probed. Then export thebus_iommu_probe()function so it can be used by IOMMU drivers.Signed-off-by Joerg Roedel <[email protected]>--- drivers/iommu/iommu.c | 6 +++++- include/linux/iommu.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-)drivers/iommu/iommu.c +0
-0
drivers/iommu/iommu.c static int probe_iommu_group(struct device *dev, void *data) · line 1619
Quoted 5 lines
drivers/iommu/iommu.c +2
-0@@ -1615,6 +1615,10 @@ static int probe_iommu_group(struct device *dev, void *data)if (!dev_iommu_get (dev))return -ENOMEM ; +/* Device is probed already if in a group */ +if (iommu_group_get (dev) !=NULL )
Same as
if (iommu_group_get(dev))
?
By the way, do we need to put the group if device has already been probed?
Best regards,
baolu
Re: [PATCH v2 13/33] iommu: Export bus_iommu_probe() and make is safe for re-probing
Hi Baolu,
Quoted 10 lines · Lu Baolu
drivers/iommu/iommu.c static int probe_iommu_group(struct device *dev, void *data) · line 1619
Quoted 2 lines · Joerg Roedel
Quoted 1 line
drivers/iommu/iommu.c +1
-0+/* Device is probed already if in a group */ drivers/iommu/iommu.c +1
-0+if (iommu_group_get (dev) !=NULL )Same as
if (iommu_group_get(dev))
?By the way, do we need to put the group if device has already been probed?
Right, fixed both, thank you.
Regards,
Joerg
Joerg Roedel
maintainerPATCH v2 14/33 iommu/amd: Remove dev_data->passthrough
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Make use of generic IOMMU infrastructure to gather the same information carried in dev_data->passthrough and remove the struct member.
--- drivers/iommu/amd_iommu.c | 10 +++++----- drivers/iommu/amd_iommu_types.h | 1 - 2 files changed, 5 insertions(+), 6 deletions(-)
drivers/iommu/amd_iommu.c +5 -5
@@ -2047,8 +2047,8 @@ static int pdev_iommuv2_enable(struct pci_dev *pdev)static int attach_device (struct device *dev,struct protection_domain *domain) { -struct pci_dev *pdev;struct iommu_dev_data *dev_data; +struct pci_dev *pdev;unsigned long flags;int ret;
@@ -2067,8 +2067,10 @@ static int attach_device(struct device *dev, pdev =to_pci_dev (dev);if (domain->flags &PD_IOMMUV2_MASK ) { +struct iommu_domain *def_domain =iommu_get_dma_domain (dev); + ret = -EINVAL ; -if (!dev_data->passthrough) +if (def_domain->type !=IOMMU_DOMAIN_IDENTITY ) goto out;if (dev_data->iommu_v2) {
@@ -2189,9 +2191,7 @@ static int amd_iommu_add_device(struct device *dev)/* Domains are initialized for this device - have a look what we ended up with */ domain =iommu_get_domain_for_dev (dev); -if (domain->type ==IOMMU_DOMAIN_IDENTITY ) - dev_data->passthrough = true; -else if (domain->type ==IOMMU_DOMAIN_DMA ) +if (domain->type ==IOMMU_DOMAIN_DMA )iommu_setup_dma_ops (dev,IOVA_START_PFN <<PAGE_SHIFT ,0 ); out:
drivers/iommu/amd_iommu_types.h +0 -1
@@ -640,7 +640,6 @@ struct iommu_dev_data {struct pci_dev *pdev;u16 devid;/* PCI Device ID */ bool iommu_v2;/* Device can make use of IOMMUv2 */ -bool passthrough;/* Device is identity mapped */ struct {bool enabled;int qdep;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 15/33 iommu/amd: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the AMD IOMMU Driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/amd_iommu.c | 71 ++++++++++++--------------------------- 1 file changed, 22 insertions(+), 49 deletions(-)
drivers/iommu/amd_iommu.c +22 -49
@@ -343,21 +343,9 @@ static bool check_device(struct device *dev)return true; } -static void init_iommu_group (struct device *dev) -{ -struct iommu_group *group; - - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return ; - -iommu_group_put (group); -} -static int iommu_init_device (struct device *dev) {struct iommu_dev_data *dev_data; -struct amd_iommu *iommu;int devid;if (dev->archdata.iommu)
@@ -367,8 +355,6 @@ static int iommu_init_device(struct device *dev)if (devid <0 )return devid; - iommu = amd_iommu_rlookup_table[devid]; - dev_data =find_dev_data (devid);if (!dev_data)return -ENOMEM ;
@@ -391,8 +377,6 @@ static int iommu_init_device(struct device *dev) dev->archdata.iommu = dev_data; -iommu_device_link (&iommu->iommu, dev); -return 0 ; }
@@ -410,7 +394,7 @@ static void iommu_ignore_device(struct device *dev)setup_aliases (dev); } -static void iommu_uninit_device (struct device *dev) +static void amd_iommu_uninit_device (struct device *dev) {struct iommu_dev_data *dev_data;struct amd_iommu *iommu;
@@ -429,13 +413,6 @@ static void iommu_uninit_device(struct device *dev)if (dev_data->domain)detach_device (dev); -iommu_device_unlink (&iommu->iommu, dev); - -iommu_group_remove_device (dev); - -/* Remove dma-ops */ - dev->dma_ops =NULL ; -/* * We keep dev_data around for unplugged devices and reuse it when the * device is re-plugged - not doing so would introduce a ton of races.
@@ -2152,55 +2129,50 @@ static void detach_device(struct device *dev)spin_unlock_irqrestore (&domain->lock, flags); } -static int amd_iommu_add_device (struct device *dev) +static struct iommu_device *amd_iommu_probe_device (struct device *dev) { -struct iommu_dev_data *dev_data; -struct iommu_domain *domain; +struct iommu_device *iommu_dev;struct amd_iommu *iommu;int ret, devid; -if (get_dev_data (dev)) -return 0 ; -if (!check_device (dev)) -return -ENODEV ; +return ERR_PTR (-ENODEV ); devid =get_device_id (dev);if (devid <0 ) -return devid; +return ERR_PTR (devid); iommu = amd_iommu_rlookup_table[devid]; +if (get_dev_data (dev)) +return &iommu->iommu; + ret =iommu_init_device (dev);if (ret) {if (ret != -ENOTSUPP )dev_err (dev,"Failed to initialize - trying to proceed anyway\n" ); - + iommu_dev =ERR_PTR (ret);iommu_ignore_device (dev); - dev->dma_ops =NULL ; - goto out; + }else { + iommu_dev = &iommu->iommu; } -init_iommu_group (dev); - dev_data =get_dev_data (dev); +iommu_completion_wait (iommu); -BUG_ON (!dev_data); +return iommu_dev; +} -if (dev_data->iommu_v2) -iommu_request_dm_for_dev (dev); +static void amd_iommu_probe_finalize (struct device *dev) +{ +struct iommu_domain *domain;/* Domains are initialized for this device - have a look what we ended up with */ domain =iommu_get_domain_for_dev (dev);if (domain->type ==IOMMU_DOMAIN_DMA )iommu_setup_dma_ops (dev,IOVA_START_PFN <<PAGE_SHIFT ,0 ); - -out: -iommu_completion_wait (iommu); - -return 0 ; } -static void amd_iommu_remove_device (struct device *dev) +static void amd_iommu_release_device (struct device *dev) {struct amd_iommu *iommu;int devid;
@@ -2214,7 +2186,7 @@ static void amd_iommu_remove_device(struct device *dev) iommu = amd_iommu_rlookup_table[devid]; -iommu_uninit_device (dev); +amd_iommu_uninit_device (dev);iommu_completion_wait (iommu); }
@@ -2687,8 +2659,9 @@ const struct iommu_ops amd_iommu_ops = { .map = amd_iommu_map, .unmap = amd_iommu_unmap, .iova_to_phys = amd_iommu_iova_to_phys, - .add_device = amd_iommu_add_device, - .remove_device = amd_iommu_remove_device, + .probe_device = amd_iommu_probe_device, + .release_device = amd_iommu_release_device, + .probe_finalize = amd_iommu_probe_finalize, .device_group = amd_iommu_device_group, .domain_get_attr = amd_iommu_domain_get_attr, .get_resv_regions = amd_iommu_get_resv_regions,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 16/33 iommu/vt-d: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Intel IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/intel-iommu.c | 67 ++++--------------------------------- 1 file changed, 6 insertions(+), 61 deletions(-)
drivers/iommu/intel-iommu.c +6 -61
@@ -5781,78 +5781,27 @@ static bool intel_iommu_capable(enum iommu_cap cap)return false; } -static int intel_iommu_add_device (struct device *dev) +static struct iommu_device *intel_iommu_probe_device (struct device *dev) { -struct dmar_domain *dmar_domain; -struct iommu_domain *domain;struct intel_iommu *iommu; -struct iommu_group *group;u8 bus, devfn; -int ret; iommu =device_to_iommu (dev, &bus, &devfn);if (!iommu) -return -ENODEV ; - -iommu_device_link (&iommu->iommu, dev); +return ERR_PTR (-ENODEV );if (translation_pre_enabled (iommu)) dev->archdata.iommu =DEFER_DEVICE_DOMAIN_INFO ; - group =iommu_group_get_for_dev (dev); - -if (IS_ERR (group)) { - ret =PTR_ERR (group); - goto unlink; - } - -iommu_group_put (group); - - domain =iommu_get_domain_for_dev (dev); - dmar_domain =to_dmar_domain (domain); -if (domain->type ==IOMMU_DOMAIN_DMA ) { -if (device_def_domain_type (dev) ==IOMMU_DOMAIN_IDENTITY ) { - ret =iommu_request_dm_for_dev (dev); -if (ret) { -dmar_remove_one_dev_info (dev); - dmar_domain->flags |=DOMAIN_FLAG_LOSE_CHILDREN ; -domain_add_dev_info (si_domain, dev); -dev_info (dev, -"Device uses a private identity domain.\n" ); - } - } - }else { -if (device_def_domain_type (dev) ==IOMMU_DOMAIN_DMA ) { - ret =iommu_request_dma_domain_for_dev (dev); -if (ret) { -dmar_remove_one_dev_info (dev); - dmar_domain->flags |=DOMAIN_FLAG_LOSE_CHILDREN ; -if (!get_private_domain_for_dev (dev)) { -dev_warn (dev, -"Failed to get a private domain.\n" ); - ret = -ENOMEM ; - goto unlink; - } - -dev_info (dev, -"Device uses a private dma domain.\n" ); - } - } - } -if (device_needs_bounce (dev)) {dev_info (dev,"Use Intel IOMMU bounce page dma_ops\n" );set_dma_ops (dev, &bounce_dma_ops); } -return 0 ; - -unlink: -iommu_device_unlink (&iommu->iommu, dev); -return ret; +return &iommu->iommu; } -static void intel_iommu_remove_device (struct device *dev) +static void intel_iommu_release_device (struct device *dev) {struct intel_iommu *iommu;u8 bus, devfn;
@@ -5863,10 +5812,6 @@ static void intel_iommu_remove_device(struct device *dev)dmar_remove_one_dev_info (dev); -iommu_group_remove_device (dev); - -iommu_device_unlink (&iommu->iommu, dev); -if (device_needs_bounce (dev))set_dma_ops (dev,NULL ); }
@@ -6198,8 +6143,8 @@ const struct iommu_ops intel_iommu_ops = { .map = intel_iommu_map, .unmap = intel_iommu_unmap, .iova_to_phys = intel_iommu_iova_to_phys, - .add_device = intel_iommu_add_device, - .remove_device = intel_iommu_remove_device, + .probe_device = intel_iommu_probe_device, + .release_device = intel_iommu_release_device, .get_resv_regions = intel_iommu_get_resv_regions, .put_resv_regions = generic_iommu_put_resv_regions, .apply_resv_region = intel_iommu_apply_resv_region,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 17/33 iommu/arm-smmu: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the arm-smmu and arm-smmu-v3 drivers to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/arm-smmu-v3.c | 38 ++++++++++-------------------------- drivers/iommu/arm-smmu.c | 39 ++++++++++++++----------------------- 2 files changed, 25 insertions(+), 52 deletions(-)
drivers/iommu/arm-smmu-v3.c +10 -28
@@ -2914,27 +2914,26 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid)static struct iommu_ops arm_smmu_ops; -static int arm_smmu_add_device (struct device *dev) +static struct iommu_device *arm_smmu_probe_device (struct device *dev) {int i, ret;struct arm_smmu_device *smmu;struct arm_smmu_master *master;struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev); -struct iommu_group *group;if (!fwspec || fwspec->ops != &arm_smmu_ops) -return -ENODEV ; +return ERR_PTR (-ENODEV );if (WARN_ON_ONCE (dev_iommu_priv_get (dev))) -return -EBUSY ; +return ERR_PTR (-EBUSY ); smmu =arm_smmu_get_by_fwnode (fwspec->iommu_fwnode);if (!smmu) -return -ENODEV ; +return ERR_PTR (-ENODEV ); master =kzalloc (sizeof (*master),GFP_KERNEL );if (!master) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); master->dev = dev; master->smmu = smmu;
@@ -2975,30 +2974,15 @@ static int arm_smmu_add_device(struct device *dev) master->ssid_bits =min_t (u8, master->ssid_bits,CTXDESC_LINEAR_CDMAX ); - ret =iommu_device_link (&smmu->iommu, dev); -if (ret) - goto err_disable_pasid; +return &smmu->iommu; - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) { - ret =PTR_ERR (group); - goto err_unlink; - } - -iommu_group_put (group); -return 0 ; - -err_unlink: -iommu_device_unlink (&smmu->iommu, dev); -err_disable_pasid: -arm_smmu_disable_pasid (master); err_free_master:kfree (master);dev_iommu_priv_set (dev,NULL ); -return ret; +return ERR_PTR (ret); } -static void arm_smmu_remove_device (struct device *dev) +static void arm_smmu_release_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);struct arm_smmu_master *master;
@@ -3010,8 +2994,6 @@ static void arm_smmu_remove_device(struct device *dev) master =dev_iommu_priv_get (dev); smmu = master->smmu;arm_smmu_detach_dev (master); -iommu_group_remove_device (dev); -iommu_device_unlink (&smmu->iommu, dev);arm_smmu_disable_pasid (master);kfree (master);iommu_fwspec_free (dev);
@@ -3138,8 +3120,8 @@ static struct iommu_ops arm_smmu_ops = { .flush_iotlb_all = arm_smmu_flush_iotlb_all, .iotlb_sync = arm_smmu_iotlb_sync, .iova_to_phys = arm_smmu_iova_to_phys, - .add_device = arm_smmu_add_device, - .remove_device = arm_smmu_remove_device, + .probe_device = arm_smmu_probe_device, + .release_device = arm_smmu_release_device, .device_group = arm_smmu_device_group, .domain_get_attr = arm_smmu_domain_get_attr, .domain_set_attr = arm_smmu_domain_set_attr,
drivers/iommu/arm-smmu.c +15 -24
@@ -220,7 +220,7 @@ static int arm_smmu_register_legacy_master(struct device *dev,* With the legacy DT binding in play, we have no guarantees about * probe order, but then we're also not doing default domains, so we can * delay setting bus ops until we're sure every possible SMMU is ready, -* and that way ensure that no add_device() calls get missed. +* and that way ensure that no probe_device() calls get missed. */ static int arm_smmu_legacy_bus_init (void ) {
@@ -1062,7 +1062,6 @@ static int arm_smmu_master_alloc_smes(struct device *dev)struct arm_smmu_master_cfg *cfg =dev_iommu_priv_get (dev);struct arm_smmu_device *smmu = cfg->smmu;struct arm_smmu_smr *smrs = smmu->smrs; -struct iommu_group *group;int i, idx, ret;mutex_lock (&smmu->stream_map_mutex);
@@ -1090,18 +1089,9 @@ static int arm_smmu_master_alloc_smes(struct device *dev) cfg->smendx[i] = (s16 )idx; } - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) { - ret =PTR_ERR (group); - goto out_err; - } -iommu_group_put (group); -/* It worked! Now, poke the actual hardware */ -for_each_cfg_sme (cfg, fwspec, i, idx) { +for_each_cfg_sme (cfg, fwspec, i, idx)arm_smmu_write_sme (smmu, idx); - smmu->s2crs[idx].group = group; - }mutex_unlock (&smmu->stream_map_mutex);return 0 ;
@@ -1172,7 +1162,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)/* * FIXME: The arch/arm DMA API code tries to attach devices to its own -* domains between of_xlate() and add_device() - we have no way to cope +* domains between of_xlate() and probe_device() - we have no way to cope * with that, so until ARM gets converted to rely on groups and default * domains, just say no (but more politely than by dereferencing NULL). * This should be at least a WARN_ON once that's sorted.
@@ -1382,7 +1372,7 @@ struct arm_smmu_device *arm_smmu_get_by_fwnode(struct fwnode_handle *fwnode)return dev ?dev_get_drvdata (dev) :NULL ; } -static int arm_smmu_add_device (struct device *dev) +static struct iommu_device *arm_smmu_probe_device (struct device *dev) {struct arm_smmu_device *smmu =NULL ;struct arm_smmu_master_cfg *cfg;
@@ -1403,7 +1393,7 @@ static int arm_smmu_add_device(struct device *dev) }else if (fwspec && fwspec->ops == &arm_smmu_ops) { smmu =arm_smmu_get_by_fwnode (fwspec->iommu_fwnode); }else { -return -ENODEV ; +return ERR_PTR (-ENODEV ); } ret = -EINVAL ;
@@ -1444,21 +1434,19 @@ static int arm_smmu_add_device(struct device *dev)if (ret) goto out_cfg_free; -iommu_device_link (&smmu->iommu, dev); -device_link_add (dev, smmu->dev,DL_FLAG_PM_RUNTIME |DL_FLAG_AUTOREMOVE_SUPPLIER ); -return 0 ; +return &smmu->iommu; out_cfg_free:kfree (cfg); out_free:iommu_fwspec_free (dev); -return ret; +return ERR_PTR (ret); } -static void arm_smmu_remove_device (struct device *dev) +static void arm_smmu_release_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);struct arm_smmu_master_cfg *cfg;
@@ -1475,13 +1463,11 @@ static void arm_smmu_remove_device(struct device *dev)if (ret <0 )return ; -iommu_device_unlink (&smmu->iommu, dev);arm_smmu_master_free_smes (cfg, fwspec);arm_smmu_rpm_put (smmu);dev_iommu_priv_set (dev,NULL ); -iommu_group_remove_device (dev);kfree (cfg);iommu_fwspec_free (dev); }
@@ -1512,6 +1498,11 @@ static struct iommu_group *arm_smmu_device_group(struct device *dev)else group =generic_device_group (dev); +/* Remember group for faster lookups */ +if (!IS_ERR (group)) +for_each_cfg_sme (cfg, fwspec, i, idx) + smmu->s2crs[idx].group = group; +return group; }
@@ -1628,8 +1619,8 @@ static struct iommu_ops arm_smmu_ops = { .flush_iotlb_all = arm_smmu_flush_iotlb_all, .iotlb_sync = arm_smmu_iotlb_sync, .iova_to_phys = arm_smmu_iova_to_phys, - .add_device = arm_smmu_add_device, - .remove_device = arm_smmu_remove_device, + .probe_device = arm_smmu_probe_device, + .release_device = arm_smmu_release_device, .device_group = arm_smmu_device_group, .domain_get_attr = arm_smmu_domain_get_attr, .domain_set_attr = arm_smmu_domain_set_attr,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 18/33 iommu/pamu: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the PAMU IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/fsl_pamu_domain.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-)
drivers/iommu/fsl_pamu_domain.c +5 -17
@@ -1016,25 +1016,13 @@ static struct iommu_group *fsl_pamu_device_group(struct device *dev)return group; } -static int fsl_pamu_add_device (struct device *dev) +static struct iommu_device *fsl_pamu_probe_device (struct device *dev) { -struct iommu_group *group; - - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); - -iommu_device_link (&pamu_iommu, dev); - -return 0 ; +return &pamu_iommu; } -static void fsl_pamu_remove_device (struct device *dev) +static void fsl_pamu_release_device (struct device *dev) { -iommu_device_unlink (&pamu_iommu, dev); -iommu_group_remove_device (dev); }static const struct iommu_ops fsl_pamu_ops = {
@@ -1048,8 +1036,8 @@ static const struct iommu_ops fsl_pamu_ops = { .iova_to_phys = fsl_pamu_iova_to_phys, .domain_set_attr = fsl_pamu_set_domain_attr, .domain_get_attr = fsl_pamu_get_domain_attr, - .add_device = fsl_pamu_add_device, - .remove_device = fsl_pamu_remove_device, + .probe_device = fsl_pamu_probe_device, + .release_device = fsl_pamu_release_device, .device_group = fsl_pamu_device_group, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 19/33 iommu/s390: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the S390 IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/s390-iommu.c | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-)
drivers/iommu/s390-iommu.c +6 -16
@@ -166,21 +166,14 @@ static void s390_iommu_detach_device(struct iommu_domain *domain, } } -static int s390_iommu_add_device (struct device *dev) +static struct iommu_device *s390_iommu_probe_device (struct device *dev) { -struct iommu_group *group =iommu_group_get_for_dev (dev);struct zpci_dev *zdev =to_pci_dev (dev)->sysdata; -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); -iommu_device_link (&zdev->iommu_dev, dev); - -return 0 ; +return &zdev->iommu_dev; } -static void s390_iommu_remove_device (struct device *dev) +static void s390_iommu_release_device (struct device *dev) {struct zpci_dev *zdev =to_pci_dev (dev)->sysdata;struct iommu_domain *domain;
@@ -191,7 +184,7 @@ static void s390_iommu_remove_device(struct device *dev)* to vfio-pci and completing the VFIO_SET_IOMMU ioctl (which triggers * the attach_dev), removing the device via * "echo 1 > /sys/bus/pci/devices/.../remove" won't trigger detach_dev, -* only remove_device will be called via the BUS_NOTIFY_REMOVED_DEVICE +* only release_device will be called via the BUS_NOTIFY_REMOVED_DEVICE * notifier. * * So let's call detach_dev from here if it hasn't been called before.
@@ -201,9 +194,6 @@ static void s390_iommu_remove_device(struct device *dev)if (domain)s390_iommu_detach_device (domain, dev); } - -iommu_device_unlink (&zdev->iommu_dev, dev); -iommu_group_remove_device (dev); } static int s390_iommu_update_trans(struct s390_domain *s390_domain,
@@ -373,8 +363,8 @@ static const struct iommu_ops s390_iommu_ops = { .map = s390_iommu_map, .unmap = s390_iommu_unmap, .iova_to_phys = s390_iommu_iova_to_phys, - .add_device = s390_iommu_add_device, - .remove_device = s390_iommu_remove_device, + .probe_device = s390_iommu_probe_device, + .release_device = s390_iommu_release_device, .device_group = generic_device_group, .pgsize_bitmap = S390_IOMMU_PGSIZES, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 20/33 iommu/virtio: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the VirtIO IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/virtio-iommu.c | 41 +++++++++--------------------------- 1 file changed, 10 insertions(+), 31 deletions(-)
drivers/iommu/virtio-iommu.c +10 -31
@@ -865,24 +865,23 @@ static struct viommu_dev *viommu_get_by_fwnode(struct fwnode_handle *fwnode)return dev ?dev_to_virtio (dev)->priv :NULL ; } -static int viommu_add_device (struct device *dev) +static struct iommu_device *viommu_probe_device (struct device *dev) {int ret; -struct iommu_group *group;struct viommu_endpoint *vdev;struct viommu_dev *viommu =NULL ;struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);if (!fwspec || fwspec->ops != &viommu_ops) -return -ENODEV ; +return ERR_PTR (-ENODEV ); viommu =viommu_get_by_fwnode (fwspec->iommu_fwnode);if (!viommu) -return -ENODEV ; +return ERR_PTR (-ENODEV ); vdev =kzalloc (sizeof (*vdev),GFP_KERNEL );if (!vdev) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); vdev->dev = dev; vdev->viommu = viommu;
@@ -896,45 +895,25 @@ static int viommu_add_device(struct device *dev) goto err_free_dev; } - ret =iommu_device_link (&viommu->iommu, dev); -if (ret) - goto err_free_dev; +return &viommu->iommu; -/* -* Last step creates a default domain and attaches to it. Everything -* must be ready. -*/ - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) { - ret =PTR_ERR (group); - goto err_unlink_dev; - } - -iommu_group_put (group); - -return PTR_ERR_OR_ZERO (group); - -err_unlink_dev: -iommu_device_unlink (&viommu->iommu, dev); err_free_dev:generic_iommu_put_resv_regions (dev, &vdev->resv_regions);kfree (vdev); -return ret; +return ERR_PTR (ret); } -static void viommu_remove_device (struct device *dev) +static void viommu_release_device (struct device *dev) { -struct viommu_endpoint *vdev;struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev); +struct viommu_endpoint *vdev;if (!fwspec || fwspec->ops != &viommu_ops)return ; vdev =dev_iommu_priv_get (dev); -iommu_group_remove_device (dev); -iommu_device_unlink (&vdev->viommu->iommu, dev);generic_iommu_put_resv_regions (dev, &vdev->resv_regions);kfree (vdev); }
@@ -960,8 +939,8 @@ static struct iommu_ops viommu_ops = { .unmap = viommu_unmap, .iova_to_phys = viommu_iova_to_phys, .iotlb_sync = viommu_iotlb_sync, - .add_device = viommu_add_device, - .remove_device = viommu_remove_device, + .probe_device = viommu_probe_device, + .release_device = viommu_release_device, .device_group = viommu_device_group, .get_resv_regions = viommu_get_resv_regions, .put_resv_regions = generic_iommu_put_resv_regions,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 21/33 iommu/msm: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the MSM IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/msm_iommu.c | 34 +++++++--------------------------- 1 file changed, 7 insertions(+), 27 deletions(-)
drivers/iommu/msm_iommu.c +7 -27
@@ -388,43 +388,23 @@ static struct msm_iommu_dev *find_iommu_for_dev(struct device *dev)return ret; } -static int msm_iommu_add_device (struct device *dev) +static struct iommu_device *msm_iommu_probe_device (struct device *dev) {struct msm_iommu_dev *iommu; -struct iommu_group *group;unsigned long flags;spin_lock_irqsave (&msm_iommu_lock, flags); iommu =find_iommu_for_dev (dev);spin_unlock_irqrestore (&msm_iommu_lock, flags); -if (iommu) -iommu_device_link (&iommu->iommu, dev); -else -return -ENODEV ; - - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); +if (!iommu) +return ERR_PTR (-ENODEV ); -return 0 ; +return &iommu->iommu; } -static void msm_iommu_remove_device (struct device *dev) +static void msm_iommu_release_device (struct device *dev) { -struct msm_iommu_dev *iommu; -unsigned long flags; - -spin_lock_irqsave (&msm_iommu_lock, flags); - iommu =find_iommu_for_dev (dev); -spin_unlock_irqrestore (&msm_iommu_lock, flags); - -if (iommu) -iommu_device_unlink (&iommu->iommu, dev); - -iommu_group_remove_device (dev); }static int msm_iommu_attach_dev (struct iommu_domain *domain,struct device *dev)
@@ -708,8 +688,8 @@ static struct iommu_ops msm_iommu_ops = {*/ .iotlb_sync = NULL, .iova_to_phys = msm_iommu_iova_to_phys, - .add_device = msm_iommu_add_device, - .remove_device = msm_iommu_remove_device, + .probe_device = msm_iommu_probe_device, + .release_device = msm_iommu_release_device, .device_group = generic_device_group, .pgsize_bitmap = MSM_IOMMU_PGSIZES, .of_xlate = qcom_iommu_of_xlate,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 22/33 iommu/mediatek: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Mediatek IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/mtk_iommu.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)
drivers/iommu/mtk_iommu.c +6 -18
@@ -441,38 +441,26 @@ static phys_addr_t mtk_iommu_iova_to_phys(struct iommu_domain *domain,return pa; } -static int mtk_iommu_add_device (struct device *dev) +static struct iommu_device *mtk_iommu_probe_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);struct mtk_iommu_data *data; -struct iommu_group *group;if (!fwspec || fwspec->ops != &mtk_iommu_ops) -return -ENODEV ;/* Not a iommu client device */ +return ERR_PTR (-ENODEV );/* Not a iommu client device */ data =dev_iommu_priv_get (dev); -iommu_device_link (&data->iommu, dev); - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); -return 0 ; +return &data->iommu; } -static void mtk_iommu_remove_device (struct device *dev) +static void mtk_iommu_release_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev); -struct mtk_iommu_data *data;if (!fwspec || fwspec->ops != &mtk_iommu_ops)return ; - data =dev_iommu_priv_get (dev); -iommu_device_unlink (&data->iommu, dev); - -iommu_group_remove_device (dev);iommu_fwspec_free (dev); }
@@ -526,8 +514,8 @@ static const struct iommu_ops mtk_iommu_ops = { .flush_iotlb_all = mtk_iommu_flush_iotlb_all, .iotlb_sync = mtk_iommu_iotlb_sync, .iova_to_phys = mtk_iommu_iova_to_phys, - .add_device = mtk_iommu_add_device, - .remove_device = mtk_iommu_remove_device, + .probe_device = mtk_iommu_probe_device, + .release_device = mtk_iommu_release_device, .device_group = mtk_iommu_device_group, .of_xlate = mtk_iommu_of_xlate, .pgsize_bitmap = SZ_4K | SZ_64K | SZ_1M | SZ_16M,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 23/33 iommu/mediatek-v1 Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Mediatek-v1 IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/mtk_iommu_v1.c | 50 +++++++++++++++--------------------- 1 file changed, 20 insertions(+), 30 deletions(-)
drivers/iommu/mtk_iommu_v1.c +20 -30
@@ -416,14 +416,12 @@ static int mtk_iommu_create_mapping(struct device *dev,return 0 ; } -static int mtk_iommu_add_device (struct device *dev) +static struct iommu_device *mtk_iommu_probe_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev); -struct dma_iommu_mapping *mtk_mapping;struct of_phandle_args iommu_spec;struct of_phandle_iterator it;struct mtk_iommu_data *data; -struct iommu_group *group;int err; of_for_each_phandle(&it, err, dev->of_node, "iommus",
@@ -442,35 +440,28 @@ static int mtk_iommu_add_device(struct device *dev) }if (!fwspec || fwspec->ops != &mtk_iommu_ops) -return -ENODEV ;/* Not a iommu client device */ +return ERR_PTR (-ENODEV );/* Not a iommu client device */ -/* -* This is a short-term bodge because the ARM DMA code doesn't -* understand multi-device groups, but we have to call into it -* successfully (and not just rely on a normal IOMMU API attach -* here) in order to set the correct DMA API ops on @dev. -*/ - group =iommu_group_alloc (); -if (IS_ERR (group)) -return PTR_ERR (group); + data =dev_iommu_priv_get (dev); - err =iommu_group_add_device (group, dev); -iommu_group_put (group); -if (err) -return err; +return &data->iommu; +} - data =dev_iommu_priv_get (dev); +static void mtk_iommu_probe_finalize (struct device *dev) +{ +struct dma_iommu_mapping *mtk_mapping; +struct mtk_iommu_data *data; +int err; + + data =dev_iommu_priv_get (dev); mtk_mapping = data->dev->archdata.iommu; - err =arm_iommu_attach_device (dev, mtk_mapping); -if (err) { -iommu_group_remove_device (dev); -return err; - } -return iommu_device_link (&data->iommu, dev); + err =arm_iommu_attach_device (dev, mtk_mapping); +if (err) +dev_err (dev,"Can't create IOMMU mapping - DMA-OPS will not work\n" ); } -static void mtk_iommu_remove_device (struct device *dev) +static void mtk_iommu_release_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);struct mtk_iommu_data *data;
@@ -479,9 +470,6 @@ static void mtk_iommu_remove_device(struct device *dev)return ; data =dev_iommu_priv_get (dev); -iommu_device_unlink (&data->iommu, dev); - -iommu_group_remove_device (dev);iommu_fwspec_free (dev); }
@@ -534,8 +522,10 @@ static const struct iommu_ops mtk_iommu_ops = { .map = mtk_iommu_map, .unmap = mtk_iommu_unmap, .iova_to_phys = mtk_iommu_iova_to_phys, - .add_device = mtk_iommu_add_device, - .remove_device = mtk_iommu_remove_device, + .probe_device = mtk_iommu_probe_device, + .probe_finalize = mtk_iommu_probe_finalize, + .release_device = mtk_iommu_release_device, + .device_group = generic_device_group, .pgsize_bitmap = ~0UL << MT2701_IOMMU_PAGE_SHIFT, };
Signature · 1 line
2.17.1
Yong Wu
maintainerRe: [PATCH v2 23/33] iommu/mediatek-v1 Convert to probe/release_device() call-backs
Quoted 65 lines · Joerg Roedel
From: Joerg Roedel <[email protected]>
Convert the Mediatek-v1 IOMMU driver to use the
probe_device()andrelease_device()call-backs ofiommu_ops, so that the iommu core code does the group and sysfs setup.Signed-off-by Joerg Roedel <[email protected]>--- drivers/iommu/mtk_iommu_v1.c | 50 +++++++++++++++--------------------- 1 file changed, 20 insertions(+), 30 deletions(-)drivers/iommu/mtk_iommu_v1.c +12
-18@@ -416,14 +416,12 @@ static int mtk_iommu_create_mapping(struct device *dev,return 0 ; } -static int mtk_iommu_add_device (struct device *dev) +static struct iommu_device *mtk_iommu_probe_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev); -struct dma_iommu_mapping *mtk_mapping;struct of_phandle_args iommu_spec;struct of_phandle_iterator it;struct mtk_iommu_data *data; -struct iommu_group *group;int err; of_for_each_phandle(&it, err, dev->of_node, "iommus",@@ -442,35 +440,28 @@ static int mtk_iommu_add_device(struct device *dev) }if (!fwspec || fwspec->ops != &mtk_iommu_ops) -return -ENODEV ;/* Not a iommu client device */ +return ERR_PTR (-ENODEV );/* Not a iommu client device */ -/* -* This is a short-term bodge because the ARM DMA code doesn't -* understand multi-device groups, but we have to call into it -* successfully (and not just rely on a normal IOMMU API attach -* here) in order to set the correct DMA API ops on @dev. -*/ - group =iommu_group_alloc (); -if (IS_ERR (group)) -return PTR_ERR (group); + data =dev_iommu_priv_get (dev); - err =iommu_group_add_device (group, dev); -iommu_group_put (group); -if (err) -return err; +return &data->iommu; +} - data =dev_iommu_priv_get (dev); +static void mtk_iommu_probe_finalize (struct device *dev) +{ +struct dma_iommu_mapping *mtk_mapping; +struct mtk_iommu_data *data; +int err; + + data =dev_iommu_priv_get (dev); mtk_mapping = data->dev->archdata.iommu;
drivers/iommu/mtk_iommu_v1.c static int mtk_iommu_add_device(struct device *dev) · line 461
Quoted 10 lines
drivers/iommu/mtk_iommu_v1.c +3
-6- err =arm_iommu_attach_device (dev, mtk_mapping); -if (err) { -iommu_group_remove_device (dev); -return err; - } -return iommu_device_link (&data->iommu, dev); + err =arm_iommu_attach_device (dev, mtk_mapping); +if (err) +dev_err (dev,"Can't create IOMMU mapping - DMA-OPS will not work\n" );
Hi Joerg,
Thanks very much for this patch.
This arm_iommu_attach_device is called just as we expected.
But it will fail in this callstack as the group->mutex was tried to
be re-locked...
[<c0938e8c>] (iommu_attach_device) from [<c0317590>] (__arm_iommu_attach_device+0x34/0x90)
[<c0317590>] (__arm_iommu_attach_device) from [<c03175f8>] (arm_iommu_attach_device+0xc/0x20)
[<c03175f8>] (arm_iommu_attach_device) from [<c09432cc>] (mtk_iommu_probe_finalize+0x34/0x50)
[<c09432cc>] (mtk_iommu_probe_finalize) from [<c093a8ac>] (bus_iommu_probe+0x2a8/0x2c4)
[<c093a8ac>] (bus_iommu_probe) from [<c093a950>] (bus_set_iommu +0x88/0xd4)
[<c093a950>] (bus_set_iommu) from [<c0943c74>] (mtk_iommu_probe +0x2f8/0x364)
Quoted 30 lines
drivers/iommu/mtk_iommu_v1.c +5
-6} -static void mtk_iommu_remove_device (struct device *dev) +static void mtk_iommu_release_device (struct device *dev) {struct iommu_fwspec *fwspec =dev_iommu_fwspec_get (dev);struct mtk_iommu_data *data;@@ -479,9 +470,6 @@ static void mtk_iommu_remove_device(struct device *dev)return ; data =dev_iommu_priv_get (dev); -iommu_device_unlink (&data->iommu, dev); - -iommu_group_remove_device (dev);iommu_fwspec_free (dev); }@@ -534,8 +522,10 @@ static const struct iommu_ops mtk_iommu_ops = { .map = mtk_iommu_map, .unmap = mtk_iommu_unmap, .iova_to_phys = mtk_iommu_iova_to_phys, - .add_device = mtk_iommu_add_device, - .remove_device = mtk_iommu_remove_device, + .probe_device = mtk_iommu_probe_device, + .probe_finalize = mtk_iommu_probe_finalize, + .release_device = mtk_iommu_release_device, + .device_group = generic_device_group, .pgsize_bitmap = ~0UL << MT2701_IOMMU_PAGE_SHIFT, };
Joerg Roedel
maintainerRe: [PATCH v2 23/33] iommu/mediatek-v1 Convert to probe/release_device() call-backs
Hi,
Quoted 16 lines · Yong Wu
drivers/iommu/mtk_iommu_v1.c static int mtk_iommu_add_device(struct device *dev) · line 461
Quoted 4 lines · Joerg Roedel
drivers/iommu/mtk_iommu_v1.c +3
-1-return iommu_device_link (&data->iommu, dev); + err =arm_iommu_attach_device (dev, mtk_mapping); +if (err) +dev_err (dev,"Can't create IOMMU mapping - DMA-OPS will not work\n" );Hi Joerg,
Thanks very much for this patch.
This
arm_iommu_attach_deviceis called just as we expected.But it will fail in this callstack as the
group->mutexwas tried to
be re-locked...
Quoted 12 lines
[<
c0938e8c>] (iommu_attach_device) from [<c0317590>] (__arm_iommu_attach_device+0x34/0x90)
[<c0317590>] (__arm_iommu_attach_device) from [<c03175f8>] (arm_iommu_attach_device+0xc/0x20)
[<c03175f8>] (arm_iommu_attach_device) from [<c09432cc>] (mtk_iommu_probe_finalize+0x34/0x50)
[<c09432cc>] (mtk_iommu_probe_finalize) from [<c093a8ac>] (bus_iommu_probe+0x2a8/0x2c4)
[<c093a8ac>] (bus_iommu_probe) from [<c093a950>] (bus_set_iommu+0x88/0xd4)
[<c093a950>] (bus_set_iommu) from [<c0943c74>] (mtk_iommu_probe+0x2f8/0x364)
Thanks for the report, is
https://lore.kernel.org/lkml/[email protected]/
The fix for this issue or is something else required?
Thanks,
Joerg
Yong Wu
maintainerRe: [PATCH v2 23/33] iommu/mediatek-v1 Convert to probe/release_device() call-backs
Quoted 32 lines · Joerg Roedel
Hi,
Quoted 16 lines · Yong Wu
Review
Quoted 4 lines · Joerg Roedel
(quoted diff) +3
-1- return iommu_device_link(&data->iommu, dev); + err = arm_iommu_attach_device(dev, mtk_mapping); + if (err) + dev_err(dev, "Can't create IOMMU mapping - DMA-OPS will not work\n");Hi Joerg,
Thanks very much for this patch.
This
arm_iommu_attach_deviceis called just as we expected.But it will fail in this callstack as the
group->mutexwas tried to
be re-locked...Quoted 12 lines
[<
c0938e8c>] (iommu_attach_device) from [<c0317590>] (__arm_iommu_attach_device+0x34/0x90)
[<c0317590>] (__arm_iommu_attach_device) from [<c03175f8>] (arm_iommu_attach_device+0xc/0x20)
[<c03175f8>] (arm_iommu_attach_device) from [<c09432cc>] (mtk_iommu_probe_finalize+0x34/0x50)
[<c09432cc>] (mtk_iommu_probe_finalize) from [<c093a8ac>] (bus_iommu_probe+0x2a8/0x2c4)
[<c093a8ac>] (bus_iommu_probe) from [<c093a950>] (bus_set_iommu+0x88/0xd4)
[<c093a950>] (bus_set_iommu) from [<c0943c74>] (mtk_iommu_probe+0x2f8/0x364)
Quoted 5 lines
Thanks for the report, is
https://lore.kernel.org/lkml/[email protected]/The fix for this issue or is something else required?
No. That patch only adjust the internal flow to satisfy the latest framework, it's not for fixing this mutex issue.
Here I only reported this issue.
below is my local patch. split "dma_attach" to attach_device and probe_finalize. About attach_device, Use the existed __iommu_attach_group instead. Then rename from the "dma_attach" to "probe_finalize" to do the probe_finalize job. And move it outside of the mutex_unlock.
I'm not sure if it is right. and of course I will test if you have any other solution. Thanks.
drivers/iommu/iommu.c +0 -0
@@ -1665,26 +1665,20 @@ static void probe_alloc_default_domain(struct
bus_type *bus,
}
-static int iommu_group_do_dma_attach(struct device *dev, void *data) +static int iommu_group_do_probe_finalize(struct device *dev, void *data)
{
struct iommu_domain *domain = data;
- const struct iommu_ops *ops;
- int ret;
-
- ret = __iommu_attach_device(domain, dev);
-
- ops = domain->ops;
+ const struct iommu_ops *ops = domain->ops;
- if (ret == 0 && ops->probe_finalize)
+ if (ops->probe_finalize)
ops->probe_finalize(dev);
-
- return ret;
+ return 0;
}
-static int __iommu_group_dma_attach(struct iommu_group *group) +static int iommu_group_probe_finalize(struct iommu_group *group)
{
return __iommu_group_for_each_dev(group, group->default_domain,
- iommu_group_do_dma_attach);
+ iommu_group_do_probe_finalize);
}
static int iommu_do_create_direct_mappings(struct device *dev, void
*data)
@@ -1731,12 +1725,14 @@ int bus_iommu_probe(struct bus_type *bus)
iommu_group_create_direct_mappings(group);
- ret = __iommu_group_dma_attach(group);
+ ret = __iommu_attach_group(group->default_domain, group);
mutex_unlock(&group->mutex);
if (ret)
break;
+
+ iommu_group_probe_finalize(group);
}
return ret;
Quoted 10 lines
Thanks,
Joerg
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Joerg Roedel
maintainerRe: [PATCH v2 23/33] iommu/mediatek-v1 Convert to probe/release_device() call-backs
Hi,
Quoted 55 lines · Yong Wu
below is my local patch. split "
dma_attach" toattach_deviceandprobe_finalize. Aboutattach_device, Use the existed__iommu_attach_groupinstead. Then rename from the "dma_attach" to "probe_finalize" to do theprobe_finalizejob. And move it outside of themutex_unlock.I'm not sure if it is right. and of course I will test if you have any other solution. Thanks.
drivers/iommu/iommu.c +6
-12@@ -1665,26 +1665,20 @@ static void probe_alloc_default_domain(struct bus_type *bus, } -static int iommu_group_do_dma_attach (struct device *dev,void *data) +static int iommu_group_do_probe_finalize (struct device *dev,void *data) {struct iommu_domain *domain = data; -const struct iommu_ops *ops; -int ret; - - ret =__iommu_attach_device (domain, dev); - - ops = domain->ops; +const struct iommu_ops *ops = domain->ops; -if (ret ==0 && ops->probe_finalize) +if (ops->probe_finalize) ops->probe_finalize (dev); - -return ret; +return 0 ; } -static int __iommu_group_dma_attach (struct iommu_group *group) +static int iommu_group_probe_finalize (struct iommu_group *group) {return __iommu_group_for_each_dev (group, group->default_domain, - iommu_group_do_dma_attach); + iommu_group_do_probe_finalize); }static int iommu_do_create_direct_mappings(struct device *dev, void
*data)drivers/iommu/iommu.c +1
-1@@ -1731,12 +1725,14 @@ int bus_iommu_probe(struct bus_type *bus)iommu_group_create_direct_mappings (group); - ret =__iommu_group_dma_attach (group); + ret =__iommu_attach_group (group->default_domain, group);
drivers/iommu/iommu.c int bus_iommu_probe(struct bus_type *bus) · line 1738
Quoted 10 lines
drivers/iommu/iommu.c +2
-0mutex_unlock (&group->mutex);if (ret)break ; + +iommu_group_probe_finalize (group); }return ret;
Yes, I think moving the probe_finalize call out of the group->mutex section is the right fix for this issue.
Thanks for reporting it and working on a fix.
Regards,
Joerg
Joerg Roedel
maintainerPATCH v2 24/33 iommu/qcom: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the QCOM IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/qcom_iommu.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-)
drivers/iommu/qcom_iommu.c +7 -17
@@ -524,14 +524,13 @@ static bool qcom_iommu_capable(enum iommu_cap cap) } } -static int qcom_iommu_add_device (struct device *dev) +static struct iommu_device *qcom_iommu_probe_device (struct device *dev) {struct qcom_iommu_dev *qcom_iommu =to_iommu (dev); -struct iommu_group *group;struct device_link *link;if (!qcom_iommu) -return -ENODEV ; +return ERR_PTR (-ENODEV );/* * Establish the link between iommu and master, so that the
@@ -542,28 +541,19 @@ static int qcom_iommu_add_device(struct device *dev)if (!link) {dev_err (qcom_iommu->dev,"Unable to create device link between %s and %s\n" ,dev_name (qcom_iommu->dev),dev_name (dev)); -return -ENODEV ; +return ERR_PTR (-ENODEV ); } - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); -iommu_device_link (&qcom_iommu->iommu, dev); - -return 0 ; +return &qcom_iommu->iommu; } -static void qcom_iommu_remove_device (struct device *dev) +static void qcom_iommu_release_device (struct device *dev) {struct qcom_iommu_dev *qcom_iommu =to_iommu (dev);if (!qcom_iommu)return ; -iommu_device_unlink (&qcom_iommu->iommu, dev); -iommu_group_remove_device (dev);iommu_fwspec_free (dev); }
@@ -619,8 +609,8 @@ static const struct iommu_ops qcom_iommu_ops = { .flush_iotlb_all = qcom_iommu_flush_iotlb_all, .iotlb_sync = qcom_iommu_iotlb_sync, .iova_to_phys = qcom_iommu_iova_to_phys, - .add_device = qcom_iommu_add_device, - .remove_device = qcom_iommu_remove_device, + .probe_device = qcom_iommu_probe_device, + .release_device = qcom_iommu_release_device, .device_group = generic_device_group, .of_xlate = qcom_iommu_of_xlate, .pgsize_bitmap = SZ_4K | SZ_64K | SZ_1M | SZ_16M,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 25/33 iommu/rockchip: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Rockchip IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/rockchip-iommu.c | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-)
drivers/iommu/rockchip-iommu.c +7 -19
@@ -1054,40 +1054,28 @@ static void rk_iommu_domain_free(struct iommu_domain *domain)kfree (rk_domain); } -static int rk_iommu_add_device (struct device *dev) +static struct iommu_device *rk_iommu_probe_device (struct device *dev) { -struct iommu_group *group; -struct rk_iommu *iommu;struct rk_iommudata *data; +struct rk_iommu *iommu; data = dev->archdata.iommu;if (!data) -return -ENODEV ; +return ERR_PTR (-ENODEV ); iommu =rk_iommu_from_dev (dev); - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); -iommu_group_put (group); - -iommu_device_link (&iommu->iommu, dev); data->link =device_link_add (dev, iommu->dev,DL_FLAG_STATELESS |DL_FLAG_PM_RUNTIME ); -return 0 ; +return &iommu->iommu; } -static void rk_iommu_remove_device (struct device *dev) +static void rk_iommu_release_device (struct device *dev) { -struct rk_iommu *iommu;struct rk_iommudata *data = dev->archdata.iommu; - iommu =rk_iommu_from_dev (dev); -device_link_del (data->link); -iommu_device_unlink (&iommu->iommu, dev); -iommu_group_remove_device (dev); }static struct iommu_group *rk_iommu_device_group (struct device *dev)
@@ -1126,8 +1114,8 @@ static const struct iommu_ops rk_iommu_ops = { .detach_dev = rk_iommu_detach_device, .map = rk_iommu_map, .unmap = rk_iommu_unmap, - .add_device = rk_iommu_add_device, - .remove_device = rk_iommu_remove_device, + .probe_device = rk_iommu_probe_device, + .release_device = rk_iommu_release_device, .iova_to_phys = rk_iommu_iova_to_phys, .device_group = rk_iommu_device_group, .pgsize_bitmap = RK_IOMMU_PGSIZE_BITMAP,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 26/33 iommu/tegra: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Tegra IOMMU drivers to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/tegra-gart.c | 24 ++++++------------------ drivers/iommu/tegra-smmu.c | 31 ++++++++----------------------- 2 files changed, 14 insertions(+), 41 deletions(-)
drivers/iommu/tegra-gart.c +6 -18
@@ -243,28 +243,16 @@ static bool gart_iommu_capable(enum iommu_cap cap)return false; } -static int gart_iommu_add_device (struct device *dev) +static struct iommu_device *gart_iommu_probe_device (struct device *dev) { -struct iommu_group *group; -if (!dev_iommu_fwspec_get (dev)) -return -ENODEV ; - - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); +return ERR_PTR (-ENODEV ); -iommu_device_link (&gart_handle->iommu, dev); - -return 0 ; +return &gart_handle->iommu; } -static void gart_iommu_remove_device (struct device *dev) +static void gart_iommu_release_device (struct device *dev) { -iommu_group_remove_device (dev); -iommu_device_unlink (&gart_handle->iommu, dev); } static int gart_iommu_of_xlate(struct device *dev,
@@ -290,8 +278,8 @@ static const struct iommu_ops gart_iommu_ops = { .domain_free = gart_iommu_domain_free, .attach_dev = gart_iommu_attach_dev, .detach_dev = gart_iommu_detach_dev, - .add_device = gart_iommu_add_device, - .remove_device = gart_iommu_remove_device, + .probe_device = gart_iommu_probe_device, + .release_device = gart_iommu_release_device, .device_group = generic_device_group, .map = gart_iommu_map, .unmap = gart_iommu_unmap,
drivers/iommu/tegra-smmu.c +8 -23
@@ -757,11 +757,10 @@ static int tegra_smmu_configure(struct tegra_smmu *smmu, struct device *dev,return 0 ; } -static int tegra_smmu_add_device (struct device *dev) +static struct iommu_device *tegra_smmu_probe_device (struct device *dev) {struct device_node *np = dev->of_node;struct tegra_smmu *smmu =NULL ; -struct iommu_group *group;struct of_phandle_args args;unsigned int index =0 ;int err;
@@ -774,7 +773,7 @@ static int tegra_smmu_add_device(struct device *dev)of_node_put (args.np);if (err <0 ) -return err; +return ERR_PTR (err);/* * Only a single IOMMU master interface is currently
@@ -783,8 +782,6 @@ static int tegra_smmu_add_device(struct device *dev)*/ dev->archdata.iommu = smmu; -iommu_device_link (&smmu->iommu, dev); -break ; }
@@ -793,26 +790,14 @@ static int tegra_smmu_add_device(struct device *dev) }if (!smmu) -return -ENODEV ; - - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); - -iommu_group_put (group); +return ERR_PTR (-ENODEV ); -return 0 ; +return &smmu->iommu; } -static void tegra_smmu_remove_device (struct device *dev) +static void tegra_smmu_release_device (struct device *dev) { -struct tegra_smmu *smmu = dev->archdata.iommu; - -if (smmu) -iommu_device_unlink (&smmu->iommu, dev); - dev->archdata.iommu =NULL ; -iommu_group_remove_device (dev); } static const struct tegra_smmu_group_soc *
@@ -895,8 +880,8 @@ static const struct iommu_ops tegra_smmu_ops = { .domain_free = tegra_smmu_domain_free, .attach_dev = tegra_smmu_attach_dev, .detach_dev = tegra_smmu_detach_dev, - .add_device = tegra_smmu_add_device, - .remove_device = tegra_smmu_remove_device, + .probe_device = tegra_smmu_probe_device, + .release_device = tegra_smmu_release_device, .device_group = tegra_smmu_device_group, .map = tegra_smmu_map, .unmap = tegra_smmu_unmap,
@@ -1015,7 +1000,7 @@ struct tegra_smmu *tegra_smmu_probe(struct device *dev,* value. However the IOMMU registration process will attempt to add * all devices to the IOMMU when bus_set_iommu() is called. In order * not to rely on global variables to track the IOMMU instance, we -* set it here so that it can be looked up from the .add_device() +* set it here so that it can be looked up from the .probe_device() * callback via the IOMMU device's .drvdata field. */ mc->smmu = smmu;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 27/33 iommu/renesas: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Renesas IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/ipmmu-vmsa.c | 60 +++++++++++++------------------------- 1 file changed, 20 insertions(+), 40 deletions(-)
drivers/iommu/ipmmu-vmsa.c +20 -40
@@ -805,24 +805,8 @@ static int ipmmu_of_xlate(struct device *dev,static int ipmmu_init_arm_mapping (struct device *dev) {struct ipmmu_vmsa_device *mmu =to_ipmmu (dev); -struct iommu_group *group;int ret; -/* Create a device group and add the device to it. */ - group =iommu_group_alloc (); -if (IS_ERR (group)) { -dev_err (dev,"Failed to allocate IOMMU group\n" ); -return PTR_ERR (group); - } - - ret =iommu_group_add_device (group, dev); -iommu_group_put (group); - -if (ret <0 ) { -dev_err (dev,"Failed to add device to IPMMU group\n" ); -return ret; - } -/* * Create the ARM mapping, used by the ARM DMA mapping core to allocate * VAs. This will allocate a corresponding IOMMU domain.
@@ -856,48 +840,39 @@ static int ipmmu_init_arm_mapping(struct device *dev)return 0 ; error: -iommu_group_remove_device (dev);if (mmu->mapping)arm_iommu_release_mapping (mmu->mapping);return ret; } -static int ipmmu_add_device (struct device *dev) +static struct iommu_device *ipmmu_probe_device (struct device *dev) {struct ipmmu_vmsa_device *mmu =to_ipmmu (dev); -struct iommu_group *group; -int ret;/* * Only let through devices that have been verified in xlate() */ if (!mmu) -return -ENODEV ; +return ERR_PTR (-ENODEV ); -if (IS_ENABLED (CONFIG_ARM ) && !IS_ENABLED (CONFIG_IOMMU_DMA )) { - ret =ipmmu_init_arm_mapping (dev); -if (ret) -return ret; - }else { - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) -return PTR_ERR (group); +return &mmu->iommu; +} -iommu_group_put (group); - } +static void ipmmu_probe_finalize (struct device *dev) +{ +int ret =0 ; -iommu_device_link (&mmu->iommu, dev); -return 0 ; +if (IS_ENABLED (CONFIG_ARM ) && !IS_ENABLED (CONFIG_IOMMU_DMA )) + ret =ipmmu_init_arm_mapping (dev); + +if (ret) +dev_err (dev,"Can't create IOMMU mapping - DMA-OPS will not work\n" ); } -static void ipmmu_remove_device (struct device *dev) +static void ipmmu_release_device (struct device *dev) { -struct ipmmu_vmsa_device *mmu =to_ipmmu (dev); - -iommu_device_unlink (&mmu->iommu, dev);arm_iommu_detach_device (dev); -iommu_group_remove_device (dev); }static struct iommu_group *ipmmu_find_group (struct device *dev)
@@ -925,9 +900,14 @@ static const struct iommu_ops ipmmu_ops = { .flush_iotlb_all = ipmmu_flush_iotlb_all, .iotlb_sync = ipmmu_iotlb_sync, .iova_to_phys = ipmmu_iova_to_phys, - .add_device = ipmmu_add_device, - .remove_device = ipmmu_remove_device, + .probe_device = ipmmu_probe_device, + .release_device = ipmmu_release_device, + .probe_finalize = ipmmu_probe_finalize, +#if defined(CONFIG_ARM) && !defined(CONFIG_IOMMU_DMA) + .device_group = generic_device_group, +#else .device_group = ipmmu_find_group, +#endif .pgsize_bitmap = SZ_1G | SZ_2M | SZ_4K, .of_xlate = ipmmu_of_xlate, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 28/33 iommu/omap: Remove orphan_dev tracking
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Remove the tracking of device which could not be probed because their IOMMU is not probed yet. Replace it with a call to bus_iommu_probe() when a new IOMMU is probed.
--- drivers/iommu/omap-iommu.c | 54 +++----------------------------------- 1 file changed, 4 insertions(+), 50 deletions(-)
drivers/iommu/omap-iommu.c +4 -50
@@ -35,15 +35,6 @@static const struct iommu_ops omap_iommu_ops; -struct orphan_dev { -struct device *dev; -struct list_head node; -}; - -static LIST_HEAD (orphan_dev_list); - -static DEFINE_SPINLOCK (orphan_lock); -#define to_iommu (dev) ((struct omap_iommu *)dev_get_drvdata(dev))/* bitmap of the page sizes currently supported */
@@ -62,8 +53,6 @@ static DEFINE_SPINLOCK(orphan_lock);static struct platform_driver omap_iommu_driver;static struct kmem_cache *iopte_cachep; -static int _omap_iommu_add_device (struct device *dev); -/** * to_omap_domain - Get struct omap_iommu_domain from generic iommu_domain * @dom: generic iommu domain handle
@@ -1177,7 +1166,6 @@ static int omap_iommu_probe(struct platform_device *pdev)struct omap_iommu *obj;struct resource *res;struct device_node *of = pdev->dev.of_node; -struct orphan_dev *orphan_dev, *tmp;if (!of) {pr_err ("%s: only DT-based devices are supported\n" , __func__);
@@ -1260,13 +1248,8 @@ static int omap_iommu_probe(struct platform_device *pdev)dev_info (&pdev->dev,"%s registered\n" , obj->name); -list_for_each_entry_safe (orphan_dev, tmp, &orphan_dev_list, node) { - err =_omap_iommu_add_device (orphan_dev->dev); -if (!err) { -list_del (&orphan_dev->node); -kfree (orphan_dev); - } - } +/* Re-probe bus to probe device attached to this IOMMU */ +bus_iommu_probe (&platform_bus_type);return 0 ;
@@ -1657,7 +1640,7 @@ static phys_addr_t omap_iommu_iova_to_phys(struct iommu_domain *domain,return ret; } -static int _omap_iommu_add_device (struct device *dev) +static int omap_iommu_add_device (struct device *dev) {struct omap_iommu_arch_data *arch_data, *tmp;struct omap_iommu *oiommu;
@@ -1666,8 +1649,6 @@ static int _omap_iommu_add_device(struct device *dev)struct platform_device *pdev;int num_iommus, i;int ret; -struct orphan_dev *orphan_dev; -unsigned long flags;/* * Allocate the archdata iommu structure for DT-based devices.
@@ -1702,23 +1683,7 @@ static int _omap_iommu_add_device(struct device *dev)if (!pdev) {of_node_put (np);kfree (arch_data); -spin_lock_irqsave (&orphan_lock, flags); -list_for_each_entry (orphan_dev, &orphan_dev_list, - node) { -if (orphan_dev->dev == dev) -break ; - } -spin_unlock_irqrestore (&orphan_lock, flags); - -if (orphan_dev && orphan_dev->dev == dev) -return -EPROBE_DEFER ; - - orphan_dev =kzalloc (sizeof (*orphan_dev),GFP_KERNEL ); - orphan_dev->dev = dev; -spin_lock_irqsave (&orphan_lock, flags); -list_add (&orphan_dev->node, &orphan_dev_list); -spin_unlock_irqrestore (&orphan_lock, flags); -return -EPROBE_DEFER ; +return -ENODEV ; } oiommu =platform_get_drvdata (pdev);
@@ -1764,17 +1729,6 @@ static int _omap_iommu_add_device(struct device *dev)return 0 ; } -static int omap_iommu_add_device (struct device *dev) -{ -int ret; - - ret =_omap_iommu_add_device (dev); -if (ret == -EPROBE_DEFER ) -return 0 ; - -return ret; -} -static void omap_iommu_remove_device (struct device *dev) {struct omap_iommu_arch_data *arch_data = dev->archdata.iommu;
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 29/33 iommu/omap: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the OMAP IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/omap-iommu.c | 49 ++++++++++---------------------------- 1 file changed, 13 insertions(+), 36 deletions(-)
drivers/iommu/omap-iommu.c +13 -36
@@ -1640,15 +1640,13 @@ static phys_addr_t omap_iommu_iova_to_phys(struct iommu_domain *domain,return ret; } -static int omap_iommu_add_device (struct device *dev) +static struct iommu_device *omap_iommu_probe_device (struct device *dev) {struct omap_iommu_arch_data *arch_data, *tmp; +struct platform_device *pdev;struct omap_iommu *oiommu; -struct iommu_group *group;struct device_node *np; -struct platform_device *pdev;int num_iommus, i; -int ret;/* * Allocate the archdata iommu structure for DT-based devices.
@@ -1657,7 +1655,7 @@ static int omap_iommu_add_device(struct device *dev)* IOMMU users. */ if (!dev->of_node) -return 0 ; +return ERR_PTR (-ENODEV );/* * retrieve the count of IOMMU nodes using phandle size as element size
@@ -1670,27 +1668,27 @@ static int omap_iommu_add_device(struct device *dev) arch_data =kcalloc (num_iommus +1 ,sizeof (*arch_data),GFP_KERNEL );if (!arch_data) -return -ENOMEM ; +return ERR_PTR (-ENOMEM );for (i =0 , tmp = arch_data; i < num_iommus; i++, tmp++) { np =of_parse_phandle (dev->of_node,"iommus" , i);if (!np) {kfree (arch_data); -return -EINVAL ; +return ERR_PTR (-EINVAL ); } pdev =of_find_device_by_node (np);if (!pdev) {of_node_put (np);kfree (arch_data); -return -ENODEV ; +return ERR_PTR (-ENODEV ); } oiommu =platform_get_drvdata (pdev);if (!oiommu) {of_node_put (np);kfree (arch_data); -return -EINVAL ; +return ERR_PTR (-EINVAL ); } tmp->iommu_dev = oiommu;
@@ -1699,46 +1697,25 @@ static int omap_iommu_add_device(struct device *dev)of_node_put (np); } + dev->archdata.iommu = arch_data; +/* * use the first IOMMU alone for the sysfs device linking. * TODO: Evaluate if a single iommu_group needs to be * maintained for both IOMMUs */ oiommu = arch_data->iommu_dev; - ret =iommu_device_link (&oiommu->iommu, dev); -if (ret) { -kfree (arch_data); -return ret; - } - - dev->archdata.iommu = arch_data; - -/* -* IOMMU group initialization calls into omap_iommu_device_group, which -* needs a valid dev->archdata.iommu pointer -*/ - group =iommu_group_get_for_dev (dev); -if (IS_ERR (group)) { -iommu_device_unlink (&oiommu->iommu, dev); - dev->archdata.iommu =NULL ; -kfree (arch_data); -return PTR_ERR (group); - } -iommu_group_put (group); -return 0 ; +return &oiommu->iommu; } -static void omap_iommu_remove_device (struct device *dev) +static void omap_iommu_release_device (struct device *dev) {struct omap_iommu_arch_data *arch_data = dev->archdata.iommu;if (!dev->of_node || !arch_data)return ; -iommu_device_unlink (&arch_data->iommu_dev->iommu, dev); -iommu_group_remove_device (dev); - dev->archdata.iommu =NULL ;kfree (arch_data);
@@ -1763,8 +1740,8 @@ static const struct iommu_ops omap_iommu_ops = { .map = omap_iommu_map, .unmap = omap_iommu_unmap, .iova_to_phys = omap_iommu_iova_to_phys, - .add_device = omap_iommu_add_device, - .remove_device = omap_iommu_remove_device, + .probe_device = omap_iommu_probe_device, + .release_device = omap_iommu_release_device, .device_group = omap_iommu_device_group, .pgsize_bitmap = OMAP_IOMMU_PGSIZES, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 30/33 iommu/exynos: Use first SYSMMU in controllers list for IOMMU core
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
On Exynos platforms there can be more than one SYSMMU (IOMMU) for one DMA master device. Since the IOMMU core code expects only one hardware IOMMU, use the first SYSMMU in the list.
--- drivers/iommu/exynos-iommu.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/iommu/exynos-iommu.c +10 -0
@@ -1261,6 +1261,11 @@ static int exynos_iommu_add_device(struct device *dev) }iommu_group_put (group); +/* There is always at least one entry, see exynos_iommu_of_xlate() */ + data =list_first_entry (&owner->controllers, + struct sysmmu_drvdata, owner_node); +iommu_device_link (&data->iommu, dev); +return 0 ; }
@@ -1286,6 +1291,11 @@ static void exynos_iommu_remove_device(struct device *dev)list_for_each_entry (data, &owner->controllers, owner_node)device_link_del (data->link); + +/* There is always at least one entry, see exynos_iommu_of_xlate() */ + data =list_first_entry (&owner->controllers, + struct sysmmu_drvdata, owner_node); +iommu_device_unlink (&data->iommu, dev); } static int exynos_iommu_of_xlate(struct device *dev,
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 31/33 iommu/exynos: Convert to probe/release_device() call-backs
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
Convert the Exynos IOMMU driver to use the probe_device() and release_device() call-backs of iommu_ops, so that the iommu core code does the group and sysfs setup.
--- drivers/iommu/exynos-iommu.c | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-)
drivers/iommu/exynos-iommu.c +6 -20
@@ -1235,19 +1235,13 @@ static phys_addr_t exynos_iommu_iova_to_phys(struct iommu_domain *iommu_domain,return phys; } -static int exynos_iommu_add_device (struct device *dev) +static struct iommu_device *exynos_iommu_probe_device (struct device *dev) {struct exynos_iommu_owner *owner = dev->archdata.iommu;struct sysmmu_drvdata *data; -struct iommu_group *group;if (!has_sysmmu (dev)) -return -ENODEV ; - - group =iommu_group_get_for_dev (dev); - -if (IS_ERR (group)) -return PTR_ERR (group); +return ERR_PTR (-ENODEV );list_for_each_entry (data, &owner->controllers, owner_node) {/*
@@ -1259,17 +1253,15 @@ static int exynos_iommu_add_device(struct device *dev)DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME); } -iommu_group_put (group);/* There is always at least one entry, see exynos_iommu_of_xlate() */ data =list_first_entry (&owner->controllers, struct sysmmu_drvdata, owner_node); -iommu_device_link (&data->iommu, dev); -return 0 ; +return &data->iommu; } -static void exynos_iommu_remove_device (struct device *dev) +static void exynos_iommu_release_device (struct device *dev) {struct exynos_iommu_owner *owner = dev->archdata.iommu;struct sysmmu_drvdata *data;
@@ -1287,15 +1279,9 @@ static void exynos_iommu_remove_device(struct device *dev)iommu_group_put (group); } } -iommu_group_remove_device (dev);list_for_each_entry (data, &owner->controllers, owner_node)device_link_del (data->link); - -/* There is always at least one entry, see exynos_iommu_of_xlate() */ - data =list_first_entry (&owner->controllers, - struct sysmmu_drvdata, owner_node); -iommu_device_unlink (&data->iommu, dev); } static int exynos_iommu_of_xlate(struct device *dev,
@@ -1341,8 +1327,8 @@ static const struct iommu_ops exynos_iommu_ops = { .unmap = exynos_iommu_unmap, .iova_to_phys = exynos_iommu_iova_to_phys, .device_group = generic_device_group, - .add_device = exynos_iommu_add_device, - .remove_device = exynos_iommu_remove_device, + .probe_device = exynos_iommu_probe_device, + .release_device = exynos_iommu_release_device, .pgsize_bitmap = SECT_SIZE | LPAGE_SIZE | SPAGE_SIZE, .of_xlate = exynos_iommu_of_xlate, };
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 32/33 iommu: Remove add_device()/remove_device() code-paths
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
All drivers are converted to use the probe/release_device() call-backs, so the add_device/remove_device() pointers are unused and the code using them can be removed.
--- drivers/iommu/iommu.c | 149 ++++++++---------------------------------- include/linux/iommu.h | 4 -- 2 files changed, 29 insertions(+), 124 deletions(-)
drivers/iommu/iommu.c +29 -120
@@ -220,7 +220,7 @@ static int __iommu_probe_device(struct device *dev, struct list_head *group_listreturn ret; } -static int __iommu_probe_device_helper (struct device *dev) +int iommu_probe_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops;struct iommu_group *group;
@@ -264,70 +264,17 @@ static int __iommu_probe_device_helper(struct device *dev) } -int iommu_probe_device (struct device *dev) +void iommu_release_device (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops; -struct iommu_group *group; -int ret; - -WARN_ON (dev->iommu_group); - -if (!ops) -return -EINVAL ; - -if (!dev_iommu_get (dev)) -return -ENOMEM ; - -if (!try_module_get (ops->owner)) { - ret = -EINVAL ; - goto err_free_dev_param; - } - -if (ops->probe_device) -return __iommu_probe_device_helper (dev); - - ret = ops->add_device (dev); -if (ret) - goto err_module_put; - - group =iommu_group_get (dev); -iommu_create_device_direct_mappings (group, dev); -iommu_group_put (group); - -if (ops->probe_finalize) - ops->probe_finalize (dev); -return 0 ; - -err_module_put: -module_put (ops->owner); -err_free_dev_param: -dev_iommu_free (dev); -return ret; -} - -static void __iommu_release_device (struct device *dev) -{ -const struct iommu_ops *ops = dev->bus->iommu_ops; +if (!dev->iommu) +return ;iommu_device_unlink (dev->iommu->iommu_dev, dev); -iommu_group_remove_device (dev); ops->release_device (dev); -} - -void iommu_release_device (struct device *dev) -{ -const struct iommu_ops *ops = dev->bus->iommu_ops; - -if (!dev->iommu) -return ; - -if (ops->release_device) -__iommu_release_device (dev); -else if (dev->iommu_group) - ops->remove_device (dev);module_put (ops->owner);dev_iommu_free (dev);
@@ -1560,23 +1507,6 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)if (ret) goto out_put_group; -/* -* Try to allocate a default domain - needs support from the -* IOMMU driver. There are still some drivers which don't support -* default domains, so the return value is not yet checked. Only -* allocate the domain here when the driver still has the -* add_device/remove_device call-backs implemented. -*/ -if (!ops->probe_device) { -iommu_alloc_default_domain (dev); - -if (group->default_domain) - ret =__iommu_attach_device (group->default_domain, dev); - -if (ret) - goto out_put_group; - } -return group; out_put_group:
@@ -1591,21 +1521,6 @@ struct iommu_domain *iommu_group_default_domain(struct iommu_group *group)return group->default_domain; } -static int add_iommu_group (struct device *dev,void *data) -{ -int ret =iommu_probe_device (dev); - -/* -* We ignore -ENODEV errors for now, as they just mean that the -* device is not translated by an IOMMU. We still care about -* other errors and fail to initialize when they happen. -*/ -if (ret == -ENODEV ) - ret =0 ; - -return ret; -} -static int probe_iommu_group (struct device *dev,void *data) {const struct iommu_ops *ops = dev->bus->iommu_ops;
@@ -1789,47 +1704,41 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group)int bus_iommu_probe (struct bus_type *bus) { -const struct iommu_ops *ops = bus->iommu_ops; +struct iommu_group *group, *next; +LIST_HEAD (group_list);int ret; -if (ops->probe_device) { -struct iommu_group *group, *next; -LIST_HEAD (group_list); - -/* -* This code-path does not allocate the default domain when -* creating the iommu group, so do it after the groups are -* created. -*/ - ret =bus_for_each_dev (bus,NULL , &group_list, probe_iommu_group); -if (ret) -return ret; +/* +* This code-path does not allocate the default domain when +* creating the iommu group, so do it after the groups are +* created. +*/ + ret =bus_for_each_dev (bus,NULL , &group_list, probe_iommu_group); +if (ret) +return ret; -list_for_each_entry_safe (group, next, &group_list, entry) { -/* Remove item from the list */ -list_del_init (&group->entry); +list_for_each_entry_safe (group, next, &group_list, entry) { +/* Remove item from the list */ +list_del_init (&group->entry); -mutex_lock (&group->mutex); +mutex_lock (&group->mutex); -/* Try to allocate default domain */ -probe_alloc_default_domain (bus, group); +/* Try to allocate default domain */ +probe_alloc_default_domain (bus, group); -if (!group->default_domain) { -mutex_unlock (&group->mutex); -continue ; - } +if (!group->default_domain) { +mutex_unlock (&group->mutex); +continue ; + } -iommu_group_create_direct_mappings (group); +iommu_group_create_direct_mappings (group); - ret =__iommu_group_dma_attach (group); + ret =__iommu_group_dma_attach (group); -mutex_unlock (&group->mutex); +mutex_unlock (&group->mutex); -if (ret) -break ; - } - }else { - ret =bus_for_each_dev (bus,NULL ,NULL , add_iommu_group); +if (ret) +break ; }return ret;
include/linux/iommu.h +0 -4
@@ -223,8 +223,6 @@ struct iommu_iotlb_gather {* @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush * queue * @iova_to_phys: translate iova to physical address -* @add_device: add device to iommu grouping -* @remove_device: remove device from iommu grouping * @probe_device: Add device to iommu driver handling * @release_device: Remove device from iommu driver handling * @probe_finalize: Do final setup work after the device is added to an IOMMU
@@ -277,8 +275,6 @@ struct iommu_ops {void (*iotlb_sync)(struct iommu_domain *domain,struct iommu_iotlb_gather *iotlb_gather);phys_addr_t (*iova_to_phys)(struct iommu_domain *domain,dma_addr_t iova); -int (*add_device)(struct device *dev); -void (*remove_device)(struct device *dev);struct iommu_device *(*probe_device)(struct device *dev);void (*release_device)(struct device *dev);void (*probe_finalize)(struct device *dev);
Signature · 1 line
2.17.1
Joerg Roedel
maintainerPATCH v2 33/33 iommu: Unexport iommu_group_get_for_dev()
In reply to Joerg RoedelFrom: Joerg Roedel <[email protected]>
The function is now only used in IOMMU core code and shouldn't be used outside of it anyway, so remove the export for it.
--- drivers/iommu/iommu.c | 4 ++-- include/linux/iommu.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/iommu/iommu.c +2 -2
@@ -91,6 +91,7 @@ static void __iommu_detach_group(struct iommu_domain *domain, struct iommu_group *group);static int iommu_create_device_direct_mappings (struct iommu_group *group,struct device *dev); +static struct iommu_group *iommu_group_get_for_dev (struct device *dev);#define IOMMU_GROUP_ATTR (_name, _mode, _show, _store) \ struct iommu_group_attribute iommu_group_attr_##_name = \
@@ -1483,7 +1484,7 @@ static int iommu_alloc_default_domain(struct device *dev)* to the returned IOMMU group, which will already include the provided * device. The reference should be released with iommu_group_put(). */ -struct iommu_group *iommu_group_get_for_dev (struct device *dev) +static struct iommu_group *iommu_group_get_for_dev (struct device *dev) {const struct iommu_ops *ops = dev->bus->iommu_ops;struct iommu_group *group;
@@ -1514,7 +1515,6 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)return ERR_PTR (ret); } -EXPORT_SYMBOL (iommu_group_get_for_dev);struct iommu_domain *iommu_group_default_domain (struct iommu_group *group) {
include/linux/iommu.h +0 -1
@@ -527,7 +527,6 @@ extern int iommu_page_response(struct device *dev, struct iommu_page_response *msg);extern int iommu_group_id (struct iommu_group *group); -extern struct iommu_group *iommu_group_get_for_dev (struct device *dev);extern struct iommu_domain *iommu_group_default_domain (struct iommu_group *); extern int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr,
Signature · 1 line
2.17.1
Hi Joerg,
Quoted 5 lines · Joerg Roedel
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/
Quoted 8 lines
Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
Thanks for this rework. This version is much better. Works fine on various Exynos-based boards (ARM and ARM64).
core changes)
Quoted 65 lines
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------
Quoted 9 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Hi Joerg,
Quoted 6 lines
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/
Thanks for the continued improvements in this area!
I may have spotted a problem with setups like VMD.
The core PCI bus is set up during early boot.
Then, for the PCI bus, we reach iommu_bus_init() -> bus_iommu_probe(). In there, we call probe_iommu_group() -> dev_iommu_get() for each PCI device, which allocates dev->iommu in each case. So far so good.
The problem is that this is the last time that we'll call dev_iommu_get(). If any PCI bus devices get added after this point, they do not get passed to dev_iommu_get().
So when the vmd module gets loaded later, and creates more PCI devices, we end up in iommu_bus_notifier() -> iommu_probe_device()
-> __iommu_probe_device() which does:
dev->iommu->iommu_dev = iommu_dev;
dev->iommu-> is a NULL dereference because dev_iommu_get() was never called for this new device.
Daniel
Hi Daniel,
Quoted 26 lines · Daniel Drake
Hi Joerg,
Quoted 6 lines
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/[email protected]/Thanks for the continued improvements in this area!
I may have spotted a problem with setups like VMD.
The core PCI bus is set up during early boot.
Then, for the PCI bus, we reachiommu_bus_init()->bus_iommu_probe(). In there, we callprobe_iommu_group()->dev_iommu_get()for each PCI device, which allocatesdev->iommuin each case. So far so good.The problem is that this is the last time that we'll call
dev_iommu_get(). If any PCI bus devices get added after this point, they do not get passed todev_iommu_get().So when the vmd module gets loaded later, and creates more PCI devices, we end up in
iommu_bus_notifier()->iommu_probe_device()
->__iommu_probe_device()which does:
Quoted 7 lines
dev->iommu->iommu_dev = iommu_dev;dev->iommu-> is a NULL dereference because
dev_iommu_get()was never called for this new device.Daniel
I should have CCed you on this, but it should temporarily resolve that issue:
https://lists.linuxfoundation.org/pipermail/iommu/2020-April/043253.html
[email protected]
maintainerHi Jonathan, Hi Daniel,
Quoted 3 lines · Jonathan
Hi Daniel> I should have CCed you on this, but it should temporarily resolve that issue:
https://lists.linuxfoundation.org/pipermail/iommu/2020-April/043253.html
Yes, this is an issue in the hotplug handling path which I already fixed in my branch. With next post of this series it should work.
Regards,
Joerg
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------
Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Joerg,
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/[email protected]/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during intel_iommu_attach_device, in is_aux_domain, due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until the domain_add_dev_info call.
Is it as simple as the following?
drivers/iommu/intel-iommu.c +2 -2
@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Regards,
Jerry
Quoted 134 lines · Jerry Snitselaar
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 3 lines
Regards,
Jerry
With the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Regards,
Jerry
Hi Jerry,
Quoted 138 lines · Jerry Snitselaar
Quoted 137 lines · Jerry Snitselaar
Quoted 103 lines · Jerry Snitselaar
Quoted 84 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/[email protected]/
Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out ofiommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++----
drivers/iommu/amd_iommu_types.h| 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +-drivers/iommu/fsl_pamu_domain.c| 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------ drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +--Quoted 15 lines
drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 10 lines
Quoted 3 lines
Regards,
JerryWith the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Thanks and looking forward to further debugging information.
Best regards,
baolu
Hi Jerry,
Quoted 138 lines · Jerry Snitselaar
Quoted 137 lines · Jerry Snitselaar
Quoted 103 lines · Jerry Snitselaar
Quoted 84 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/[email protected]/
Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out ofiommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++----
drivers/iommu/amd_iommu_types.h| 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +-drivers/iommu/fsl_pamu_domain.c| 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------ drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +--Quoted 15 lines
drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 10 lines
Quoted 3 lines
Regards,
JerryWith the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Thanks and looking forward to further debugging information.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Jerry,
Quoted 138 lines · Jerry Snitselaar
Quoted 137 lines · Jerry Snitselaar
Quoted 103 lines · Jerry Snitselaar
Quoted 84 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/[email protected]/
Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out ofiommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++----
drivers/iommu/amd_iommu_types.h| 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +-drivers/iommu/fsl_pamu_domain.c| 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------ drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +--Quoted 15 lines
drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 10 lines
Quoted 3 lines
Regards,
JerryWith the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Thanks and looking forward to further debugging information.
Best regards,
baolu
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Jerry,
Quoted 138 lines · Jerry Snitselaar
Quoted 137 lines · Jerry Snitselaar
Quoted 103 lines · Jerry Snitselaar
Quoted 84 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/
Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out ofiommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++----
drivers/iommu/amd_iommu_types.h| 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +-drivers/iommu/fsl_pamu_domain.c| 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------ drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +--Quoted 15 lines
drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 10 lines
Quoted 3 lines
Regards,
JerryWith the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Thanks and looking forward to further debugging information.
Best regards,
baolu
Quoted 134 lines · Jerry Snitselaar
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 3 lines
Regards,
Jerry
With the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Regards,
Jerry
Quoted 134 lines · Jerry Snitselaar
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 3 lines
Regards,
Jerry
With the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Regards,
Jerry
Quoted 134 lines · Jerry Snitselaar
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Quoted 3 lines
Regards,
Jerry
With the patch, I avoid the panic, but I'm seeing an issue similar to the epyc system. I'm getting dmar faults from a couple of nics and the hp ilo. The addresses in question were in e820 reserved sections, but there aren't rmrr covering those addresses. The system manages to harvest the vmcore and reboot like the epyc. Without the patches I don't see the dmar faults. I needed to give this system back, but I'll try to poke at it some more in the next couple of days.
Regards,
Jerry
Hi Jerry,
Quoted 12 lines · Jerry Snitselaar
Quoted 11 lines
Hi Joerg,
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
Quoted 6 lines
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.Is it as simple as the following?
I guess you won't hit this issue if you use iommu/next branch of Joerg's tree. We've changed to use a generic helper to retrieve the valid per device iommu data or NULL (if there's no).
Best regards,
baolu
Quoted 22 lines
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; }static void auxiliary_link_device(struct
dmar_domain*domain,Regards,
Jerry
Quoted 20 lines · Lu Baolu
Hi Jerry,
Quoted 17 lines · Jerry Snitselaar
Quoted 11 lines
Hi Joerg,
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
JerryI just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during
intel_iommu_attach_device, inis_aux_domain, due todevice_domain_infobeingDEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until thedomain_add_dev_infocall.
Quoted 9 lines
Quoted 1 line
Is it as simple as the following?
I guess you won't hit this issue if you use iommu/next branch of Joerg's tree. We've changed to use a generic helper to retrieve the valid per device iommu data or NULL (if there's no).
Best regards,
baolu
Yeah, that will solve the panic.
Quoted 26 lines
Quoted 17 lines
drivers/iommu/intel-iommu.c +2
-2@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) { struct device_domain_info *info = dev->archdata.iommu; - return info && info->auxd_enabled && - domain->type == IOMMU_DOMAIN_UNMANAGED; + return info && info != DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; }Quoted 5 lines
static void auxiliary_link_device(struct
dmar_domain*domain,Regards,
Jerry_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
maintainerHi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Joerg
drivers/iommu/iommu.c +5 -1
@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)
Quoted 7 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
Quoted 7 lines
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched group->domain to domain since group isn't an argument, and *data being passed in comes from group->domain anyways.
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 13 lines · Jerry Snitselaar
Quoted 12 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Quoted 8 lines
Quoted 2 lines
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched
group->domainto domain since group isn't an argument, and *data being passed in comes fromgroup->domainanyways.
Looks like it solves problem for both the epyc system, and the hp proliant server,
Quoted 23 lines
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 13 lines · Jerry Snitselaar
Quoted 12 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Quoted 8 lines
Quoted 2 lines
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched
group->domainto domain since group isn't an argument, and *data being passed in comes fromgroup->domainanyways.
Looks like it solves problem for both the epyc system, and the hp proliant server,
Quoted 23 lines
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 13 lines · Jerry Snitselaar
Quoted 12 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Quoted 8 lines
Quoted 2 lines
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched
group->domainto domain since group isn't an argument, and *data being passed in comes fromgroup->domainanyways.
Looks like it solves problem for both the epyc system, and the hp proliant server,
Quoted 23 lines
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 13 lines · Jerry Snitselaar
Quoted 12 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Quoted 8 lines
Quoted 2 lines
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched
group->domainto domain since group isn't an argument, and *data being passed in comes fromgroup->domainanyways.
Looks like it solves problem for both the epyc system, and the hp proliant server,
Quoted 23 lines
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 13 lines · Jerry Snitselaar
Quoted 12 lines · Joerg Roedel
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Quoted 8 lines
Quoted 2 lines
Joerg
I have another hp proliant server now, and reproduced. I will have the patch below tested shortly. Minor change, I switched
group->domainto domain since group isn't an argument, and *data being passed in comes fromgroup->domainanyways.
Looks like it solves problem for both the epyc system, and the hp proliant server,
Quoted 23 lines
Quoted 23 lines
drivers/iommu/iommu.c +5
-1@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)_______________________________________________
iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Joerg
drivers/iommu/iommu.c +5 -1
@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Joerg
drivers/iommu/iommu.c +5 -1
@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)
Hi Jerry,
Quoted 3 lines · Jerry Snitselaar
Yeah, that will solve the panic.
If you still see the kdump faults, can you please try with the attached diff? I was not able to reproduce them in my setup.
Regards,
Joerg
drivers/iommu/iommu.c +5 -1
@@ -1680,8 +1680,12 @@ static void probe_alloc_default_domain(struct bus_type *bus,static int iommu_group_do_dma_attach (struct device *dev,void *data) {struct iommu_domain *domain = data; +int ret =0 ; -return __iommu_attach_device (domain, dev); +if (!iommu_is_attach_deferred (group->domain, dev)) + ret =__iommu_attach_device (group->domain, dev); + +return ret; }static int __iommu_group_dma_attach (struct iommu_group *group)
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during intel_iommu_attach_device, in is_aux_domain, due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until the domain_add_dev_info call.
Is it as simple as the following?
drivers/iommu/intel-iommu.c +2 -2
@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Regards,
Jerry
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during intel_iommu_attach_device, in is_aux_domain, due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until the domain_add_dev_info call.
Is it as simple as the following?
drivers/iommu/intel-iommu.c +2 -2
@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Regards,
Jerry
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during intel_iommu_attach_device, in is_aux_domain, due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until the domain_add_dev_info call.
Is it as simple as the following?
drivers/iommu/intel-iommu.c +2 -2
@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Regards,
Jerry
Quoted 102 lines · Jerry Snitselaar
Quoted 81 lines · Joerg Roedel
Hi,
here is the second version of this patch-set. The first version with some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org/Changes
v1->v2:* Rebased to v5.7-rc1
* Re-wrote the arm-smmu changes as suggested by Robin Murphy
* Re-worked the Exynos patches to hopefully not break the driver anymore
* Fixed a missing
mutex_unlock()reported by Marek Szyprowski, thanks for that.There is also a git-branch available with these patches applied:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=iommu-probe-device-v2
Please review.
Thanks,
Joerg
Joerg Roedel (32):
iommu: Move default domain allocation to separate function iommu/amd: Implementiommu_ops->def_domain_typecall-back iommu/vt-d: Wire upiommu_ops->def_domain_type
iommu/amd: Removedma_maskcheck fromcheck_device()iommu/amd: Return-ENODEVinadd_devicewhen device is not handled by
IOMMU
iommu: Addprobe_device()andremove_device()call-backs
iommu: Move default domain allocation toiommu_probe_device()
iommu: Keep a list of allocated groups in__iommu_probe_device()
iommu: Move newprobe_devicepath to separate function
iommu: Split off default domain allocation from group assignment
iommu: Moveiommu_group_create_direct_mappings()out of
iommu_group_add_device()
iommu: Exportbus_iommu_probe()and make is safe for re-probing iommu/amd: Removedev_data->passthrough
iommu/amd: Convert to probe/release_device() call-backs iommu/vt-d: Convert to probe/release_device() call-backs iommu/arm-smmu: Convert to probe/release_device() call-backs iommu/pamu: Convert to probe/release_device() call-backs iommu/s390: Convert to probe/release_device() call-backs iommu/virtio: Convert to probe/release_device() call-backs iommu/msm: Convert to probe/release_device() call-backs iommu/mediatek: Convert to probe/release_device() call-backs iommu/mediatek-v1 Convert to probe/release_device() call-backs iommu/qcom: Convert to probe/release_device() call-backs iommu/rockchip: Convert to probe/release_device() call-backs iommu/tegra: Convert to probe/release_device() call-backs iommu/renesas: Convert to probe/release_device() call-backs iommu/omap: Removeorphan_devtracking
iommu/omap: Convert to probe/release_device() call-backs iommu/exynos: Use first SYSMMU in controllers list for IOMMU core iommu/exynos: Convert to probe/release_device() call-backs
iommu: Remove add_device()/remove_device() code-paths
iommu: Unexportiommu_group_get_for_dev()Sai Praneeth Prakhya (1):
iommu: Adddef_domain_type()callback iniommu_opsdrivers/iommu/amd_iommu.c | 97 ++++---- drivers/iommu/amd_iommu_types.h | 1 - drivers/iommu/arm-smmu-v3.c | 38 +-- drivers/iommu/arm-smmu.c | 39 ++-- drivers/iommu/exynos-iommu.c | 24 +- drivers/iommu/fsl_pamu_domain.c | 22 +- drivers/iommu/intel-iommu.c | 68 +----- drivers/iommu/iommu.c | 393 +++++++++++++++++++++++++------- drivers/iommu/ipmmu-vmsa.c | 60 ++--- drivers/iommu/msm_iommu.c | 34 +-- drivers/iommu/mtk_iommu.c | 24 +- drivers/iommu/mtk_iommu_v1.c | 50 ++-- drivers/iommu/omap-iommu.c | 99 ++------Quoted 17 lines
drivers/iommu/qcom_iommu.c | 24 +- drivers/iommu/rockchip-iommu.c | 26 +-- drivers/iommu/s390-iommu.c | 22 +- drivers/iommu/tegra-gart.c | 24 +- drivers/iommu/tegra-smmu.c | 31 +-- drivers/iommu/virtio-iommu.c | 41 +--- include/linux/iommu.h | 21 +- 20 files changed, 533 insertions(+), 605 deletions(-)Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommuHi Joerg,
Quoted 8 lines
With this patchset, I have an epyc system where if I boot with iommu=nopt and force a dump I will see some io page faults for a nic on the system. The vmcore is harvested and the system reboots. I haven't reproduced it on other systems yet, but without the patchset I don't see the io page faults during the kdump.
Regards,
Jerry
I just hit an issue on a separate intel based system (kdump iommu=nopt), where it panics in during intel_iommu_attach_device, in is_aux_domain, due to device_domain_info being DEFER_DEVICE_DOMAIN_INFO. That doesn't get set to a valid address until the domain_add_dev_info call.
Is it as simple as the following?
drivers/iommu/intel-iommu.c +2 -2
@@ -5053,8 +5053,8 @@ is_aux_domain(struct device *dev, struct iommu_domain *domain) {struct device_domain_info *info = dev->archdata.iommu; -return info && info->auxd_enabled && - domain->type ==IOMMU_DOMAIN_UNMANAGED ; +return info && info !=DEFER_DEVICE_DOMAIN_INFO && + info->auxd_enabled && domain->type ==IOMMU_DOMAIN_UNMANAGED ; } static void auxiliary_link_device(struct dmar_domain *domain,
Regards,
Jerry