arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
PATCH v2 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Commit e71b6f6622d6 ("i2c: designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation. New timing calculation is based on calculation from Designware i2c databook.
After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in socfpga_cyclone5_socdk.dts.
This patch overwrite i2c-scl-falling-time-ns to 300ns (default SCL fall time used in Designware i2c driver) for Uboot.
Before the fix:
=> i2c dev 0
Setting bus to 0
Failure changing bus number (-22)
After the fix:
=> i2c dev 0
Setting bus to 0
=> i2c probe
Valid chip addresses: 17 51 55 5B 5C 5E 66 68 70
---
v2:
- Mentioned new timing calculation is from databook in commit message.
--- arch/arm/dts/socfpga_cyclone5_socdk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/dts/socfpga_cyclone5_socdk-u-boot.dtsi +4 -0
@@ -68,3 +68,7 @@ &portc { bank-name = "portc"; }; + +&i2c0 { + i2c-scl-falling-time-ns = <300>; +};
Signature · 1 line
2.19.0
Marek Vasut
AppliedPATCH v2 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Quoted 9 lines · Ley Foon Tan
Commit
e71b6f6622d6("i2c:designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation. New timing calculation is based on calculation from Designware i2c databook.After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in
socfpga_cyclone5_socdk.dts.This patch overwrite i2c-scl-falling-time-ns to 300ns (default SCL fall time used in Designware i2c driver) for Uboot.
Applied, thanks.