arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
PATCH 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Commit e71b6f6622d6 ("i2c: designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation.
After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in socfpga_cyclone5_socdk.dts.
This patch overwrite i2c-scl-falling-time-ns to 300ns (default SCL fall time used in Designware i2c driver) for Uboot.
Before the fix:
=> i2c dev 0
Setting bus to 0
Failure changing bus number (-22)
After the fix:
=> i2c dev 0
Setting bus to 0
=> i2c probe
Valid chip addresses: 17 51 55 5B 5C 5E 66 68 70
--- arch/arm/dts/socfpga_cyclone5_socdk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/dts/socfpga_cyclone5_socdk-u-boot.dtsi +4 -0
@@ -68,3 +68,7 @@ &portc { bank-name = "portc"; }; + +&i2c0 { + i2c-scl-falling-time-ns = <300>; +};
Signature · 1 line
2.19.0
PATCH 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Quoted 5 lines · Ley Foon Tan
Commit
e71b6f6622d6("i2c:designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation.After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in
socfpga_cyclone5_socdk.dts.
Shouldn't either the driver or the calculation be fixed instead ?
Tan
PATCH 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Quoted 13 lines
-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Friday, June 5, 2020 8:52 PM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>; Ang, Chee Hong <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: cyclone5: Update i2c-scl-falling- time-ns
Quoted 7 lines
Quoted 5 lines · Ley Foon Tan
Commit
e71b6f6622d6("i2c:designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation.After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in
socfpga_cyclone5_socdk.dts.Shouldn't either the driver or the calculation be fixed instead ?
The original timing calculation in driver doesn't take fall time or rise time into calculation.
The new i2c timing calculation is based on calculation from Designware i2c databook. So, I don't think need fix in driver.
Regards
Ley Foon
PATCH 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
On 6/9/20 8:33 AM, Tan, Ley Foon wrote:
[...]
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Commit
e71b6f6622d6("i2c:designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation.After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in
socfpga_cyclone5_socdk.dts.Shouldn't either the driver or the calculation be fixed instead ?
The original timing calculation in driver doesn't take fall time or rise time into calculation.
The new i2c timing calculation is based on calculation from Designware i2c databook. So, I don't think need fix in driver.
Then just mention it in the commit message that it's from the databook please.
Tan
PATCH 1/1 arm: dts: socfpga: cyclone5: Update i2c-scl-falling-time-ns
Quoted 20 lines
-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Tuesday, June 9, 2020 5:53 PM
To: Tan, Ley Foon <[email protected]>; u-boot at lists.denx.de
Cc: Ley Foon Tan <[email protected]>; See, Chin Liang <[email protected]>; Simon Goldschmidt <[email protected]>; Ang, Chee Hong <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: cyclone5: Update i2c-scl-falling- time-nsOn 6/9/20 8:33 AM, Tan, Ley Foon wrote:
[...]Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Commit
e71b6f6622d6("i2c:designware_i2c: Rewrite timing calculation") change the hcnt and lcnt timing calculation.After this new timing calculation, hcnt will have negative value with i2c-scl-falling-time-ns 5000 that set in
socfpga_cyclone5_socdk.dts.
Quoted 8 lines
Quoted 2 lines
Quoted 1 line
Shouldn't either the driver or the calculation be fixed instead ?
The original timing calculation in driver doesn't take fall time or rise time
into calculation.
Quoted 1 line
The new i2c timing calculation is based on calculation from Designware i2c
databook. So, I don't think need fix in driver.
Then just mention it in the commit message that it's from the databook please.
Okay.
Regards
Ley Foon