kthread: remove incorrect comment in kthread_create_on_cpu()
PATCH 1/1 kthread: remove incorrect comment in kthread_create_on_cpu()
Originally kthread_create_on_cpu() parked and woke up the new thread. However, since commit a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.
--- kernel/kthread.c | 1 - 1 file changed, 1 deletion(-)
kernel/kthread.c +0 -1
@@ -455,7 +455,6 @@ EXPORT_SYMBOL(kthread_bind);* to "name.*%u". Code fills in cpu number. * * Description: This helper function creates and names a kernel thread -* The thread will be woken and put into park mode. */ struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data), void *data, unsigned int cpu,
Signature · 1 line
2.27.0
Quoted 6 lines · Ilias Stamatis
Originally
kthread_create_on_cpu()parked and woke up the new thread. However, since commita65d40961dc7("kthread/smpboot: do not park inkthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.Signed-off-by Ilias Stamatis <[email protected]>
Good catch!
Best Regards,
Petr
Quoted 9 lines · Petr Mladek
Quoted 6 lines · Ilias Stamatis
Originally
kthread_create_on_cpu()parked and woke up the new thread. However, since commita65d40961dc7("kthread/smpboot: do not park inkthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.Signed-off-by Ilias Stamatis <[email protected]>
Quoted 7 lines
Good catch!
Fixes a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()")Reviewed-by Petr Mladek <[email protected]>Best Regards,
Petr
Hi,
Thanks for the review!
Will somebody pick this up from the list for merging or should I forward it somewhere else?
I'm new so I'm not sure exactly how the process works.
Best,
Ilias