Skip to contentSkip to conversation

kthread: remove incorrect comment in kthread_create_on_cpu()

PATCH Applied Ilias Stamatis 2 participants 3 messages Jun 11, 2020 – Jul 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kthread: remove incorrect comment in kthread_create_on_cpu()

Originally kthread_create_on_cpu() parked and woke up the new thread. However, since commit a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.

---
 kernel/kthread.c | 1 -
 1 file changed, 1 deletion(-)
kernel/kthread.c +0 -1
index bfbfa481be3a..38fa07ae59f6 100644
@@ -455,7 +455,6 @@ EXPORT_SYMBOL(kthread_bind);
  *	     to "name.*%u". Code fills in cpu number.
  *
  * Description: This helper function creates and names a kernel thread
- * The thread will be woken and put into park mode.
  */
 struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data),
 					  void *data, unsigned int cpu,
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ilias Stamatis

Originally kthread_create_on_cpu() parked and woke up the new thread. However, since commit a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.

Good catch!

Fixes a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()")

Best Regards,
Petr

#2 lore raw
Quoted 9 lines · Petr Mladek
Quoted 6 lines · Ilias Stamatis

Originally kthread_create_on_cpu() parked and woke up the new thread. However, since commit a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()") this is no longer the case. This patch removes the comment that has been left behind and is now incorrect / stale.

Quoted 7 lines

Good catch!

Fixes a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()")

Best Regards,
Petr

Hi,

Thanks for the review!

Will somebody pick this up from the list for merging or should I forward it somewhere else?

I'm new so I'm not sure exactly how the process works.

Best,
Ilias