Skip to contentSkip to conversation

tpm: Enable usage of TPM TIS with interrupts

PATCH Superseded Stefan Berger 5 participants 22 messages Jun 15, 2020 – Jun 16, 2020

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover tpm: Enable usage of TPM TIS with interrupts

This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is also accepted by Windows.

Stefan

v1->v2:
- Added updated DSDT

Stefan Berger (5):
tpm_tis: Allow lowering of IRQ also when locality is not active
tpm: Extend TPMIfClass with get_irqnum() function
tests: Temporarily ignore DSDT table differences
acpi: Enable TPM IRQ
tests: Add updated DSDT

 hw/i386/acpi-build.c         |  11 +++++------
 hw/tpm/tpm_tis_common.c      |   4 ----
 hw/tpm/tpm_tis_isa.c         |   9 +++++++++
 hw/tpm/tpm_tis_sysbus.c      |   9 +++++++++
 include/hw/acpi/tpm.h        |   2 +-
 include/sysemu/tpm.h         |  10 ++++++++++
 tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes
 7 files changed, 34 insertions(+), 11 deletions(-)
Signature · 1 line
2.24.1
#1 lore raw

PATCH v2 1/5 tpm_tis: Allow lowering of IRQ also when locality is not active

From: Stefan Berger <[email protected]>

This patch fixes a bug that occurs when using interrupts. It allows to lower the IRQ also when a locality is not active.

---
 hw/tpm/tpm_tis_common.c | 4 ----
 1 file changed, 4 deletions(-)
hw/tpm/tpm_tis_common.c +0 -4
index 1af4bce139..0f42696f1f 100644
@@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
         /* hard wired -- ignore */
         break;
     case TPM_TIS_REG_INT_STATUS:
-        if (s->active_locty != locty) {
-            break;
-        }
-
         /* clearing of interrupt flags */
         if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
             (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
Signature · 1 line
2.24.1
#2 lore raw

Re: [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active

Hi

Quoted 6 lines · Stefan Berger

From: Stefan Berger <[email protected]>

This patch fixes a bug that occurs when using interrupts. It allows to lower the IRQ also when a locality is not active.

Can you quote the specification, or is it purely based on testing (Windows & Linux) or checking expected behaviour from Linux code?

Quoted 23 lines
---
 hw/tpm/tpm_tis_common.c | 4 ----
 1 file changed, 4 deletions(-)
hw/tpm/tpm_tis_common.c +0 -5
index 1af4bce139..0f42696f1f 100644
@@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
         /* hard wired -- ignore */
         break;
     case TPM_TIS_REG_INT_STATUS:
-        if (s->active_locty != locty) {
-            break;
-        }
-
         /* clearing of interrupt flags */
         if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
             (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
--

2.24.1

#3 lore raw

Re: [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active

Quoted 11 lines · Marc-André Lureau

Hi

Quoted 5 lines · Stefan Berger

From: Stefan Berger <[email protected]>

This patch fixes a bug that occurs when using interrupts. It allows to lower the IRQ also when a locality is not active.

Can you quote the specification, or is it purely based on testing (Windows & Linux) or checking expected behaviour from Linux code?

There's no spec for this detail. It's purely based on testing.

also: Linux 5.x had interrupt support for a short while but this was removed due to some laptops receiving an interrupt storm following enablement: https://www.spinics.net/lists/linux-integrity/msg11870.html  [ reason seems to be misconfiguration of some GPIO pin]

I tested it with this patch: https://lkml.org/lkml/2019/8/20/421

5.4 kernel: https://elixir.bootlin.com/linux/v5.4/source/drivers/char/tpm/tpm_tis_core.c#L983

   Stefan

Quoted 24 lines
Quoted 24 lines
---
  hw/tpm/tpm_tis_common.c | 4 ----
  1 file changed, 4 deletions(-)
hw/tpm/tpm_tis_common.c +0 -5
index 1af4bce139..0f42696f1f 100644
@@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
          /* hard wired -- ignore */
          break;
      case TPM_TIS_REG_INT_STATUS:
-        if (s->active_locty != locty) {
-            break;
-        }
-
          /* clearing of interrupt flags */
          if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
              (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
--

2.24.1

Reviewed-by on v2 1/5
#4 lore raw

Re: [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active

In reply to Stefan Berger

Hi Stefan,

Quoted 6 lines · Stefan Berger

From: Stefan Berger <[email protected]>

This patch fixes a bug that occurs when using interrupts. It allows to lower the IRQ also when a locality is not active.

Thanks

Eric

Quoted 21 lines

---

 hw/tpm/tpm_tis_common.c | 4 ----
 1 file changed, 4 deletions(-)
hw/tpm/tpm_tis_common.c +0 -4
index 1af4bce139..0f42696f1f 100644
@@ -601,10 +601,6 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
         /* hard wired -- ignore */
         break;
     case TPM_TIS_REG_INT_STATUS:
-        if (s->active_locty != locty) {
-            break;
-        }
-
         /* clearing of interrupt flags */
         if (((val & TPM_TIS_INTERRUPTS_SUPPORTED)) &&
             (s->loc[locty].ints & TPM_TIS_INTERRUPTS_SUPPORTED)) {
#5 lore raw

PATCH v2 2/5 tpm: Extend TPMIfClass with get_irqnum() function

In reply to Stefan Berger

From: Stefan Berger <[email protected]>

Implement get_irqnum() as part of the TPMIfClass to be get the assigned IRQ number.

---
 hw/tpm/tpm_tis_isa.c    |  9 +++++++++
 hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
 include/sysemu/tpm.h    | 10 ++++++++++
 3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +9 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_isa_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_isa_reset(DeviceState *dev)
 {
     TPMStateISA *isadev = TPM_TIS_ISA(dev);
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_isa_reset;
     tc->request_completed = tpm_tis_isa_request_completed;
     tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_isa_info = {
hw/tpm/tpm_tis_sysbus.c +9 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_sysbus_reset(DeviceState *dev)
 {
     TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_sysbus_reset;
     tc->request_completed = tpm_tis_sysbus_request_completed;
     tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_sysbus_info = {
include/sysemu/tpm.h +10 -0
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
     enum TpmModel model;
     void (*request_completed)(TPMIf *obj, int ret);
     enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
 } TPMIfClass;
 
 #define TYPE_TPM_TIS_ISA            "tpm-tis"
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
     return TPM_IF_GET_CLASS(ti)->get_version(ti);
 }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
 #endif /* QEMU_TPM_H */
Signature · 1 line
2.24.1
#6 lore raw

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

Hi

Quoted 4 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Implement get_irqnum() as part of the TPMIfClass to be get the assigned

^^ to get

Quoted 2 lines

IRQ number.

Since it is TIS ISA specific (at least for now), perhaps a dedicated tpm_tis_get_irq_num() is more appropriate?

Quoted 90 lines
---
 hw/tpm/tpm_tis_isa.c    |  9 +++++++++
 hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
 include/sysemu/tpm.h    | 10 ++++++++++
 3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +9 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_isa_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_isa_reset(DeviceState *dev)
 {
     TPMStateISA *isadev = TPM_TIS_ISA(dev);
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_isa_reset;
     tc->request_completed = tpm_tis_isa_request_completed;
     tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_isa_info = {
hw/tpm/tpm_tis_sysbus.c +9 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_sysbus_reset(DeviceState *dev)
 {
     TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_sysbus_reset;
     tc->request_completed = tpm_tis_sysbus_request_completed;
     tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_sysbus_info = {
include/sysemu/tpm.h +10 -1
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
     enum TpmModel model;
     void (*request_completed)(TPMIf *obj, int ret);
     enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
 } TPMIfClass;
 
 #define TYPE_TPM_TIS_ISA            "tpm-tis"
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
     return TPM_IF_GET_CLASS(ti)->get_version(ti);
 }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
 #endif /* QEMU_TPM_H */
--

2.24.1

#7 lore raw

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

Quoted 6 lines · Marc-André Lureau

Hi

Quoted 2 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Quoted 7 lines
Quoted 1 line

Implement get_irqnum() as part of the TPMIfClass to be get the assigned

^^ to get

Quoted 2 lines

IRQ number.

Since it is TIS ISA specific (at least for now), perhaps a dedicated tpm_tis_get_irq_num() is more appropriate?

There's no caller from ARM at the moment but at least it is preparing it to support getting the IRQ number since it also allows passing it in via command lie. So it wouldn't have any side-effects on ARM for as long as no extra code was added there. And once sysbus was to use it, it would funnel through the same tpm_get_irqnum code. Other option is to drop the parts for sysbus entirely.

Quoted 91 lines
Quoted 91 lines
---
  hw/tpm/tpm_tis_isa.c    |  9 +++++++++
  hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
  include/sysemu/tpm.h    | 10 ++++++++++
  3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +9 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_isa_get_tpm_version(TPMIf *ti)
      return tpm_tis_get_tpm_version(s);
  }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
  static void tpm_tis_isa_reset(DeviceState *dev)
  {
      TPMStateISA *isadev = TPM_TIS_ISA(dev);
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass *klass, void *data)
      dc->reset = tpm_tis_isa_reset;
      tc->request_completed = tpm_tis_isa_request_completed;
      tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
  }
 
  static const TypeInfo tpm_tis_isa_info = {
hw/tpm/tpm_tis_sysbus.c +9 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
      return tpm_tis_get_tpm_version(s);
  }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
  static void tpm_tis_sysbus_reset(DeviceState *dev)
  {
      TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
      dc->reset = tpm_tis_sysbus_reset;
      tc->request_completed = tpm_tis_sysbus_request_completed;
      tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
  }
 
  static const TypeInfo tpm_tis_sysbus_info = {
include/sysemu/tpm.h +10 -1
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
      enum TpmModel model;
      void (*request_completed)(TPMIf *obj, int ret);
      enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
  } TPMIfClass;
 
  #define TYPE_TPM_TIS_ISA            "tpm-tis"
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
      return TPM_IF_GET_CLASS(ti)->get_version(ti);
  }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
  #endif /* QEMU_TPM_H */
--

2.24.1

#8 lore raw

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

Hi Stefan,

Quoted 16 lines · Stefan Berger
Quoted 6 lines · Marc-André Lureau

Hi

Quoted 2 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Quoted 7 lines
Quoted 1 line

Implement get_irqnum() as part of the TPMIfClass to be get the assigned

^^ to get

Quoted 2 lines

IRQ number.

Since it is TIS ISA specific (at least for now), perhaps a dedicated tpm_tis_get_irq_num() is more appropriate?

Quoted 6 lines

There's no caller from ARM at the moment but at least it is preparing it to support getting the IRQ number since it also allows passing it in via command lie. So it wouldn't have any side-effects on ARM for as long as no extra code was added there. And once sysbus was to use it, it would funnel through the same tpm_get_irqnum code. Other option is to drop the parts for sysbus entirely.

As there is no caller on ARM side, I think I would leave the ops undefined for the sysbus device. But as already reported it does not break anything on ARM side.

Thanks

Eric

Quoted 98 lines
Quoted 97 lines
Quoted 97 lines

---
  hw/tpm/tpm_tis_isa.c    |  9 +++++++++
  hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
  include/sysemu/tpm.h    | 10 ++++++++++

  3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +8 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion
 tpm_tis_isa_get_tpm_version(TPMIf *ti)
       return tpm_tis_get_tpm_version(s);
   }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
   static void tpm_tis_isa_reset(DeviceState *dev)
   {

      TPMStateISA *isadev = TPM_TIS_ISA(dev);

hw/tpm/tpm_tis_isa.c +1 -0
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass
 *klass, void *data)
       dc->reset = tpm_tis_isa_reset;
       tc->request_completed = tpm_tis_isa_request_completed;
       tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
   }
 

  static const TypeInfo tpm_tis_isa_info = {

hw/tpm/tpm_tis_sysbus.c +8 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion
 tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
       return tpm_tis_get_tpm_version(s);
   }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
   static void tpm_tis_sysbus_reset(DeviceState *dev)
   {

      TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);

hw/tpm/tpm_tis_sysbus.c +1 -0
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass
 *klass, void *data)
       dc->reset = tpm_tis_sysbus_reset;
       tc->request_completed = tpm_tis_sysbus_request_completed;
       tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
   }
 

  static const TypeInfo tpm_tis_sysbus_info = {

include/sysemu/tpm.h +10 -0
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
       enum TpmModel model;
       void (*request_completed)(TPMIf *obj, int ret);
       enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
   } TPMIfClass;
 
   #define TYPE_TPM_TIS_ISA            "tpm-tis"
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
       return TPM_IF_GET_CLASS(ti)->get_version(ti);
   }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
   #endif /* QEMU_TPM_H */
Signature · 1 line
2.24.1
#9 lore raw

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

In reply to Stefan Berger
Quoted 79 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Implement get_irqnum() as part of the TPMIfClass to be get the assigned IRQ number.

---
 hw/tpm/tpm_tis_isa.c    |  9 +++++++++
 hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
 include/sysemu/tpm.h    | 10 ++++++++++
 3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +9 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_isa_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_isa_reset(DeviceState *dev)
 {
     TPMStateISA *isadev = TPM_TIS_ISA(dev);
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_isa_reset;
     tc->request_completed = tpm_tis_isa_request_completed;
     tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_isa_info = {
hw/tpm/tpm_tis_sysbus.c +9 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
     return tpm_tis_get_tpm_version(s);
 }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
 static void tpm_tis_sysbus_reset(DeviceState *dev)
 {
     TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
     dc->reset = tpm_tis_sysbus_reset;
     tc->request_completed = tpm_tis_sysbus_request_completed;
     tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
 }
 
 static const TypeInfo tpm_tis_sysbus_info = {
include/sysemu/tpm.h +1 -0
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
     enum TpmModel model;
     void (*request_completed)(TPMIf *obj, int ret);
     enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
 } TPMIfClass;
 
 #define TYPE_TPM_TIS_ISA            "tpm-tis"

include/sysemu/tpm.h static inline TPMVersion tpm_get_version(TPMIf *ti) · line 81

Quoted 7 lines
include/sysemu/tpm.h +4 -0
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
     return TPM_IF_GET_CLASS(ti)->get_version(ti);
 }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;

0 is valid...

Shouldn't we use an Error* argument?

Else return -1 when invalid?

Quoted 7 lines
include/sysemu/tpm.h +5 -0
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
 #endif /* QEMU_TPM_H */
#10 lore raw

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

Quoted 89 lines · Philippe Mathieu-Daudé
Quoted 79 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Implement get_irqnum() as part of the TPMIfClass to be get the assigned IRQ number.

---
  hw/tpm/tpm_tis_isa.c    |  9 +++++++++
  hw/tpm/tpm_tis_sysbus.c |  9 +++++++++
  include/sysemu/tpm.h    | 10 ++++++++++
  3 files changed, 28 insertions(+)
hw/tpm/tpm_tis_isa.c +9 -0
index 30ba37079d..63b62f4c21 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_isa_get_tpm_version(TPMIf *ti)
      return tpm_tis_get_tpm_version(s);
  }
 
+static uint8_t tpm_tis_isa_get_irqnum(TPMIf *ti)
+{
+    TPMStateISA *isadev = TPM_TIS_ISA(ti);
+    TPMState *s = &isadev->state;
+
+    return s->irq_num;
+}
+
  static void tpm_tis_isa_reset(DeviceState *dev)
  {
      TPMStateISA *isadev = TPM_TIS_ISA(dev);
@@ -148,6 +156,7 @@ static void tpm_tis_isa_class_init(ObjectClass *klass, void *data)
      dc->reset = tpm_tis_isa_reset;
      tc->request_completed = tpm_tis_isa_request_completed;
      tc->get_version = tpm_tis_isa_get_tpm_version;
+    tc->get_irqnum = tpm_tis_isa_get_irqnum;
  }
 
  static const TypeInfo tpm_tis_isa_info = {
hw/tpm/tpm_tis_sysbus.c +9 -0
index eced1fc843..6cf45e5057 100644
@@ -80,6 +80,14 @@ static enum TPMVersion tpm_tis_sysbus_get_tpm_version(TPMIf *ti)
      return tpm_tis_get_tpm_version(s);
  }
 
+static uint8_t tpm_tis_sysbus_get_irqnum(TPMIf *ti)
+{
+    TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(ti);
+    TPMState *s = &sbdev->state;
+
+    return s->irq_num;
+}
+
  static void tpm_tis_sysbus_reset(DeviceState *dev)
  {
      TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(dev);
@@ -137,6 +145,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
      dc->reset = tpm_tis_sysbus_reset;
      tc->request_completed = tpm_tis_sysbus_request_completed;
      tc->get_version = tpm_tis_sysbus_get_tpm_version;
+    tc->get_irqnum = tpm_tis_sysbus_get_irqnum;
  }
 
  static const TypeInfo tpm_tis_sysbus_info = {
include/sysemu/tpm.h +1 -0
index 03fb25941c..b94a8a2b16 100644
@@ -41,6 +41,7 @@ typedef struct TPMIfClass {
      enum TpmModel model;
      void (*request_completed)(TPMIf *obj, int ret);
      enum TPMVersion (*get_version)(TPMIf *obj);
+    uint8_t (*get_irqnum)(TPMIf *obj);
  } TPMIfClass;
 
  #define TYPE_TPM_TIS_ISA            "tpm-tis"

include/sysemu/tpm.h static inline TPMVersion tpm_get_version(TPMIf *ti) · line 81

Quoted 7 lines
include/sysemu/tpm.h +4 -0
@@ -74,4 +75,13 @@ static inline TPMVersion tpm_get_version(TPMIf *ti)
      return TPM_IF_GET_CLASS(ti)->get_version(ti);
  }
 
+static inline uint8_t tpm_get_irqnum(TPMIf *ti)
+{
+    if (!ti || !TPM_IF_GET_CLASS(ti)->get_irqnum) {
+        return 0;

0 is valid...

Quoted 3 lines

Shouldn't we use an Error* argument?

Else return -1 when invalid?

Indeed. Let me fix this. Thanks.

Quoted 8 lines
Quoted 8 lines
include/sysemu/tpm.h +5 -0
+    }
+
+    return TPM_IF_GET_CLASS(ti)->get_irqnum(ti);
+}
+
  #endif /* QEMU_TPM_H */
#11 lore raw

PATCH v2 3/5 tests: Temporarily ignore DSDT table differences

In reply to Stefan Berger

Ignore DSDT table differences before enabling IRQ support for TPM.

CC Michael S. Tsirkin <[email protected]>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)
tests/qtest/bios-tables-test-allowed-diff.h +1 -0
index dfb8523c8b..bb4ce8967b 100644
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.tis",
Signature · 1 line
2.24.1
Reviewed-by on v2 3/5
#12 lore raw

Re: [PATCH v2 3/5] tests: Temporarily ignore DSDT table differences

Quoted 5 lines · Stefan Berger

Ignore DSDT table differences before enabling IRQ support for TPM.

CC Michael S. Tsirkin <[email protected]>

make sense, to split implementation & test commits:

Quoted 14 lines
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)
tests/qtest/bios-tables-test-allowed-diff.h +1 -1
index dfb8523c8b..bb4ce8967b 100644
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.tis",
--

2.24.1

Reviewed-by on v2 3/5
#13 lore raw

Re: [PATCH v2 3/5] tests: Temporarily ignore DSDT table differences

In reply to Stefan Berger
Quoted 4 lines · Stefan Berger

Ignore DSDT table differences before enabling IRQ support for TPM.

CC Michael S. Tsirkin <[email protected]>

Thanks

Eric

Quoted 13 lines

---

 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)
tests/qtest/bios-tables-test-allowed-diff.h +1 -0
index dfb8523c8b..bb4ce8967b 100644
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.tis",
#14 lore raw

PATCH v2 4/5 acpi: Enable TPM IRQ

In reply to Stefan Berger

From: Stefan Berger <[email protected]>

Move the TPM TIS IRQ to unused IRQ 13, which is also accepted by Windows. Query for the TPM's irq number and enable the TPM IRQ if not zero.

CC Michael S. Tsirkin <[email protected]>
---
 hw/i386/acpi-build.c  | 11 +++++------
 include/hw/acpi/tpm.h |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)
hw/i386/acpi-build.c +5 -6
index 900f786d08..747defe1ce 100644
@@ -2021,6 +2021,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
             build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en);
 
             if (TPM_IS_TIS_ISA(tpm)) {
+                uint8_t irq = tpm_get_irqnum(tpm);
                 if (misc->tpm_version == TPM_VERSION_2_0) {
                     dev = aml_device("TPM");
                     aml_append(dev, aml_name_decl("_HID",
@@ -2035,12 +2036,10 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
                 crs = aml_resource_template();
                 aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
                            TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
-                /*
-                    FIXME: TPM_TIS_IRQ=5 conflicts with PNP0C0F irqs,
-                    Rewrite to take IRQ from TPM device model and
-                    fix default IRQ value there to use some unused IRQ
-                 */
-                /* aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); */
+
+                if (irq) {
+                    aml_append(crs, aml_irq_no_flags(irq));
+                }
                 aml_append(dev, aml_name_decl("_CRS", crs));
 
                 tpm_build_ppi_acpi(tpm, dev);
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
 #define TPM_TIS_ADDR_BASE           0xFED40000
 #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13
 
 #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
 #define TPM_TIS_LOCALITY_SHIFT      12
Signature · 1 line
2.24.1
Reviewed-by on v2 4/5
#15 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Quoted 8 lines · Stefan Berger

From: Stefan Berger <[email protected]>

Move the TPM TIS IRQ to unused IRQ 13, which is also accepted by Windows. Query for the TPM's irq number and enable the TPM IRQ if not zero.

CC Michael S. Tsirkin <[email protected]>
Quoted 50 lines
---
 hw/i386/acpi-build.c  | 11 +++++------
 include/hw/acpi/tpm.h |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)
hw/i386/acpi-build.c +5 -6
index 900f786d08..747defe1ce 100644
@@ -2021,6 +2021,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
             build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en);
 
             if (TPM_IS_TIS_ISA(tpm)) {
+                uint8_t irq = tpm_get_irqnum(tpm);
                 if (misc->tpm_version == TPM_VERSION_2_0) {
                     dev = aml_device("TPM");
                     aml_append(dev, aml_name_decl("_HID",
@@ -2035,12 +2036,10 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
                 crs = aml_resource_template();
                 aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
                            TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
-                /*
-                    FIXME: TPM_TIS_IRQ=5 conflicts with PNP0C0F irqs,
-                    Rewrite to take IRQ from TPM device model and
-                    fix default IRQ value there to use some unused IRQ
-                 */
-                /* aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ)); */
+
+                if (irq) {
+                    aml_append(crs, aml_irq_no_flags(irq));
+                }
                 aml_append(dev, aml_name_decl("_CRS", crs));
 
                 tpm_build_ppi_acpi(tpm, dev);
include/hw/acpi/tpm.h +1 -2
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
 #define TPM_TIS_ADDR_BASE           0xFED40000
 #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13
 
 #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
 #define TPM_TIS_LOCALITY_SHIFT      12
--

2.24.1

#16 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Quoted 11 lines · Marc-André Lureau

include/hw/acpi/tpm.h line 27

Quoted 11 lines
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
  #define TPM_TIS_ADDR_BASE           0xFED40000
  #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13

Eric,

 does this change have any negative side effects on ARM? If you prefer, we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS IRQ and leave the latter at '5' because we know that this is working.

   Stefan

Quoted 6 lines
Quoted 6 lines
include/hw/acpi/tpm.h +0 -1
  #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
  #define TPM_TIS_LOCALITY_SHIFT      12
--

2.24.1

#17 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Hi Stefan,

Quoted 16 lines · Stefan Berger
Quoted 11 lines · Marc-André Lureau

include/hw/acpi/tpm.h line 27

Quoted 11 lines
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
   #define TPM_TIS_ADDR_BASE           0xFED40000
   #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13

Eric,

Quoted 3 lines

 does this change have any negative side effects on ARM? If you prefer, we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS IRQ and leave the latter at '5' because we know that this is working.

I just gave it a try and it does not seem to introduce any regression with automatic LUKS decryption. I will take more time to review the code though.

Thanks

Eric

Quoted 12 lines

   Stefan

Quoted 6 lines
Quoted 6 lines
include/hw/acpi/tpm.h +0 -0
   #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
   #define TPM_TIS_LOCALITY_SHIFT      12
Signature · 1 line
2.24.1
#18 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

In reply to Stefan Berger

Hi Stefan,

Quoted 16 lines · Stefan Berger
Quoted 11 lines · Marc-André Lureau

include/hw/acpi/tpm.h line 27

Quoted 11 lines
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
   #define TPM_TIS_ADDR_BASE           0xFED40000
   #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13

Eric,

Quoted 3 lines

 does this change have any negative side effects on ARM? If you prefer, we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS IRQ and leave the latter at '5' because we know that this is working.

The IRQ is not advertised in dt nor ACPI on ARM. However it is advertised in the capability reg and in the vector. reg So I think this should be fixed? I guess on ARM we will pick up a completely different IRQ num, allocated from the platform bus slot.

Thanks

Eric

Quoted 11 lines

   Stefan

Quoted 6 lines
Quoted 6 lines
include/hw/acpi/tpm.h +0 -0
   #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
   #define TPM_TIS_LOCALITY_SHIFT      12
Signature · 1 line
2.24.1
#19 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Quoted 17 lines · Auger Eric

Hi Stefan,

Quoted 14 lines · Stefan Berger
Quoted 10 lines · Marc-André Lureau

include/hw/acpi/tpm.h line 27

Quoted 10 lines
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
   #define TPM_TIS_ADDR_BASE           0xFED40000
   #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13

Eric,

Quoted 7 lines
Quoted 3 lines

 does this change have any negative side effects on ARM? If you prefer,
we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS IRQ and leave the latter at '5' because we know that this is working.

The IRQ is not advertised in dt nor ACPI on ARM. However it is advertised in the capability reg and in the vector. reg So I think this should be fixed? I guess on ARM we will pick up a completely different IRQ num, allocated from the platform bus slot.

The specification

https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p04_r0p37_pub-1.pdf

declares several fields in the Interface Capability Register (table 23, pdf page 89) to be mandatory and they must be set to '1'. So I would not want to touch those. We can set the interrupt vector register to '0' in case interrupts are not supported. Following the spec 0 means that no interrupts are supported. I will now split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ and will in the end set TPM_TIS_SYSBUS_IRQ to 'disabled', indicating that IRQs are not supported, though they should work even though on ARM there may not be a driver to test this with. Does this sound ok?

   Stefan

Quoted 12 lines

Thanks

Eric

Quoted 8 lines

   Stefan

Quoted 5 lines
Quoted 5 lines
include/hw/acpi/tpm.h +0 -0
   #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
   #define TPM_TIS_LOCALITY_SHIFT      12
Signature · 1 line
2.24.1
#20 lore raw

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Hi Stefan,

Quoted 32 lines · Stefan Berger
Quoted 17 lines · Auger Eric

Hi Stefan,

Quoted 14 lines · Stefan Berger
Quoted 10 lines · Marc-André Lureau

include/hw/acpi/tpm.h line 27

Quoted 10 lines
include/hw/acpi/tpm.h +1 -1
index 1a2a57a21f..063a9eb42a 100644
@@ -24,7 +24,7 @@
    #define TPM_TIS_ADDR_BASE           0xFED40000
    #define TPM_TIS_ADDR_SIZE           0x5000
 
-#define TPM_TIS_IRQ                 5
+#define TPM_TIS_IRQ                 13

Eric,

Quoted 7 lines
Quoted 3 lines

  does this change have any negative side effects on ARM? If you prefer, we can split this part here up into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS IRQ and leave the latter at '5' because we know that this is working.

The IRQ is not advertised in dt nor ACPI on ARM. However it is advertised in the capability reg and in the vector. reg So I think this should be fixed? I guess on ARM we will pick up a completely different IRQ num, allocated from the platform bus slot.

The specification

https://trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2p0-v1p04_r0p37_pub-1.pdf

Quoted 9 lines

declares several fields in the Interface Capability Register (table 23, pdf page 89) to be mandatory and they must be set to '1'. So I would not want to touch those. We can set the interrupt vector register to '0' in case interrupts are not supported. Following the spec 0 means that no interrupts are supported. I will now split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ and will in the end set TPM_TIS_SYSBUS_IRQ to 'disabled', indicating that IRQs are not supported, though they should work even though on ARM there may not be a driver to test this with. Does this sound ok?

Yes it does.

Thanks

Eric

Quoted 19 lines

   Stefan

Quoted 12 lines

Thanks

Eric

Quoted 8 lines

    Stefan

Quoted 5 lines
Quoted 5 lines
include/hw/acpi/tpm.h +0 -0
    #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
    #define TPM_TIS_LOCALITY_SHIFT      12

--
2.24.1

#21 lore raw

PATCH v2 5/5 tests: Add updated DSDT

In reply to Stefan Berger

Add the updated DSDT following the interrupt enablement.

@@ -5,13 +5,13 @@
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/q35/DSDT.tis, Mon Jun 15 09:57:05 2020
+ * Disassembly of /tmp/aml-Y77YL0, Mon Jun 15 09:57:05 2020 *
* Original Table Header:

  *     Signature        "DSDT"
- *     Length           0x000020A5 (8357)
+ *     Length           0x000020A8 (8360)
  *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
- *     Checksum         0xAD
+ *     Checksum         0x77
  *     OEM ID           "BOCHS "
  *     OEM Table ID     "BXPCDSDT"
  *     OEM Revision     0x00000001 (1)
@@ -3162,6 +3162,8 @@
                         0xFED40000,         // Address Base
                         0x00005000,         // Address Length
                         )
+                    IRQNoFlags ()
+                        {13}
                 })
                 OperationRegion (TPP2, SystemMemory, 0xFED45100, 0x5A)
                 Field (TPP2, AnyAcc, NoLock, Preserve)

**

CC Michael S. Tsirkin <[email protected]>
---
 tests/data/acpi/q35/DSDT.tis                | Bin 8357 -> 8360 bytes
 tests/qtest/bios-tables-test-allowed-diff.h |   1 -
 2 files changed, 1 deletion(-)
tests/data/acpi/q35/DSDT.tis binary +0 -0
index 56b6fb0c3298517d080e38fea05a748b9f1dba54..3f9db960aa05d399fa7f8449e6db688788211832 100644
GIT binary patch
tests/qtest/bios-tables-test-allowed-diff.h +0 -1
index bb4ce8967b..dfb8523c8b 100644
@@ -1,2 +1 @@
 /* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/DSDT.tis",
Signature · 1 line
2.24.1