Skip to content

tpm: Enable usage of TPM TIS with interrupts

Stefan Berger qemu-devel 4 versions – Applied

Status from this message: Queued it here: https://github.com/stefanberger/qemu-tpm/commits/tpm-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 12 repliesApplied
  2. v38 patches 14 repliesSuperseded
  3. v25 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches1 replySuperseded

Changes in v4 from the cover letter

- Changed TPM_IRQ_DISABLED from -1 to ~0

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/8tpm_tis: Allow lowering of IRQ also when locality is not activehw/tpm/tpm_tis_common.c+0 -40 replies
2/8tpm: Extend TPMIfClass with get_irqnum() functionhw/tpm/tpm_tis_isa.c hw/tpm/tpm_tis_sysbus.c include/sysemu/tpm.h+30 -01 reply
3/8tests: Temporarily ignore DSDT table differencestests/qtest/bios-tables-test-allowed-diff.h+1 -00 replies
4/8tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQhw/tpm/tpm_tis_isa.c hw/tpm/tpm_tis_sysbus.c include/hw/acpi/tpm.h+5 -31 reply
5/8acpi: Enable TPM IRQhw/i386/acpi-build.c include/hw/acpi/tpm.h+6 -72 replies
6/8tests: Add updated DSDTtests/data/acpi/q35/DSDT.tis tests/qtest/bios-tables-test-allowed-diff.h+0 -12 replies
7/8tpm: Guard irq related ops in case interrupts are disabledhw/tpm/tpm_tis_common.c hw/tpm/tpm_tis_isa.c+15 -31 reply
8/8tpm: Disable interrupt support for TIS on sysbusinclude/hw/acpi/tpm.h+1 -11 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric AugerMarc-André LureauIgor MammedovMichael S. Tsirkin
SeriesT-b R-b
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b R-b
6/8R-b R-b R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is the only one accepted by Windows.

Stefan

v3->v4:
- Changed TPM_IRQ_DISABLED from -1 to ~0

v2->v3:
- Extended series to disable IRQ for TIS on sysbus

v1->v2:
- Added updated DSDT

Stefan Berger (8):
tpm_tis: Allow lowering of IRQ also when locality is not active
tpm: Extend TPMIfClass with get_irqnum() function
tests: Temporarily ignore DSDT table differences
tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ
acpi: Enable TPM IRQ
tests: Add updated DSDT
tpm: Guard irq related ops in case interrupts are disabled
tpm: Disable interrupt support for TIS on sysbus

 hw/i386/acpi-build.c         |  11 +++++------
 hw/tpm/tpm_tis_common.c      |  12 +++++++++---
 hw/tpm/tpm_tis_isa.c         |  17 ++++++++++++++---
 hw/tpm/tpm_tis_sysbus.c      |  12 +++++++++++-
 include/hw/acpi/tpm.h        |   3 ++-
 include/sysemu/tpm.h         |  12 ++++++++++++
 tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes
 7 files changed, 53 insertions(+), 14 deletions(-)
Signature · 1 line
2.24.1