Skip to contentSkip to conversation

ARM: dts: Aspeed: Enable EHCI controllers

PATCH In review Eddie James 3 participants 6 messages Jun 16, 2020 – Jul 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: Aspeed: Enable EHCI controllers

Enable the second EHCI controller on both the Tacoma board and Rainier system.

Eddie James (2):
ARM: dts: Aspeed: Rainier: Enable EHCI controller
ARM: dts: Aspeed: Tacoma: Enable EHCI controller

 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 6 +++++-
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts  | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/2 ARM: dts: Aspeed: Rainier: Enable EHCI controller

Enable the second EHCI controller on the AST2600. Also add a line-name for the GPIO that controls power to the USB port.

---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +5 -1
index bcf96e16f8cc..e41a2c2f4438 100644
@@ -71,6 +71,10 @@
 
 };
 
+&ehci1 {
+	status = "okay";
+};
+
 &gpio0 {
 	gpio-line-names =
 	/*A0-A7*/	"","","","","","","","",
@@ -87,7 +91,7 @@
 	/*L0-L7*/	"","","","","","","","",
 	/*M0-M7*/	"","","","","","","","",
 	/*N0-N7*/	"","","","","","","","",
-	/*O0-O7*/	"","","","","","","","",
+	/*O0-O7*/	"","","","usb-power","","","","",
 	/*P0-P7*/	"","","","","","","","",
 	/*Q0-Q7*/	"cfam-reset","","","","","","","",
 	/*R0-R7*/	"","","","","","","","",
Signature · 1 line
2.24.0
#2 lore raw

PATCH 2/2 ARM: dts: Aspeed: Tacoma: Enable EHCI controller

In reply to Eddie James

Enable the second EHCI controller on the AST2600. Also add a line-name for the GPIO that controls power to the USB port.

---
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +5 -1
index 96a45014b7e5..fcaff4023240 100644
@@ -95,6 +95,10 @@
 	};
 };
 
+&ehci1 {
+	status = "okay";
+};
+
 &gpio0 {
 	gpio-line-names =
 	/*A0-A7*/	"","","","","","","","",
@@ -111,7 +115,7 @@
 	/*L0-L7*/	"","","","","","","","",
 	/*M0-M7*/	"","","","","","","","",
 	/*N0-N7*/	"","","","","","","","",
-	/*O0-O7*/	"led-rear-power","led-rear-id","","","","","","",
+	/*O0-O7*/	"led-rear-power","led-rear-id","","usb-power","","","","",
 	/*P0-P7*/	"","","","","","","","",
 	/*Q0-Q7*/	"cfam-reset","","","","","","","fsi-routing",
 	/*R0-R7*/	"","","","","","","","",
Signature · 1 line
2.24.0
maintainer
#3 lore raw

Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller

Quoted 3 lines · Eddie James

Enable the second EHCI controller on the AST2600. Also add a line-name for the GPIO that controls power to the USB port.

What's the idea behind the power control?

Is there any reason not to add a hog, so power is always applied?

Quoted 33 lines
---
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +5 -2
index 96a45014b7e5..fcaff4023240 100644
@@ -95,6 +95,10 @@
        };
 };
 
+&ehci1 {
+       status = "okay";
+};
+
 &gpio0 {
        gpio-line-names =
        /*A0-A7*/       "","","","","","","","",
@@ -111,7 +115,7 @@
        /*L0-L7*/       "","","","","","","","",
        /*M0-M7*/       "","","","","","","","",
        /*N0-N7*/       "","","","","","","","",
-       /*O0-O7*/       "led-rear-power","led-rear-id","","","","","","",
+       /*O0-O7*/       "led-rear-power","led-rear-id","","usb-power","","","","",
        /*P0-P7*/       "","","","","","","","",
        /*Q0-Q7*/       "cfam-reset","","","","","","","fsi-routing",
        /*R0-R7*/       "","","","","","","","",
--

2.24.0

#4 lore raw

Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller

Quoted 9 lines · Joel Stanley
Quoted 3 lines · Eddie James

Enable the second EHCI controller on the AST2600. Also add a line- name
for the GPIO that controls power to the USB port.

What's the idea behind the power control?

Is there any reason not to add a hog, so power is always applied?

There is a desire to allow the port to be disabled, for those that are worried about rogue USB sticks.

maintainer
#5 lore raw

Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller

Quoted 8 lines · Brad Bishop
Quoted 6 lines · Joel Stanley
Quoted 3 lines · Eddie James

Enable the second EHCI controller on the AST2600. Also add a line- name
for the GPIO that controls power to the USB port.

Quoted 6 lines
Quoted 3 lines

What's the idea behind the power control?

Is there any reason not to add a hog, so power is always applied?

There is a desire to allow the port to be disabled, for those that are worried about rogue USB sticks.

Ok. Do we have userspace that enables the power?

I propose we hog them on for now, so we can test the USB function. When someone has time to implement the enable/disable function we can remove the hog.

Cheers,

Joel