Skip to contentSkip to conversation

dt-bindings: power: supply: bq25890: Indent example with tabs

PATCH In review Krzysztof Kozlowski 2 participants 4 messages Jun 17, 2020 – Jun 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: power: supply: bq25890: Indent example with tabs

Fix example indentation to tabs to follow generic Linux coding style. This avoids copying the space indentation to DTS when re-using the example.

---
 .../bindings/power/supply/bq25890.txt         | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)
Documentation/devicetree/bindings/power/supply/bq25890.txt +11 -11
index dc9c8f76e06c..51ecc756521f 100644
@@ -36,17 +36,17 @@ Optional properties:
 Example:
 
 bq25890 {
-        compatible = "ti,bq25890";
-        reg = <0x6a>;
+	compatible = "ti,bq25890";
+	reg = <0x6a>;
 
-        ti,battery-regulation-voltage = <4200000>;
-        ti,charge-current = <1000000>;
-        ti,termination-current = <50000>;
-        ti,precharge-current = <128000>;
-        ti,minimum-sys-voltage = <3600000>;
-        ti,boost-voltage = <5000000>;
-        ti,boost-max-current = <1000000>;
+	ti,battery-regulation-voltage = <4200000>;
+	ti,charge-current = <1000000>;
+	ti,termination-current = <50000>;
+	ti,precharge-current = <128000>;
+	ti,minimum-sys-voltage = <3600000>;
+	ti,boost-voltage = <5000000>;
+	ti,boost-max-current = <1000000>;
 
-        ti,use-ilim-pin;
-        ti,thermal-regulation-threshold = <120>;
+	ti,use-ilim-pin;
+	ti,thermal-regulation-threshold = <120>;
 };
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 dt-bindings: power: supply: bq25890: Document required interrupt

The driver requires interrupts (fails probe if it is not provided) so document this requirement in bindings.

Fixes 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")
---
 Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/power/supply/bq25890.txt +4 -0
index 51ecc756521f..3b4c69a7fa70 100644
@@ -10,6 +10,7 @@ Required properties:
     * "ti,bq25895"
     * "ti,bq25896"
 - reg: integer, i2c address of the device.
+- interrupts: interrupt line;
 - ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
 - ti,charge-current: integer, maximum charging current (in uA);
 - ti,termination-current: integer, charge will be terminated when current in
@@ -39,6 +40,9 @@ bq25890 {
 	compatible = "ti,bq25890";
 	reg = <0x6a>;
 
+	interrupt-parent = <&gpio1>;
+	interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
+
 	ti,battery-regulation-voltage = <4200000>;
 	ti,charge-current = <1000000>;
 	ti,termination-current = <50000>;
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt

Hi,

Quoted 7 lines · Krzysztof Kozlowski

The driver requires interrupts (fails probe if it is not provided) so document this requirement in bindings.

Fixes 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")

---

Thanks, queued.

-- Sebastian

Quoted 28 lines
 Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/power/supply/bq25890.txt +4 -0
index 51ecc756521f..3b4c69a7fa70 100644
@@ -10,6 +10,7 @@ Required properties:
     * "ti,bq25895"
     * "ti,bq25896"
 - reg: integer, i2c address of the device.
+- interrupts: interrupt line;
 - ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
 - ti,charge-current: integer, maximum charging current (in uA);
 - ti,termination-current: integer, charge will be terminated when current in
@@ -39,6 +40,9 @@ bq25890 {
 	compatible = "ti,bq25890";
 	reg = <0x6a>;
 
+	interrupt-parent = <&gpio1>;
+	interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
+
 	ti,battery-regulation-voltage = <4200000>;
 	ti,charge-current = <1000000>;
 	ti,termination-current = <50000>;
Signature · 1 line
2.17.1
#3 lore raw
In reply to Krzysztof Kozlowski

Hi,

Quoted 6 lines · Krzysztof Kozlowski

Fix example indentation to tabs to follow generic Linux coding style. This avoids copying the space indentation to DTS when re-using the example.

---

Thanks, queued.

-- Sebastian

Quoted 39 lines
 .../bindings/power/supply/bq25890.txt         | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)
Documentation/devicetree/bindings/power/supply/bq25890.txt +11 -11
index dc9c8f76e06c..51ecc756521f 100644
@@ -36,17 +36,17 @@ Optional properties:
 Example:
 
 bq25890 {
-        compatible = "ti,bq25890";
-        reg = <0x6a>;
+	compatible = "ti,bq25890";
+	reg = <0x6a>;
 
-        ti,battery-regulation-voltage = <4200000>;
-        ti,charge-current = <1000000>;
-        ti,termination-current = <50000>;
-        ti,precharge-current = <128000>;
-        ti,minimum-sys-voltage = <3600000>;
-        ti,boost-voltage = <5000000>;
-        ti,boost-max-current = <1000000>;
+	ti,battery-regulation-voltage = <4200000>;
+	ti,charge-current = <1000000>;
+	ti,termination-current = <50000>;
+	ti,precharge-current = <128000>;
+	ti,minimum-sys-voltage = <3600000>;
+	ti,boost-voltage = <5000000>;
+	ti,boost-max-current = <1000000>;
 
-        ti,use-ilim-pin;
-        ti,thermal-regulation-threshold = <120>;
+	ti,use-ilim-pin;
+	ti,thermal-regulation-threshold = <120>;
 };
Signature · 1 line
2.17.1