Skip to contentSkip to conversation

drm/panfrost: Reduce the amount of logs on deferred probe

PATCH In review Krzysztof Kozlowski 4 participants 6 messages May 27, 2020 – Jun 18, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/panfrost: Reduce the amount of logs on deferred probe

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
 drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/panfrost/panfrost_device.c +4 -4
index 8136babd3ba9..b172087eee6a 100644
@@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
 				      pfdev->comp->num_supplies,
 				      pfdev->regulators);
 	if (ret < 0) {
-		dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulators: %d\n",
+				ret);
 		return ret;
 	}
 
@@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
 	}
 
 	err = panfrost_regulator_init(pfdev);
-	if (err) {
-		dev_err(pfdev->dev, "regulator init failed %d\n", err);
+	if (err)
 		goto err_out0;
-	}
 
 	err = panfrost_reset_init(pfdev);
 	if (err) {
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v3 1/1
#1 lore raw
Quoted 51 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
 drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/panfrost/panfrost_device.c +4 -4
index 8136babd3ba9..b172087eee6a 100644
@@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
 				      pfdev->comp->num_supplies,
 				      pfdev->regulators);
 	if (ret < 0) {
-		dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulators: %d\n",
+				ret);
 		return ret;
 	}
 
@@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
 	}
 
 	err = panfrost_regulator_init(pfdev);
-	if (err) {
-		dev_err(pfdev->dev, "regulator init failed %d\n", err);
+	if (err)
 		goto err_out0;
-	}
 
 	err = panfrost_reset_init(pfdev);
 	if (err) {
Signature · 1 line
2.17.1
#2 lore raw
Quoted 24 lines · Alyssa Rosenzweig
Quoted 21 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
 drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Hi Rob, Tomeu and Steven,

You're listed as maintainers for panfrost. Is anyone going to pick this up?

Maybe I sent it to wrong mailing list or forgot about anything?

Best regards,
Krzysztof

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#3 lore raw
Quoted 26 lines · Krzysztof Kozlowski
Quoted 24 lines · Alyssa Rosenzweig
Quoted 21 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
  drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 4 lines

Hi Rob, Tomeu and Steven,

You're listed as maintainers for panfrost. Is anyone going to pick this up?

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can pick it up if Rob/Tomeu are happy for me to do that.

Quoted 1 line

Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo list to ask if Rob/Tomeu needed some help with merging patches.

Steve
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#4 lore raw
Quoted 33 lines · Steven Price
Quoted 26 lines · Krzysztof Kozlowski
Quoted 24 lines · Alyssa Rosenzweig
Quoted 21 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
  drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 4 lines

Hi Rob, Tomeu and Steven,

You're listed as maintainers for panfrost. Is anyone going to pick this up?

Quoted 7 lines

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can pick it up if Rob/Tomeu are happy for me to do that.

Quoted 1 line

Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo list to ask if Rob/Tomeu needed some help with merging patches.

Please do, I haven't had the cycles for panfrost lately.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#5 lore raw
Quoted 37 lines · Rob Herring
Quoted 36 lines · Steven Price
Quoted 26 lines · Krzysztof Kozlowski
Quoted 24 lines · Alyssa Rosenzweig
Quoted 21 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice.

In case of multiple probe tries this would pollute the dmesg.

---

Changes since v2:
1. Rebase
2. Add Steven's review

Changes since v1:
1. Remove second error message from calling panfrost_regulator_init()

---
   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 4 lines

Hi Rob, Tomeu and Steven,

You're listed as maintainers for panfrost. Is anyone going to pick this up?

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can pick it up if Rob/Tomeu are happy for me to do that.

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo list to ask if Rob/Tomeu needed some help with merging patches.

Please do, I haven't had the cycles for panfrost lately.

Rob

Ok, this patch is pushed to drm-misc-next. I'll dig through my emails for the other patches which are pending and take a look at them too.

Steve
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel