Skip to contentSkip to conversation

t_client.sh: correctly report all failed instances in summary

PATCH In review Gert Doering 2 participants 4 messages Jun 26, 2020 – Jul 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 t_client.sh: correctly report all failed instances in summary

t_client.sh reports a summary at the end:

Test sets succeeded: none.
Test sets failed: 1 2 3 4 5.

for tests that are skipped due to the pre-test ping check ("vpn target IP must not ping before VPN ist started") the script forgot to add the instance number to the summary line. Fixed.

---
 tests/t_client.sh.in | 1 +
 1 file changed, 1 insertion(+)
tests/t_client.sh.in +1 -0
index 69866fb5..294546be 100755
@@ -298,6 +298,7 @@ do
         echo -e "OK.\n"
     else
 	echo -e "FAIL: make sure that ping hosts are ONLY reachable via VPN, SKIP test $SUF".
+	SUMMARY_FAIL="$SUMMARY_FAIL $SUF"
 	exit_code=31
 	continue
     fi
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 10 lines · Gert Doering

t_client.sh reports a summary at the end:

Test sets succeeded: none.
Test sets failed: 1 2 3 4 5.

for tests that are skipped due to the pre-test ping check ("vpn target IP must not ping before VPN ist started") the script forgot to add the instance number to the summary line. Fixed.

Simple enough and pretty clear. This is the only FAIL case where we set the exit code, print a message, but don't append the test to the SUMMARY_FAIL.

This is fixed now.

I can't easily come up with a t_client instance that verifies this failure, but I trust Gert to have done so after having spotted the issue.

Signature · 1 line
Antonio Quartulli
#2 lore raw

Hi,

Quoted 5 lines · Antonio Quartulli
Quoted 4 lines · Gert Doering

t_client.sh reports a summary at the end:

Test sets succeeded: none.
Test sets failed: 1 2 3 4 5.

[..]

Quoted 2 lines

I can't easily come up with a t_client instance that verifies this failure, but I trust Gert to have done so after having spotted the issue.

Actually I was wondering why my failed tests did not show up in the summary in some cases :-) - so I had the perfect test case up front.

(How to reproduce is easy: just run one of the test VPN instances manually before starting t_client.sh - it will fail all/most of the test due to "these addresse must not ping before we start openvpn!")

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
#3 lore raw
In reply to Gert Doering

Patch has been applied to the master branch.

commit ec33bae311e7f3549b05de4a4c92fa7bc7144d29

Author: Gert Doering
Date:   Fri Jun 26 10:27:43 2020 +0200
     t_client.sh: correctly report all failed instances in summary

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Antonio Quartulli <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg20130.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering