Skip to contentSkip to conversation

dt-bindings: fsl: add kamstrup flex concentrator to schema

PATCH Superseded Bruno Thomsen 2 participants 4 messages Jul 16, 2020

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: fsl: add kamstrup flex concentrator to schema

Add Kamstrup OMNIA Flex Concentrator compatibles to the schema so we can make use of them for the validation.

---
Changes since version 1:
- Patch prefix renamed to "dt-bindings: fsl:"
- Added acked-by from Rob Herring.
- Fixed typo in commit message.

 Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +2 -0
index 05906e291e38..66627b272e40 100644
@@ -299,6 +299,8 @@ properties:
           - enum:
               - fsl,imx7d-sdb             # i.MX7 SabreSD Board
               - fsl,imx7d-sdb-reva        # i.MX7 SabreSD Rev-A Board
+              - kam,imx7d-flex-concentrator       # Kamstrup OMNIA Flex Concentrator
+              - kam,imx7d-flex-concentrator-mfg   # Kamstrup OMNIA Flex Concentrator in manufacturing mode
               - novtech,imx7d-meerkat96   # i.MX7 Meerkat96 Board
               - technexion,imx7d-pico-dwarf   # TechNexion i.MX7D Pico-Dwarf
               - technexion,imx7d-pico-hobbit  # TechNexion i.MX7D Pico-Hobbit

base-commit: f8456690ba8eb18ea4714e68554e242a04f65cff

Signature · 1 line
2.26.2
#1 lore raw

PATCH v2 2/2 ARM: dts: imx7: add support for kamstrup flex concentrator

This adds support for the OMNIA Flex Concentrator product from Kamstrup A/S. It's providing radio mesh communication infrastructure for smart electricity meters.

Kamstrup OMNIA is a modular and scalable smart grid platform.

Limitations: Ethernet PHY type auto detection does not work when using reset-{assert-us,deassert-us,gpios} properties so it's using a fixed PHY type ID for now. Auto detection worked when using the deprecated FEC properties phy-reset-{gpios,duration,post-delay}.

---
Changes since version 1:
- Sorted labeling nodes.
- Sorted pinctrl entries.
- Removed deprecated fec phy reset properties.
- Added mdio phy reset properties.
- Disabled phy type auto detection and added note to commit message.
- Fixed two comment typos.

 arch/arm/boot/dts/Makefile                    |   2 +
 .../boot/dts/imx7d-flex-concentrator-mfg.dts  |  25 ++
 arch/arm/boot/dts/imx7d-flex-concentrator.dts | 309 ++++++++++++++++++
 3 files changed, 336 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dts
 create mode 100644 arch/arm/boot/dts/imx7d-flex-concentrator.dts
arch/arm/boot/dts/Makefile +2 -0
index e6a1cac0bfc7..bf5c5d86a2e8 100644
@@ -628,6 +628,8 @@ dtb-$(CONFIG_SOC_IMX7D) += \
 	imx7d-colibri-emmc-aster.dtb \
 	imx7d-colibri-emmc-eval-v3.dtb \
 	imx7d-colibri-eval-v3.dtb \
+	imx7d-flex-concentrator.dtb \
+	imx7d-flex-concentrator-mfg.dtb \
 	imx7d-mba7.dtb \
 	imx7d-meerkat96.dtb \
 	imx7d-nitrogen7.dtb \
arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dts new file +25 -0
new file mode 100644
index 000000000000..789f0837058f
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for Kamstrup OMNIA Flex Concentrator in
+ * manufacturing/debugging mode.
+ *
+ * Copyright (C) 2020 Kamstrup A/S
+ * Author: Bruno Thomsen <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "imx7d-flex-concentrator.dts"
+
+/ {
+	model = "Kamstrup OMNIA Flex Concentrator - Manufacturing";
+	compatible = "kam,imx7d-flex-concentrator-mfg", "kam,imx7d-flex-concentrator", "fsl,imx7d";
+
+	chosen {
+		stdout-path = &uart4;
+	};
+};
+
+&uart4 {
+	status = "okay";
+};
arch/arm/boot/dts/imx7d-flex-concentrator.dts new file +309 -0

309 lines not on this page · raw message

Signature · 1 line
2.26.2
reviewer
#2 lore raw

Re: [PATCH v2 2/2] ARM: dts: imx7: add support for kamstrup flex concentrator

Hi Bruno,

Quoted 5 lines · Bruno Thomsen

Limitations: Ethernet PHY type auto detection does not work when using reset-{assert-us,deassert-us,gpios} properties so it's using a fixed PHY type ID for now. Auto detection worked when using the deprecated FEC properties phy-reset-{gpios,duration,post-delay}.

I think we need to understand this better. Why does it fail?

I gave a test on an imx6q-sabresd and the Ethernet PHY (AR8031) could be properly detected using reset-{assert-us,deassert-us,gpios} properties inside the mdio node.

Is this a Micrel KSZ8081 specific issue?

Please report this issue to the Ethernet PHY folks.

#3 lore raw

Re: [PATCH v2 2/2] ARM: dts: imx7: add support for kamstrup flex concentrator

Hi Fabio,

Den tor. 16. jul. 2020 kl. 20.01 skrev Fabio Estevam <[email protected]>:

Quoted 9 lines · Bruno Thomsen
Quoted 6 lines

Limitations: Ethernet PHY type auto detection does not work when using reset-{assert-us,deassert-us,gpios} properties so it's using a fixed PHY type ID for now. Auto detection worked when using the deprecated FEC properties phy-reset-{gpios,duration,post-delay}.

I think we need to understand this better. Why does it fail?

Yes, we need to locate the root cause.

Quoted 3 lines

I gave a test on an imx6q-sabresd and the Ethernet PHY (AR8031) could be properly detected using reset-{assert-us,deassert-us,gpios} properties inside the mdio node.

Okay, thanks.

Quoted 1 line

Is this a Micrel KSZ8081 specific issue?

Maybe, I'm actually beginning to suspect that the issue might be related to polling vs interrupt mode. As all partially related examples I have seen uses interrupt mode and I have only configured poll mode. But the hardware does have the interrupt signal connected to the imx7.

Quoted 1 line

Please report this issue to the Ethernet PHY folks.

I'm going to send an Ethernet PHY mail tomorrow with the details I know at the moment. Just wanted to get an updated version of the device tree out in case of any other issues not related to the PHY part.

/Bruno