Remaining RKL patches
Subsystems (3)
v8 cover Remaining RKL patches
The first couple patches here already have r-b's from Jose, but since it's been a while since they were last sent to the list we should get another CI pass before merging them.
Changes since v7:
- Undo the renumbering of PLL IDs in the DPLL4 patch; the shared DPLL code has deep-rooted assumptions that the PLL table has no holes and that id==idx; renumbering works fine for RKL, but breaks one of those assumptions for TGL. Instead introduce RKL-specific RKL_DPLL_CFGCR macros to look up the proper register with the existing PLL IDs.
- Incorporate Jose's review feedback on the HTI patch and combo PHY WA patch.
Matt Roper (5):
drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout drm/i915/rkl: Add initial workarounds drm/i915/rkl: Add DPLL4 support
drm/i915/rkl: Handle HTI
drm/i915/rkl: Add Wa_14011224835 for PHY B initialization
.../gpu/drm/i915/display/intel_combo_phy.c | 50 +++++++++++ drivers/gpu/drm/i915/display/intel_ddi.c | 37 +++++++- drivers/gpu/drm/i915/display/intel_display.c | 23 ++++- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 52 +++++++++-- drivers/gpu/drm/i915/display/intel_sprite.c | 5 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 89 ++++++++++++------- drivers/gpu/drm/i915/i915_drv.h | 8 ++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 31 ++++++- drivers/gpu/drm/i915/intel_device_info.h | 1 + 10 files changed, 249 insertions(+), 48 deletions(-)
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 1/5 drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout
RKL uses a slightly different bit layout for the DPCLKA_CFGCR0 register.
v2:
- Fix inverted mask application when updating ICL_DPCLKA_CFGCR0
- Checkpatch style fixes
Bspec: 50287
--- drivers/gpu/drm/i915/display/intel_ddi.c | 18 +++++++++++++++--- drivers/gpu/drm/i915/display/intel_display.c | 15 ++++++++++++--- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ 3 files changed, 33 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +15 -3
@@ -2845,7 +2845,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp)static u32 icl_dpclka_cfgcr0_clk_off (struct drm_i915_private *dev_priv,enum phy phy) { -if (intel_phy_is_combo (dev_priv, phy)) { +if (IS_ROCKETLAKE (dev_priv)) { +return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF (phy); + }else if (intel_phy_is_combo (dev_priv, phy)) {return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF (phy); }else if (intel_phy_is_tc (dev_priv, phy)) { enum tc_port tc_port = intel_port_to_tc(dev_priv,
@@ -2872,6 +2874,16 @@ static void icl_map_plls_to_ports(struct intel_encoder *encoder, (val & icl_dpclka_cfgcr0_clk_off(dev_priv, phy)) == 0);if (intel_phy_is_combo (dev_priv, phy)) { +u32 mask, sel; + +if (IS_ROCKETLAKE (dev_priv)) { + mask =RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); + sel =RKL_DPCLKA_CFGCR0_DDI_CLK_SEL (pll->info->id, phy); + }else { + mask =ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); + sel =ICL_DPCLKA_CFGCR0_DDI_CLK_SEL (pll->info->id, phy); + } +/* * Even though this register references DDIs, note that we * want to pass the PHY rather than the port (DDI). For
@@ -2882,8 +2894,8 @@ static void icl_map_plls_to_ports(struct intel_encoder *encoder,* Clock Select chooses the PLL for both DDIA and DDID and * drives port A in all cases." */ - val &= ~ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); - val |=ICL_DPCLKA_CFGCR0_DDI_CLK_SEL (pll->info->id, phy); + val &= ~mask; + val |= sel;intel_de_write (dev_priv,ICL_DPCLKA_CFGCR0 , val);intel_de_posting_read (dev_priv,ICL_DPCLKA_CFGCR0 ); }
drivers/gpu/drm/i915/display/intel_display.c +12 -3
@@ -10802,9 +10802,18 @@ static void icl_get_ddi_pll(struct drm_i915_private *dev_priv, enum port port,u32 temp;if (intel_phy_is_combo (dev_priv, phy)) { - temp =intel_de_read (dev_priv,ICL_DPCLKA_CFGCR0 ) & -ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); - id = temp >>ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT (phy); +u32 mask, shift; + +if (IS_ROCKETLAKE (dev_priv)) { + mask =RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); + shift =RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT (phy); + }else { + mask =ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy); + shift =ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT (phy); + } + + temp =intel_de_read (dev_priv,ICL_DPCLKA_CFGCR0 ) & mask; + id = temp >> shift; port_dpll_id =ICL_PORT_DPLL_DEFAULT ; }else if (intel_phy_is_tc (dev_priv, phy)) {u32 clk_sel =intel_de_read (dev_priv,DDI_CLK_SEL (port)) &DDI_CLK_SEL_MASK ;
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -10279,12 +10279,18 @@ enum skl_power_gate {#define ICL_DPCLKA_CFGCR0 _MMIO(0x164280)#define ICL_DPCLKA_CFGCR0_DDI_CLK_OFF (phy) (1 << _PICK(phy, 10, 11, 24)) +#define RKL_DPCLKA_CFGCR0_DDI_CLK_OFF (phy) REG_BIT((phy) + 10)#define ICL_DPCLKA_CFGCR0_TC_CLK_OFF (tc_port) (1 << ((tc_port) < PORT_TC4 ? \ (tc_port) + 12 : \ (tc_port) - PORT_TC4 + 21))#define ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT (phy) ((phy) * 2)#define ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy) (3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))#define ICL_DPCLKA_CFGCR0_DDI_CLK_SEL (pll, phy) ((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)) +#define RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT (phy) _PICK(phy, 0, 2, 4, 27) +#define RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK (phy) \ + (3 << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy)) +#define RKL_DPCLKA_CFGCR0_DDI_CLK_SEL (pll, phy) \ + ((pll) << RKL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))/* CNL PLL */ #define DPLL0_ENABLE 0x46010
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 2/5 drm/i915/rkl: Add initial workarounds
In reply to Matt RoperRKL and TGL share some general gen12 workarounds, but each platform also has its own platform-specific workarounds.
v2:
- Add Wa_1604555607 for RKL. This makes RKL's ctx WA list identical to TGL's, so we'll have both functions call the tgl_ function for now; this workaround isn't listed for DG1 so we don't want to add it to the general gen12_ function.
--- drivers/gpu/drm/i915/display/intel_sprite.c | 5 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 89 +++++++++++++-------- 2 files changed, 60 insertions(+), 34 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +3 -2
@@ -2843,8 +2843,9 @@ static bool skl_plane_format_mod_supported(struct drm_plane *_plane,static bool gen12_plane_supports_mc_ccs (struct drm_i915_private *dev_priv,enum plane_id plane_id) { -/* Wa_14010477008:tgl[a0..c0] */ -if (IS_TGL_REVID (dev_priv,TGL_REVID_A0 ,TGL_REVID_C0 )) +/* Wa_14010477008:tgl[a0..c0],rkl[all] */ +if (IS_ROCKETLAKE (dev_priv) || +IS_TGL_REVID (dev_priv,TGL_REVID_A0 ,TGL_REVID_C0 ))return false;return plane_id <PLANE_SPRITE4 ;
drivers/gpu/drm/i915/gt/intel_workarounds.c +57 -32
162 lines not on this page · raw message
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 3/5 drm/i915/rkl: Add DPLL4 support
In reply to Matt RoperRocket Lake has a third DPLL (called 'DPLL4') that must be used to enable a third display. Unlike EHL's variant of DPLL4, the RKL variant behaves the same as DPLL0/1. And despite its name, the DPLL4 registers are offset as if it were DPLL2.
v2:
- Add new .update_ref_clks() hook.
v3:
- Renumber TBT PLL to '3' and switch _MMIO_PLL3 to _MMIO_PLL (Lucas)
v4:
- Don't drop _MMIO_PLL3; although it's now unused, we're going to need it very soon again for upcoming DG1 patches. (Lucas)
v5:
- Don't re-number TBT PLL and beyond, just use new RKL_DPLL_CFGCR macros to lookup the proper registers instead. Although renumbering the PLLs might be something we want to consider down the road, it opens a big can of worms right now since a bunch of places in the code have an assumption that the PLL table has idx==id and no holes. Renumbering creates a hole for TGL, so we'd either need to allow holes in the table or break the idx==id invariant, both of which are somewhat invasive changes to the design.
Bspec: 49202
Bspec: 49443
Bspec: 50288
Bspec: 50289
--- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 41 ++++++++++++++++--- drivers/gpu/drm/i915/i915_reg.h | 6 ++- 2 files changed, 40 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +36 -5
@@ -3504,13 +3504,19 @@ static bool icl_get_combo_phy_dpll(struct intel_atomic_state *state,icl_calc_dpll_state (dev_priv, &pll_params, &port_dpll->hw_state); -if (IS_ELKHARTLAKE (dev_priv) && port !=PORT_A ) +if (IS_ROCKETLAKE (dev_priv)) { dpll_mask =BIT (DPLL_ID_EHL_DPLL4 ) |BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); -else + }else if (IS_ELKHARTLAKE (dev_priv) && port !=PORT_A ) { + dpll_mask = +BIT (DPLL_ID_EHL_DPLL4 ) | +BIT (DPLL_ID_ICL_DPLL1 ) | +BIT (DPLL_ID_ICL_DPLL0 ); + }else { dpll_mask =BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); + } port_dpll->pll = intel_find_shared_dpll(state, crtc, &port_dpll->hw_state,
@@ -3791,7 +3797,12 @@ static bool icl_pll_get_hw_state(struct drm_i915_private *dev_priv,if (!(val &PLL_ENABLE )) goto out; -if (INTEL_GEN (dev_priv) >=12 ) { +if (IS_ROCKETLAKE (dev_priv)) { + hw_state->cfgcr0 =intel_de_read (dev_priv, +RKL_DPLL_CFGCR0 (id)); + hw_state->cfgcr1 =intel_de_read (dev_priv, +RKL_DPLL_CFGCR1 (id)); + }else if (INTEL_GEN (dev_priv) >=12 ) { hw_state->cfgcr0 =intel_de_read (dev_priv,TGL_DPLL_CFGCR0 (id)); hw_state->cfgcr1 = intel_de_read(dev_priv,
@@ -3844,7 +3855,10 @@ static void icl_dpll_write(struct drm_i915_private *dev_priv,const enum intel_dpll_id id = pll->info->id;i915_reg_t cfgcr0_reg, cfgcr1_reg; -if (INTEL_GEN (dev_priv) >=12 ) { +if (IS_ROCKETLAKE (dev_priv)) { + cfgcr0_reg =RKL_DPLL_CFGCR0 (id); + cfgcr1_reg =RKL_DPLL_CFGCR1 (id); + }else if (INTEL_GEN (dev_priv) >=12 ) { cfgcr0_reg =TGL_DPLL_CFGCR0 (id); cfgcr1_reg =TGL_DPLL_CFGCR1 (id); }else {
@@ -4276,6 +4290,21 @@ static const struct intel_dpll_mgr tgl_pll_mgr = { .dump_hw_state = icl_dump_hw_state, }; +static const struct dpll_info rkl_plls[] = { + {"DPLL 0" , &combo_pll_funcs,DPLL_ID_ICL_DPLL0 ,0 }, + {"DPLL 1" , &combo_pll_funcs,DPLL_ID_ICL_DPLL1 ,0 }, + {"DPLL 4" , &combo_pll_funcs,DPLL_ID_EHL_DPLL4 ,0 }, + { }, +}; + +static const struct intel_dpll_mgr rkl_pll_mgr = { + .dpll_info = rkl_plls, + .get_dplls = icl_get_dplls, + .put_dplls = icl_put_dplls, + .update_ref_clks = icl_update_dpll_ref_clks, + .dump_hw_state = icl_dump_hw_state, +}; +/** * intel_shared_dpll_init - Initialize shared DPLLs * @dev: drm device
@@ -4289,7 +4318,9 @@ void intel_shared_dpll_init(struct drm_device *dev)const struct dpll_info *dpll_info;int i; -if (INTEL_GEN (dev_priv) >=12 ) +if (IS_ROCKETLAKE (dev_priv)) + dpll_mgr = &rkl_pll_mgr; +else if (INTEL_GEN (dev_priv) >=12 ) dpll_mgr = &tgl_pll_mgr;else if (IS_ELKHARTLAKE (dev_priv)) dpll_mgr = &ehl_pll_mgr;
drivers/gpu/drm/i915/i915_reg.h +4 -2
@@ -10511,19 +10511,21 @@ enum skl_power_gate {#define _TGL_DPLL0_CFGCR0 0x164284#define _TGL_DPLL1_CFGCR0 0x16428C -/* TODO: add DPLL4 */ #define _TGL_TBTPLL_CFGCR0 0x16429C#define TGL_DPLL_CFGCR0 (pll) _MMIO_PLL3(pll, _TGL_DPLL0_CFGCR0, \ _TGL_DPLL1_CFGCR0, \ _TGL_TBTPLL_CFGCR0) +#define RKL_DPLL_CFGCR0 (pll) _MMIO_PLL(pll, _TGL_DPLL0_CFGCR0, \ + _TGL_DPLL1_CFGCR0)#define _TGL_DPLL0_CFGCR1 0x164288#define _TGL_DPLL1_CFGCR1 0x164290 -/* TODO: add DPLL4 */ #define _TGL_TBTPLL_CFGCR1 0x1642A0#define TGL_DPLL_CFGCR1 (pll) _MMIO_PLL3(pll, _TGL_DPLL0_CFGCR1, \ _TGL_DPLL1_CFGCR1, \ _TGL_TBTPLL_CFGCR1) +#define RKL_DPLL_CFGCR1 (pll) _MMIO_PLL(pll, _TGL_DPLL0_CFGCR1, \ + _TGL_DPLL1_CFGCR1)#define _DKL_PHY1_BASE 0x168000#define _DKL_PHY2_BASE 0x169000
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v8 3/5] drm/i915/rkl: Add DPLL4 support
Quoted 25 lines · Matt Roper
Rocket Lake has a third DPLL (called 'DPLL4') that must be used to enable a third display. Unlike EHL's variant of DPLL4, the RKL variant behaves the same as DPLL0/1. And despite its name, the DPLL4 registers are offset as if it were DPLL2.
v2:
- Add new .update_ref_clks() hook.v3:
- Renumber TBT PLL to '3' and switch_MMIO_PLL3to_MMIO_PLL(Lucas)v4:
- Don't drop_MMIO_PLL3; although it's now unused, we're going to need it very soon again for upcoming DG1 patches. (Lucas)v5:
- Don't re-number TBT PLL and beyond, just use newRKL_DPLL_CFGCRmacros to lookup the proper registers instead. Although renumbering the PLLs might be something we want to consider down the road, it opens a big can of worms right now since a bunch of places in the code have an assumption that the PLL table has idx==id and no holes. Renumbering creates a hole for TGL, so we'd either need to allow holes in the table or break the idx==id invariant, both of which are somewhat invasive changes to the design.
Quoted 7 lines
Bspec: 49202
Bspec: 49443
Bspec: 50288
Bspec: 50289Cc Lucas De Marchi <[email protected]>Cc José Roberto de Souza <[email protected]>Signed-off-by Matt Roper <[email protected]>
Lucas De Marchi
Quoted 125 lines
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c| 41 ++++++++++++++++---drivers/gpu/drm/i915/i915_reg.h| 6 ++-2 files changed, 40 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_dpll_mgr.c +36
-5@@ -3504,13 +3504,19 @@ static bool icl_get_combo_phy_dpll(struct intel_atomic_state *state,icl_calc_dpll_state (dev_priv, &pll_params, &port_dpll->hw_state); -if (IS_ELKHARTLAKE (dev_priv) && port !=PORT_A ) +if (IS_ROCKETLAKE (dev_priv)) { dpll_mask =BIT (DPLL_ID_EHL_DPLL4 ) |BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); -else + }else if (IS_ELKHARTLAKE (dev_priv) && port !=PORT_A ) { + dpll_mask = +BIT (DPLL_ID_EHL_DPLL4 ) | +BIT (DPLL_ID_ICL_DPLL1 ) | +BIT (DPLL_ID_ICL_DPLL0 ); + }else { dpll_mask =BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); + } port_dpll->pll = intel_find_shared_dpll(state, crtc, &port_dpll->hw_state,@@ -3791,7 +3797,12 @@ static bool icl_pll_get_hw_state(struct drm_i915_private *dev_priv,if (!(val &PLL_ENABLE )) goto out; -if (INTEL_GEN (dev_priv) >=12 ) { +if (IS_ROCKETLAKE (dev_priv)) { + hw_state->cfgcr0 =intel_de_read (dev_priv, +RKL_DPLL_CFGCR0 (id)); + hw_state->cfgcr1 =intel_de_read (dev_priv, +RKL_DPLL_CFGCR1 (id)); + }else if (INTEL_GEN (dev_priv) >=12 ) { hw_state->cfgcr0 =intel_de_read (dev_priv,TGL_DPLL_CFGCR0 (id)); hw_state->cfgcr1 = intel_de_read(dev_priv,@@ -3844,7 +3855,10 @@ static void icl_dpll_write(struct drm_i915_private *dev_priv,const enum intel_dpll_id id = pll->info->id;i915_reg_t cfgcr0_reg, cfgcr1_reg; -if (INTEL_GEN (dev_priv) >=12 ) { +if (IS_ROCKETLAKE (dev_priv)) { + cfgcr0_reg =RKL_DPLL_CFGCR0 (id); + cfgcr1_reg =RKL_DPLL_CFGCR1 (id); + }else if (INTEL_GEN (dev_priv) >=12 ) { cfgcr0_reg =TGL_DPLL_CFGCR0 (id); cfgcr1_reg =TGL_DPLL_CFGCR1 (id); }else {@@ -4276,6 +4290,21 @@ static const struct intel_dpll_mgr tgl_pll_mgr = { .dump_hw_state = icl_dump_hw_state, }; +static const struct dpll_info rkl_plls[] = { + {"DPLL 0" , &combo_pll_funcs,DPLL_ID_ICL_DPLL0 ,0 }, + {"DPLL 1" , &combo_pll_funcs,DPLL_ID_ICL_DPLL1 ,0 }, + {"DPLL 4" , &combo_pll_funcs,DPLL_ID_EHL_DPLL4 ,0 }, + { }, +}; + +static const struct intel_dpll_mgr rkl_pll_mgr = { + .dpll_info = rkl_plls, + .get_dplls = icl_get_dplls, + .put_dplls = icl_put_dplls, + .update_ref_clks = icl_update_dpll_ref_clks, + .dump_hw_state = icl_dump_hw_state, +}; +/** * intel_shared_dpll_init - Initialize shared DPLLs * @dev: drm device @@ -4289,7 +4318,9 @@ void intel_shared_dpll_init(struct drm_device *dev)const struct dpll_info *dpll_info;int i; -if (INTEL_GEN (dev_priv) >=12 ) +if (IS_ROCKETLAKE (dev_priv)) + dpll_mgr = &rkl_pll_mgr; +else if (INTEL_GEN (dev_priv) >=12 ) dpll_mgr = &tgl_pll_mgr;else if (IS_ELKHARTLAKE (dev_priv)) dpll_mgr = &ehl_pll_mgr;drivers/gpu/drm/i915/i915_reg.h +4
-2@@ -10511,19 +10511,21 @@ enum skl_power_gate {#define _TGL_DPLL0_CFGCR0 0x164284#define _TGL_DPLL1_CFGCR0 0x16428C -/* TODO: add DPLL4 */ #define _TGL_TBTPLL_CFGCR0 0x16429C#define TGL_DPLL_CFGCR0 (pll) _MMIO_PLL3(pll, _TGL_DPLL0_CFGCR0, \ _TGL_DPLL1_CFGCR0, \ _TGL_TBTPLL_CFGCR0) +#define RKL_DPLL_CFGCR0 (pll) _MMIO_PLL(pll, _TGL_DPLL0_CFGCR0, \ + _TGL_DPLL1_CFGCR0)#define _TGL_DPLL0_CFGCR1 0x164288#define _TGL_DPLL1_CFGCR1 0x164290 -/* TODO: add DPLL4 */ #define _TGL_TBTPLL_CFGCR1 0x1642A0#define TGL_DPLL_CFGCR1 (pll) _MMIO_PLL3(pll, _TGL_DPLL0_CFGCR1, \ _TGL_DPLL1_CFGCR1, \ _TGL_TBTPLL_CFGCR1) +#define RKL_DPLL_CFGCR1 (pll) _MMIO_PLL(pll, _TGL_DPLL0_CFGCR1, \ + _TGL_DPLL1_CFGCR1)#define _DKL_PHY1_BASE 0x168000#define _DKL_PHY2_BASE 0x169000Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 4/5 drm/i915/rkl: Handle HTI
In reply to Matt RoperIf HTI (also sometimes called HDPORT) is enabled at startup, it may be using some of the PHYs and DPLLs making them unavailable for general usage. Let's read out the HDPORT_STATE register and avoid making use of resources that HTI is already using.
v2:
- Fix minor checkpatch warnings
v3:
- Just readout HDPORT_STATE register once during init and then parse it later as needed.
- Add a 'has_hti' device info flag to track whether we should readout HDPORT_STATE or not. We can skip the platform/flag tests later since the hti_state in dev_priv will remain 0 for platforms it does not apply to.
- Move PLL masking into icl_get_combo_phy_dpll() since at the moment RKL is the only platform that has HTI. (Jose)
Bspec: 49189
Bspec: 53707
--- drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 8 ++++++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 11 +++++++++++ drivers/gpu/drm/i915/i915_drv.h | 8 ++++++++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 7 files changed, 54 insertions(+)
drivers/gpu/drm/i915/display/intel_ddi.c +19 -0
@@ -4923,6 +4923,13 @@ intel_ddi_max_lanes(struct intel_digital_port *dig_port)return max_lanes; } +static bool hti_uses_phy (struct drm_i915_private *i915,enum phy phy) +{ +return i915->hti_state &HDPORT_ENABLED && + (i915->hti_state &HDPORT_PHY_USED_DP (phy) || + i915->hti_state &HDPORT_PHY_USED_HDMI (phy)); +} +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port) {struct intel_digital_port *dig_port;
@@ -4930,6 +4937,18 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)bool init_hdmi, init_dp, init_lspcon = false;enum phy phy =intel_port_to_phy (dev_priv, port); +/* +* On platforms with HTI (aka HDPORT), if it's enabled at boot it may +* have taken over some of the PHYs and made them unavailable to the +* driver. In that case we should skip initializing the corresponding +* outputs. +*/ +if (hti_uses_phy (dev_priv, phy)) { +drm_dbg_kms (&dev_priv->drm,"PORT %c / PHY %c reserved by HTI\n" , +port_name (port),phy_name (phy)); +return ; + } + init_hdmi =intel_bios_port_supports_dvi (dev_priv, port) ||intel_bios_port_supports_hdmi (dev_priv, port); init_dp =intel_bios_port_supports_dp (dev_priv, port);
drivers/gpu/drm/i915/display/intel_display.c +8 -0
@@ -47,6 +47,7 @@#include "display/intel_ddi.h" #include "display/intel_dp.h" #include "display/intel_dp_mst.h" +#include "display/intel_dpll_mgr.h" #include "display/intel_dsi.h" #include "display/intel_dvo.h" #include "display/intel_gmbus.h"
@@ -17903,6 +17904,13 @@ int intel_modeset_init(struct drm_i915_private *i915)if (i915->max_cdclk_freq ==0 )intel_update_max_cdclk (i915); +/* +* If the platform has HTI, we need to find out whether it has reserved +* any display resources before we create our display outputs. +*/ +if (INTEL_INFO (i915)->display.has_hti) + i915->hti_state =intel_de_read (i915,HDPORT_STATE ); +/* Just disable it once at startup */ intel_vga_disable (i915);intel_setup_outputs (i915);
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +11 -0
@@ -3475,6 +3475,14 @@ static void icl_update_active_dpll(struct intel_atomic_state *state,icl_set_active_port_dpll (crtc_state, port_dpll_id); } +static u32 intel_get_hti_plls (struct drm_i915_private *i915) +{ +if (!(i915->hti_state &HDPORT_ENABLED )) +return 0 ; + +return REG_FIELD_GET (HDPORT_DPLL_USED_MASK , i915->hti_state); +} +static bool icl_get_combo_phy_dpll (struct intel_atomic_state *state,struct intel_crtc *crtc,struct intel_encoder *encoder)
@@ -3518,6 +3526,9 @@ static bool icl_get_combo_phy_dpll(struct intel_atomic_state *state, dpll_mask =BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); } +/* Eliminate DPLLs from consideration if reserved by HTI */ + dpll_mask &= ~intel_get_hti_plls (dev_priv); + port_dpll->pll =intel_find_shared_dpll (state, crtc, &port_dpll->hw_state, dpll_mask);
drivers/gpu/drm/i915/i915_drv.h +8 -0
@@ -1044,6 +1044,14 @@ struct drm_i915_private {struct intel_l3_parity l3_parity; +/* +* HTI (aka HDPORT) state read during initial hw readout. Most +* platforms don't have HTI, so this will just stay 0. Those that do +* will use this later to figure out which PLLs and PHYs are unavailable +* for driver usage. +*/ +u32 hti_state; +/* * edram size in MB. * Cannot be determined by PCIID. You must always read a register.
drivers/gpu/drm/i915/i915_pci.c +1 -0
@@ -890,6 +890,7 @@ static const struct intel_device_info rkl_info = { .cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), .require_force_probe = 1, + .display.has_hti = 1, .display.has_psr_hw_tracking = 0, .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0),
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -2921,6 +2921,12 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define MBUS_BBOX_CTL_S1 _MMIO(0x45040)#define MBUS_BBOX_CTL_S2 _MMIO(0x45044) +#define HDPORT_STATE _MMIO(0x45050) +#define HDPORT_DPLL_USED_MASK REG_GENMASK(14, 12) +#define HDPORT_PHY_USED_DP (phy) REG_BIT(2 * (phy) + 2) +#define HDPORT_PHY_USED_HDMI (phy) REG_BIT(2 * (phy) + 1) +#define HDPORT_ENABLED REG_BIT(0) +/* Make render/texture TLB fetches lower priorty than associated data * fetches. This is not turned on by default */
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -146,6 +146,7 @@ enum intel_ppgtt_type {func (has_gmch); \func (has_hdcp); \func (has_hotplug); \ +func (has_hti); \func (has_ipc); \func (has_modular_fia); \func (has_overlay); \
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v8 4/5] drm/i915/rkl: Handle HTI
Quoted 8 lines · Matt Roper
If HTI (also sometimes called HDPORT) is enabled at startup, it may be using some of the PHYs and DPLLs making them unavailable for general usage. Let's read out the
HDPORT_STATEregister and avoid making use of resources that HTI is already using.v2:
- Fix minor checkpatch warnings
Quoted 10 lines
v3:
- Just readoutHDPORT_STATEregister once during init and then parse it later as needed.
- Add a 'has_hti' device info flag to track whether we should readoutHDPORT_STATEor not. We can skip the platform/flag tests later since thehti_stateindev_privwill remain 0 for platforms it does not apply to.
- Move PLL masking intoicl_get_combo_phy_dpll()since at the moment RKL is the only platform that has HTI. (Jose)
Quoted 160 lines
Bspec: 49189
Bspec: 53707Cc Lucas De Marchi <[email protected]>Cc José Roberto de Souza <[email protected]>Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/i915/display/intel_ddi.c | 19 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_display.c | 8 ++++++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 11 +++++++++++ drivers/gpu/drm/i915/i915_drv.h | 8 ++++++++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 7 files changed, 54 insertions(+)drivers/gpu/drm/i915/display/intel_ddi.c +19
-0@@ -4923,6 +4923,13 @@ intel_ddi_max_lanes(struct intel_digital_port *dig_port)return max_lanes; } +static bool hti_uses_phy (struct drm_i915_private *i915,enum phy phy) +{ +return i915->hti_state &HDPORT_ENABLED && + (i915->hti_state &HDPORT_PHY_USED_DP (phy) || + i915->hti_state &HDPORT_PHY_USED_HDMI (phy)); +} +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port) {struct intel_digital_port *dig_port;@@ -4930,6 +4937,18 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)bool init_hdmi, init_dp, init_lspcon = false;enum phy phy =intel_port_to_phy (dev_priv, port); +/* +* On platforms with HTI (aka HDPORT), if it's enabled at boot it may +* have taken over some of the PHYs and made them unavailable to the +* driver. In that case we should skip initializing the corresponding +* outputs. +*/ +if (hti_uses_phy (dev_priv, phy)) { +drm_dbg_kms (&dev_priv->drm,"PORT %c / PHY %c reserved by HTI\n" , +port_name (port),phy_name (phy)); +return ; + } + init_hdmi =intel_bios_port_supports_dvi (dev_priv, port) ||intel_bios_port_supports_hdmi (dev_priv, port); init_dp =intel_bios_port_supports_dp (dev_priv, port);drivers/gpu/drm/i915/display/intel_display.c +8
-0@@ -47,6 +47,7 @@#include "display/intel_ddi.h" #include "display/intel_dp.h" #include "display/intel_dp_mst.h" +#include "display/intel_dpll_mgr.h" #include "display/intel_dsi.h" #include "display/intel_dvo.h" #include "display/intel_gmbus.h" @@ -17903,6 +17904,13 @@ int intel_modeset_init(struct drm_i915_private *i915)if (i915->max_cdclk_freq ==0 )intel_update_max_cdclk (i915); +/* +* If the platform has HTI, we need to find out whether it has reserved +* any display resources before we create our display outputs. +*/ +if (INTEL_INFO (i915)->display.has_hti) + i915->hti_state =intel_de_read (i915,HDPORT_STATE ); +/* Just disable it once at startup */ intel_vga_disable (i915);intel_setup_outputs (i915);drivers/gpu/drm/i915/display/intel_dpll_mgr.c +11
-0@@ -3475,6 +3475,14 @@ static void icl_update_active_dpll(struct intel_atomic_state *state,icl_set_active_port_dpll (crtc_state, port_dpll_id); } +static u32 intel_get_hti_plls (struct drm_i915_private *i915) +{ +if (!(i915->hti_state &HDPORT_ENABLED )) +return 0 ; + +return REG_FIELD_GET (HDPORT_DPLL_USED_MASK , i915->hti_state); +} +static bool icl_get_combo_phy_dpll (struct intel_atomic_state *state,struct intel_crtc *crtc,struct intel_encoder *encoder)@@ -3518,6 +3526,9 @@ static bool icl_get_combo_phy_dpll(struct intel_atomic_state *state, dpll_mask =BIT (DPLL_ID_ICL_DPLL1 ) |BIT (DPLL_ID_ICL_DPLL0 ); } +/* Eliminate DPLLs from consideration if reserved by HTI */ + dpll_mask &= ~intel_get_hti_plls (dev_priv); + port_dpll->pll =intel_find_shared_dpll (state, crtc, &port_dpll->hw_state, dpll_mask);drivers/gpu/drm/i915/i915_drv.h +8
-0@@ -1044,6 +1044,14 @@ struct drm_i915_private {struct intel_l3_parity l3_parity; +/* +* HTI (aka HDPORT) state read during initial hw readout. Most +* platforms don't have HTI, so this will just stay 0. Those that do +* will use this later to figure out which PLLs and PHYs are unavailable +* for driver usage. +*/ +u32 hti_state; +/* * edram size in MB. * Cannot be determined by PCIID. You must always read a register. drivers/gpu/drm/i915/i915_pci.c +1
-0@@ -890,6 +890,7 @@ static const struct intel_device_info rkl_info = { .cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C), .require_force_probe = 1, + .display.has_hti = 1, .display.has_psr_hw_tracking = 0, .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0),drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -2921,6 +2921,12 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define MBUS_BBOX_CTL_S1 _MMIO(0x45040)#define MBUS_BBOX_CTL_S2 _MMIO(0x45044) +#define HDPORT_STATE _MMIO(0x45050) +#define HDPORT_DPLL_USED_MASK REG_GENMASK(14, 12) +#define HDPORT_PHY_USED_DP (phy) REG_BIT(2 * (phy) + 2) +#define HDPORT_PHY_USED_HDMI (phy) REG_BIT(2 * (phy) + 1) +#define HDPORT_ENABLED REG_BIT(0) +/* Make render/texture TLB fetches lower priorty than associated data * fetches. This is not turned on by default */ drivers/gpu/drm/i915/intel_device_info.h +0
-0
drivers/gpu/drm/i915/intel_device_info.h enum intel_ppgtt_type { · line 152
Quoted 7 lines
drivers/gpu/drm/i915/intel_device_info.h +1
-0@@ -146,6 +146,7 @@ enum intel_ppgtt_type {func (has_gmch); \func (has_hdcp); \func (has_hotplug); \ +func (has_hti); \func (has_ipc); \func (has_modular_fia); \func (has_overlay); \
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [Intel-gfx] [PATCH v8 4/5] drm/i915/rkl: Handle HTI
In reply to Matt Roperdrivers/gpu/drm/i915/display/intel_display.c int intel_modeset_init(struct drm_i915_private *i915) · line 17913
Quoted 11 lines · Matt Roper
drivers/gpu/drm/i915/display/intel_display.c +7
-0@@ -17903,6 +17904,13 @@ int intel_modeset_init(struct drm_i915_private *i915)if (i915->max_cdclk_freq ==0 )intel_update_max_cdclk (i915); +/* +* If the platform has HTI, we need to find out whether it has reserved +* any display resources before we create our display outputs. +*/ +if (INTEL_INFO (i915)->display.has_hti) + i915->hti_state =intel_de_read (i915,HDPORT_STATE ); +
Just stumbled upon this in code.
This is supposed to be a high level modeset init function, and basically anything doing direct register access here is at a completely wrong abstraction layer. Please fix.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v8 5/5 drm/i915/rkl: Add Wa_14011224835 for PHY B initialization
In reply to Matt RoperAfter doing normal PHY-B initialization on Rocket Lake, we need to manually copy some additional PHY-A register values into PHY-B registers.
Note that the bspec's combo phy page doesn't specify that this workaround is restricted to specific platform steppings (and doesn't even do a very good job of specifying that RKL is the only platform this is needed on), but the RKL workaround page lists this as relevant only for A and B steppings, so I'm trusting that information for now.
v2: Make rkl_combo_phy_b_init_wa() static
v3:
- Minimize variables in WA function. (Jose)
- Fix timeout duration (usec vs msec). (Jose)
- Add verification of workaround. (Jose)
- Fix stepping bounds in comment.
Bspec: 49291
Bspec: 53273
--- .../gpu/drm/i915/display/intel_combo_phy.c | 50 +++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 13 ++++- 2 files changed, 62 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_combo_phy.c +50 -0
@@ -255,6 +255,26 @@ static bool phy_is_master(struct drm_i915_private *dev_priv, enum phy phy)return phy ==PHY_A ; } +static bool verify_wa14011224835 (struct drm_i915_private *i915) +{ +u32 grccode, val; +bool ret = true; + + grccode =REG_FIELD_GET (GRCCODE , +intel_de_read (i915,ICL_PORT_COMP_DW6 (PHY_A ))); + val =REG_FIELD_PREP (IREF_RCAL_ORD , grccode); + ret &=check_phy_reg (i915,PHY_B ,ICL_PORT_COMP_DW2 (PHY_B ), +IREF_RCAL_ORD , val); + + grccode =REG_FIELD_GET (GRCCODE_LDO , +intel_de_read (i915,ICL_PORT_COMP_DW0 (PHY_A ))); + val =REG_FIELD_PREP (RCOMPCODE_LD_CAP_OV , grccode); + ret &=check_phy_reg (i915,PHY_B ,ICL_PORT_COMP_DW2 (PHY_B ), +IREF_RCAL_ORD , val); + +return ret; +} +static bool icl_combo_phy_verify_state (struct drm_i915_private *dev_priv,enum phy phy) {
@@ -295,6 +315,11 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv, ret &=check_phy_reg (dev_priv, phy,ICL_PORT_CL_DW5 (phy),CL_POWER_DOWN_ENABLE ,CL_POWER_DOWN_ENABLE ); +/* Wa_14011224835:rkl[a0..b0] */ +if (IS_RKL_REVID (dev_priv,RKL_REVID_A0 ,RKL_REVID_B0 ) && + phy ==PHY_B ) + ret &=verify_wa14011224835 (dev_priv); +return ret; }
@@ -350,6 +375,26 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,intel_de_write (dev_priv,ICL_PORT_CL_DW10 (phy), val); } +static void rkl_combo_phy_b_init_wa (struct drm_i915_private *i915) +{ +u32 grccode, val; + +wait_for_us (intel_de_read (i915,ICL_PORT_COMP_DW3 (PHY_A )) & +FIRST_COMP_DONE ,100 ); + + grccode =REG_FIELD_GET (GRCCODE , +intel_de_read (i915,ICL_PORT_COMP_DW6 (PHY_A ))); + val =REG_FIELD_PREP (IREF_RCAL_ORD , grccode); +intel_de_rmw (i915,ICL_PORT_COMP_DW2 (PHY_B ),IREF_RCAL_ORD , + val |IREF_RCAL_ORD_EN ); + + grccode =REG_FIELD_GET (GRCCODE_LDO , +intel_de_read (i915,ICL_PORT_COMP_DW0 (PHY_A ))); + val =REG_FIELD_PREP (RCOMPCODE_LD_CAP_OV , grccode); +intel_de_rmw (i915,ICL_PORT_COMP_DW6 (PHY_B ),RCOMPCODE_LD_CAP_OV , + val |RCOMPCODEOVEN_LDO_SYNC ); +} +static void icl_combo_phys_init (struct drm_i915_private *dev_priv) {enum phy phy;
@@ -415,6 +460,11 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv) val =intel_de_read (dev_priv,ICL_PORT_CL_DW5 (phy)); val |=CL_POWER_DOWN_ENABLE ;intel_de_write (dev_priv,ICL_PORT_CL_DW5 (phy), val); + +if (IS_RKL_REVID (dev_priv,RKL_REVID_A0 ,RKL_REVID_B0 ) && + phy ==PHY_B ) +/* Wa_14011224835:rkl[a0..b0] */ +rkl_combo_phy_b_init_wa (dev_priv); } }
drivers/gpu/drm/i915/i915_reg.h +12 -1
@@ -1911,11 +1911,16 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define CNL_PORT_COMP_DW0 _MMIO(0x162100)#define ICL_PORT_COMP_DW0 (phy) _MMIO(_ICL_PORT_COMP_DW(0, phy)) -#define COMP_INIT (1 << 31) +#define COMP_INIT REG_BIT(31) +#define GRCCODE_LDO REG_GENMASK(7, 0)#define CNL_PORT_COMP_DW1 _MMIO(0x162104)#define ICL_PORT_COMP_DW1 (phy) _MMIO(_ICL_PORT_COMP_DW(1, phy)) +#define ICL_PORT_COMP_DW2 (phy) _MMIO(_ICL_PORT_COMP_DW(2, phy)) +#define IREF_RCAL_ORD_EN REG_BIT(7) +#define IREF_RCAL_ORD REG_GENMASK(6, 0) +#define CNL_PORT_COMP_DW3 _MMIO(0x16210c)#define ICL_PORT_COMP_DW3 (phy) _MMIO(_ICL_PORT_COMP_DW(3, phy))#define PROCESS_INFO_DOT_0 (0 << 26)
@@ -1928,6 +1933,12 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define VOLTAGE_INFO_1_05V (2 << 24)#define VOLTAGE_INFO_MASK (3 << 24)#define VOLTAGE_INFO_SHIFT 24 +#define FIRST_COMP_DONE REG_BIT(22) + +#define ICL_PORT_COMP_DW6 (phy) _MMIO(_ICL_PORT_COMP_DW(6, phy)) +#define GRCCODE REG_GENMASK(30, 24) +#define RCOMPCODEOVEN_LDO_SYNC REG_BIT(23) +#define RCOMPCODE_LD_CAP_OV REG_GENMASK(22, 16)#define ICL_PORT_COMP_DW8 (phy) _MMIO(_ICL_PORT_COMP_DW(8, phy))#define IREFGEN (1 << 24)
Signature · 6 lines
2.24.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v8 5/5] drm/i915/rkl: Add Wa_14011224835 for PHY B initialization
Quoted 10 lines · Matt Roper
After doing normal PHY-B initialization on Rocket Lake, we need to manually copy some additional PHY-A register values into PHY-B registers.
Note that the bspec's combo phy page doesn't specify that this workaround is restricted to specific platform steppings (and doesn't even do a very good job of specifying that RKL is the only platform this is needed on), but the RKL workaround page lists this as relevant only for A and B steppings, so I'm trusting that information for now.
Quoted 8 lines
v2: Make
rkl_combo_phy_b_init_wa()staticv3:
- Minimize variables in WA function. (Jose)
- Fix timeout duration (usec vs msec). (Jose)
- Add verification of workaround. (Jose)
- Fix stepping bounds in comment.
Quoted 116 lines
Bspec: 49291
Bspec: 53273Cc José Roberto de Souza <[email protected]>Signed-off-by Matt Roper <[email protected]>--- .../gpu/drm/i915/display/intel_combo_phy.c | 50 +++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 13 ++++- 2 files changed, 62 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_combo_phy.c +50
-0@@ -255,6 +255,26 @@ static bool phy_is_master(struct drm_i915_private *dev_priv, enum phy phy)return phy ==PHY_A ; } +static bool verify_wa14011224835 (struct drm_i915_private *i915) +{ +u32 grccode, val; +bool ret = true; + + grccode =REG_FIELD_GET (GRCCODE , +intel_de_read (i915,ICL_PORT_COMP_DW6 (PHY_A ))); + val =REG_FIELD_PREP (IREF_RCAL_ORD , grccode); + ret &=check_phy_reg (i915,PHY_B ,ICL_PORT_COMP_DW2 (PHY_B ), +IREF_RCAL_ORD , val); + + grccode =REG_FIELD_GET (GRCCODE_LDO , +intel_de_read (i915,ICL_PORT_COMP_DW0 (PHY_A ))); + val =REG_FIELD_PREP (RCOMPCODE_LD_CAP_OV , grccode); + ret &=check_phy_reg (i915,PHY_B ,ICL_PORT_COMP_DW2 (PHY_B ), +IREF_RCAL_ORD , val); + +return ret; +} +static bool icl_combo_phy_verify_state (struct drm_i915_private *dev_priv,enum phy phy) {@@ -295,6 +315,11 @@ static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv, ret &=check_phy_reg (dev_priv, phy,ICL_PORT_CL_DW5 (phy),CL_POWER_DOWN_ENABLE ,CL_POWER_DOWN_ENABLE ); +/* Wa_14011224835:rkl[a0..b0] */ +if (IS_RKL_REVID (dev_priv,RKL_REVID_A0 ,RKL_REVID_B0 ) && + phy ==PHY_B ) + ret &=verify_wa14011224835 (dev_priv); +return ret; }@@ -350,6 +375,26 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,intel_de_write (dev_priv,ICL_PORT_CL_DW10 (phy), val); } +static void rkl_combo_phy_b_init_wa (struct drm_i915_private *i915) +{ +u32 grccode, val; + +wait_for_us (intel_de_read (i915,ICL_PORT_COMP_DW3 (PHY_A )) & +FIRST_COMP_DONE ,100 ); + + grccode =REG_FIELD_GET (GRCCODE , +intel_de_read (i915,ICL_PORT_COMP_DW6 (PHY_A ))); + val =REG_FIELD_PREP (IREF_RCAL_ORD , grccode); +intel_de_rmw (i915,ICL_PORT_COMP_DW2 (PHY_B ),IREF_RCAL_ORD , + val |IREF_RCAL_ORD_EN ); + + grccode =REG_FIELD_GET (GRCCODE_LDO , +intel_de_read (i915,ICL_PORT_COMP_DW0 (PHY_A ))); + val =REG_FIELD_PREP (RCOMPCODE_LD_CAP_OV , grccode); +intel_de_rmw (i915,ICL_PORT_COMP_DW6 (PHY_B ),RCOMPCODE_LD_CAP_OV , + val |RCOMPCODEOVEN_LDO_SYNC ); +} +static void icl_combo_phys_init (struct drm_i915_private *dev_priv) {enum phy phy;@@ -415,6 +460,11 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv) val =intel_de_read (dev_priv,ICL_PORT_CL_DW5 (phy)); val |=CL_POWER_DOWN_ENABLE ;intel_de_write (dev_priv,ICL_PORT_CL_DW5 (phy), val); + +if (IS_RKL_REVID (dev_priv,RKL_REVID_A0 ,RKL_REVID_B0 ) && + phy ==PHY_B ) +/* Wa_14011224835:rkl[a0..b0] */ +rkl_combo_phy_b_init_wa (dev_priv); } }drivers/gpu/drm/i915/i915_reg.h +6
-1@@ -1911,11 +1911,16 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define CNL_PORT_COMP_DW0 _MMIO(0x162100)#define ICL_PORT_COMP_DW0 (phy) _MMIO(_ICL_PORT_COMP_DW(0, phy)) -#define COMP_INIT (1 << 31) +#define COMP_INIT REG_BIT(31) +#define GRCCODE_LDO REG_GENMASK(7, 0)#define CNL_PORT_COMP_DW1 _MMIO(0x162104)#define ICL_PORT_COMP_DW1 (phy) _MMIO(_ICL_PORT_COMP_DW(1, phy)) +#define ICL_PORT_COMP_DW2 (phy) _MMIO(_ICL_PORT_COMP_DW(2, phy)) +#define IREF_RCAL_ORD_EN REG_BIT(7) +#define IREF_RCAL_ORD REG_GENMASK(6, 0) +#define CNL_PORT_COMP_DW3 _MMIO(0x16210c)#define ICL_PORT_COMP_DW3 (phy) _MMIO(_ICL_PORT_COMP_DW(3, phy))#define PROCESS_INFO_DOT_0 (0 << 26)@@ -1928,6 +1933,12 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define VOLTAGE_INFO_1_05V (2 << 24)#define VOLTAGE_INFO_MASK (3 << 24)
drivers/gpu/drm/i915/i915_reg.h static inline bool i915_mmio_reg_valid(i915_reg_t reg) · line 1944
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0#define VOLTAGE_INFO_SHIFT 24 +#define FIRST_COMP_DONE REG_BIT(22) + +#define ICL_PORT_COMP_DW6 (phy) _MMIO(_ICL_PORT_COMP_DW(6, phy)) +#define GRCCODE REG_GENMASK(30, 24) +#define RCOMPCODEOVEN_LDO_SYNC REG_BIT(23) +#define RCOMPCODE_LD_CAP_OV REG_GENMASK(22, 16)#define ICL_PORT_COMP_DW8 (phy) _MMIO(_ICL_PORT_COMP_DW(8, phy))#define IREFGEN (1 << 24)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remaining RKL patches (rev7)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Remaining RKL patches (rev7)
URL : https://patchwork.freedesktop.org/series/77971/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Remaining RKL patches (rev7)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Remaining RKL patches (rev7)
URL : https://patchwork.freedesktop.org/series/77971/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8758 -> Patchwork_18197
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/index.html
Known issues
------------
Here are the changes found in Patchwork_18197 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-bsw-kefka/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-bsw-kefka/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][5] -> [DMESG-WARN][6] ([i915#62] / [i915#92] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-kbl-x1275/igt@kms_busy@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-y/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-icl-u2/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-icl-u2/igt@kms_flip@[email protected]
* igt@vgem_basic@dmabuf-fence-before:
- fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#402]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-y/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-dsi/igt@[email protected]
- fi-tgl-u2: [DMESG-WARN][15] ([i915#402]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6700k2: [INCOMPLETE][17] ([i915#151]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-skl-6700k2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-skl-6700k2/igt@[email protected]
* igt@i915_selftest@live@coherency:
- fi-gdg-551: [DMESG-FAIL][19] ([i915#1748]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-gdg-551/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-gdg-551/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@gt_lrc:
- fi-tgl-u2: [DMESG-FAIL][21] ([i915#1233]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [DMESG-WARN][23] ([i915#402]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-tgl-y/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-tgl-y/igt@[email protected]
* igt@vgem_basic@unload:
- fi-blb-e6850: [INCOMPLETE][25] -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-blb-e6850/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-blb-e6850/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [SKIP][27] ([fdo#109271]) -> [DMESG-FAIL][28] ([i915#62])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][29] ([i915#62] / [i915#92]) -> [DMESG-WARN][30] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-kbl-x1275/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-kbl-x1275/igt@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][31] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][32] ([i915#62] / [i915#92])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/fi-kbl-x1275/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/fi-kbl-x1275/igt@kms_flip@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8758 -> Patchwork_18197
CI-20190529: 20190529
CI_DRM_8758: b6738761bde03de00a1c84c6a85f9379f53f585c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18197: dfcce2d96955e0636baa8270decdc53ec3519ab2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dfcce2d96955 drm/i915/rkl: Add Wa_14011224835 for PHY B initialization 8cfb04468d86 drm/i915/rkl: Handle HTI31fbc2a9271c drm/i915/rkl: Add DPLL4 support8954a2f2cf54 drm/i915/rkl: Add initial workarounds c182e5c80066 drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Remaining RKL patches (rev7)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: Remaining RKL patches (rev7)
URL : https://patchwork.freedesktop.org/series/77971/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8758_full -> Patchwork_18197_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18197_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18197_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18197_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18197_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_userptr_blits@invalid-mmap-offset-unsync@gtt:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([i915#2119])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-iclb1/igt@gem_userptr_blits@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-iclb8/igt@gem_userptr_blits@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][5] -> [WARN][6] ([i915#1519])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw1/igt@[email protected]
* igt@i915_selftest@mock@requests:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([i915#2110])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw7/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-glk: [PASS][9] -> [DMESG-FAIL][10] ([i915#118] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk8/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#177] / [i915#52] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw1/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#2122])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl6/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#53])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-iclb7/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@crtc-id:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl1/igt@[email protected]
* igt@kms_vblank@pipe-a-query-forked-busy:
- shard-tglb: [PASS][33] -> [DMESG-WARN][34] ([i915#402]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb5/igt@[email protected]
* igt@kms_vblank@pipe-c-wait-busy-hang:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#1635] / [i915#1982]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][37] ([i915#118] / [i915#95]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk2/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl5/igt@[email protected]
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][41] ([i915#118] / [i915#95]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][43] ([i915#300]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl2/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-snb: [TIMEOUT][45] ([i915#1958] / [i915#2119]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
- shard-kbl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl4/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-apl: [DMESG-WARN][49] ([i915#1635] / [i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-tglb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][53] ([fdo#108145] / [i915#265]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl8/igt@[email protected]
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl1/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl6/igt@[email protected]
* igt@perf@blocking-parameterized:
- shard-tglb: [FAIL][59] ([i915#1542]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb2/igt@[email protected]
* igt@perf_pmu@busy-idle@rcs0:
- shard-snb: [FAIL][61] ([i915#1958]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@perf_pmu@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@perf_pmu@[email protected]
* igt@perf_pmu@busy-idle@vcs0:
- shard-snb: [INCOMPLETE][63] ([i915#2119] / [i915#82]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@perf_pmu@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@perf_pmu@[email protected]
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [TIMEOUT][65] ([i915#1958] / [i915#2119]) -> [FAIL][66] ([i915#1930])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]
* igt@kms_ccs@pipe-c-ccs-on-another-bo:
- shard-snb: [TIMEOUT][67] ([i915#1958] / [i915#2119]) -> [SKIP][68] ([fdo#109271]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]
* igt@runner@aborted:
- shard-hsw: [FAIL][69] ([i915#2110]) -> [FAIL][70] ([i915#1436] / [i915#2110])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@[email protected]
- shard-apl: ([FAIL][71], [FAIL][72], [FAIL][73]) ([i915#1610] / [i915#1635] / [i915#2110] / [i915#637]) -> [FAIL][74] ([i915#1635] / [i915#2110])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl7/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#637]: https://gitlab.freedesktop.org/drm/intel/issues/637
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8758 -> Patchwork_18197
CI-20190529: 20190529
CI_DRM_8758: b6738761bde03de00a1c84c6a85f9379f53f585c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18197: dfcce2d96955e0636baa8270decdc53ec3519ab2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Remaining RKL patches (rev7)
Quoted 30 lines · Patchwork
== Series Details ==
Series: Remaining RKL patches (rev7)
URL : https://patchwork.freedesktop.org/series/77971/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_8758_full->Patchwork_18197_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
Patchwork_18197_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_18197_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.Possible new issues
-------------------Here are the unknown changes that may have been introduced in
Patchwork_18197_full:
Quoted 8 lines
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl2/igt@[email protected]
It looks like this gen9 system just never came out of S3; that wouldn't have been caused by this series.
Patches applied to dinq. Thanks Jose and Lucas for the reviews.
Matt
Quoted 243 lines
Known issues
------------Here are the changes found in
Patchwork_18197_fullthat come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_userptr_blits@invalid-mmap-offset-unsync@gtt:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([i915#2119])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-iclb1/igt@gem_userptr_blits@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-iclb8/igt@gem_userptr_blits@[email protected]* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][5] -> [WARN][6] ([i915#1519])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw1/igt@[email protected]* igt@i915_selftest@mock@requests:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([i915#2110])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw7/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@i915_selftest@[email protected]* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-glk: [PASS][9] -> [DMESG-FAIL][10] ([i915#118] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk8/igt@[email protected]* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#177] / [i915#52] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw1/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@kms_flip@[email protected]* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#2122])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl5/igt@kms_flip@[email protected]* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl6/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl4/igt@kms_flip@[email protected]* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl7/igt@[email protected]* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite.html* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#53])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl9/igt@[email protected]* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-iclb7/igt@kms_psr@psr2_sprite_render.html* igt@kms_vblank@crtc-id:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl1/igt@[email protected]* igt@kms_vblank@pipe-a-query-forked-busy:
- shard-tglb: [PASS][33] -> [DMESG-WARN][34] ([i915#402]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb5/igt@[email protected]* igt@kms_vblank@pipe-c-wait-busy-hang:
- shard-apl: [PASS][35] -> [DMESG-WARN][36] ([i915#1635] / [i915#1982]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl4/igt@[email protected]#### Possible fixes ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][37] ([i915#118] / [i915#95]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk2/igt@[email protected]* igt@i915_pm_rpm@i2c:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +8 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl5/igt@[email protected]* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][41] ([i915#118] / [i915#95]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-glk8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-glk3/igt@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][43] ([i915#300]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl9/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl2/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-snb: [TIMEOUT][45] ([i915#1958] / [i915#2119]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
- shard-kbl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl4/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-apl: [DMESG-WARN][49] ([i915#1635] / [i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl2/igt@[email protected]* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-tglb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb2/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][53] ([fdo#108145] / [i915#265]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-skl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-skl8/igt@[email protected]* igt@kms_setmode@basic:
- shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl1/igt@[email protected]* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-kbl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-kbl6/igt@[email protected]* igt@perf@blocking-parameterized:
- shard-tglb: [FAIL][59] ([i915#1542]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-tglb3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-tglb2/igt@[email protected]* igt@perf_pmu@busy-idle@rcs0:
- shard-snb: [FAIL][61] ([i915#1958]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@perf_pmu@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@perf_pmu@[email protected]* igt@perf_pmu@busy-idle@vcs0:
- shard-snb: [INCOMPLETE][63] ([i915#2119] / [i915#82]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@perf_pmu@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@perf_pmu@[email protected]#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [TIMEOUT][65] ([i915#1958] / [i915#2119]) -> [FAIL][66] ([i915#1930])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]* igt@kms_ccs@pipe-c-ccs-on-another-bo:
- shard-snb: [TIMEOUT][67] ([i915#1958] / [i915#2119]) -> [SKIP][68] ([fdo#109271]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-snb5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-snb5/igt@[email protected]* igt@runner@aborted:
- shard-hsw: [FAIL][69] ([i915#2110]) -> [FAIL][70] ([i915#1436] / [i915#2110])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-hsw1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-hsw6/igt@[email protected]
- shard-apl: ([FAIL][71], [FAIL][72], [FAIL][73]) ([i915#1610] / [i915#1635] / [i915#2110] / [i915#637]) -> [FAIL][74] ([i915#1635] / [i915#2110])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl1/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8758/shard-apl8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/shard-apl7/igt@[email protected][fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#637]: https://gitlab.freedesktop.org/drm/intel/issues/637
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95Participating hosts (10 -> 10)
------------------------------No changes in participating hosts
Build changes
-------------* Linux:
CI_DRM_8758->Patchwork_18197CI-20190529: 20190529
CI_DRM_8758:b6738761bde03de00a1c84c6a85f9379f53f585c@git://anongit.freedesktop.org/gfx-ci/linux
IGT_5738:bc8b56fe177af34fbde7b96f1f66614a0014c6ef@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18197:dfcce2d96955e0636baa8270decdc53ec3519ab2@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509:fdc5a4ca11124ab8413c7988896eec4c97336694@git://anongit.freedesktop.org/piglit== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18197/index.html
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx