Skip to content

Remaining RKL patches

Matt Roper intel-gfx 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 5 repliesIn review
  2. v75 patches 11 repliesSuperseded
  3. v65 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v54 patches0 repliesSuperseded
v47 patches3 repliesSuperseded
v315 patches21 repliesSuperseded

Changes in v8 from the cover letter

- Undo the renumbering of PLL IDs in the DPLL4 patch; the shared DPLL code has deep-rooted assumptions that the PLL table has no holes and that id==idx; renumbering works fine for RKL, but breaks one of those assumptions for TGL. Instead introduce RKL-specific RKL_DPLL_CFGCR macros to look up the proper register with the existing PLL IDs.
- Incorporate Jose's review feedback on the HTI patch and combo PHY WA patch.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915/rkl: Handle new DPCLKA_CFGCR0 layoutdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/i915_reg.h+33 -60 replies
2/5drm/i915/rkl: Add initial workaroundsdrivers/gpu/drm/i915/display/intel_sprite.c drivers/gpu/drm/i915/gt/intel_workarounds.c+60 -340 replies
3/5drm/i915/rkl: Add DPLL4 supportdrivers/gpu/drm/i915/display/intel_dpll_mgr.c drivers/gpu/drm/i915/i915_reg.h+40 -71 reply
4/5drm/i915/rkl: Handle HTIdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_dpll_mgr.c +4 more+54 -02 replies
5/5drm/i915/rkl: Add Wa_14011224835 for PHY B initializationdrivers/gpu/drm/i915/display/intel_combo_phy.c drivers/gpu/drm/i915/i915_reg.h+62 -11 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJosé Roberto de SouzaLucas De Marchi
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [Intel-gfx] [PATCH v8 0/5] Remaining RKL patches

The first couple patches here already have r-b's from Jose, but since it's been a while since they were last sent to the list we should get another CI pass before merging them.

Changes since v7:
- Undo the renumbering of PLL IDs in the DPLL4 patch; the shared DPLL code has deep-rooted assumptions that the PLL table has no holes and that id==idx; renumbering works fine for RKL, but breaks one of those assumptions for TGL. Instead introduce RKL-specific RKL_DPLL_CFGCR macros to look up the proper register with the existing PLL IDs.
- Incorporate Jose's review feedback on the HTI patch and combo PHY WA patch.

Cc José Roberto de Souza <[email protected]>

Matt Roper (5):
drm/i915/rkl: Handle new DPCLKA_CFGCR0 layout drm/i915/rkl: Add initial workarounds drm/i915/rkl: Add DPLL4 support
drm/i915/rkl: Handle HTI
drm/i915/rkl: Add Wa_14011224835 for PHY B initialization

 .../gpu/drm/i915/display/intel_combo_phy.c    | 50 +++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.c      | 37 +++++++-
 drivers/gpu/drm/i915/display/intel_display.c  | 23 ++++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 52 +++++++++--
 drivers/gpu/drm/i915/display/intel_sprite.c   |  5 +-
 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 89 ++++++++++++-------
 drivers/gpu/drm/i915/i915_drv.h               |  8 ++
 drivers/gpu/drm/i915/i915_pci.c               |  1 +
 drivers/gpu/drm/i915/i915_reg.h               | 31 ++++++-
 drivers/gpu/drm/i915/intel_device_info.h      |  1 +
 10 files changed, 249 insertions(+), 48 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx