pulseaudio: improve the Thumb frame pointer fix
PATCH 1/1 pulseaudio: improve the Thumb frame pointer fix
By changing the register that PulseAudio uses in its asm code makes it unnecessary to care whether frame pointers are enabled or not.
This fix was suggested by Andre McCurdy.
--- .../pulseaudio/pulseaudio.inc | 8 --- ..._neon-use-register-r12-instead-of-r7.patch | 49 +++++++++++++++++++ .../pulseaudio/pulseaudio_13.0.bb | 1 + 3 files changed, 50 insertions(+), 8 deletions(-) create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-remap_neon-use-register-r12-instead-of-r7.patch
meta/recipes-multimedia/pulseaudio/pulseaudio.inc +0 -8
@@ -63,14 +63,6 @@ DEPENDS += "speexdsp libxml-parser-perl-native libcap" inherit autotools bash-completion pkgconfig useradd gettext perlnative systemd manpages gsettings -# When compiling for Thumb or Thumb2, frame pointers _must_ be disabled since the -# Thumb frame pointer in r7 clashes with pulseaudio's use of inline asm to make syscalls -# (where r7 is used for the syscall NR). In most cases, frame pointers will be -# disabled automatically due to the optimisation level, but append an explicit -# -fomit-frame-pointer to handle cases where optimisation is set to -O0 or frame -# pointers have been enabled by -fno-omit-frame-pointer earlier in CFLAGS, etc. -CFLAGS_append_arm = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" - # *.desktop rules wont be generated during configure and build will fail # if using --disable-nls USE_NLS = "yes"
meta/recipes-multimedia/pulseaudio/pulseaudio/0001-remap_neon-use-register-r12-instead-of-r7.patch new file +49 -0
49 lines not on this page · raw message
meta/recipes-multimedia/pulseaudio/pulseaudio_13.0.bb +1 -0
@@ -4,6 +4,7 @@ SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \ file://0001-client-conf-Add-allow-autospawn-for-root.patch \ file://0002-do-not-display-CLFAGS-to-improve-reproducibility-bui.patch \ file://0001-remap-arm-Adjust-inline-asm-constraints.patch \ + file://0001-remap_neon-use-register-r12-instead-of-r7.patch \ file://volatiles.04_pulse \ " SRC_URI[md5sum] = "e41d606f90254ed45c90520faf83d95c"
Signature · 1 line
2.20.1
✗ patchtest: failure for pulseaudio: improve the Thumb frame pointer fix
== Series Details ==
Series: pulseaudio: improve the Thumb frame pointer fix
Revision: 1
URL : https://patchwork.openembedded.org/series/25177/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Upstream-Status is Submitted, but it is not mentioned where [test_upstream_status_presence_format]
Suggested fix Include where 0001-remap_neon-use-register-r12-instead-of-r7.patch was submitted Current Upstream-Status: Submitted Standard format Upstream-Status: Submitted [where]
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe