arm64: dts: clearfog-gt-8k: fix switch link configuration
Subsystems (4)
PATCH 1/1 arm64: dts: clearfog-gt-8k: fix switch link configuration
The commit below caused a regression for clearfog-gt-8k, where the link between the switch and the host does not come up.
Investigation revealed two issues:
- MV88E6xxx DSA no longer allows an in-band link to come up as the link is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix in-band AN link establishment" addresses this.
- The dts configured dissimilar link modes at each end of the host to switch link; the host was configured using a fixed link (so has no in-band status) and the switch was configured to expect in-band status.
With both issues fixed, the regression is resolved.
--- arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +1 -4
@@ -454,10 +454,7 @@ status = "okay"; phy-mode = "2500base-x"; phys = <&cp1_comphy5 2>; - fixed-link { - speed = <2500>; - full-duplex; - }; + managed = "in-band-status"; }; &cp1_spi1 {
Signature · 1 line
2.20.1
Quoted 13 lines · Russell King
The commit below caused a regression for clearfog-gt-8k, where the link between the switch and the host does not come up.
Investigation revealed two issues:
- MV88E6xxx DSA no longer allows an in-band link to come up as the link is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix in-band AN link establishment" addresses this.- The dts configured dissimilar link modes at each end of the host to switch link; the host was configured using a fixed link (so has no in-band status) and the switch was configured to expect in-band status.
Quoted 5 lines
With both issues fixed, the regression is resolved.
Fixes 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")Reported-by Martin Rowe <[email protected]>Signed-off-by Russell King <[email protected]>
Andrew
David Miller
maintainerFrom: Russell King <[email protected]>
Date: Sun, 19 Jul 2020 12:00:40 +0100
Quoted 13 lines
The commit below caused a regression for clearfog-gt-8k, where the link between the switch and the host does not come up.
Investigation revealed two issues:
- MV88E6xxx DSA no longer allows an in-band link to come up as the link is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix in-band AN link establishment" addresses this.- The dts configured dissimilar link modes at each end of the host to switch link; the host was configured using a fixed link (so has no in-band status) and the switch was configured to expect in-band status.
Quoted 5 lines
With both issues fixed, the regression is resolved.
Fixes 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")Reported-by Martin Rowe <[email protected]>Signed-off-by Russell King <[email protected]>
Applied and queued up for -stable, thanks.