Skip to contentSkip to conversation

net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

PATCH In review Wang Hai 2 participants 2 messages Jul 20, 2020

Subsystems (3)
lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH v3 1/1 net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

Fix sparse build warning:

drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointer

---
v1->v2:
Improve code readability based on Joe Perches's suggestion
v2->v3:
Simplify code based on Joe Perches's suggestion

 drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/amazon/ena/ena_netdev.c +2 -3
index 91be3ffa1c5c..3eb63b12dd68 100644
@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,
 static void ena_init_napi_in_range(struct ena_adapter *adapter,
 				   int first_index, int count)
 {
-	struct ena_napi *napi = {0};
 	int i;
 
 	for (i = first_index; i < first_index + count; i++) {
-		napi = &adapter->ena_napi[i];
+		struct ena_napi *napi = &adapter->ena_napi[i];
 
 		netif_napi_add(adapter->netdev,
-			       &adapter->ena_napi[i].napi,
+			       &napi->napi,
 			       ENA_IS_XDP_INDEX(adapter, i) ? ena_xdp_io_poll : ena_io_poll,
 			       ENA_NAPI_BUDGET);
 
Signature · 1 line
2.17.1
Acked-by on v3 1/1
#1 lore raw
Quoted 38 lines · Wang Hai

Fix sparse build warning:

drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointer

---
v1->v2:
Improve code readability based on Joe Perches's suggestion
v2->v3:
Simplify code based on Joe Perches's suggestion

 drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/amazon/ena/ena_netdev.c +2 -3
index 91be3ffa1c5c..3eb63b12dd68 100644
@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct 
 ena_adapter *adapter,
 static void ena_init_napi_in_range(struct ena_adapter *adapter,
 				   int first_index, int count)
 {
-	struct ena_napi *napi = {0};
 	int i;
 
 	for (i = first_index; i < first_index + count; i++) {
-		napi = &adapter->ena_napi[i];
+		struct ena_napi *napi = &adapter->ena_napi[i];
 
 		netif_napi_add(adapter->netdev,
-			       &adapter->ena_napi[i].napi,
+			       &napi->napi,
 			       ENA_IS_XDP_INDEX(adapter, i) ? 
 ena_xdp_io_poll : ena_io_poll,
Quoted 1 line

ENA_NAPI_BUDGET);

Thanks a lot for your work