net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
Subsystems (3)
PATCH v3 1/1 net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
Fix sparse build warning:
drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointer
Reported-by Hulk Robot <[email protected]>
Signed-off-by Wang Hai <[email protected]>
Suggested-by Joe Perches <[email protected]>
Acked-by Shay Agroskin <[email protected]>
---v1->v2:
Improve code readability based on Joe Perches's suggestionv2->v3:
Simplify code based on Joe Perches's suggestion
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/amazon/ena/ena_netdev.c +2 -3
@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,static void ena_init_napi_in_range (struct ena_adapter *adapter,int first_index,int count) { -struct ena_napi *napi = {0 };int i;for (i = first_index; i < first_index + count; i++) { - napi = &adapter->ena_napi[i]; +struct ena_napi *napi = &adapter->ena_napi[i];netif_napi_add (adapter->netdev, - &adapter->ena_napi[i].napi, + &napi->napi,ENA_IS_XDP_INDEX (adapter, i) ? ena_xdp_io_poll : ena_io_poll,ENA_NAPI_BUDGET );
Signature · 1 line
2.17.1
Quoted 38 lines · Wang Hai
Fix sparse build warning:
drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointerReported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>Suggested-by Joe Perches <[email protected]>Acked-by Shay Agroskin <[email protected]>---
v1->v2:
Improve code readability based on Joe Perches's suggestionv2->v3:
Simplify code based on Joe Perches's suggestiondrivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/net/ethernet/amazon/ena/ena_netdev.c +2
-3@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(structena_adapter *adapter, static void ena_init_napi_in_range(struct ena_adapter *adapter, int first_index, int count) { - struct ena_napi *napi = {0}; int i;for (i = first_index; i < first_index + count; i++) { - napi = &adapter->ena_napi[i]; +struct ena_napi *napi = &adapter->ena_napi[i]; netif_napi_add(adapter->netdev, - &adapter->ena_napi[i].napi, + &napi->napi, ENA_IS_XDP_INDEX(adapter, i) ? ena_xdp_io_poll : ena_io_poll,
Quoted 1 line
ENA_NAPI_BUDGET);
Acked-by Shay Agroskin <[email protected]>
Thanks a lot for your work