Skip to contentSkip to conversation

usb: cdns3: ep0: delete the unnecessary operation

PATCH New Peter Chen 1 participant 1 message Jul 22, 2020

Subsystems (3)
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 1/1 usb: cdns3: ep0: delete the unnecessary operation

It doesn't need to enable/disable L1 on the fly for EP0 transfer, we only need to enable L1 after SET_CONFIGURATION.

This code may be introduced by careless.

Cc Pawel Laszczak <[email protected]>
---
 drivers/usb/cdns3/ep0.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/usb/cdns3/ep0.c +0 -3
index a2b9af5a80cc..5104414ce243 100644
@@ -122,8 +122,6 @@ static void cdns3_ep0_complete_setup(struct cdns3_device *priv_dev,
 	priv_dev->ep0_stage = CDNS3_SETUP_STAGE;
 	writel((send_erdy ? EP_CMD_ERDY : 0) | EP_CMD_REQ_CMPL,
 	       &priv_dev->regs->ep_cmd);
-
-	cdns3_allow_enable_l1(priv_dev, 1);
 }
 
 /**
@@ -639,7 +637,6 @@ void cdns3_check_ep0_interrupt_proceed(struct cdns3_device *priv_dev, int dir)
 
 	if (priv_dev->wait_for_setup && ep_sts_reg & EP_STS_IOC) {
 		priv_dev->wait_for_setup = 0;
-		cdns3_allow_enable_l1(priv_dev, 0);
 		cdns3_ep0_setup_phase(priv_dev);
 	} else if ((ep_sts_reg & EP_STS_IOC) || (ep_sts_reg & EP_STS_ISP)) {
 		priv_dev->ep0_data_dir = dir;
Signature · 1 line
2.17.1