KEYS: remove redundant memset
Subsystems (2)
PATCH v2 1/1 KEYS: remove redundant memset
From: Tom Rix <[email protected]>
Reviewing use of memset in keyctrl_pkey.c
keyctl_pkey_params_get prologue code to set params up
memset(params, 0, sizeof(*params)); params->encoding = "raw";
keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.
So remove the prologue.
---
v1: remove change to keyctl_pkey_params_get_2
security/keys/keyctl_pkey.c | 2 -- 1 file changed, 2 deletions(-)
security/keys/keyctl_pkey.c +0 -2
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,struct kernel_pkey_query res;long ret; -memset (¶ms,0 ,sizeof (params)); - ret =keyctl_pkey_params_get (id, _info, ¶ms);if (ret <0 ) goto error;
Signature · 1 line
2.18.1
Quoted 9 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Reviewing use of memset in
keyctrl_pkey.c
keyctl_pkey_params_getprologue code to set params upmemset(params, 0, sizeof(*params)); params->encoding = "raw";
Quoted 6 lines
keyctl_pkey_queryhas the same prologue
and callskeyctl_pkey_params_get.So remove the prologue.
Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")
At best, this is a micro optimization.
How is this appropriate for a Fixes: line?
security/keys/keyctl_pkey.c
Quoted 1 line
security/keys/keyctl_pkey.c +0
-0
[]
Quoted 9 lines
security/keys/keyctl_pkey.c +0
-2@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,struct kernel_pkey_query res;long ret; -memset (¶ms,0 ,sizeof (params)); - ret =keyctl_pkey_params_get (id, _info, ¶ms);if (ret <0 ) goto error;
Quoted 10 lines · Joe Perches
Quoted 9 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Reviewing use of memset in
keyctrl_pkey.c
keyctl_pkey_params_getprologue code to set params upmemset(params, 0, sizeof(*params)); params->encoding = "raw";
Quoted 7 lines
Quoted 6 lines
keyctl_pkey_queryhas the same prologue
and callskeyctl_pkey_params_get.So remove the prologue.
Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")At best, this is a micro optimization.
Yes
Quoted 1 line
How is this appropriate for a Fixes: line?
Removing unneeded code is not a fix?
Quoted 12 lines
security/keys/keyctl_pkey.c
Quoted 2 lines
security/keys/keyctl_pkey.c +0
-0[]
Quoted 9 lines
security/keys/keyctl_pkey.c +0
-2@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,struct kernel_pkey_query res;long ret; -memset (¶ms,0 ,sizeof (params)); - ret =keyctl_pkey_params_get (id, _info, ¶ms);if (ret <0 ) goto error;
Quoted 14 lines · Tom Rix
Quoted 13 lines · Joe Perches
Quoted 12 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Reviewing use of memset in
keyctrl_pkey.c
keyctl_pkey_params_getprologue code to set params upmemset(params, 0, sizeof(*params)); params->encoding = "raw";
keyctl_pkey_queryhas the same prologue
and callskeyctl_pkey_params_get.
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
So remove the prologue.
Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")At best, this is a micro optimization.
Yes
Quoted 1 line
How is this appropriate for a Fixes: line?
Removing unneeded code is not a fix?
IMO: there's no "bug" here.
It's not a logic defect causing some unintended outcome. It doesn't need backporting to stable branches.
Documentation/process/submitting-patches.rst-If your patch fixes a bug in a specific commit, e.g. you found an issue using Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters of Documentation/process/submitting-patches.rst-the SHA-1 ID, and the one line summary.
Quoted 23 lines · Joe Perches
Quoted 14 lines · Tom Rix
Quoted 13 lines · Joe Perches
Quoted 12 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:
From: Tom Rix <[email protected]>
Reviewing use of memset in
keyctrl_pkey.c
keyctl_pkey_params_getprologue code to set params upmemset(params, 0, sizeof(*params)); params->encoding = "raw";
keyctl_pkey_queryhas the same prologue
and callskeyctl_pkey_params_get.Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
So remove the prologue.
Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")At best, this is a micro optimization.
Yes
Quoted 1 line
How is this appropriate for a Fixes: line?
Removing unneeded code is not a fix?
Quoted 8 lines
IMO: there's no "bug" here.
It's not a logic defect causing some unintended outcome. It doesn't need backporting to stable branches.
Documentation/process/submitting-patches.rst-Ifyour patch fixes a bug in a specific commit, e.g. you found an issue using Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters ofDocumentation/process/submitting-patches.rst-theSHA-1 ID, and the one line summary.
I agree.
At worst it can cause unnecessary merge conflicts when backporting bug fixes.
No measurable gain merging it.
/Jarkko