Skip to contentSkip to conversation

KEYS: remove redundant memset

PATCH In review [email protected] 3 participants 5 messages Jul 22, 2020 – Jul 23, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 KEYS: remove redundant memset

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

---
v1: remove change to keyctl_pkey_params_get_2

 security/keys/keyctl_pkey.c | 2 --
 1 file changed, 2 deletions(-)
security/keys/keyctl_pkey.c +0 -2
index 931d8dfb4a7f..5de0d599a274 100644
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
 	struct kernel_pkey_query res;
 	long ret;
 
-	memset(&params, 0, sizeof(params));
-
 	ret = keyctl_pkey_params_get(id, _info, &params);
 	if (ret < 0)
 		goto error;
Signature · 1 line
2.18.1
#1 lore raw
Quoted 9 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";
Quoted 6 lines

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

At best, this is a micro optimization.

How is this appropriate for a Fixes: line?

security/keys/keyctl_pkey.c

Quoted 1 line
security/keys/keyctl_pkey.c +0 -0

[]

Quoted 9 lines
security/keys/keyctl_pkey.c +0 -2
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
 	struct kernel_pkey_query res;
 	long ret;
 
-	memset(&params, 0, sizeof(params));
-
 	ret = keyctl_pkey_params_get(id, _info, &params);
 	if (ret < 0)
 		goto error;
author
#2 lore raw
Quoted 10 lines · Joe Perches
Quoted 9 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";
Quoted 7 lines
Quoted 6 lines

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

At best, this is a micro optimization.

Yes

Quoted 1 line

How is this appropriate for a Fixes: line?

Removing unneeded code is not a fix?

Quoted 12 lines

security/keys/keyctl_pkey.c

Quoted 2 lines
security/keys/keyctl_pkey.c +0 -0

[]

Quoted 9 lines
security/keys/keyctl_pkey.c +0 -2
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
 	struct kernel_pkey_query res;
 	long ret;
 
-	memset(&params, 0, sizeof(params));
-
 	ret = keyctl_pkey_params_get(id, _info, &params);
 	if (ret < 0)
 		goto error;
#3 lore raw
Quoted 14 lines · Tom Rix
Quoted 13 lines · Joe Perches
Quoted 12 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

So remove the prologue.

Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

At best, this is a micro optimization.

Yes

Quoted 1 line

How is this appropriate for a Fixes: line?

Removing unneeded code is not a fix?

IMO: there's no "bug" here.

It's not a logic defect causing some unintended outcome. It doesn't need backporting to stable branches.

Documentation/process/submitting-patches.rst-If your patch fixes a bug in a specific commit, e.g. you found an issue using Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters of Documentation/process/submitting-patches.rst-the SHA-1 ID, and the one line summary.

#4 lore raw
Quoted 23 lines · Joe Perches
Quoted 14 lines · Tom Rix
Quoted 13 lines · Joe Perches
Quoted 12 lines · On Wed, 2020-07-22 at 06:46 -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

So remove the prologue.

Fixes 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

At best, this is a micro optimization.

Yes

Quoted 1 line

How is this appropriate for a Fixes: line?

Removing unneeded code is not a fix?

Quoted 8 lines

IMO: there's no "bug" here.

It's not a logic defect causing some unintended outcome. It doesn't need backporting to stable branches.

Documentation/process/submitting-patches.rst-If your patch fixes a bug in a specific commit, e.g. you found an issue using Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters of Documentation/process/submitting-patches.rst-the SHA-1 ID, and the one line summary.

I agree.

At worst it can cause unnecessary merge conflicts when backporting bug fixes.

No measurable gain merging it.

/Jarkko