xfs/030: repair should actually find the zeroed block pointer in the agfl
PATCH 1/1 xfs/030: repair should actually find the zeroed block pointer in the agfl
From: Darrick J. Wong <[email protected]>
In xfs/030, at some point we zero the entire AGFL. Repair should really find and complain about the AGFL list item that points to the AG superblock.
--- tests/xfs/030.out | 1 + 1 file changed, 1 insertion(+)
tests/xfs/030.out +1 -0
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock... Phase 2 - using <TYPEOF> log - zero log... - scan filesystem freespace and inode maps... +bad agbno AGBNO in agfl, agno 0 - found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists...
Quoted 16 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
In xfs/030, at some point we zero the entire AGFL. Repair should really find and complain about the AGFL list item that points to the AG superblock.
Signed-off-by Darrick J. Wong <[email protected]>--- tests/xfs/030.out | 1 + 1 file changed, 1 insertion(+)tests/xfs/030.out +0
-0
tests/xfs/030.out Phase 1 - find and verify superblock... · line 108
Quoted 4 lines
tests/xfs/030.out +1
-0@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock... Phase 2 - using <TYPEOF> log - zero log... - scan filesystem freespace and inode maps... +bad agbno AGBNO in agfl, agno 0
So this line is expected? This cause xfs/030 fails on old xfsprogs (on RHEL7 and RHEL8).
Quoted 4 lines
tests/xfs/030.out +0
-0- found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists...
Quoted 12 lines · Zorro Lang
Quoted 11 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
In xfs/030, at some point we zero the entire AGFL. Repair should really find and complain about the AGFL list item that points to the AG superblock.
Signed-off-by Darrick J. Wong <[email protected]>--- tests/xfs/030.out | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
tests/xfs/030.out Phase 1 - find and verify superblock... · line 108
Quoted 9 lines
tests/xfs/030.out +1
-0@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock... Phase 2 - using <TYPEOF> log - zero log... - scan filesystem freespace and inode maps... +bad agbno AGBNO in agfl, agno 0So this line is expected? This cause xfs/030 fails on old xfsprogs (on RHEL7 and RHEL8).
Yes, because xfs_repair was changed in dcd6c2e1 ("xfs_repair: convert to libxfs_verify_agbno") to complain about zeroed entries in the AGFL. I guess now that that's upstream I should really change the commit log...
--D
Quoted 6 lines
Quoted 5 lines
tests/xfs/030.out +0
-0- found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists...