Skip to contentSkip to conversation

da7280: haptic driver submission

PATCH Superseded Roy Im 5 participants 17 messages Jul 29, 2020 – Aug 3, 2020

Subsystems (5)

v18 of 20 Superseded Latest is v20 →

lore
Share & tools
lore

Roy Im

author
#0 lore raw

v18 cover da7280: haptic driver submission

This patch adds support for the Dialog DA7280 Haptic driver IC.

In this patch set the following is provided:

[PATCH v18 1/3] MAINTAINERS file update for DA7280 [PATCH v18 2/3] DA7280 DT Binding
[PATCH v18 3/3] DA7280 Driver

This patch applies against linux-next and v5.8-rc7

Thank you,
Roy Im, Dialog Semiconductor Ltd.

Roy Im (3):
MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms
dt-bindings: input: Add document bindings for DA7280
Input: new da7280 haptic driver

 .../devicetree/bindings/input/dlg,da7280.txt       |  109 ++
 MAINTAINERS                                        |    2 +
 drivers/input/misc/Kconfig                         |   12 +
 drivers/input/misc/Makefile                        |    1 +
 drivers/input/misc/da7280.c                        | 1845 ++++++++++++++++++++
 5 files changed, 1969 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/dlg,da7280.txt
 create mode 100644 drivers/input/misc/da7280.c
Signature · 1 line
end-of-patch for PATCH v18
author
#1 lore raw

PATCH v18 1/3 MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms

This patch adds the da7280 bindings doc and driver to the Dialog Semiconductor support list.

---
v18: No changes.
v17: No changes.
v16: No changes.
v15: No changes.
v14: No changes.
v13: No changes.
v12: Corrected file list order.
v11: No changes.
v10: No changes.
v9: No changes.
v8: No changes.
v7: No changes.
v6: No changes.
v5: No changes.
v4: No changes.
v3: No changes.
v2: No changes.

 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index f0569cf..6d76a80 100644
@@ -5003,6 +5003,7 @@ M:	Support Opensource <[email protected]>
 S:	Supported
 W:	http://www.dialog-semiconductor.com/products
 F:	Documentation/devicetree/bindings/input/da90??-onkey.txt
+F:	Documentation/devicetree/bindings/input/dlg,da72??.txt
 F:	Documentation/devicetree/bindings/mfd/da90*.txt
 F:	Documentation/devicetree/bindings/regulator/da92*.txt
 F:	Documentation/devicetree/bindings/regulator/slg51000.txt
@@ -5013,6 +5014,7 @@ F:	Documentation/hwmon/da90??.rst
 F:	drivers/gpio/gpio-da90??.c
 F:	drivers/hwmon/da90??-hwmon.c
 F:	drivers/iio/adc/da91??-*.c
+F:	drivers/input/misc/da72??.[ch]
 F:	drivers/input/misc/da90??_onkey.c
 F:	drivers/input/touchscreen/da9052_tsi.c
 F:	drivers/leds/leds-da90??.c
Signature · 1 line
end-of-patch for PATCH v18
author
#2 lore raw

PATCH v18 2/3 dt-bindings: input: Add document bindings for DA7280

In reply to Roy Im

Add device tree binding information for DA7280 haptic driver. Example bindings for DA7280 are added.

---
v18: No changes.
v17: No changes.
v16: No changes.
v15: No changes.
v14: No changes.
v13: No changes.
v12: No changes.
v11: No changes.
v10: No changes.
v9: No changes.
v8: Updated descriptions for new properties.
v7: No changes.
v6: No changes.
v5: Updated descriptions and fixed errors.
v4: Fixed commit message, properties.
v3: Fixed subject format.
v2: No changes

 .../devicetree/bindings/input/dlg,da7280.txt       | 109 +++++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/dlg,da7280.txt
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +109 -0
new file mode 100644
index 0000000..e6b719d
@@ -0,0 +1,109 @@
+Dialog Semiconductor DA7280 Haptics bindings
+
+Required properties:
+- compatible: Should be "dlg,da7280".
+- reg: Specifies the I2C slave address.
+
+- interrupt-parent : Specifies the phandle of the interrupt controller to
+  which the IRQs from DA7280 are delivered to.
+
+- dlg,actuator-type: Set Actuator type. it should be one of:
+  "LRA" - Linear Resonance Actuator type.
+  "ERM-bar" - Bar type Eccentric Rotating Mass.
+  "ERM-coin" - Coin type Eccentric Rotating Mass.
+
+- dlg,const-op-mode: Haptic operation mode for FF_CONSTANT.
+  Possible values:
+	1 - Direct register override(DRO) mode triggered by i2c(default),
+	2 - PWM data source mode controlled by PWM duty,
+- dlg,periodic-op-mode: Haptic operation mode for FF_PERIODIC.
+  Possible values:
+	1 - Register triggered waveform memory(RTWM) mode, the pattern
+	    assigned to the PS_SEQ_ID played as much times as PS_SEQ_LOOP,
+	2 - Edge triggered waveform memory(ETWM) mode, external GPI(N)
+	    control are required to enable/disable and it needs to keep
+	    device enabled by sending magnitude (X > 0),
+	    the pattern is assigned to the GPI(N)_SEQUENCE_ID below.
+	The default value is 1 for both of the operation modes.
+	For more details, please see the datasheet.
+
+- dlg,nom-microvolt: Nominal actuator voltage rating.
+  Valid values: 0 - 6000000.
+- dlg,abs-max-microvolt: Absolute actuator maximum voltage rating.
+  Valid values: 0 - 6000000.
+- dlg,imax-microamp: Actuator max current rating.
+  Valid values: 0 - 252000.
+  Default: 130000.
+- dlg,impd-micro-ohms: the impedance of the actuator in micro ohms.
+  Valid values: 0 - 1500000000.
+
+Optional properties:
+- pwms : phandle to the physical PWM(Pulse Width Modulation) device.
+  PWM properties should be named "pwms". And number of cell is different
+  for each pwm device.
+  (See Documentation/devicetree/bindings/pwm/pwm.txt
+   for further information relating to pwm properties)
+
+- dlg,ps-seq-id: the PS_SEQ_ID(pattern ID in waveform memory inside chip)
+  to play back when RTWM-MODE is enabled.
+  Valid range: 0 - 15.
+- dlg,ps-seq-loop: the PS_SEQ_LOOP, Number of times the pre-stored sequence
+  pointed to by PS_SEQ_ID or GPI(N)_SEQUENCE_ID is repeated.
+  Valid range: 0 - 15.
+- dlg,gpiN-seq-id: the GPI(N)_SEQUENCE_ID, pattern to play
+  when gpi0 is triggered, 'N' must be 0 - 2.
+  Valid range: 0 - 15.
+- dlg,gpiN-mode: the pattern mode which can select either
+  "Single-pattern" or "Multi-pattern", 'N' must be 0 - 2.
+- dlg,gpiN-polarity: gpiN polarity which can be chosen among
+  "Rising-edge", "Falling-edge" and "Both-edge",
+  'N' must be 0 - 2
+  Haptic will work by this edge option in case of ETWM mode.
+
+- dlg,resonant-freq-hz: use in case of LRA.
+  the frequency range: 50 - 300.
+  Default: 205.
+
+- dlg,bemf-sens-enable: Enable for internal loop computations.
+- dlg,freq-track-enable: Enable for resonant frequency tracking.
+- dlg,acc-enable: Enable for active acceleration.
+- dlg,rapid-stop-enable: Enable for rapid stop.
+- dlg,amp-pid-enable: Enable for the amplitude PID.
+- dlg,mem-array: Customized waveform memory(patterns) data downloaded to
+  the device during initialization. This is an array of 100 values(u8).
+
+For further information, see device datasheet.
+
+======
+
+Example:
+
+	haptics: da7280-haptics@4a {
+		compatible = "dlg,da7280";
+		reg = <0x4a>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+		dlg,actuator-type = "LRA";
+		dlg,dlg,const-op-mode = <1>;
+		dlg,dlg,periodic-op-mode = <1>;
+		dlg,nom-microvolt = <2000000>;
+		dlg,abs-max-microvolt = <2000000>;
+		dlg,imax-microamp = <170000>;
+		dlg,resonant-freq-hz = <180>;
+		dlg,impd-micro-ohms = <10500000>;
+		dlg,freq-track-enable;
+		dlg,rapid-stop-enable;
+		dlg,mem-array = <
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+ 		  0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+		>;
+
+	};
Signature · 1 line
end-of-patch for PATCH v18
author
#3 lore raw

PATCH v18 3/3 Input: new da7280 haptic driver

In reply to Roy Im

Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device.

---
v18:
- Corrected comments in Kconfig
- Updated to preferred style for multi line comments in c file.
v17:
- fixed an issue.
v16:
- Corrected some code and updated description in Kconfig.
v15:
- Removed some defines and updated some comments.
v14:
- Updated pwm related code, alignments and comments.
v13:
- Updated some conditions in pwm function and alignments.
v12: No changes.
v11:
- Updated the pwm related code, comments and typo.
v10:
- Updated the pwm related function and added some comments.
v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE
v8:
- Added changes to support FF_PERIODIC/FF_CUSTOM and FF_CONSTANT.
- Updated the dt-related code.
- Removed memless related functions.
v7:
- Added more attributes to handle one value per file.
- Replaced and updated the dt-related code and functions called.
- Fixed error/functions.
v6: No changes.
v5: Fixed errors in Kconfig file.
v4: Updated code as dt-bindings are changed.
v3: No changes.
v2: Fixed kbuild error/warning

 drivers/input/misc/Kconfig  |   12 +
 drivers/input/misc/Makefile |    1 +
 drivers/input/misc/da7280.c | 1845 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1858 insertions(+)
 create mode 100644 drivers/input/misc/da7280.c
drivers/input/misc/Kconfig +12 -0
index 362e8a0..d38b466 100644
@@ -869,4 +869,16 @@ config INPUT_STPMIC1_ONKEY
 	  To compile this driver as a module, choose M here: the
 	  module will be called stpmic1_onkey.
 
+config INPUT_DA7280_HAPTICS
+	tristate "Dialog Semiconductor DA7280 haptics support"
+	depends on INPUT && I2C
+	select REGMAP_I2C
+	help
+	  Say Y to enable support for the Dialog DA7280 haptics driver.
+	  The haptics can be controlled by PWM or GPIO
+	  with I2C communication.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called da7280.
+
 endif
drivers/input/misc/Makefile +1 -0
index a48e5f2..9cfd6ab 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000)		+= cma3000_d0x.o
 obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON)	+= cpcap-pwrbutton.o
+obj-$(CONFIG_INPUT_DA7280_HAPTICS)	+= da7280.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
 obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
drivers/input/misc/da7280.c new file +1845 -0

1,845 lines not on this page · raw message

Signature · 1 line
end-of-patch for PATCH v18
maintainer
#4 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hi Roy,

Quoted 3 lines · Roy Im

Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device.

A few questions/suggestions...

Quoted 19 lines

---
v18:
- Corrected comments in Kconfig
- Updated to preferred style for multi line comments in c file.
v17:
- fixed an issue.
v16:
- Corrected some code and updated description in Kconfig.
v15:
- Removed some defines and updated some comments.
v14:
- Updated pwm related code, alignments and comments.
v13:
- Updated some conditions in pwm function and alignments.

Quoted 8 lines

v12: No changes.
v11:
- Updated the pwm related code, comments and typo.
v10:
- Updated the pwm related function and added some comments.
v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

...

drivers/input/misc/da7280.c line 94

Quoted 3 lines
drivers/input/misc/da7280.c new file +3 -0
+
+/* DA7280_ACTUATOR3 (Address 0x0e) */
+#define DA7280_IMAX_MASK			(31 << 0)

We have GENMASK(h,l) macro in include/linux/bits.h that could be used here and in other mask definitions.

drivers/input/misc/da7280.c line 229

Quoted 5 lines
drivers/input/misc/da7280.c new file +5 -0
+
+	bool legacy;
+	struct delayed_work work_duration;
+	struct work_struct work_playback;
+	struct work_struct work_setgain;

How do we ensure that all these works do not clash with each other? As far as I can see we could have the "duration" work executing simultaneously with playback...

drivers/input/misc/da7280.c line 692

Quoted 8 lines
drivers/input/misc/da7280.c new file +8 -0
+static int da7280_haptics_playback(struct input_dev *dev,
+				   int effect_id, int val)
+{
+	struct da7280_haptic *haptics = input_get_drvdata(dev);
+
+	if (!haptics->op_mode) {
+		dev_warn(haptics->dev,
+			 "Any effects are not uploaded yet\n");

"No effects have been uploaded"?

drivers/input/misc/da7280.c line 693

Quoted 1 line
drivers/input/misc/da7280.c new file +1 -0
+		return -EPERM;

I'd say EINVAL.

drivers/input/misc/da7280.c line 1632

Quoted 6 lines
drivers/input/misc/da7280.c new file +6 -0
+static DEVICE_ATTR_RW(ps_seq_id);
+static DEVICE_ATTR_RW(ps_seq_loop);
+static DEVICE_ATTR_RW(gpi_seq_id0);
+static DEVICE_ATTR_RW(gpi_seq_id1);
+static DEVICE_ATTR_RW(gpi_seq_id2);
+static DEVICE_ATTR_WO(patterns);

Should this be a binary attribute instead of having string parsing in the kernel?

Thanks.

Signature · 1 line
Dmitry
#5 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hello,

Quoted 8 lines · Dmitry Torokhov
Quoted 3 lines

v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

compared with %d %pe is easier to understand as it emits "-ETIMEOUT" instead of "-110". And yes, %pE is wrong.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
maintainer
#6 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hi Uwe,

Quoted 7 lines · Uwe Kleine-König

Hello,

Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines

v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 7 lines
Quoted 4 lines

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

compared with %d %pe is easier to understand as it emits "-ETIMEOUT" instead of "-110". And yes, %pE is wrong.

While I can see that symbolic name instead of a numeric constant might be appealing, I do not believe that we want fragments like this with endless conversions between integer and pointer errors:

	if (haptics->const_op_mode == DA7280_PWM_MODE) {
		haptics->pwm_dev = devm_pwm_get(dev, NULL);
		if (IS_ERR(haptics->pwm_dev)) {
			error = PTR_ERR(haptics->pwm_dev);
			if (error != -EPROBE_DEFER)
				dev_err(dev, "unable to request PWM: %pE\n",
					ERR_PTR(error));
			return error;
		}

Maybe we should introduce something like '%de' for the integer error case? In the meantime I would prefer using %d when we have integer error. We should not see these error messages anyway ;)

Thanks.

Signature · 1 line
Dmitry
#7 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

[Adding vsprintf maintainers to Cc:]

Hello,

Quoted 30 lines · Dmitry Torokhov
Quoted 7 lines · Uwe Kleine-König

Hello,

Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines

v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 7 lines
Quoted 4 lines

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

compared with %d %pe is easier to understand as it emits "-ETIMEOUT" instead of "-110". And yes, %pE is wrong.

While I can see that symbolic name instead of a numeric constant might be appealing, I do not believe that we want fragments like this with endless conversions between integer and pointer errors:

	if (haptics->const_op_mode == DA7280_PWM_MODE) {
		haptics->pwm_dev = devm_pwm_get(dev, NULL);
		if (IS_ERR(haptics->pwm_dev)) {
			error = PTR_ERR(haptics->pwm_dev);
			if (error != -EPROBE_DEFER)
				dev_err(dev, "unable to request PWM: %pE\n",
					ERR_PTR(error));
			return error;
		}
Quoted 2 lines

Maybe we should introduce something like '%de' for the integer error case?

I suggested that some time ago with limited success, see
https://lore.kernel.org/lkml/[email protected]/
.

Quoted 2 lines

In the meantime I would prefer using %d when we have integer error. We should not see these error messages anyway ;)

I don't agree. Error messages are supposed to be helpful and I prefer some casting between error pointer and error int over emitting bare numbers to the kernel log. (And additionally the uglyness might help to convince the vsprintf guys that %de might be a good idea after all :-)

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
maintainer
#8 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Quoted 42 lines · Uwe Kleine-König

[Adding vsprintf maintainers to Cc:]

Hello,

Quoted 30 lines · Dmitry Torokhov
Quoted 7 lines · Uwe Kleine-König

Hello,

Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines

v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 7 lines
Quoted 4 lines

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

compared with %d %pe is easier to understand as it emits "-ETIMEOUT" instead of "-110". And yes, %pE is wrong.

While I can see that symbolic name instead of a numeric constant might be appealing, I do not believe that we want fragments like this with endless conversions between integer and pointer errors:

	if (haptics->const_op_mode == DA7280_PWM_MODE) {
		haptics->pwm_dev = devm_pwm_get(dev, NULL);
		if (IS_ERR(haptics->pwm_dev)) {
			error = PTR_ERR(haptics->pwm_dev);
			if (error != -EPROBE_DEFER)
				dev_err(dev, "unable to request PWM: %pE\n",
					ERR_PTR(error));
			return error;
		}
Quoted 2 lines

Maybe we should introduce something like '%de' for the integer error case?

I suggested that some time ago with limited success, see
https://lore.kernel.org/lkml/[email protected]/
.

Quoted 7 lines
Quoted 2 lines

In the meantime I would prefer using %d when we have integer error. We should not see these error messages anyway ;)

I don't agree. Error messages are supposed to be helpful and I prefer some casting between error pointer and error int over emitting bare numbers to the kernel log. (And additionally the uglyness might help to convince the vsprintf guys that %de might be a good idea after all :-)

Sorry, but I do not think that I want to introduce this pointless casting just to sway printk folks. Either we have proper way of formatting error codes, or we do not and we stick with what was working since forever.

Thanks.

Signature · 1 line
Dmitry
#9 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hello,

Quoted 13 lines · Dmitry Torokhov
Quoted 11 lines · Uwe Kleine-König

I suggested that some time ago with limited success, see
https://lore.kernel.org/lkml/[email protected]/
.

Quoted 2 lines

In the meantime I would prefer using %d when we have integer error. We should not see these error messages anyway ;)

I don't agree. Error messages are supposed to be helpful and I prefer some casting between error pointer and error int over emitting bare numbers to the kernel log. (And additionally the uglyness might help to convince the vsprintf guys that %de might be a good idea after all :-)

Quoted 4 lines

Sorry, but I do not think that I want to introduce this pointless casting just to sway printk folks. Either we have proper way of formatting error codes, or we do not and we stick with what was working since forever.

You got me wrong. Getting an argument to rediscuss %de is just a minor side reason for me. Getting an expressive error message is the relevant reason.

There is also an inconsitence in what you suggest that I don't like. If in a probe function devm_clk_get fails it should say "-ENODEV" but if it's clk_enable that fails it should say "-5"?

Also "we stick with what was working since forever" is a poor argument.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#10 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

In reply to Uwe Kleine-König
Quoted 3 lines · Uwe Kleine-König
Quoted 2 lines · Dmitry Torokhov
Quoted 1 line · Uwe Kleine-König

On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote:

...

Quoted 5 lines
Quoted 2 lines

Maybe we should introduce something like '%de' for the integer error case?

I suggested that some time ago with limited success, see
https://lore.kernel.org/lkml/[email protected]/

Oh, please, no need for that really. We have now dev_err_probe() on its way to upstream (now in Greg's tree) which hides all this behind.

Just switch to dev_err_probe() and forget about what is under the hood.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#11 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Quoted 10 lines · Andy Shevchenko
Quoted 3 lines · Uwe Kleine-König
Quoted 2 lines · Dmitry Torokhov
Quoted 1 line · Uwe Kleine-König

On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote:

...

Quoted 3 lines
Quoted 2 lines

Maybe we should introduce something like '%de' for the integer error case?

Quoted 7 lines
Quoted 2 lines

I suggested that some time ago with limited success, see
https://lore.kernel.org/lkml/[email protected]/

Oh, please, no need for that really. We have now dev_err_probe() on its way to upstream (now in Greg's tree) which hides all this behind.

Just switch to dev_err_probe() and forget about what is under the hood.

Awesome, we just need to make sure there is never an error condition outside of probe path, and we will be set ;) Easy peasy ;)

Thanks.

Signature · 1 line
Dmitry
author
#12 lore raw

RE: [PATCH v18 3/3] Input: new da7280 haptic driver

In reply to Dmitry Torokhov

Hello Dmitry and Uwe,

Quoted 35 lines · Dmitry Torokhov
Quoted 3 lines · Roy Im

Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device.

A few questions/suggestions...

Quoted 19 lines

---
v18:
- Corrected comments in Kconfig
- Updated to preferred style for multi line comments in c file.
v17:
- fixed an issue.
v16:
- Corrected some code and updated description in Kconfig.
v15:
- Removed some defines and updated some comments.
v14:
- Updated pwm related code, alignments and comments.
v13:
- Updated some conditions in pwm function and alignments.

Quoted 8 lines

v12: No changes.
v11:
- Updated the pwm related code, comments and typo.
v10:
- Updated the pwm related function and added some comments.
v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 2 lines

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

Right, it should be %pe as you and Uwe said, Uwe suggested %pe to understand easier.. do you still prefer to stick with %d?

Quoted 7 lines

...

drivers/input/misc/da7280.c line 94

Quoted 3 lines
drivers/input/misc/da7280.c new file +3 -0
+
+/* DA7280_ACTUATOR3 (Address 0x0e) */
+#define DA7280_IMAX_MASK			(31 << 0)

We have GENMASK(h,l) macro in include/linux/bits.h that could be used here and in other mask definitions.

I will do.

Quoted 9 lines

drivers/input/misc/da7280.c line 229

Quoted 6 lines
drivers/input/misc/da7280.c new file +5 -0
+
+	bool legacy;
+	struct delayed_work work_duration;
+	struct work_struct work_playback;
+	struct work_struct work_setgain;

How do we ensure that all these works do not clash with each other?
As far as I can see we could have the "duration" work executing simultaneously with playback...

You are right, I will use use cancel_delayed_work_sync()/duration and cancel_work_sync()/playback before scheduling playback work. And same as for the work_setgain. For setgain, there is no problem to run this regardless the playback.

Quoted 11 lines

drivers/input/misc/da7280.c line 692

Quoted 9 lines
drivers/input/misc/da7280.c new file +8 -0
+static int da7280_haptics_playback(struct input_dev *dev,
+				   int effect_id, int val)
+{
+	struct da7280_haptic *haptics = input_get_drvdata(dev);
+
+	if (!haptics->op_mode) {
+		dev_warn(haptics->dev,
+			 "Any effects are not uploaded yet\n");

"No effects have been uploaded"?

Ok, let me update so.

Quoted 4 lines

drivers/input/misc/da7280.c line 693

Quoted 2 lines
drivers/input/misc/da7280.c new file +1 -0
+		return -EPERM;

I'd say EINVAL.

OK

Quoted 9 lines

drivers/input/misc/da7280.c line 1632

Quoted 7 lines
drivers/input/misc/da7280.c new file +6 -0
+static DEVICE_ATTR_RW(ps_seq_id);
+static DEVICE_ATTR_RW(ps_seq_loop);
+static DEVICE_ATTR_RW(gpi_seq_id0);
+static DEVICE_ATTR_RW(gpi_seq_id1);
+static DEVICE_ATTR_RW(gpi_seq_id2);
+static DEVICE_ATTR_WO(patterns);

Should this be a binary attribute instead of having string parsing in the kernel?

I have carefully reviewed my driver again with your comments, now the upload effect covers this attributes, so I would like to remove them and add some code more for gpi_seq_idx update.

Thanks for your comments.

Kinds regards,
Roy

maintainer
#13 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Quoted 39 lines · Roy Im

Hello Dmitry and Uwe,

Quoted 35 lines · Dmitry Torokhov
Quoted 3 lines · Roy Im

Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device.

A few questions/suggestions...

Quoted 27 lines

---
v18:
- Corrected comments in Kconfig
- Updated to preferred style for multi line comments in c file.
v17:
- fixed an issue.
v16:
- Corrected some code and updated description in Kconfig.
v15:
- Removed some defines and updated some comments.
v14:
- Updated pwm related code, alignments and comments.
v13:
- Updated some conditions in pwm function and alignments.
v12: No changes.
v11:
- Updated the pwm related code, comments and typo.
v10:
- Updated the pwm related function and added some comments.
v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 4 lines
Quoted 2 lines

I believe the %pE is to format an escaped buffer, you probably want to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or we should stick with %d as most of the kernel does.

Right, it should be %pe as you and Uwe said, Uwe suggested %pe to understand easier.. do you still prefer to stick with %d?

Depends on the situation. If you already have ERR_PTR-encoded error there is no reason for not using %pe, but if you have integer error, or you have already converted pointer to integer I'd prefer we stick with %d.

As I mentioned in another message maybe we should consider adding '%de' or similar for formatting integer errors.

Thanks.

Signature · 1 line
Dmitry
author
#14 lore raw

RE: [PATCH v18 3/3] Input: new da7280 haptic driver

On Thu, July 30, 2020 2:10 PM, Dmitry Torokhov

Quoted 15 lines · Roy Im
Quoted 10 lines
Quoted 9 lines · Dmitry Torokhov
Quoted 7 lines · Roy Im

v11:
- Updated the pwm related code, comments and typo.
v10:
- Updated the pwm related function and added some comments.
v9:
- Removed the header file and put the definitions into the c file.
- Updated the pwm code and error logs with %pE

Quoted 2 lines
Quoted 2 lines

I believe the %pE is to format an escaped buffer, you probably want
to %pe (lowercase) to print errors. I am also not quite sure if we want to use it in cases when we have non-pointer error, or

we should stick with %d as most of the kernel does.

Quoted 1 line
Quoted 7 lines
Quoted 1 line

Right, it should be %pe as you and Uwe said, Uwe suggested %pe to understand easier.. do you still prefer to stick with %d?

Depends on the situation. If you already have ERR_PTR-encoded error there is no reason for not using %pe, but if you have integer error, or you have already converted pointer to integer I'd prefer we stick with %d.

As I mentioned in another message maybe we should consider adding '%de' or similar for formatting integer errors.

I have seen the discussion messages in another email, then I am not still quite sure what could be good for now.
Do you still prefer to be with %d if I have already converted pointer to integer and with %pe for something that I already have ERR_PTR-encoded error?

Kind regards,
Roy

#15 lore raw

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

In reply to Dmitry Torokhov

Hi!

Quoted 9 lines

drivers/input/misc/da7280.c line 1632

Quoted 6 lines
drivers/input/misc/da7280.c new file +6 -0
+static DEVICE_ATTR_RW(ps_seq_id);
+static DEVICE_ATTR_RW(ps_seq_loop);
+static DEVICE_ATTR_RW(gpi_seq_id0);
+static DEVICE_ATTR_RW(gpi_seq_id1);
+static DEVICE_ATTR_RW(gpi_seq_id2);
+static DEVICE_ATTR_WO(patterns);

Should this be a binary attribute instead of having string parsing in the kernel?

Plus... is this suitable userland interface? Should it be documetned?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#16 lore raw

RE: [PATCH v18 3/3] Input: new da7280 haptic driver

Quoted 11 lines · Pavel Machek

Hi!

Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+static DEVICE_ATTR_RW(ps_seq_id);
+static DEVICE_ATTR_RW(ps_seq_loop); static
+DEVICE_ATTR_RW(gpi_seq_id0); static DEVICE_ATTR_RW(gpi_seq_id1);
+static DEVICE_ATTR_RW(gpi_seq_id2); static
+DEVICE_ATTR_WO(patterns);

Should this be a binary attribute instead of having string parsing in the kernel?

Quoted 1 line

Plus... is this suitable userland interface? Should it be documetned?

It could be used by sysfs interface and string parsing, and I added some examples ahead of id and loop attributes, but for the patterns yes, it should be. As I have already added some comment before for the first comment from Dmitry, now the upload effect covers this attributes, so I would like to remove them and I have added some code a little bit more in the upload effect function in the next patch.

Thanks for your comments.

Quoted 4 lines

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Kind regards
Roy