media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable
Subsystems (2)
PATCH 18/20 media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following coccinelle reports:
drivers/media/pci/cobalt/cobalt-i2c.c:176:16-21: WARNING:
Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:180:29-33: WARNING:
Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:121:16-21: WARNING:
Comparison of 0/1 to bool variable drivers/media/pci/cobalt/cobalt-i2c.c:125:29-33: WARNING:
Comparison of 0/1 to bool variable
Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by Daniel W. S. Almeida <[email protected]>
--- drivers/media/pci/cobalt/cobalt-i2c.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/pci/cobalt/cobalt-i2c.c +4 -4
@@ -118,11 +118,11 @@ static int cobalt_tx_bytes(struct cobalt_i2c_regs __iomem *regs,iowrite8 (data[i], ®s->txr_rxr);/* Setup command */ -if (i ==0 && start !=0 ) { +if (i ==0 && start) {/* Write + Start */ cmd =M00018_CR_BITMAP_WR_MSK |M00018_CR_BITMAP_STA_MSK ; - }else if (i == len -1 && stop !=0 ) { + }else if (i == len -1 && stop) {/* Write + Stop */ cmd =M00018_CR_BITMAP_WR_MSK |M00018_CR_BITMAP_STO_MSK ;
@@ -173,11 +173,11 @@ static int cobalt_rx_bytes(struct cobalt_i2c_regs __iomem *regs,for (i =0 ; i < len; i++) {/* Setup command */ -if (i ==0 && start !=0 ) { +if (i ==0 && start) {/* Read + Start */ cmd =M00018_CR_BITMAP_RD_MSK |M00018_CR_BITMAP_STA_MSK ; - }else if (i == len -1 && stop !=0 ) { + }else if (i == len -1 && stop) {/* Read + Stop */ cmd =M00018_CR_BITMAP_RD_MSK |M00018_CR_BITMAP_STO_MSK ;
Signature · 1 line
2.28.0