Skip to contentSkip to conversation

Makefile: fix annoying sunxi hack message

PATCH New Frank Wunderlich 4 participants 9 messages Aug 11, 2020 – Aug 12, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 4483a9bc8a..75c2987405 100644
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
 all: .binman_stamp inputs
-	# Hack for sunxi which doesn't have a proper binman definition for
-	# 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
 	$(call if_changed,binman)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

Quoted 22 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 4483a9bc8a..75c2987405 100644

Makefile PHONY += inputs · line 1031

Quoted 10 lines
Makefile +2 -2
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
 all: .binman_stamp inputs
-	# Hack for sunxi which doesn't have a proper binman definition for
-	# 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
 	$(call if_changed,binman)

Um, what environment is this failing on? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200811/3896035c/attachment.sig>
#2 lore raw

Hi

Quoted 3 lines

Gesendet: Dienstag, 11. August 2020 um 17:32 Uhr
Von: "Tom Rini" <[email protected]>
Um, what environment is this failing on? Thanks!

i get this when compiling for bananapi-r2 (mt7623, armhf).

i guessed it is designed as comment, or should these printed for the sunxi?

build does not fail, but the "message" is printed and imho this was not intended ;)

regards Frank

#3 lore raw
In reply to Tom Rini
Quoted 4 lines

Gesendet: Dienstag, 11. August 2020 um 17:32 Uhr
Von: "Tom Rini" <[email protected]>

Um, what environment is this failing on? Thanks!

sorry forgot data about host where i compile it...i guess this is more interesting ;)

$ cat /etc/issue
Ubuntu 20.04.1 LTS \n \l
$ uname -a
Linux frank-G5-U20 5.4.52-custom #1 SMP Thu Jul 16 19:16:51 CEST 2020 x86_64 x86_64 x86_64 GNU/Linux
$ make -v
GNU Make 4.2.1
$ arm-linux-gnueabihf-gcc -v
Using built-in specs.
COLLECT_GCC=arm-linux-gnueabihf-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/arm-linux-gnueabihf/8/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 8.4.0-3ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-8/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libitm --disable-libquadmath --disable-libquadmath-support --enable-plugin --enable-default-pie --with-system-zlib --without-target-system-zlib --enable-multiarch --enable-multilib --disable-sjlj-exceptions --with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard --with-mode=thumb --disable-werror --enable-multilib --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=arm-linux-gnueabihf --program-prefix=arm-linux-gnueabihf- --includedir=/usr/arm-linux-gnueabihf/include
Thread model: posix
gcc version 8.4.0 (Ubuntu/Linaro 8.4.0-3ubuntu1)

my config: https://github.com/frank-w/u-boot/blob/2020-10-bpi/configs/mt7623n_bpir2_defconfig

#4 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

In reply to Tom Rini

?t 11. 8. 2020 v 17:33 odes?latel Tom Rini <[email protected]> napsal:

Quoted 27 lines · Frank Wunderlich
Quoted 25 lines

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 4483a9bc8a..75c2987405 100644
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
Quoted 10 lines

Makefile PHONY += inputs · line 1031

Quoted 8 lines
Makefile +2 -2
 all: .binman_stamp inputs
-     # Hack for sunxi which doesn't have a proper binman definition for
-     # 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
      $(call if_changed,binman)

Um, what environment is this failing on? Thanks!

I also see this message when I build stuff for zynqmp.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
#5 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

Quoted 39 lines · Michal Simek

?t 11. 8. 2020 v 17:33 odes?latel Tom Rini <[email protected]> napsal:

Quoted 27 lines · Frank Wunderlich
Quoted 25 lines

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 4483a9bc8a..75c2987405 100644
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
Quoted 10 lines

Makefile PHONY += inputs · line 1031

Quoted 8 lines
Makefile +2 -2
 all: .binman_stamp inputs
-     # Hack for sunxi which doesn't have a proper binman definition for
-     # 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
      $(call if_changed,binman)

Um, what environment is this failing on? Thanks!

Quoted 1 line

I also see this message when I build stuff for zynqmp.

Interesting, are you also on make 4.2 ?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/eb103c38/attachment.sig>
#6 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

Quoted 40 lines · Tom Rini
Quoted 39 lines · Michal Simek

?t 11. 8. 2020 v 17:33 odes?latel Tom Rini <[email protected]> napsal:

Quoted 37 lines · Frank Wunderlich
Quoted 23 lines

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 4483a9bc8a..75c2987405 100644

Makefile PHONY += inputs · line 1031

Quoted 10 lines
Makefile +2 -2
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
 all: .binman_stamp inputs
-     # Hack for sunxi which doesn't have a proper binman definition for
-     # 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
      $(call if_changed,binman)

Um, what environment is this failing on? Thanks!

Quoted 3 lines
Quoted 1 line

I also see this message when I build stuff for zynqmp.

Interesting, are you also on make 4.2 ?

I am on 4.1.

Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/65fe38f7/attachment.sig>
#7 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

Quoted 43 lines · Michal Simek
Quoted 40 lines · Tom Rini
Quoted 39 lines · Michal Simek

?t 11. 8. 2020 v 17:33 odes?latel Tom Rini <[email protected]> napsal:

Quoted 37 lines · Frank Wunderlich
Quoted 23 lines

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 4483a9bc8a..75c2987405 100644

Makefile PHONY += inputs · line 1031

Quoted 10 lines
Makefile +2 -2
@@ -1024,8 +1024,8 @@ PHONY += inputs
 inputs: $(INPUTS-y)
 
 all: .binman_stamp inputs
-     # Hack for sunxi which doesn't have a proper binman definition for
-     # 64-bit boards
+# Hack for sunxi which doesn't have a proper binman definition for
+# 64-bit boards
 ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy)
 ifeq ($(CONFIG_BINMAN),y)
      $(call if_changed,binman)

Um, what environment is this failing on? Thanks!

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

I also see this message when I build stuff for zynqmp.

Interesting, are you also on make 4.2 ?

I am on 4.1.

Ugh. I'll apply the patch shortly as clearly we need it. But I don't see why it's failing in some places and not others, which is worrying.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/e7c3dba8/attachment.sig>
#8 lore raw

PATCH 1/1 Makefile: fix annoying sunxi hack message

In reply to Frank Wunderlich
Quoted 7 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

every compilation shows this error

Hack for sunxi which doesn't have a proper binman definition for 64-bit boards

Quoted 6 lines

not only for sunxi-boards/arm64

fix this by changing to real comments

Fixes 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/e734e0ea/attachment.sig>