TypeC Connector Class driver improvements
v3 cover TypeC Connector Class driver improvements
Changes in v3:
* Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
usb_role_switch_set_role()"
- No change
* Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice during disconnect"
- Move the location of calling usb_role_switch_set_role() to end of function in cros_typec_configure_mux() to avoid any change in code flow.
* Patch 3: "platform/chrome: cros_ec_typec: Re-order connector configuration steps"
- New patch added
Changes in v2:
* Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
usb_role_switch_set_role()"
- Update the commit message to change 'USB_ROLE_HOST in case of UFP.' to 'USB_ROLE_HOST in case of DFP.'
* Patch 2: "platform/chrome: cros_ec_typec: Avoid setting usb role twice during disconnect"
- New patch added.
Azhar Shaikh (3):
platform/chrome: cros_ec_typec: Send enum values to
usb_role_switch_set_role()
platform/chrome: cros_ec_typec: Avoid setting usb role twice during
disconnect
platform/chrome: cros_ec_typec: Re-order connector configuration steps
drivers/platform/chrome/cros_ec_typec.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/3 platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
usb_role_switch_set_role() has the second argument as enum for usb_role. Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates to USB_ROLE_NONE in case of UFP and USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of DFP.
---
Changes in v3:
- No changes
Changes in v2:
- Update the commit message to change 'USB_ROLE_HOST in case of UFP.' to 'USB_ROLE_HOST in case of DFP.'
drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/platform/chrome/cros_ec_typec.c +2 -1
@@ -591,7 +591,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)dev_warn (typec->dev,"Configure muxes failed, err = %d\n" , ret);return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - !!(resp.role &PD_CTRL_RESP_ROLE_DATA )); + resp.role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)
Signature · 1 line
2.17.1
Re: [PATCH v3 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
Hi Azhar,
Thank you for your patch.
Quoted 9 lines · Azhar Shaikh
usb_role_switch_set_role()has the second argument as enum forusb_role. Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates toUSB_ROLE_NONEin case of UFP andUSB_ROLE_DEVICEin case of DFP. Correct this by sending correct enum values asUSB_ROLE_DEVICEin case of UFP andUSB_ROLE_HOSTin case of DFP.Fixes 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
No extra line here.
Quoted 1 line
Signed-off-by Azhar Shaikh <[email protected]>
Did the Prashant reviewed tag disappear for some reason? Can you resend the patches with all the collected tags? (looks like this patch and others from this series already have been reviewed)
Thanks,
Enric
Quoted 26 lines
---
Changes in v3:
- No changesChanges in v2:
- Update the commit message to change 'USB_ROLE_HOSTin case of UFP.' to 'USB_ROLE_HOSTin case of DFP.'drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/platform/chrome/cros_ec_typec.c +2
-1@@ -591,7 +591,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)dev_warn (typec->dev,"Configure muxes failed, err = %d\n" , ret);return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - !!(resp.role &PD_CTRL_RESP_ROLE_DATA )); + resp.role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)
RE: [PATCH v3 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
Hi Enric,
Quoted 25 lines
-----Original Message-----
From: Enric Balletbo i Serra <[email protected]>
Sent: Tuesday, August 18, 2020 6:38 AM
To: Shaikh, Azhar <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Mani, Rajmohan <[email protected]>; Patel, Utkarsh H <[email protected]>; Bowman, Casey G <[email protected]>
Subject: Re: [PATCH v3 1/3] platform/chrome:cros_ec_typec: Send enum values tousb_role_switch_set_role()Hi Azhar,
Thank you for your patch.
Quoted 1 line · Azhar Shaikh
usb_role_switch_set_role()has the second argument as enum for
usb_role.Quoted 6 lines
Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. This eventually translates to
USB_ROLE_NONEin case of UFP andUSB_ROLE_DEVICEin case of DFP. Correct this by sending correct enum values asUSB_ROLE_DEVICEin case of UFP andUSB_ROLE_HOSTin case of DFP.
Quoted 5 lines
Quoted 3 lines
Fixes 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB muxcontrol")
No extra line here.
Ack
Quoted 7 lines
Quoted 2 lines
Signed-off-by Azhar Shaikh <[email protected]>Did the Prashant reviewed tag disappear for some reason? Can you resend the patches with all the collected tags? (looks like this patch and others from this series already have been reviewed)
Sorry about that, will add the tags back.
Quoted 34 lines
Thanks,
Enricdrivers/platform/chrome/cros_ec_typec.c static int cros_typec_port_update(struct
Quoted 17 lines
---
Changes in v3:
- No changesChanges in v2:
- Update the commit message to change 'USB_ROLE_HOSTin case of UFP.' to 'USB_ROLE_HOSTin case of DFP.'drivers/platform/chrome/cros_ec_typec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/platform/chrome/cros_ec_typec.c +0
-0@@ -591,7 +591,8 @@ static int cros_typec_port_update(struct
cros_typec_data*typec, intport_num)drivers/platform/chrome/cros_ec_typec.c static int cros_typec_port_update(struct · line 591
Quoted 1 line
drivers/platform/chrome/cros_ec_typec.c +0
-0dev_warn(typec->dev, "Configure muxes failed, err = %d\n",ret);
drivers/platform/chrome/cros_ec_typec.c static int cros_typec_port_update(struct · line 594
Quoted 4 lines
drivers/platform/chrome/cros_ec_typec.c +0
-1return usb_role_switch_set_role(typec->ports[port_num]- role_sw, - !!(resp.role &
PD_CTRL_RESP_ROLE_DATA));Quoted 6 lines
drivers/platform/chrome/cros_ec_typec.c +2
-0+ resp.role &PD_CTRL_RESP_ROLE_DATA + ? USB_ROLE_HOST : USB_ROLE_DEVICE); }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)
PATCH v3 2/3 platform/chrome: cros_ec_typec: Avoid setting usb role twice during disconnect
In reply to Azhar ShaikhOn disconnect port partner is removed and usb role is set to NONE. But then in cros_typec_port_update() the role is set again. Avoid this by moving usb_role_switch_set_role() to cros_typec_configure_mux().
---
Changes in v3:
- Move the location of calling usb_role_switch_set_role() to end of function in cros_typec_configure_mux() to avoid any change in code flow.
Changes in v2:
- New patch added
drivers/platform/chrome/cros_ec_typec.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/platform/chrome/cros_ec_typec.c +7 -4
@@ -533,7 +533,12 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num, ret = -ENOTSUPP ; } -return ret; +if (ret) +return ret; + +return usb_role_switch_set_role (typec->ports[port_num]->role_sw, + pd_ctrl->role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); }static int cros_typec_port_update (struct cros_typec_data *typec,int port_num)
@@ -590,9 +595,7 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)if (ret)dev_warn (typec->dev,"Configure muxes failed, err = %d\n" , ret); -return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - resp.role &PD_CTRL_RESP_ROLE_DATA - ?USB_ROLE_HOST :USB_ROLE_DEVICE ); +return ret; }static int cros_typec_get_cmd_version (struct cros_typec_data *typec)
Signature · 1 line
2.17.1
PATCH v3 3/3 platform/chrome: cros_ec_typec: Re-order connector configuration steps
In reply to Azhar ShaikhAs per USB Type-C Spec R2.0 section 4.5.1.2 (Connecting Sources and Sinks) and section 4.5.2.2 (Connection State Machine Requirements), the typical flow for configuring a device connected to a typeC port is as below:
1. Source/sink detection
2. Orientation
3. Data role
4. VCONN
5. VBUS (USB Type-C currents)
6. The connector is now configured. We can start the PD communication that should lead into configuration of the mux if we enter a mode.
But in existing code data role was set after the connector and mux are already configured. So fix this by following the spec to set the data role before the connector and mux are configured.
---
Changes in v3:
- New patch added
drivers/platform/chrome/cros_ec_typec.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/platform/chrome/cros_ec_typec.c +7 -6
@@ -516,6 +516,12 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,if (ret)return ret; + ret =usb_role_switch_set_role (typec->ports[port_num]->role_sw, + pd_ctrl->role &PD_CTRL_RESP_ROLE_DATA + ?USB_ROLE_HOST :USB_ROLE_DEVICE ); +if (ret) +return ret; +if (mux_flags &USB_PD_MUX_TBT_COMPAT_ENABLED ) { ret =cros_typec_enable_tbt (typec, port_num, pd_ctrl); }else if (mux_flags &USB_PD_MUX_DP_ENABLED ) {
@@ -533,12 +539,7 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num, ret = -ENOTSUPP ; } -if (ret) -return ret; - -return usb_role_switch_set_role (typec->ports[port_num]->role_sw, - pd_ctrl->role &PD_CTRL_RESP_ROLE_DATA - ?USB_ROLE_HOST :USB_ROLE_DEVICE ); +return ret; }static int cros_typec_port_update (struct cros_typec_data *typec,int port_num)
Signature · 1 line
2.17.1